Rather than clients needing to create an appropriate view in a XIB and
attach it to an FLEViewController, which is error-prone, have
FLEViewController create its own view programatically. The view is now
an internal detail, so calling setView: on an FLEViewController will no
longer work.
As a result of the view being internal, the public API surface is
simplified.
This is a breaking change for macOS Runners.
This patch reworks image decompression and collection in the following ways
because of misbehavior in the described edge cases.
The current flow for realizing a texture on the GPU from a blob of compressed
bytes is to first pass it to the IO thread for image decompression and then
upload to the GPU. The handle to the texture on the GPU is then passed back to
the UI thread so that it can be included in subsequent layer trees for
rendering. The GPU contexts on the Render & IO threads are in the same
sharegroup so the texture ends up being visible to the Render Thread context
during rendering. This works fine and does not block the UI thread. All
references to the image are owned on UI thread by Dart objects. When the final
reference to the image is dropped, the texture cannot be collected on the UI
thread (because it has not GPU context). Instead, it must be passed to either
the GPU or IO threads. The GPU thread is usually in the middle of a frame
workload so we redirect the same to the IO thread for eventual collection. While
texture collections are usually (comparatively) fast, texture decompression and
upload are slow (order of magnitude of frame intervals).
For application that end up creating (by not necessarily using) numerous large
textures in straight-line execution, it could be the case that texture
collection tasks are pending on the IO task runner after all the image
decompressions (and upload) are done. Put simply, the collection of the first
image could be waiting for the decompression and upload of the last image in the
queue.
This is exacerbated by two other hacks added to workaround unrelated issues.
* First, creating a codec with a single image frame immediately kicks of
decompression and upload of that frame image (even if the frame was never
request from the codec). This hack was added because we wanted to get rid of
the compressed image allocation ASAP. The expectation was codecs would only be
created with the sole purpose of getting the decompressed image bytes.
However, for applications that only create codecs to get image sizes (but
never actually decompress the same), we would end up replacing the compressed
image allocation with a larger allocation (device resident no less) for no
obvious use. This issue is particularly insidious when you consider that the
codec is usually asked for the native image size first before the frame is
requested at a smaller size (usually using a new codec with same data but new
targetsize). This would cause the creation of a whole extra texture (at 1:1)
when the caller was trying to “optimize” for memory use by requesting a
texture of a smaller size.
* Second, all image collections we delayed in by the unref queue by 250ms
because of observations that the calling thread (the UI thread) was being
descheduled unnecessarily when a task with a timeout of zero was posted from
the same (recall that a task has to be posted to the IO thread for the
collection of that texture). 250ms is multiple frame intervals worth of
potentially unnecessary textures.
The net result of these issues is that we may end up creating textures when all
that the application needs is to ask it’s codec for details about the same (but
not necessarily access its bytes). Texture collection could also be delayed
behind other jobs to decompress the textures on the IO thread. Also, all texture
collections are delayed for an arbitrary amount of time.
These issues cause applications to be susceptible to OOM situations. These
situations manifest in various ways. Host memory exhaustion causes the usual OOM
issues. Device memory exhaustion seems to manifest in different ways on iOS and
Android. On Android, allocation of a new texture seems to be causing an
assertion (in the driver). On iOS, the call hangs (presumably waiting for
another thread to release textures which we won’t do because those tasks are
blocked behind the current task completing).
To address peak memory usage, the following changes have been made:
* Image decompression and upload/collection no longer happen on the same thread.
All image decompression will now be handled on a workqueue. The number of
worker threads in this workqueue is equal to the number of processors on the
device. These threads have a lower priority that either the UI or Render
threads. These workers are shared between all Flutter applications in the
process.
* Both the images and their codec now report the correct allocation size to Dart
for GC purposes. The Dart VM uses this to pick objects for collection. Earlier
the image allocation was assumed to 32bpp with no mipmapping overhead
reported. Now, the correct image size is reported and the mipmapping overhead
is accounted for. Image codec sizes were not reported to the VM earlier and
now are. Expect “External” VM allocations to be higher than previously
reported and the numbers in Observatory to line up more closely with actual
memory usage (device and host).
* Decoding images to a specific size used to decode to 1:1 before performing a
resize to the correct dimensions before texture upload. This has now been
reworked so that images are first decompressed to a smaller size supported
natively by the codec before final resizing to the requested target size. The
intermediate copy is now smaller and more promptly collected. Resizing also
happens on the workqueue worker.
* The drain interval of the unref queue is now sub-frame-interval. I am hesitant
to remove the delay entirely because I have not been able to instrument the
performance overhead of the same. That is next on my list. But now, multiple
frame intervals worth of textures no longer stick around.
The following issues have been addressed:
* https://github.com/flutter/flutter/issues/34070 Since this was the first usage
of the concurrent message loops, the number of idle wakes were determined to
be too high and this component has been rewritten to be simpler and not use
the existing task runner and MessageLoopImpl interface.
* Image decoding had no tests. The new `ui_unittests` harness has been added
that sets up a GPU test harness on the host using SwiftShader. Tests have been
added for image decompression, upload and resizing.
* The device memory exhaustion in this benchmark has been addressed. That
benchmark is still not viable for inclusion in any harness however because it
creates 9 million codecs in straight-line execution. Because these codecs are
destroyed in the microtask callbacks, these are referenced till those
callbacks are executed. So now, instead of device memory exhaustion, this will
lead to (slower) exhaustion of host memory. This is expected and working as
intended.
This patch only addresses peak memory use and makes collection of unused images
and textures more prompt. It does NOT address memory use by images referenced
strongly by the application or framework.
Adds an initial version of FLEDartProject, which contains the
configuration for running the engine. In the future this will align with
FlutterDartProject, and likely share a significant portion of the
implementation.
This is a breaking change for macOS runners.
This is part of a bigger change that will facilitate us
to act on this `RasterStatus`. The specific case is where
after pre-roll we might decide to want to merge the threads
and re-submit the frame -- `RasterStatus::kResubmit` can then
let us achieve this result.
* Roll src/third_party/dart 67ab3be10d...43891316ca
dart-lang/sdk@/43891316ca [ VM / Observatory ] Emit IsolateReload event after reload completes
dart-lang/sdk@/2ea7e5513b Perform type promotion when NNBD, using flow analysis.
dart-lang/sdk@/766e542e53 handle return in async function
dart-lang/sdk@/51cf8f218a Add entension support to the summary idl
dart-lang/sdk@/0e9957c7b1 [dartdevc] Adding support for analyzer dep pruning
dart-lang/sdk@/c100308ba6 Repro for inferring arrays with out of range lengths
dart-lang/sdk@/5d77657e7a Prepare to publish analyzer version 0.37.0.
dart-lang/sdk@/86ce74caaa update NodeBuilder for default value type arguments
dart-lang/sdk@/439692c9e2 Mark the name in an extension as being in a declaration context
dart-lang/sdk@/372bcae536 [gardening] Fix 3xHEAD Flutter build after revert
dart-lang/sdk@/052874e93e Avoid non-web integer literal in corelib_2/int_round_test
dart-lang/sdk@/480337106e Implementation of extension override AST node
dart-lang/sdk@/4f78ad90df An initial and partial implementation of an element model for extensions
dart-lang/sdk@/744bb47361 [infra] Remove custom timeouts for dart2js compiler config
dart-lang/sdk@/9b53686ffb update NodeBuilder for declared identifier implicit type
dart-lang/sdk@/3d14b75f97 Revert "Reland "[vm/concurrency] Introduce concept of Isolate Groups""
dart-lang/sdk@/527238e008 [vm] Cleanup C99 header includes
dart-lang/sdk@/9f32f9b87e [cfe] Store the initializer tokens in constructor builders
dart-lang/sdk@/bbbeb8b509 Pull in latest pub
dart-lang/sdk@/851958ee54 update NodeBuilder to handle for loop
dart-lang/sdk@/7a73682c6a update NodeBuilder to handle catch clause
dart-lang/sdk@/fc6cb0ac21 [vm/ffi] Revamp struct representation in FFI.
dart-lang/sdk@/5fd51b9fd2 Cleanup remnants of ignoring Dart v1.x subtype checks
dart-lang/sdk@/45172f0690 Revert "Reland "[llvm] Add initial scaffolding""
dart-lang/sdk@/b9a6630367 [ Observatory ] _getVMTimeline -> getVMTimeline in timeline.js
dart-lang/sdk@/1f02c10b9a Update language_2/const_map4_test for type inference
dart-lang/sdk@/99ed4871b3 Fix a hint in analysis server
dart-lang/sdk@/c3c43689d5 [vm] Remove platform/math.h
dart-lang/sdk@/524fdc13a9 Reland "[llvm] Add initial scaffolding"
dart-lang/sdk@/45a9815aff [vm/debugger] break on asyncfunction entry
dart-lang/sdk@/e0eeffaf9b update NodeBuilder parameter tracking when visiting executable declarations
dart-lang/sdk@/182a59cebb Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator.
dart-lang/sdk@/1427a218f3 update DecoratedType asserts
dart-lang/sdk@/f4dc001729 Migration: begin adding support for LUB computations in conditional expressions.
dart-lang/sdk@/585794ab75 Fix status file line.
dart-lang/sdk@/4a69ef4a50 Skip all spawnURI tests for the simulator architectures as these tests involve invoking the front end for compilation which would mean the front end has to run in simulated mode.
dart-lang/sdk@/26f369eb8e Fix doc comment for NullabilityNode.forLUB
dart-lang/sdk@/9ed728ec7a Add: Example usage to fillRange method.
dart-lang/sdk@/fc7049ae7d Migration: implement support for user-definable prefix expressions.
dart-lang/sdk@/77aa5f0c02 Migration: Add support for function-typed formal parameters.
dart-lang/sdk@/326e970b81 Migration: handle method invocations that resolve to a getter.
dart-lang/sdk@/822de210b5 fix branch_canonicalization_test
dart-lang/sdk@/a2e1434603 Breaking changes for analyzer version 0.37
dart-lang/sdk@/6694aa821d [dart2js] new-rti: Temporary work-around for timeouts
dart-lang/sdk@/18ff5ce893 [dart2js] new-rti: Implement general As/Check methods
dart-lang/sdk@/90c88d984e Fix large integer literals in dart2js_extra/round_constant_folding_test
dart-lang/sdk@/9349f71721 bump linter to 0.1.93
dart-lang/sdk@/c384212f9e [vm] Remove vestigial verified_memory_test.cc file
dart-lang/sdk@/f4824d332d [vm] Drop support for MSVC older than 2013
dart-lang/sdk@/bbb027aa2a [vm] Fix offset that was breaking bare_instructions_trampolines_test
dart-lang/sdk@/1db0b4436c [dart2js] new-rti: Implement type bounds check
dart-lang/sdk@/686742585a Migration: add a more robust assertion to the DecoratedType constructor
dart-lang/sdk@/2fd4ca570b set DecoratedType.returnType for FunctionType
dart-lang/sdk@/ca4b6e533a [dart2js] new-rti: Implement basic is-test
dart-lang/sdk@/39b71253ce Fix for curly_braces_in_flow_control_structures lint.
dart-lang/sdk@/b6c3b2c98c Enable 'Surround with XYZ' only for Statement(s) in Block(s).
dart-lang/sdk@/79e478e50e Fixed some links
dart-lang/sdk@/279c1da42d Use absolute paths as canonical paths for inputs digest maps
dart-lang/sdk@/cbf9cff19f Infer types of field formals before all fields.
dart-lang/sdk@/0c6b3d1277 Migration: do better function type formatting in DecoratedType.toString.
dart-lang/sdk@/a76c459239 Migration: Remove unnecessary duplicate type test
dart-lang/sdk@/a515a0c256 Reland "[vm/ffi] SimDBC on Arm64 Android"
dart-lang/sdk@/0baf81e7d6 Tests for Never and potential nullable / non-nullable.
dart-lang/sdk@/26d308aad3 Use flow analysis for reporting use sites of not assigned locals during resolution.
dart-lang/sdk@/79f276e07d Migration: handle field formal parameters.
dart-lang/sdk@/c8c3572ca9 Migration: standardize method names in EdgeBuilderTest.
dart-lang/sdk@/c0c15c1283 Migration: build nullability node for default type parameter bounds directly.
dart-lang/sdk@/b57ff85906 Migration: clean up and test implicit dynamic return type of Function() syntax.
dart-lang/sdk@/0f2eda8644 Migration: add support for function expression invocations.
dart-lang/sdk@/a200980da0 Migration: add support for variable and field type inference.
dart-lang/sdk@/ca25f56883 Migration: add support for type inference of function types.
dart-lang/sdk@/a436c0621f Migration: fix DecoratedType.toString to support named function parameters.
dart-lang/sdk@/9dee307bdb Migration: update nullability graph debug dump to support union edges.
dart-lang/sdk@/b60dcdbf73 Migration: Remove the `create` parameter from Variables.decoratedElementType.
dart-lang/sdk@/18c21ee9d1 Migration: add support for generic instance creation.
dart-lang/sdk@/f7ddfdf6ca Migration: don't forget to visit variable initializers in NodeBuilder.
dart-lang/sdk@/a39e4fabfb Add information about the deprecated ParameterElement.parameterKind
dart-lang/sdk@/f6dfad02f4 [analyzer] add a space to the quick for for REPLACE_COLON_WITH_EQUALS
* Revert changes makde in the engine for the Isolate Group API change.
* Fix compilation error.
* Update license.
* Format.
Creates an initial, minimal FLEEngine that parallels the iOS
FlutterEngine, and moves engine launch, plugin registration, and binary
messenger functionality from FLEViewController to there. Uses the FLE
prefix since the current APIs will change to better match FlutterEngine;
the current APIs are intended to minimize conceptual changes relative to
the current FLEViewController APIs since it's already a substantial
change.
Further changes will move channels from FLEViewController to FLEEngine,
and further align the APIs and functionality with the iOS version.
Part of #32421
* ExternalViewEmbedder can CancelFrame after pre-roll
- Resets the state so next pre-roll can be successful.
- Commit any pending `CATransaction` so we don't create
nested transactions.
* Update flow/embedded_views.h
* refactoring to move the mutator stack handling to preroll
* more review fixes
* Add support for external view embedded to know if it has changed
* remove the need to reset
* address comments
* Rename to HasPendingViewOperations
* Make pipeline hold a deque so we can push_front
- Also assert that all the DoDraw tasks are executed
on the GPU thread.
* Add tests for pipeline
* Add support for pipeline to push resources to the front
These services will replace fuchsia.net.SocketProvider.
Note that dart_{aot,jit}_product_runner.cmx were invalid before this
change. I'm not sure how that was allowed to happen.
... replaced by fuchsia.tracing.provider.Registry.
PT-127
Change-Id: I8e1243e28292a2442c1ceb3b685a79979bd0bd42
This is a followup to 76599141095069c12160b0c079d1dddf9809552c.
Ported from the Topaz tree.
with the synchronous call, this actually blocks the Flutter component
from serving its out/directory and prevents the Inspect synchronous
discovery
DX-1568 #done #comment
TESTED=`fx shell run fuchsia-pkg://fuchsia.com/crasher_dart#meta/crasher_dart.cmx` (report id 0b59643af026bc37)
TESTED=`fx shell sessionctl add_mod fuchsia-pkg://fuchsia.com/crasher_flutter#meta/crasher_flutter.cmx` then clicked on "Th
Change-Id: I8b0abd1034dba66cd7bb1d6768322cab36ed453b
Ported from Topaz tree.
Ensure that the string data backing package.resolved_url is not modified
or moved by making a copy to pass as the argument value for
TRACE_DURATION.
PT-169 #comment
Change-Id: I1ef6ab9b1ecf350e82134d1d616a841611ac19c6
Ported from Topaz tree.
This re-enables unhandled Dart error handling in Flutter applications,
which was removed in a76b958.
The error handling as originally landed was unsafe. Specifically, in the
case where the unhandled error handler was triggered during shutdown,
there was a race condition which could cause a crash in the following
scenario:
1. Runner::OnApplicationTerminate() is triggered, which posts a task to
the application's platform thread will free the Application instance
and terminate the platform thread.
2. Before that task is serviced, the unhandled error handler is called
(by hooks.dart -> window.cc -> ui_dart_state.cc) on the UI thread.
3. The kill task is serviced and the Application dtor and Thread::Quit()
are called, terminating the platform thread.
4. The unhandled error handler attempts to post a task to the platform
thread, whose thread was killed in step 3. This triggers a crash.
Fixing this requires a mechanism for the message loop to know that the
associated thread has been terminated out from under it.
This patch adds mitigation for this scenario, but remains
non-threadsafe/racy. We pass the unhandled error handler a weak pointer
to the Application and check it before posting a task to the platform
thread. This has two issues:
1. WeakPtr isn't threadsafe, and assumes that all operations occur on a
single thread. We're checking its value (which is mutated on the
platform thread) on the UI thread without synchronization.
2. Even with a guarantee that the WeakPtr state were synchronized,
there's a window between when we check the weak pointer and when we
post to the platform thread in which application shutdown and thread
destruction may occur.
This unsafe mitigation is being landed in order to unblock a high
priority bug (FL-256) on a short schedule, and a proper refactoring will
be required to make this properly threadsafe.
Change-Id: If60d1d3ca5799d82597f8a3acc4ddd3871058972
Ported from Topaz tree.
This is the topaz counterpart to
https://fuchsia-review.googlesource.com/c/fuchsia/+/277254.
This is a backwards-incompatible ABI change that will be landed together
with that CL. All clients have been migrated to be compatible with the
new ABI.
Change-Id: I07bb460ce3c6971eb671874db1f90e8c4906e656
Ported from Topaz tree.
DX-939 #progress
MA-394 #progress
This informs the vulkan driver that we're creating an image
that will be backed by external memory. The driver driver can
decide to use different memory requirements based on the if
memory for the image can be exported or not.
No change in behavior. Existing tests (modular_tests,
scenic_tests, etc.) are sufficient and regressions will be
prevented by running these tests on aemu.
Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#
Change-Id: I489318c2e31f752f76c80a81245e203861d44d94
Ported from Topaz tree.
... being renamed from fuchsia.tracelink.Register.
fuchsia.tracelink.Registry will be removed after change lands in fuchsia.
PT-127
Change-Id: Ie876228cf9d1e6fb052877e65b47918fdd0b9696
Ported from Topaz tree.
Made the engine and the view controllers have BinaryMessengers, not be
BinaryMessengers. This allows us to break retain cycles and makes the
leaking channels we have not less dire.
