8002 Commits

Author SHA1 Message Date
Ferhat
1f2d6ce8f8 [web] Support gif/webp animations, Speed up image drawing in BitmapCanvas. (flutter/engine#13748)
* Add draw image test
* Optimize drawImageScaled
* optimize cloning in HtmlImage, implement drawImageRect using image tag
2019-11-08 12:52:01 -08:00
Chris Yang
a4a346f317 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13755) 2019-11-08 12:26:48 -08:00
Greg Spencer
d7e49ecd5b Move TextRange from the framework to dart:ui. (flutter/engine#13747)
This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, like Paragraph.getWordBoundary instead of a List<int>.

Also added new tests for TextRange.
2019-11-08 12:21:46 -08:00
skia-flutter-autoroll
591957f3ca Roll src/third_party/skia 8c1e265f6f81..c88d1774ed50 (7 commits) (flutter/engine#13754)
https://skia.googlesource.com/skia.git/+log/8c1e265f6f81..c88d1774ed50

git log 8c1e265f6f81..c88d1774ed50 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com add SkColorTypeIsNormalized()
2019-11-08 jlavrova@google.com Font resolution: all unit tests working
2019-11-08 kjlubick@google.com [canvaskit] Expand SkAnimatedImage
2019-11-08 kjlubick@google.com [canvaskit] Fix null dereference when GrContext cannot be made
2019-11-08 egdaniel@google.com Handle failure to create VkRenderPasses in vulkan backend.
2019-11-08 mtklein@google.com Pre-flight SkTLS_pthread changes for C++17

Created with:
  gclient setdep -r src/third_party/skia@c88d1774ed50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 15:16:52 -05:00
Chris Yang
af43ff4a31 Revert "Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter/engine#13753) 2019-11-08 10:59:45 -08:00
Chris Yang
4953fbdd3f Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter/engine#13314) 2019-11-08 10:02:23 -08:00
skia-flutter-autoroll
118a07c1de Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751)
https://skia.googlesource.com/skia.git/+log/99b558b594a1..8c1e265f6f81

git log 99b558b594a1..8c1e265f6f81 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 mtklein@google.com remove redundant comparison ops

Created with:
  gclient setdep -r src/third_party/skia@8c1e265f6f81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 10:04:30 -05:00
skia-flutter-autoroll
aaeab00d4f Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749)
https://skia.googlesource.com/skia.git/+log/3fd426d19df3..99b558b594a1

git log 3fd426d19df3..99b558b594a1 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0919dcb64b..652dbfc63e70 (7 commits)

Created with:
  gclient setdep -r src/third_party/skia@99b558b594a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 04:51:31 -05:00
skia-flutter-autoroll
acc53bacbe Roll src/third_party/skia 76eaab6b8cef..3fd426d19df3 (1 commits) (flutter/engine#13746)
https://skia.googlesource.com/skia.git/+log/76eaab6b8cef..3fd426d19df3

git log 76eaab6b8cef..3fd426d19df3 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 27a3d31d7a9d..d9ed1c2732ba (1 commits)

Created with:
  gclient setdep -r src/third_party/skia@3fd426d19df3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 00:59:22 -05:00
Chinmay Garde
a8b3ff268a Create a new picture recorder even when the embedder supplied render target is recycled. (flutter/engine#13744)
The earlier assumption was that the render target would be re-materialized per frame. The render target needs its own picture recorder to be create per frame as well. When render targets are cached in the registry, an existing target will be reused. But submitting the previous frame would have discarded the recorder already. The layer tree paint would then attempt to dererence a null canvas causing a crash at runtime.

Added tests to ensure that this does not happen both with and without a custom compositor specified by the embedder. I am going to rework this code so that the external view embedders thinks of render target access on a per frame basis but that is a larger change. This smaller patchset should unblock broken builds.

Fixes b/144093523
2019-11-07 19:53:51 -08:00
skia-flutter-autoroll
0709512556 Roll src/third_party/skia 345a2735e2c8..76eaab6b8cef (18 commits) (flutter/engine#13745)
https://skia.googlesource.com/skia.git/+log/345a2735e2c8..76eaab6b8cef

git log 345a2735e2c8..76eaab6b8cef --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 csmartdalton@google.com Implement multisample "disable" in Vulkan
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 mtklein@google.com Reland "hook up float comparisons to x86 JIT"
2019-11-07 herb@google.com Remove unused methods from SkStrike
2019-11-07 mtklein@google.com avoid the JIT on MSAN builds
2019-11-07 halcanary@google.com SkPDF/docs: note that Sfntly subsetter is deprecated
2019-11-07 herb@google.com One glyph() to rule them all!!!
2019-11-07 reed@google.com flesh out blendmodes through Screen
2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 robertphillips@google.com Use GrProgramInfo's primitiveType field
2019-11-07 mtklein@google.com Revert "hook up float comparisons to x86 JIT"
2019-11-07 egdaniel@google.com Add handling of failed framebuffer creation in vulkan.
2019-11-07 mtklein@google.com hook up float comparisons to x86 JIT
2019-11-07 mtklein@google.com gn format BUILD.gn
2019-11-07 robertphillips@google.com Add GrPrimitiveType to GrProgramInfo
2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1d09b983031b..cc0919dcb64b (8 commits)

Created with:
  gclient setdep -r src/third_party/skia@76eaab6b8cef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-07 21:06:31 -05:00
George Wright
606f78fdf6 Only specify --no-link-platform when not specifying --aot, roll dart-lang sdk (flutter/engine#13742)
* Only specify --no-link-platform when --aot isn't specified

* [dart_roll] Update to e68ca9b652acdb642668a6acb5f630d5be6c03da
2019-11-07 17:48:14 -08:00
Ferhat
c759a9b47b Don't run engine tests under vm (causing warnings) (flutter/engine#13737) 2019-11-07 16:28:17 -08:00
Christopher Fujino
c54d4e4eff Switch to Cirrus Dockerfile as CI (flutter/engine#13440) 2019-11-07 15:37:07 -08:00
Matt Carroll
d024332cdf Removed scary experimental warnings for new embedding. (#44314) (flutter/engine#13738) 2019-11-07 22:54:10 +00:00
skia-flutter-autoroll
d652a0a566 Roll src/third_party/skia f66ec5d69d04..345a2735e2c8 (1 commits) (flutter/engine#13732)
https://skia.googlesource.com/skia.git/+log/f66ec5d69d04..345a2735e2c8

git log f66ec5d69d04..345a2735e2c8 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 215bc7949b35..27a3d31d7a9d (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@345a2735e2c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-07 17:11:16 -05:00
liyuqian
9f3eacc712 Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728)
This doc update solves our TODO in https://github.com/flutter/flutter/pull/43676/files#diff-6a35a9a692c9af7473ba1a0a74c979c8R223
2019-11-07 14:05:43 -08:00
Alexander Markov
01365aaf02 Cleanup obsolete --strong option of front-end server (flutter/engine#13735) 2019-11-07 13:34:55 -08:00
skia-flutter-autoroll
d40b21c548 Roll src/third_party/skia 714f8cc3ff4b..f66ec5d69d04 (3 commits) (flutter/engine#13729)
https://skia.googlesource.com/skia.git/+log/714f8cc3ff4b..f66ec5d69d04

git log 714f8cc3ff4b..f66ec5d69d04 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 rosasco@google.com No GL support on Fuchsia.
2019-11-06 csmartdalton@google.com Rename stencil face terminology to clockwise/counter-clockwise
2019-11-06 herb@google.com Allow more sub-pixel position bits

Created with:
  gclient setdep -r src/third_party/skia@f66ec5d69d04

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-06 21:09:35 -05:00
skia-flutter-autoroll
81851417da Roll src/third_party/skia 6790423f84ef..714f8cc3ff4b (8 commits) (flutter/engine#13724)
https://skia.googlesource.com/skia.git/+log/6790423f84ef..714f8cc3ff4b

git log 6790423f84ef..714f8cc3ff4b --date=short --no-merges --format='%ad %ae %s'
2019-11-06 mtklein@google.com add vcmpps
2019-11-06 herb@google.com Improve the dynamic range of SkPackedGlyphID ctor
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 mtklein@google.com unnest matrix multiply
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 jvanverth@google.com Fix issue with RenderPipelineDescriptor creation
2019-11-06 mtklein@google.com JIT splat(0) as xor

Created with:
  gclient setdep -r src/third_party/skia@714f8cc3ff4b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-06 17:15:43 -05:00
Mouad Debbar
0129e64c89 [web] Proper support for text field's obscureText (flutter/engine#13722) 2019-11-06 13:20:23 -08:00
George Wright
04e239fc43 Package fml_unittests in a .far file for fml unit tests on Fuchsia (flutter/engine#13471)
Add fml_tests target for the fml unit tests on Fuchsia
2019-11-06 13:01:54 -08:00
chunhtai
5e7e183369 Revert "Issues/39832 reland (#13642)" (flutter/engine#13720)
This reverts commit a1824112a46ba1968217be011efd19d528330127.
2019-11-06 11:41:36 -08:00
Chinmay Garde
a0fd895dfb Ensure that the device pixel ratio is taken into account with window metrics in physical pixels. (flutter/engine#13708)
This was originally patched in https://github.com/flutter/engine/pull/13193 but
the unit-tests were written under the mistaken assumption (that has been
documented already) that the Flutter window metrics used logical pixel
coordinates. That mistake has been corrected and additional tests to verify
rendering intent has been added.

Fixes https://github.com/flutter/flutter/issues/43906
Fixes https://b.corp.google.com/issues/143529469
2019-11-06 11:16:18 -08:00
Jason Simmons
70d674fd14 Fix NPE in splash screen lookup (flutter/engine#13719) 2019-11-06 10:31:41 -08:00
skia-flutter-autoroll
9e4ef9a7f5 Roll src/third_party/skia 6e54a299cce9..6790423f84ef (11 commits) (flutter/engine#13718)
https://skia.googlesource.com/skia.git/+log/6e54a299cce9..6790423f84ef

git log 6e54a299cce9..6790423f84ef --date=short --no-merges --format='%ad %ae %s'
2019-11-06 bsalomon@google.com fix tolerance in read pixels tests
2019-11-06 robertphillips@google.com Revert "Fully delineate GL usage w/ skia_use_gl"
2019-11-06 mtklein@google.com guard all SkVMBlitter debug features together
2019-11-06 nifong@google.com find min and max, separared by comma. not minmax.
2019-11-06 nigeltao@google.com Inline SkWuffsCodec::readFrames
2019-11-06 rosasco@google.com Fully delineate GL usage w/ skia_use_gl
2019-11-06 borenet@google.com [infra] Remove Calmbench and ParentRevision bots
2019-11-06 nifong@google.com Record min and max frame times from skpbench in perf
2019-11-06 egdaniel@google.com Have vulkan command and descriptor sets handle failed creation.
2019-11-06 bungeman@google.com Reland "Fix empty run handling in trivial shaper iterators"
2019-11-06 michaelludwig@google.com Combine mask and edge distance in TessellationHelper

Created with:
  gclient setdep -r src/third_party/skia@6790423f84ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-06 13:21:25 -05:00
skia-flutter-autoroll
3aebba4ff2 Roll src/third_party/skia f00524707da7..6e54a299cce9 (1 commits) (flutter/engine#13715)
https://skia.googlesource.com/skia.git/+log/f00524707da7..6e54a299cce9

git log f00524707da7..6e54a299cce9 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 robertphillips@google.com Assert we are now in the world of single-primitive-type render passes

Created with:
  gclient setdep -r src/third_party/skia@6e54a299cce9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-06 09:27:47 -05:00
skia-flutter-autoroll
b9708a6937 Roll src/third_party/skia cdc0c23f1a2e..f00524707da7 (2 commits) (flutter/engine#13712)
https://skia.googlesource.com/skia.git/+log/cdc0c23f1a2e..f00524707da7

git log cdc0c23f1a2e..f00524707da7 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 67527cb45293..1d09b983031b (5 commits)
2019-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader aaa64b76c0b4..215bc7949b35 (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@f00524707da7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-06 03:36:22 -05:00
skia-flutter-autoroll
3143f17152 Roll src/third_party/skia f3d4109a793b..cdc0c23f1a2e (36 commits) (flutter/engine#13707)
https://skia.googlesource.com/skia.git/+log/f3d4109a793b..cdc0c23f1a2e

git log f3d4109a793b..cdc0c23f1a2e --date=short --no-merges --format='%ad %ae %s'
2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-05 reed@google.com split out blendmodes for skvm
2019-11-05 reed@google.com split out serial functions for SkFont into separate impl
2019-11-05 michaelludwig@google.com Cache tessellation metadata between inset/outset calls
2019-11-05 senorblanco@chromium.org Dawn: fix mipmap width and height computation during upload.
2019-11-05 mtklein@google.com friendly wrapper to allocate uniforms
2019-11-05 senorblanco@chromium.org Roll Dawn to ToT.
2019-11-05 halcanary@google.com SkPDF/bublic.bzl: switch away from Sfntly subsetter.
2019-11-05 bungeman@google.com Revert "Fix empty run handling in trivial shaper iterators"
2019-11-05 robertphillips@google.com Revert "Reland "Implement sample mask and sample locations support in Vulkan""
2019-11-05 robertphillips@google.com Revert "Add a "conservative raster" flag to GrPipeline and implement in Vulkan"
2019-11-05 bungeman@google.com Fix empty run handling in trivial shaper iterators
2019-11-05 fmalita@chromium.org [skottie] Streamlined gradient stop merger
2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-05 mtklein@google.com implement SkColorFilterShader::isOpaque()
2019-11-05 csmartdalton@google.com Add a "conservative raster" flag to GrPipeline and implement in Vulkan
2019-11-05 egdaniel@google.com Add new macro for checking device lost when making Vulkan calls.
2019-11-05 borenet@google.com [recipes] CanvasKit, PathKit, some others don't need bot_update
2019-11-05 ethannicholas@google.com Reland "Implement sample mask and sample locations support in Vulkan"
2019-11-05 mtklein@google.com unify program() and uniforms()
2019-11-05 brianosman@google.com Reland "Fully embrace skcms types in SkColorSpace API"
2019-11-05 bsalomon@google.com Cleanup kGray_8 readback.
2019-11-05 fmalita@chromium.org [skottie] Fix trim path mode interpretation
2019-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6c7208f93d6e..67527cb45293 (10 commits)
2019-11-05 fmalita@chromium.org [skottie] Use SkColor4f for gradient color stops
2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-05 benjaminwagner@google.com Fail Skpbench on unsupported hardware
2019-11-05 herb@google.com Speed up diff canvas using small bit vector
2019-11-05 mtklein@google.com add color filter support
2019-11-05 mtklein@google.com x86-64 JIT support for Op::index
2019-11-05 csmartdalton@google.com ccpr: Fail gracefully when atlas instantiation fails
2019-11-05 bsalomon@google.com Add valgrind suppressions for GrClearImage
2019-11-05 robertphillips@google.com Revert "Fully embrace skcms types in SkColorSpace API"
2019-11-05 mtklein@google.com simpler uniforms() api
2019-11-05 mtklein@google.com merge key() and CanBuild() into CacheKey()
2019-11-05 mtklein@google.com indent loop so it stands out

Created with:
  gclient setdep -r src/third_party/skia@cdc0c23f1a2e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-05 23:45:39 -05:00
Matt Carroll
2ddf0e8cf4 Fix splash screen lookup. (#44131) (flutter/engine#13660) 2019-11-06 04:37:48 +00:00
Greg Spencer
1b80f40efa Fix editing selection and deletion on macOS (flutter/engine#13702)
This fixes the selection and deletion during text editing on macOS so that it can handle selections that have a base (selection start) that is after the extent (selection end) in the string.

Apparently the insertText:replacementRange on macOS can supply an NSRange object that has negative values for the length (even though the length is an unsigned NSUInteger). This change checks for that case, and fixes the range of characters replaced in the text to have the right bounds.

Also, I added an additional updateEditState after the state is set from the framework, since there is a timing problem: when the delete key is pressed, it sends an insertText message, which updates the framework state after the framework has already sent its state update to delete the selected region. This additional updateEditState puts the engine and framework back in sync again. Ideally, we would just avoid sending the insertText message, but there's really no way for the engine to know if the pressed key is part of an edit sequence or not.
2019-11-05 19:17:52 -08:00
Mouad Debbar
c7ab18cec2 [web] Don't send keyboard events from text fields to flutter (flutter/engine#13699) 2019-11-05 19:00:51 -08:00
Filip Filmar
8cb106f918 [fuchsia] Temporarily disable intl provider (flutter/engine#13696)
The intention of the property provider is to try to connect, not
bail out if connection is not possible.

This code tried to connect unconditionally, which is not what we wanted.
Removing this initialization code to enable a roll, and will fix in a
followup.
2019-11-05 18:51:37 -08:00
Matt Carroll
9c4534c7dd Fix plugin registrant reflection path. (#44161) (flutter/engine#13698) 2019-11-05 23:36:35 +00:00
Darren Austin
bb82d46bdb Added Semantic header support on Android. (flutter/engine#13262)
Added Semantic header support on Android.
2019-11-05 15:27:25 -08:00
Darren Austin
b9c225a35d Fixed the scroll direction for iOS horizontal accessibility scroll events. (flutter/engine#13651)
* Fixed the scroll direction for horizonatal accessibilty scroll events.

* Updated the comment describing the scroll direction mapping.
2019-11-05 15:25:18 -08:00
chunhtai
a1824112a4 Issues/39832 reland (flutter/engine#13642)
* Reland "Added new lifecycle enum (#11913)"
2019-11-05 14:52:16 -08:00
Jason Simmons
3c3c69c4af Fix Class.forName unchecked call warning (flutter/engine#13695) 2019-11-05 13:45:57 -08:00
skia-flutter-autoroll
784e440ebc Roll src/third_party/skia 4a4f34b76f3a..f3d4109a793b (1 commits) (flutter/engine#13659)
https://skia.googlesource.com/skia.git/+log/4a4f34b76f3a..f3d4109a793b

git log 4a4f34b76f3a..f3d4109a793b --date=short --no-merges --format='%ad %ae %s'
2019-11-05 mtklein@google.com add (x,y) params to shader program()

Created with:
  gclient setdep -r src/third_party/skia@f3d4109a793b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-05 16:41:50 -05:00
Mouad Debbar
a15479ce5f [web] Ignore changes in *.ttf files in felt build watch mode (flutter/engine#13634) 2019-11-05 13:31:51 -08:00
Mouad Debbar
0fac649339 Fix bug where Enter doesn't add new line in multi-line fields (flutter/engine#13630) 2019-11-05 13:31:40 -08:00
Gary Qian
c5f7b9536d Add 'Cough' test font and support multiple test fonts. (flutter/engine#13649) 2019-11-05 12:27:34 -08:00
skia-flutter-autoroll
245d5f994e Roll src/third_party/skia 4cc2dc64ff13..4a4f34b76f3a (19 commits) (flutter/engine#13637)
https://skia.googlesource.com/skia.git/+log/4cc2dc64ff13..4a4f34b76f3a

git log 4cc2dc64ff13..4a4f34b76f3a --date=short --no-merges --format='%ad %ae %s'
2019-11-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-04 brianosman@google.com Fully embrace skcms types in SkColorSpace API
2019-11-04 michaelludwig@google.com Make SkBlendMode_AsCoeff() public
2019-11-04 bsalomon@google.com Some improvements to backend texture creation.
2019-11-04 jvanverth@google.com Fix memory leak in iOS viewer.
2019-11-04 robertphillips@google.com Use QuadHelper and PatternHelper in more places
2019-11-04 herb@google.com Fix fuzz bug in isValid for SkDescriptor
2019-11-04 fmalita@chromium.org [skottie] Add support for gradient opacity stops
2019-11-04 michaelludwig@google.com Return coverage from inset() call instead of using a separate function.
2019-11-04 mtklein@google.com updateUniforms() just once
2019-11-04 fmalita@chromium.org [skottie] Add a couple more 3D tests
2019-11-04 brianosman@google.com Update comment on isNumericalTransferFn to clarify that fn is always set
2019-11-04 michaelludwig@google.com Skip unnecessary moveTo in degenerate quad calculations
2019-11-04 borenet@google.com Reland "[recipes] Assert that Git is obtained from CIPD"
2019-11-04 penghuang@chromium.org Make GrVkResource::Trace thread safe.
2019-11-04 borenet@google.com [infra] Make SkottieWASM and LottieWeb use git from CIPD
2019-11-04 brianosman@google.com SkColorMatrix cleanup
2019-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e96039218e9d..6c7208f93d6e (8 commits)
2019-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fda994c63075..aaa64b76c0b4 (8 commits)

Created with:
  gclient setdep -r src/third_party/skia@4a4f34b76f3a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-04 21:23:20 -05:00
Chinmay Garde
df53c9f095 Ensure that the CAMetalLayer FBO attachments can be read from. (flutter/engine#13643)
By default, the CAMetalLayer backing store is a framebuffer attachment that is
only optimized for display. However, effects such as backdrop filters require
renderbuffer readback. Making this calls will result in exceptions. Disable the
write only optimization on such backing store.

Fixes https://github.com/flutter/flutter/issues/43555
2019-11-04 17:28:51 -08:00
chunhtai
2958712751 Revert "Added new lifecycle enum (#11913)" (flutter/engine#13632)
This reverts commit 583e1335bbf9842ff4dc349021c6c71e6141fffe.
2019-11-04 13:40:20 -08:00
chunhtai
583e1335bb Added new lifecycle enum (flutter/engine#11913) 2019-11-04 12:33:41 -08:00
skia-flutter-autoroll
a869557923 Roll src/third_party/skia 8e083eee8ece..4cc2dc64ff13 (1 commits) (flutter/engine#13543)
https://skia.googlesource.com/skia.git/+log/8e083eee8ece..4cc2dc64ff13

git log 8e083eee8ece..4cc2dc64ff13 --date=short --no-merges --format='%ad %ae %s'
2019-11-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

Created with:
  gclient setdep -r src/third_party/skia@4cc2dc64ff13

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-04 14:28:23 -05:00
Yegor
06cdc0299f fix getBoxesForRange for zero-length ranges (flutter/engine#13483) 2019-11-04 10:16:38 -08:00
skia-flutter-autoroll
d09f110c38 Roll src/third_party/skia 283ec65f632a..8e083eee8ece (32 commits) (flutter/engine#13489)
https://skia.googlesource.com/skia.git/+log/283ec65f632a..8e083eee8ece

git log 283ec65f632a..8e083eee8ece --date=short --no-merges --format='%ad %ae %s'
2019-11-01 robertphillips@google.com Tighten up min and max vertex indices passed to GrTextureOp's meshes
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-01 michaelludwig@google.com Progress towards consolidating aa mask and edge distances
2019-11-01 ethannicholas@google.com Revert "Implement sample mask and sample locations support in Vulkan"
2019-11-01 ethannicholas@google.com Implement sample mask and sample locations support in Vulkan
2019-11-01 kjlubick@google.com [canvaskit] Add relative SkPath operators
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-01 robertphillips@google.com Revert "Reduce max # of AA Quads that can be merged or chained into a single GrTextureOp"
2019-11-01 borenet@google.com Revert "[recipes] Assert that Git is obtained from CIPD"
2019-11-01 senorblanco@chromium.org Dawn: update to recent texture proxy changes.
2019-11-01 borenet@google.com [recipes] Assert that Git is obtained from CIPD
2019-11-01 borenet@google.com [infra] Make CheckGeneratedFiles use git from CIPD
2019-11-01 mtklein@google.com opaque shaders and srcover -> src
2019-11-01 mtklein@google.com get rid of Uniforms
2019-11-01 michaelludwig@google.com Refactor tessellation metadata to move towards independent inset/outset calculations
2019-11-01 mtklein@google.com paint color -> shader
2019-11-01 mtklein@google.com paint alpha scaling as its own effect
2019-11-01 senorblanco@chromium.org Dawn: fix RTHeight adjustment.
2019-11-01 robertphillips@google.com Reduce max # of AA Quads that can be merged or chained into a single GrTextureOp
2019-11-01 halcanary@google.com tools/git-sync-deps: enforce commit hash in DEPS, not tags or branches
2019-11-01 egdaniel@google.com Use GrSurfaceProxyView for dst proxies.
2019-11-01 mtklein@google.com add --quick to fm
2019-11-01 michaelludwig@google.com Remove extraneous semicolons
2019-11-01 mtklein@google.com add GM for exercising interesting paths in SkVMBlitter
2019-11-01 mtklein@google.com try hashing shaders via their program
2019-11-01 brianosman@google.com Add BT2020 (non-constant-luminance) YUV color space
2019-11-01 brianosman@google.com Remove SK_LEGACY_YUV_MATRICES
2019-11-01 robertphillips@google.com Update GrTextureOp to use index buffer offsets for draws
2019-11-01 borenet@google.com [infra] Update git, make [Canvas|Path]Kit et al use git from CIPD
2019-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 841b01678c49..e96039218e9d (6 commits)
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@8e083eee8ece

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jcgregorio@google.com
2019-11-02 13:57:53 -04:00
xster
7e3e60d902 Release shim bindings when detaching (flutter/engine#13432) 2019-11-01 17:53:15 -07:00