1949 Commits

Author SHA1 Message Date
Nathan Rogers
1ce85bec2f
[flutter_runner] Enable Skia tracing by default on Fuchsia (#13457)
Since Flutter tracing is wired up to Fuchsia system level tracing (and
that includes Skia tracing within Flutter), it makes more sense to
enable Skia tracing by default on Fuchsia, and to control Flutter Skia
tracing, rely on whether Fuchsia system tracing is enabled, in progress,
and contains the "skia" category.
2019-12-11 21:03:12 -08:00
Kaushik Iska
9bafb3cd3c
[tests] Use distinct begin and end times (#14361) 2019-12-11 17:23:49 -08:00
xster
fc8cafb3c6
objcdoc fix for some ambiguity (#14367) 2019-12-11 16:43:22 -08:00
Wu Zhong
9e4c6ad40c Fix CGMutablePathRef memory leaks when the path is invalid. (#14275) 2019-12-11 15:52:29 -08:00
Chinmay Garde
0a40f3d784
Assert that arc end caps on canvases with root surface transformations are drawn correctly. (#14359)
Verifies that the Skia commit https://skia-review.googlesource.com/c/skia/+/259174 has been pulled into the engine. This should have happened in the roll https://github.com/flutter/engine/pull/14345.

Fixes https://github.com/flutter/flutter/issues/46691
Fixes b/142280381
2019-12-11 15:17:34 -08:00
Jim Graham
85953615eb
Conditionally use offscreen root surface only when needed
Currently helps primarily on iOS when no BackdropFilter is present by lowering energy usage
2019-12-11 15:10:55 -08:00
Kaushik Iska
fb9dfe0fb6
[fuchsia] Move async_get_default_dispatcher include to the header (#14351) 2019-12-11 13:40:38 -08:00
Kaushik Iska
18519e9169
Roll fuchsia/sdk/core/linux-amd64 from UdfLO... to 9wKTl... (#14342)
* Roll fuchsia/sdk/core/linux-amd64 from UdfLO... to 9wKTl...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

* async set dispatcher is now from async-default
2019-12-11 11:47:30 -08:00
Kaushik Iska
6430ecfd39
[fuchsia] Do not Execute paint tasks when there is no vsync (#14298)
This should also reduce the number of OnSurfacesPresented calls
made.
2019-12-10 18:03:55 -08:00
liyuqian
212fbbaf82
Cleanup the IO thread GrContext (#14265)
Fixes https://github.com/flutter/flutter/issues/19558

This is tested by the devicelab test fast_scroll_large_images__memory
2019-12-10 16:02:02 -08:00
Craig Stout
b2ab78fb41 [shell][fuchsia] Add lib/async/default.h
For async_get_default_dispatcher().
2019-12-09 15:21:45 -08:00
Andy Weiss
5b870a218f Add support for setting window size limits for glfw (#13415)
Add a function to the window which calls the glfw function for fixing
the size limits of the window. This can then be called after window
creation.
2019-12-08 13:58:58 -08:00
Kaushik Iska
f5250ec9b1
[fuchsia] SnapToNextPhase refactor + add tests and documentation (#14158) 2019-12-06 13:47:36 -08:00
Filip Filmar
29998f07fa Configures ICU to load the timezone data (#13952)
The timezone data in Fuchsia is at a fixed path. This will have the
flutter runner attempt to load it and log, but not fail if loading
does not work out.

Added two tests

(1) Shows that the specific TZ data version loaded takes effect after
initialization

(2) Shows that when TZ data files are absent the initialization
continues.
2019-12-05 17:32:55 -08:00
Dan Field
2a1ade7908
Raise API level for reportFullyDrawn (#14146) 2019-12-05 14:51:55 -08:00
gaaclarke
84497ba495
Started setting the FlutterOverlayView's bounds when it gets added to its superview. (#14018) 2019-12-05 13:53:07 -08:00
Dan Field
73da385c11
Disable a11y on detach (#14142) 2019-12-05 11:16:38 -08:00
David Worsham
d117ac979c
Wire up Opacity on Fuchsia, round 2 (#14024)
* Remove erroneous ChildView opacity

* Wire frame metrics through contexts

* Maintain layer stack inside of SceneBuilder

* Remove EnsureSingleChild

* Centralize system-composite and elevation logic

* Wire up OpacityLayer to Scenic
2019-12-04 19:29:31 -08:00
Chinmay Garde
e6887328a1
Fix platform view offsets incorrectly taking into account device pixel ratios. (#14135)
This issue was hidden by an incorrect test expectation that has been corrected.

Fixes b/144555069
Fixes https://github.com/flutter/flutter/issues/45991
2019-12-04 13:15:47 -08:00
David Worsham
2fc1e1bce1 Relanding: Add Flow unittests and fixtures (#14091) 2019-12-03 14:33:02 -08:00
Kaushik Iska
ea228f2f83
Revert "Fix fml_unittests (#14062)" (#14087)
This reverts commit 6c605f8a9624a99573c6801395f03bff7ee8cc4c.
2019-12-03 12:24:19 -08:00
liyuqian
84bf72917c
Revert PRs to unblock David and Jim's work (#14088)
* Revert "Add flow test fixtures and tests (#13986)"

This reverts commit 620f5281b819f304e8e9e945222e26b17b087cc3.

* Revert "Dynamically determine whether to use offscreen surface based on need (#13976)"

This reverts commit a86ef946563b020108320bbfb974bf7343284fd3.
2019-12-03 12:02:37 -08:00
David Worsham
620f5281b8 Add flow test fixtures and tests (#13986) 2019-12-03 09:43:02 -08:00
Dan Field
e3e2a3899e
Remove suprious warning (#14079) 2019-12-02 16:51:30 -08:00
stuartmorgan
063efce92b Report backing store changes in the macOS view (#13933) 2019-12-02 16:33:04 -08:00
Francisco Magdaleno
a68805bcf8
Listen to keyUp event on meta modified keys (#13984) 2019-12-02 16:17:19 -08:00
Dan Field
ea721ebf1a
Fix live region logic (#14081) 2019-12-02 15:49:15 -08:00
David Worsham
6c605f8a96
Fix fml_unittests (#14062) 2019-11-27 16:04:30 -08:00
Jim Graham
a86ef94656
Dynamically determine whether to use offscreen surface based on need (#13976)
Only use an offscreen surface on iOS if a layer which reads back from the destination surface, such as BackdropFilter, is present.
2019-11-27 15:01:25 -08:00
Gary Qian
bcb826759d
Revert "Do not default to downstream affinity on iOS insertText (#13852)" (#14053)
This reverts commit 0d60e1a324c8f17617855f4cfe7287368e15f3dd.
2019-11-28 07:34:40 +09:00
神楽坂花火
f61bec8467 Pass "null" when copy data is null to iOS pasteboard.string (#14046) 2019-11-27 23:46:30 +09:00
Gary Qian
2c0eee4392
Always set mEditable values when different in TextPlugin (#13951) 2019-11-27 07:51:04 +09:00
Dan Field
c139def52f
Avoid retaining self in block (#14022) 2019-11-26 14:47:00 -08:00
Chinmay Garde
ca68af252c
Add a separate target for Dart coverter on FML types. (#14011)
The converters are still in a separate target that must be included manually. This allows targets that depend on FML but not Dart runtime not have to depend on the runtime.

Adds a test that includes this target and tests image decompression from assets. There is also a test for the standalone DartConvertor in shell_unittests but not in fml_unittests be cause FML uni-tests cannot yet launch a VM. I will work on adding fixtures for those.
2019-11-26 13:33:56 -08:00
gaaclarke
27fa60793b
Added docstring for FlutterOverlayView. (#14019) 2019-11-26 13:10:24 -08:00
Kaushik Iska
201cfae8c7
[vulkan] Bundle vulkan validation layer so files (#13930)
Enable vulkan validation for Fuchsia in debug mode as well.
2019-11-25 16:09:56 -08:00
Chinmay Garde
9f6401362d
Don't crash but warn when the scene builder specifies no layers. (#14008) 2019-11-25 15:38:41 -08:00
Francisco Magdaleno
c0db9aa11f
Remove device independent mask (#14010) 2019-11-25 14:55:12 -08:00
Jason Simmons
c7ec5bbc1c
Convert images to raster on the GPU thread for Image.toByteData (#13647)
If the image is a cross-context image that might be read from the GPU thread
during onscreen rendering, then it is not safe to read it concurrently from
the IO thread as part of Image.toByteData.

If the GPU thread does not have a graphics context, then fall back to
converting the image on the IO thread.

Fixes https://github.com/flutter/flutter/issues/30697
2019-11-25 14:44:57 -08:00
David Worsham
e2aa235ab8
Fix most fml tests on Fuchsia (#14007)
* Add fuchsia MessageLoopImpl; fix several tests
2019-11-25 14:16:50 -08:00
gaaclarke
97a23a80e1
Made a way to turn off the OpenGL operations on the IO thread for backgrounded apps (#13908) 2019-11-22 14:08:33 -08:00
Gary Qian
0d60e1a324
Do not default to downstream affinity on iOS insertText (#13852) 2019-11-22 14:02:50 -08:00
gaaclarke
89e395853c
Refactor to passing functions by const ref (#13975)
Moved our code to passing functions by const ref
2019-11-22 12:20:02 -08:00
Matt Carroll
7c5a954dd3
Removed GET_ACTIVITIES flag from all manifest meta-data lookups. (#38891) (#13932) 2019-11-21 15:00:27 -08:00
Craig Stout
e307b05b7d [shell][fuchsia] Migrate away from deprecated async loop configs 2019-11-21 13:49:53 -08:00
George Wright
537590377e
Ensure we use the base CompositorContext's AcquireFrame method when screenshotting (#13934)
This ensures we rasterize into the canvas passed in as subclasses may reimplement AcquireFrame in different ways that don't utilize the canvas object passed in (such as Fuchsia's flutter_runner::CompositorContext).
2019-11-20 14:09:27 -08:00
Ian McKellar
a5673e3a1f
[flutter_runner] fix a11y tests (#13947)
Instead of running over 400000000 nodes, do something a little quicker.
2019-11-20 12:11:35 -08:00
Chinmay Garde
75ea3e2445
Expose the platform view mutator stack to custom compositors. (#13731)
This allows custom compositors to affect scene builder modifications made
to the platform view.

Fixes https://github.com/flutter/flutter/issues/44211
Fixes b/143612326
2019-11-19 10:35:41 -08:00
Chinmay Garde
5924eebd0c
Add virtual destructor to GPUSurfaceSoftwareDelegate. (#13918) 2019-11-19 10:15:34 -08:00
chunhtai
132d38cd22
Moves pointer event sanitizing to engine. (#13697)
* Moves pointer event sanitizing to engine

* fix comment format

* fix formatting

* addressing comment

* fix format

* fix format

* addressing comment
2019-11-19 09:48:25 -08:00