1780 Commits

Author SHA1 Message Date
Michael Goderbauer
ec7ebd8373 Remove ignores that are not ignoring anything (flutter/engine#25252) 2021-03-25 16:12:26 -07:00
Mouad Debbar
f8d60eac0b [web] More meaningful test for font features (flutter/engine#25206) 2021-03-25 14:59:05 -07:00
Ferhat
0ad0b86cab [web] Add samsung browser detection (flutter/engine#25198) 2021-03-25 11:49:39 -07:00
Ferhat
b9f5ee0604 [web] Fix drawImage colorFilter with dstATop blend mode (flutter/engine#25165) 2021-03-25 10:45:28 -07:00
Michael Goderbauer
d627e66bcf remove ignores (flutter/engine#25131) 2021-03-25 10:19:01 -07:00
Ferhat
4a40574762 Fix exactCullRect computation (flutter/engine#24651) 2021-03-25 09:01:27 -07:00
Zachary Anderson
7c93f9b45f Revert "Call Dart plugin registrant if available (#23813)" (flutter/engine#25221) 2021-03-25 08:59:02 -07:00
Michael Goderbauer
5d4faf7368 Sync analyzer_options.yaml (flutter/engine#25129) 2021-03-23 17:51:01 -07:00
Michael Goderbauer
265a223709 Remove ignores that are not ignoring anything (flutter/engine#25128) 2021-03-23 17:46:01 -07:00
Mouad Debbar
9297fa9eb2 [web] Fix few potential issues with DOM/Bitmap rendering (flutter/engine#25126) 2021-03-23 12:53:03 -07:00
Mouad Debbar
586df25fe1 [web] Implement font features in the html renderer (flutter/engine#25088) 2021-03-23 12:15:26 -07:00
Jason Simmons
77995f0b9a Do not return a Minikin font collection if the SkFontStyleSet is unable to create any typefaces (flutter/engine#24951) 2021-03-19 11:36:01 -07:00
Ferhat
3b6c8434cb [web] Fix handling of ClipOp.none (flutter/engine#25080) 2021-03-18 15:58:26 -07:00
Jason Simmons
cda084e0a3 Complete Picture.toImage futures with an exception if the image is null (flutter/engine#25058) 2021-03-18 10:56:01 -07:00
Harry Terkelsen
e8a33f1be4 Improve error message when CanvasKit is unable to parse a font (flutter/engine#24827) 2021-03-16 09:16:10 -07:00
Yegor
17bc7504a7 revert auto-enabling semantics (flutter/engine#24978) 2021-03-12 13:52:02 -08:00
Mouad Debbar
bbea85c8cc [web] Skip the history tests that introduced flakiness (flutter/engine#24957) 2021-03-11 21:52:41 -08:00
Yegor
5a5f326745 [web] Make window.locale(s) non-null; upgrade to null safe deps (flutter/engine#24922)
* Make window.locale(s) non-null

* upgrade deps to null-safe; migrate some test libs
2021-03-11 14:28:49 -08:00
Yegor
f98d97d32f [web:semantics] fix node positioning; expose debug tree (flutter/engine#24903) 2021-03-11 13:21:01 -08:00
Mouad Debbar
8eeb5f9c3a [web] Silence flaky history test (flutter/engine#24949) 2021-03-11 12:50:07 -08:00
Yegor
90930adf2a Respond to Skia platform messages (flutter/engine#24880) 2021-03-11 12:20:01 -08:00
Jason Simmons
300a119335 Complete the Scene.toImage future with an error if rasterization fails (flutter/engine#24877)
Also fix the nullability annotations on _futurize

Fixes https://github.com/flutter/flutter/issues/76591
2021-03-10 16:51:27 -08:00
Mouad Debbar
b29e65be16 [web] Add few awaits in history tests (flutter/engine#24934) 2021-03-10 15:50:02 -08:00
Mouad Debbar
eea586c427 [web] Reland: Fix painting of last placeholder in paragraph (flutter/engine#24905) 2021-03-10 15:30:01 -08:00
Yegor
a8c65cb9cb Expand FilterQuality API docs (flutter/engine#24582) 2021-03-10 15:25:02 -08:00
Mouad Debbar
2330650208 [web] Reland: Fix url updates when using Router (flutter/engine#24876) 2021-03-10 09:38:22 -08:00
chunhtai
ccb762f01b Adds setText to web engine (flutter/engine#24873) 2021-03-09 23:50:02 -08:00
Chris Bracken
13cf185e1c Correct setup-related typos (flutter/engine#24846)
Corrects uses of setup as a verb to 'set up', leaves noun/noun-phrase
forms of setup as 'setup'. Also settles on 'teardown' as opposed to
tear-down for consistency across the codebase.

A few other minor comment/wording corrections.
2021-03-08 17:31:10 -08:00
Chris Bracken
8aefbe04f6 Revert "[web] Fix url updates when using Router (#24798)" (flutter/engine#24870)
Seeing many web tests fail with errors like:

```
00:07 +0 -11: test/cupertino/search_field_test.dart: clear button removes text
══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
The following message was thrown:
Could not navigate to initial route.
The requested route name was: "/default"
There was no corresponding route in the app, and therefore the initial route specified will be
ignored and "/" will be used instead.
════════════════════════════════════════════════════════════════════════════════════════════════════

00:07 +0 -12: test/cupertino/search_field_test.dart: clear button removes text [E]
  Test failed. See exception logs above.
  The test description was: clear button removes text
```

This reverts commit ee8a5e9bd0e8afaded0ea3265e7abe974caf98e1.
2021-03-08 12:21:52 -08:00
Mouad Debbar
a0f418b769 [web] Don't set both color and foreground at the same time (flutter/engine#24828) 2021-03-05 17:38:19 -08:00
Mouad Debbar
ee8a5e9bd0 [web] Fix url updates when using Router (flutter/engine#24798) 2021-03-05 17:34:01 -08:00
chunhtai
92d11213ff Adds set text action for voice access (flutter/engine#24734) 2021-03-04 17:44:01 -08:00
Chris Bracken
a15f44a9e2 Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773)
This broke the Linux Web Tests target in the framework tests.

Example failure:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tests/11335/overview

Failure log:
```
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: WidgetSpan calculate correct intrinsic heights [E]
  Test failed. See exception logs above.
  The test description was: WidgetSpan calculate correct intrinsic heights

01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
Assertion failed: file:///b/s/w/ir/k/flutter/packages/flutter/lib/src/rendering/box.dart:2237:16
!RenderObject.debugCheckingIntrinsics
is not true

The relevant error-causing widget was:
  Text file:///b/s/w/ir/k/flutter/packages/flutter_test/lib/src/binding.dart:567:12

When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49  throw_
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3    assertFailed
../packages/flutter/src/rendering/layer.dart.js 4485:79                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4551:26                          debugAssertDoesMeetConstraints
../packages/flutter/src/rendering/layer.dart.js 4380:14                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4382:26                          set size
../packages/flutter/src/rendering/paragraph.dart.js 786:17                       performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/shifted_box.dart.js 451:36                     performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/layer.dart.js 4875:58                          performLayout
../packages/flutter/src/rendering/layer.dart.js 3279:14                          [_layoutWithoutResize]
../packages/flutter/src/rendering/layer.dart.js 6876:107                         flushLayout
../packages/flutter_test/src/_matchers_web.dart.js 3990:30                       drawFrame
../packages/flutter/src/rendering/layer.dart.js 6128:12                          [_handlePersistentFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 764:9                          [_invokeFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 732:37                         handleDrawFrame
../packages/flutter_test/src/_matchers_web.dart.js 3954:12                       scheduleWarmUpFrame
../packages/flutter/src/widgets/widget_span.dart.js 52123:11                     <fn>
../packages/flutter/src/widgets/widget_span.dart.js 52125:7                      runApp
../packages/flutter_test/src/_matchers_web.dart.js 3647:18                       _runTestBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54            runBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5            _async
../packages/flutter_test/src/_matchers_web.dart.js 3644:20                       [_runTestBody]
../dart-sdk/lib/async/zone.dart 1386:13                                          _rootRunBinary
../dart-sdk/lib/async/zone.dart 1272:19                                          runBinary
../packages/flutter_test/src/_matchers_web.dart.js 3636:16                       [_runTest]
../packages/flutter_test/src/_matchers_web.dart.js 4072:44                       <fn>
../packages/fake_async/fake_async.dart.js 141:96                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/clock/src/stopwatch.dart.js 364:18                                   withClock
../packages/fake_async/fake_async.dart.js 141:55                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/fake_async/fake_async.dart.js 141:20                                 run
../packages/flutter_test/src/_matchers_web.dart.js 4067:17                       runTest
../packages/flutter_test/src/_matchers_web.dart.js 5312:24                       <fn>
../packages/test_api/src/frontend/async_matcher.dart.js 862:17                   <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50            <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 179:98              <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 179:80              <fn>
../dart-sdk/lib/async/zone.dart 1362:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1265:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 155:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 707:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 736:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 406:9                                     <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 170:71              <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1162:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1202:23                                          callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                              _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                               _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15           <fn>

The following RenderObject was being processed when the exception was fired: RenderParagraph#e6e8f relayoutBoundary=up1 NEEDS-PAINT:
  creator: RichText ← Text ← Center ← Container-[#9a020] ← [root]
  parentData: offset=Offset(0.0, 0.0) (can use size)
  constraints: BoxConstraints(0.0<=w<=800.0, 0.0<=h<=600.0)
  size: Size(640.0, 40.0)
  textAlign: start
  textDirection: ltr
  softWrap: wrapping at box width
  overflow: clip
  maxLines: unlimited
This RenderObject had the following child:
    text: TextSpan
```

This reverts commit bcba78b6829849ffe7c4638bd69b3ceeb7631666.
2021-03-03 22:27:07 -08:00
Mouad Debbar
7e1da11b95 [web] Fix pointer events for Wacom pen (flutter/engine#24719) 2021-03-02 10:47:41 -08:00
Mouad Debbar
bcba78b682 [web] Fix painting of last placeholder in paragraph (flutter/engine#24716) 2021-03-02 10:30:21 -08:00
Yegor
ba5ca8be29 Revert "remove _getRRect: fixes assertion error (#24688)" (flutter/engine#24718)
This reverts commit 3a5c7654ab16d35c26e43f49eba437a537361585.

The commit broke golden tests.
2021-03-01 15:08:56 -08:00
LongCatIsLooong
deec3a0d07 Reland "TextStyle level leadingDistribution (#24025)" reverted in #24665 (flutter/engine#24668) 2021-03-01 14:55:03 -08:00
Yegor
3a5c7654ab remove _getRRect: fixes assertion error (flutter/engine#24688) 2021-03-01 12:12:50 -08:00
Jason Simmons
274b163520 Declare a constant for the bit index of the force_strut_height flag value (flutter/engine#24675) 2021-02-27 10:01:01 -08:00
LongCatIsLooong
b82a309954 Revert "TextStyle level leadingDistribution (#24025)" (flutter/engine#24665) 2021-02-26 12:41:01 -08:00
xxrl
c8fa179207 remove useless code (flutter/engine#24546) 2021-02-26 11:36:01 -08:00
Ferhat
a3eec1815c [web] Add xcode-symlinks flag to felt tool (flutter/engine#24556) 2021-02-25 14:26:41 -08:00
LongCatIsLooong
e10becadf3 TextStyle level leadingDistribution (flutter/engine#24025) 2021-02-25 11:46:02 -08:00
Ferhat
c694e1d965 [web] Implement Canvas.drawPicture (flutter/engine#24574) 2021-02-24 13:01:44 -08:00
Ferhat
5298568b15 skip shadermask test for webkit (flutter/engine#24602) 2021-02-24 12:01:14 -08:00
Jim Graham
e3b2cc8ce9 backdrop filter layer should report cull_rect as its paint bounds (flutter/engine#24489) 2021-02-23 18:02:49 -08:00
Mouad Debbar
a3117e9445 [web] Fix placeholder-only paragraphs (flutter/engine#24572) 2021-02-23 17:16:01 -08:00
Michael Reed
5d1c5e1c51 Restore call to setFilterQuality (flutter/engine#24542) 2021-02-22 09:21:02 -08:00
Ferhat
639f8a2474 NNBD cleanup (flutter/engine#24529) 2021-02-19 16:45:51 -08:00
Ferhat
f6c8fa6910 Refactor gradient renderer to produce image. Implement gradient based Shadermask (flutter/engine#24029) 2021-02-19 16:45:23 -08:00