DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,031 Commits 882 Branches 1,069 Tags
Commit Graph

23632 Commits

Author SHA1 Message Date
Jonah Williams
199e8abb3f [Impeller] Sync presentation when rendering into FlutterImageView. (flutter/engine#44881) 
Fixes https://github.com/flutter/flutter/issues/131730

When the Android embedder starts rendering into a FlutterImageView, notify the Impeller context to block on submitKHR.
 2023-08-29 00:00:54 +00:00
Jackson Gardner
fd9e7e8e8f [skwasm] encode PNGs using browser APIs (flutter/engine#45187) 
This allows us to remove libpng from skia entirely, which saves us about 25kb brotli compressed.

Note, this should not change any functionality. The existing functionality is covered by the unit tests here: bfcb9d08e8/lib/web_ui/test/ui/image_golden_test.dart (L197-L197)
 2023-08-28 23:08:46 +00:00
skia-flutter-autoroll
bbc8869c1c Roll Dart SDK from 5d3ab5db5037 to 2900ad211f38 (3 revisions) (flutter/engine#45192) 
https://dart.googlesource.com/sdk.git/+log/5d3ab5db5037..2900ad211f38

2023-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-117.0.dev
2023-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-116.0.dev
2023-08-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-115.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 22:40:01 +00:00
skia-flutter-autoroll
bfcb9d08e8 Roll Skia from 335f748463db to 66e367b12e96 (1 revision) (flutter/engine#45189) 
https://skia.googlesource.com/skia.git/+log/335f748463db..66e367b12e96

2023-08-28 johnstiles@google.com Change extraneous sampler/texture check to an assertion.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 22:20:47 +00:00
Jonah Williams
089cb17e97 [Impeller] Cache Skia text bounds computation. (flutter/engine#45150) 
Fixes https://github.com/flutter/flutter/issues/133388

Just use the TextBounds that Skia gives us. These are slightly larger but already computed. If the larger bounds are a problem we can go back to Impeller computed bounds, but using a cached computation.

### Skia
![flutter_02](https://github.com/flutter/engine/assets/8975114/c1824eb3-bd82-47b0-a6af-282e51419a00)

### Impeller
![flutter_03](https://github.com/flutter/engine/assets/8975114/bb2eff8c-ae6e-4c59-90a5-228f8a115dca)
 2023-08-28 21:49:41 +00:00
skia-flutter-autoroll
ec6964204d Roll Skia from 83f6fbad8a38 to 335f748463db (1 revision) (flutter/engine#45186) 
https://skia.googlesource.com/skia.git/+log/83f6fbad8a38..335f748463db

2023-08-28 johnstiles@google.com Fix loop-unrolling for single-iteration inclusive reverse loops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 21:33:04 +00:00
Matan Lurey
fd931a48e5 Explain how to update the embedder/fixtures golden outputs. (flutter/engine#45184) 
Closes https://github.com/flutter/flutter/issues/133375.
 2023-08-28 20:54:43 +00:00
skia-flutter-autoroll
5f2a0a7679 Roll Skia from ded5d08a9999 to 83f6fbad8a38 (1 revision) (flutter/engine#45183) 
https://skia.googlesource.com/skia.git/+log/ded5d08a9999..83f6fbad8a38

2023-08-28 bungeman@google.com Specify COLRv1 gradient interpolation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 20:30:20 +00:00
Jonah Williams
e4d3c07fa5 [Impeller] Simplify color source + text with new Skia API. (flutter/engine#45090) 
The original implementation of arbitrary color source + text was quite complicated due to the fact that I had to use blending to emulate this functionality. Now that we can get paths from a given text data, I can instead make non solid color color sources and text just use the regular geometry + color source pipelines.

Fixes https://github.com/flutter/flutter/issues/132928
Fixes https://github.com/flutter/flutter/issues/132972
 2023-08-28 20:15:04 +00:00
Matan Lurey
254401dca0 Re-write docs for DlSkCanvas{Adapter|Dispatcher}. (flutter/engine#44961) 
Closes https://github.com/flutter/flutter/issues/132994.

I suspect this is imperfect, so please suggest any changes or additions (either using GitHub's tooling or as a review comment).

/cc @dnfield
 2023-08-28 20:06:14 +00:00
skia-flutter-autoroll
08fd91052e Roll Skia from 5baa2c74fbc6 to ded5d08a9999 (1 revision) (flutter/engine#45181) 
https://skia.googlesource.com/skia.git/+log/5baa2c74fbc6..ded5d08a9999

2023-08-28 johnstiles@google.com Revert "Pass colorspace-transform coefficients in a 4x4 matrix."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 19:33:04 +00:00
skia-flutter-autoroll
566723870e Roll Skia from 651ada29fcb0 to 5baa2c74fbc6 (2 revisions) (flutter/engine#45178) 
https://skia.googlesource.com/skia.git/+log/651ada29fcb0..5baa2c74fbc6

2023-08-28 michaelludwig@google.com Reland "Move 1D linear Gaussian FP to a runtime GrSkSLFP"
2023-08-28 johnstiles@google.com Pass colorspace-transform coefficients in a 4x4 matrix.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 18:40:18 +00:00
skia-flutter-autoroll
4b8cbe7e5b Roll Skia from 477659e6f41b to 651ada29fcb0 (3 revisions) (flutter/engine#45176) 
https://skia.googlesource.com/skia.git/+log/477659e6f41b..651ada29fcb0

2023-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9fc352d7f6e3 to b847b1b89c33 (6 revisions)
2023-08-28 fmalita@chromium.org [mesh2d demo] Initial styling
2023-08-28 johnstiles@google.com Shrink the $apply_swizzle function.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 17:53:02 +00:00
Brandon DeRosier
52da5a7633 [Impeller] Only enable captures in debug builds. (flutter/engine#45174) 
Disable Impeller captures on profile builds.

So that we can verify it doesn't have any overhead when build-time disabled in the benchmarks: https://github.com/flutter/flutter/issues/133440
 2023-08-28 17:34:03 +00:00
skia-flutter-autoroll
94b8556ae8 Roll Skia from ce99ad7b587e to 477659e6f41b (1 revision) (flutter/engine#45173) 
https://skia.googlesource.com/skia.git/+log/ce99ad7b587e..477659e6f41b

2023-08-28 johnstiles@google.com Avoid generating unnecessary _skParam variables in WGSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 17:05:58 +00:00
Jackson Gardner
69b2747ca3 Skwasm platform views (flutter/engine#43011) 
This implements platform views in Skwasm. There are a number of substantial changes rolled up in this change, including:
* Reworked the rendering system to use multiple canvases with a single WebGL context, via ImageBitmap rendering.
* Reworked our object management and bindings to use the `__externref_t` construct in C code.
* Upgraded emscripten to a much newer version
* Generified skwasm's scene builder to be able to work with any renderer that can produce `ImageBitmap` objects from Pictures, and whose `Canvas`, `Picture` and `ImageFilter` objects conform to `SceneCanvas`/`ScenePicture`/`SceneImageFilter`

For platform views themselves, most stuff is implemented except for clipping. I plan on doing that in a subsequent change.
 2023-08-28 16:29:14 +00:00
skia-flutter-autoroll
953f039ede Roll Skia from df783b542165 to ce99ad7b587e (2 revisions) (flutter/engine#45172) 
https://skia.googlesource.com/skia.git/+log/df783b542165..ce99ad7b587e

2023-08-28 brianosman@google.com Fix GL-tests bazel build
2023-08-28 johnstiles@google.com Show WGSL code in Viewer's Shader pane.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 16:21:04 +00:00
skia-flutter-autoroll
da5246ab14 Roll Skia from fe4f018ef935 to df783b542165 (1 revision) (flutter/engine#45171) 
https://skia.googlesource.com/skia.git/+log/fe4f018ef935..df783b542165

2023-08-28 brianosman@google.com Remove SK_VULKAN #ifdefs from GrBackendSurface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 15:37:04 +00:00
skia-flutter-autoroll
645fb7814f Roll Fuchsia Linux SDK from jnDJLdEAx34diOWFx... to AQZddYgKiWrQL8vny... (flutter/engine#45167) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 11:07:14 +00:00
skia-flutter-autoroll
0001a29d61 Manual roll Dart SDK from ab417bc74bb1 to 5d3ab5db5037 (17 revisions) (flutter/engine#45165) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/ab417bc74bb1..5d3ab5db5037

2023-08-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-114.0.dev
2023-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-113.0.dev
2023-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-112.0.dev
2023-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-111.0.dev
2023-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-110.0.dev
2023-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-109.0.dev
2023-08-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-108.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-107.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-106.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-105.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-104.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-103.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-102.0.dev
2023-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-101.0.dev
2023-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-100.0.dev
2023-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-99.0.dev
2023-08-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-98.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 07:04:59 +00:00
skia-flutter-autoroll
12073acc49 Roll Skia from 2582a06b4618 to 1ce3c2af0971 (2 revisions) (flutter/engine#45163) 
https://skia.googlesource.com/skia.git/+log/2582a06b4618..1ce3c2af0971

2023-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6587ca5b6e44 to 14707bc35498
2023-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7a3cf15a1fc1 to 6587ca5b6e44 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-28 06:22:23 +00:00
Jonah Williams
a03b6e3a36 [Impeller] SuboptimalKHR is not an exit condition. (flutter/engine#45157) 
Sometimes we can get SuboptimalKHR on swapchain aquisition, and if we dont treat that as success the app will exit.
 2023-08-27 22:05:14 +00:00
Matan Lurey
123bf44114 Use YAML >- to avoid strange formatting. (flutter/engine#45158) 
Partial (safe) re-land of https://github.com/flutter/engine/pull/44936.
 2023-08-27 14:52:08 -07:00
Matan Lurey
761720dc4c [Impeller] Implement TextDecoration (i.e. dashed lines) (flutter/engine#45041) 
Closes https://github.com/flutter/flutter/issues/126673.

Ideally, this would be an `#ifdef`, but currently Impeller is a runtime
flag, for reasons (CI capacity?)

~~To be able to write tests, I'd need
https://github.com/flutter/flutter/issues/133264 completed.~~ Edit:


![life-uh](https://github.com/flutter/engine/assets/168174/c77314e4-f3f9-4b0d-b3f7-5b070ef51308)

## Before

![Screenshot 2023-08-23 at 5 25 40
PM](https://github.com/flutter/engine/assets/168174/40576807-17f2-4f5f-ba56-3cd5771e472d)

## After

<img width="795" alt="Screenshot 2023-08-24 at 9 56 48 AM"
src="https://github.com/flutter/engine/assets/168174/0e33f705-6a71-4468-8ec8-372a2e98624e">
 2023-08-27 14:24:30 -07:00
Matan Lurey
fa81dcec02 Use SkTextBlob::bounds instead of TextFrame::getBounds(). (flutter/engine#45148) 
Closes https://github.com/flutter/flutter/issues/133157.
 2023-08-26 17:50:18 -07:00
skia-flutter-autoroll
a31b90edb8 Roll Fuchsia Linux SDK from IYiIm4zYdKPYfpOIG... to xYHxghcipvy5XZAK6... (flutter/engine#45151) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-26 21:06:00 +00:00
Jonah Williams
a04635d9e6 Revert "[Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas" (flutter/engine#45149) 
Reverts flutter/engine#45131

This is failing the Impeller variants of the unobstructed platform views tests:

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/132249/overview

```
Failing tests:
	-[UnobstructedPlatformViewTests testPlatformViewsMaxOverlays]
	-[UnobstructedPlatformViewTests testOneOverlay]
	-[UnobstructedPlatformViewTests testOneOverlayPartialIntersection]
	-[UnobstructedPlatformViewTests testTwoIntersectingOverlays]
	-[UnobstructedPlatformViewTests testOneOverlayAndTwoIntersectingOverlays]

** TEST FAILED **
```

We've retried it a few times so I suspect this isn't a flake.
 2023-08-26 19:31:39 +00:00
Dan Field
e9b2008748 [Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas (flutter/engine#45131) 
This is a reland of https://github.com/flutter/engine/pull/44248

Fixes https://github.com/flutter/flutter/issues/132416

Changes from last time:

- The `drawPoints` benchmark was failing to render anything meaningful because of an error in `AiksLayer` that resulted in an infinitely sized bounding rectangle poisoning the bounds with `NaN` (this happens, for example, with a `drawPaint` call, which that benchmark happens to use). Added a test covering this and filed https://github.com/flutter/flutter/issues/132770 to explore ways to avoid this in the future.
- There was a bug in `DlAiksCanvas::SaveLayer` where a `nullptr` `paint` but non-`nullptr` `backdrop` was failing to actually save the layer. This resulted in incorrect rendering.
- There was a bug in `impeller::Canvas::DrawPicture` that resulted in incorrect stencil depth counting. That was fixed separately by @bdero, but was the cause of incorrect rendering in some Wonderous screens.
- I've added a simple implementation for `AiksLayer::IsReplacing`. It does not currently compare as deeply as the `DisplayListLayer` version potentially does, but it is good enough to avoid the regression noted in https://github.com/flutter/flutter/issues/132071. That regression was on a benchmark that greatly benefits from partial repaint. With the new implementation, it still gains partial repaint where it previously did not. There is more work that can be done here, filed https://github.com/flutter/flutter/issues/133361 to track that work.

I merged but did not fully integrate the `DisplayListBuilder`/`CanvasToReceiver` work that @flar has done. I have a local experiment with that, but would prefer to see this land and run through the device lab so we get some better comparison numbers for which one performs better.
 2023-08-26 05:37:28 +00:00
skia-flutter-autoroll
c4c95dd2be Roll Skia from ac39b12fd835 to e64e8f4094b2 (1 revision) (flutter/engine#45136) 
https://skia.googlesource.com/skia.git/+log/ac39b12fd835..e64e8f4094b2

2023-08-26 michaelludwig@google.com Revert "Move 1D linear Gaussian FP to a runtime GrSkSLFP"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-26 02:00:23 +00:00
skia-flutter-autoroll
147ffbea6c Roll Skia from e67d9439a8c4 to ac39b12fd835 (1 revision) (flutter/engine#45133) 
https://skia.googlesource.com/skia.git/+log/e67d9439a8c4..ac39b12fd835

2023-08-25 johnstiles@google.com Remove GrBackendApi::kDawn.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-26 00:04:13 +00:00
skia-flutter-autoroll
a8c8493d5d Roll Skia from 40f4e01fca40 to e67d9439a8c4 (4 revisions) (flutter/engine#45132) 
https://skia.googlesource.com/skia.git/+log/40f4e01fca40..e67d9439a8c4

2023-08-25 michaelludwig@google.com Move 1D linear Gaussian FP to a runtime GrSkSLFP
2023-08-25 johnstiles@google.com Unify 'all GL contexts' with 'GL rendering contexts.'
2023-08-25 johnstiles@google.com Factor out context-type helper functions.
2023-08-25 michaelludwig@google.com Remove some testing-only image filter subclasses

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 22:57:04 +00:00
Brandon DeRosier
2e61f4d1a8 [Impeller] Reland debug captures and inspector. (flutter/engine#45094) 
Original PR: https://github.com/flutter/engine/pull/43764
 2023-08-25 15:13:01 -07:00
Brandon DeRosier
da50e36224 [Impeller] Fix mask blurs and the Gaussian blur coverage hint. (flutter/engine#45079) 
Resolves https://github.com/flutter/flutter/issues/132936.

* In some cases, mask blurs were getting applied twice.
* Coverage hint clipping was too aggressive on the second pass of the
gaussian blur.
* Rework the mask blur applicator to support gracefully falling back to
GPU-based color filters when necessary.

This fix requires us to cherry-pick:
https://github.com/flutter/engine/pull/43519
Going a revert-based route to fix all of these problems would also be
pretty complex.

https://github.com/flutter/engine/assets/919017/9ee5e856-af7a-42b9-b135-ea268c2ba53f
 2023-08-25 14:11:13 -07:00
Chris Yang
26e997b337 ios: remove shared_application and support app extension build (flutter/engine#44732) 
This PR turns on the flag to support engine to build app extension. 
When building for app extension, the usage of sharedApplication API is removed.

fixes https://github.com/flutter/flutter/issues/124286 and https://github.com/flutter/flutter/issues/124289

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 21:08:19 +00:00
skia-flutter-autoroll
75c5678a3f Roll Skia from 76672468e8d7 to 40f4e01fca40 (3 revisions) (flutter/engine#45126) 
https://skia.googlesource.com/skia.git/+log/76672468e8d7..40f4e01fca40

2023-08-25 johnstiles@google.com Treat GR_TEST_UTILS as defined or not, not 1 or 0.
2023-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 00368bd7466b to fc1cafa4c10c (15 revisions)
2023-08-25 michaelludwig@google.com Move fGpuBudgetInBytes outside of GRAPHITE_TEST_UTILS guard

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 20:51:40 +00:00
Zachary Anderson
d72727e744 Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093) 2023-08-25 20:29:05 +00:00
skia-flutter-autoroll
1645ca13fc Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121) 
https://skia.googlesource.com/skia.git/+log/56bb647a49ac..76672468e8d7

2023-08-25 johnstiles@google.com Remove gn flag 'skia_enable_sksl'.
2023-08-25 michaelludwig@google.com Replace GrMatrixConvolutionEffect with GrSkSLFP runtime effect
2023-08-25 johnstiles@google.com Revert "Make empty GN lists for Ganesh Dawn."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 20:03:04 +00:00
Yatendra Kumar
d2bfe45c44 Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880) 
## Description

This PR completes the documentation for `RasterStatus::kSkipAndRetry` in the `compositor_context.h` file. The previous comment ended abruptly, leaving ambiguity regarding the behavior when the thread merger is disabled.

### Changes:
- Added clarification on the behavior when the thread merger is disabled.
- Explained the potential performance implications when threads are not merged.

## Related Issues

https://github.com/flutter/flutter/issues/131814

## Tests

No tests were added as this PR only involves documentation changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 20:01:05 +00:00
gaaclarke
25873b17bd [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123) 
Just some documentation and cleanup while i'm trying to get render pass recycling working.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 19:59:21 +00:00
Zachary Anderson
41c9a99978 Revert "Fix global tests doing nothing." (flutter/engine#45125) 
Reverts flutter/engine#45097

Many failures on CI like:
```
ld: warning: ignoring file ../../../../out/ios_debug_sim_arm64_extension_safe/libocmock_shared.dylib, building for iOS Simulator-x86_64 but attempting to link with file built for iOS Simulator-arm64
ld: warning: ignoring file ../../../../out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib, building for iOS Simulator-x86_64 but attempting to link with file built for iOS Simulator-arm64
```


https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/131188/overview

Not sure if there are also other tests failing in different ways.
 2023-08-25 12:38:23 -07:00
skia-flutter-autoroll
714ed0931a Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118) 
https://skia.googlesource.com/skia.git/+log/ba7c5258d2b4..56bb647a49ac

2023-08-25 michaelludwig@google.com [skif] Add ::Empty() convenience factory
2023-08-25 egdaniel@google.com [Graphite] Add option to set independent, custom gpu budgets on Context and Recorders.
2023-08-25 kjlubick@google.com Change defined(GR_TEST_UTILS) -> GR_TEST_UTILS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 18:21:04 +00:00
Reid Baker
d8b11bc6fa Update gradle to 7.5.1 (flutter/engine#45113) 
fixes flutter/flutter#133259
Added gradle update instructions and bumped gradle version.
 2023-08-25 17:34:03 +00:00
Chris Yang
5734f9a52f Ignore unguarded-availability for unit test (flutter/engine#44852) 
Ignore ungarded-availability for unit test

fixes https://github.com/flutter/flutter/issues/128958

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 17:31:30 +00:00
Jonah Williams
843b0a5719 [Impeller] avoid hashing and std::vector growth when binding descriptor sets. (flutter/engine#45070) 
We call allocateAndBindDescriptorSets once for every cmd rendered, so this time can bubble up quite a bit. From the traces I've gathered map emplacement (emplace_unique_key_args) and std::vector growth (__push_back_slow_path) contribute the most to this trace.

I think we have physical limits on the number of descriptors we can bind, though I'm not sure if we enforce that anywhere?
 2023-08-25 17:22:43 +00:00
skia-flutter-autoroll
578dc16da4 Roll Skia from 4b30261160a2 to ba7c5258d2b4 (5 revisions) (flutter/engine#45116) 
https://skia.googlesource.com/skia.git/+log/4b30261160a2..ba7c5258d2b4

2023-08-25 johnstiles@google.com Reland "Factor out ContextType from GrContextFactory."
2023-08-25 robertphillips@google.com [graphite] Loosen assert in MakeColorSpace_Test
2023-08-25 robertphillips@google.com Add GrRecordingContext/GrDirectContext::supportsProtectedContent
2023-08-25 johnstiles@google.com Make empty GN lists for Ganesh Dawn.
2023-08-25 robertphillips@google.com Fix bug in picture image cache key creation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 16:57:55 +00:00
skia-flutter-autoroll
2fe6ab4dd5 Roll Fuchsia Linux SDK from R_deCnScH70FbSeii... to u8ovJYTk3nN78xF4X... (flutter/engine#45115) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 16:47:04 +00:00
Greg Spencer
87e6e728ca Add quotes around Doxygen configuration values (flutter/engine#45087) 
## Description

Add quotes are the Doxygen configuration values that may have spaces, since otherwise Doxygen strips them.
 2023-08-25 16:41:04 +00:00
Jonah Williams
c94e38673c [Impeller] fix validation warning on iOS/macOS when compiling external texture shader. (flutter/engine#45080) 
```
[VERBOSE-2:validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create render pipeline for TextureFillExternal Pipeline :Fragment input(s) `user(locn1)` mismatching vertex shader output type(s) or not written by vertex shader
```

Fixes https://github.com/flutter/flutter/issues/133286
Fixes https://github.com/flutter/flutter/issues/133268
 2023-08-25 15:59:15 +00:00
godofredoc
ee26f237c7 Remove cirrus build badge (flutter/engine#45103) 
It was showing an error because the engine is not running cirrus tests anymore.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 15:14:06 +00:00
skia-flutter-autoroll
c95b1de397 Roll Skia from 8a26fe31389d to 4b30261160a2 (1 revision) (flutter/engine#45109) 
https://skia.googlesource.com/skia.git/+log/8a26fe31389d..4b30261160a2

2023-08-25 egdaniel@google.com [Graphite] Add public API for performDeferredCleanup.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 15:10:10 +00:00