854 Commits

Author SHA1 Message Date
Jason Simmons
1945052c8e Remove image sizes from Picture::GetAllocationSize (flutter/engine#20673) 2020-08-21 16:26:02 -07:00
David Worsham
3a6e0d47c6 fuchsia: Convert legacy permutations to build flag (flutter/engine#20647) 2020-08-19 19:09:51 -07:00
Dan Field
73490a2ca4 Hint freed (flutter/engine#19842)
* Hint the VM when a layer or picture goes out of scope
2020-08-19 14:04:31 -07:00
David Worsham
ad2bff1014 Reland: "fuchsia: Remove dead code / break dependencies" (flutter/engine#20532)
Reland #19396 with a fix for improper scale that was affecting internal tests

Tested: Ran all unittests, ran internal tests, and ran workstation on Fuchsia
BUG: 53062, 53063
2020-08-14 20:41:18 -07:00
xster
5ac78f5be6 Refactor initial route code take 2 (flutter/engine#20468) 2020-08-13 14:18:11 -07:00
Jason Simmons
a67e03a61c Do not access members after calling ClearDartWrapper (flutter/engine#20465) 2020-08-13 11:06:02 -07:00
gaaclarke
232d6c4fca Revert "Refactor initial route code (#19684)" (flutter/engine#20450)
This reverts commit 21404b56c6c183a829d9c758bec2330155e2d86d.
2020-08-12 12:43:08 -07:00
xster
21404b56c6 Refactor initial route code (flutter/engine#19684) 2020-08-11 19:52:04 -07:00
Ming Lyu (CareF)
61fa4d1ff6 remove FrameTiming named constructor (flutter/engine#20380) 2020-08-10 12:21:03 -07:00
Ming Lyu (CareF)
24b22ade69 FrameTiming build start timestamp fix and add vsync start timestamp (flutter/engine#20229) 2020-08-07 19:41:01 -07:00
Yegor
0535e4b0db remove leftover temp annotation from pre-null safe world (flutter/engine#20234)
Co-authored-by: David Iglesias <ditman@gmail.com>
2020-08-06 14:03:52 -07:00
Zachary Anderson
275f2b04cc Revert "fuchsia: Remove dead code / break dependencies (#19396)" (flutter/engine#20302)
This reverts commit 017f07942e8e80a4e886def19c6fffac7ce18479.
2020-08-06 12:06:06 -07:00
Ming Lyu (CareF)
5a07f10d7d add a named constructor to FrameTiming (flutter/engine#20269) 2020-08-05 17:26:02 -07:00
Adlai Holler
bfd36563a7 Migrate a few last places to GrDirectContext (flutter/engine#20235)
* Migrate a few last places to GrDirectContext

This is a followup to #19962 to cover a few places where we
were still using GrContext. No functional impact.

* Formatting
2020-08-05 10:31:43 -07:00
David Worsham
017f07942e fuchsia: Remove dead code / break dependencies (flutter/engine#19396)
The fuchsia code around metrics and sizing was just sending this
information through a side-channel, when the engine already had the
information available. So, delete all of it to make future CLs simpler.

Additionally, the SceneUpdateContext has many unneccesary dependencies
re: metrics and PaintTasks. Break those to make future CLs simpler.

Tested: Ran all unittests and ran workstation on Fuchsia
BUG: 53062, 53063
2020-08-03 22:09:26 -07:00
Jim Graham
c32ae6bc2b update nullability of drawAtlas methods and flesh out docs (flutter/engine#20176) 2020-07-31 17:26:02 -07:00
Greg Spencer
e994f832d2 Move platform specific information to PlatformConfiguration class (flutter/engine#19652) 2020-07-31 17:21:02 -07:00
Juyeong Lee
8fefd60dda Fix Typos (flutter/engine#19691) 2020-07-31 16:32:58 -07:00
Zachary Anderson
e3000379c7 Reland: Avoid a copy in EncodeImage (flutter/engine#20003) 2020-07-31 08:24:08 -07:00
Greg Spencer
da16206acd Fix lint errors in lib/ui (flutter/engine#19988)
This fixes all of the lint errors in lib/ui, except for a few (three, I think) where it would have changed the API, converting non-const references to pointers. For those, I just did NOLINT on the particular line instead of ignoring the whole file.
2020-07-30 20:21:37 -07:00
Michael Goderbauer
7e544890cb Fix dartdocs of dart:ui (flutter/engine#20140) 2020-07-29 23:56:02 -07:00
Siva
03706dce89 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)
* Manual roll of Dart from 24c7666def...40fd1c456e

dart-lang/sdk@40fd1c456e Revert "[dart:io] Add Abort() on HttpClientRequest"
dart-lang/sdk@17d7296a42 [vm/nnbd/bytecode] Fix reuse of type arguments in bytecode
dart-lang/sdk@58b6f40c73 Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns. (reland)
dart-lang/sdk@fc8a6d9f9b [VM/compiler] Dereference TypeRef literal when propagating constants.
dart-lang/sdk@0689ec527a Move "test.dart" (well, most of its contents) into pkg/test_runner.
dart-lang/sdk@1094b3c61d Prepare static error test updater tool to handle web tests.
dart-lang/sdk@b258585f2f [observatory] Migrate from deprecated isInstanceOf to isA.
dart-lang/sdk@dfe1d9b682 Disable OverrideContributor for Cider.
dart-lang/sdk@aea99b2f5c scope debug property assist to Diagnosticables
dart-lang/sdk@4b96f20a79 [dart:io] Add Abort() on HttpClientRequest
dart-lang/sdk@1b1a39708c [build] Use frameworks instead of libs
dart-lang/sdk@3fef522496 Revert "Reland "[vm] Replaces fuchsia.deprecatedtimezone""
dart-lang/sdk@8c664d4f3f Revert "Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns."
dart-lang/sdk@2efb5bebc7 [ dart:_http ] Fix typo in HTTP response timeline event
dart-lang/sdk@0884dae36c Revert "Fix the #include path for ICU headers"
dart-lang/sdk@5171534e81 Scope tweaks. Report REFERENCED_BEFORE_DECLARATION in more places.
dart-lang/sdk@6bba75079a Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns.
dart-lang/sdk@b4ebbb7f5c [build] Update gn to match Fuchsia
dart-lang/sdk@cb428a7a02 [dart2js] Remove old bug work around in collector.
dart-lang/sdk@08663c20ab Change flutter patch to match existing DEPS on master branch
dart-lang/sdk@146ad014d9 update js/meta for the 2.10 dev sdk
dart-lang/sdk@488c718793 [co19] Roll co19 to d79951e06e443213243e54c2c32694b79a221b65
dart-lang/sdk@ba20edd7be Add patch for flutter-engine when changing to version 2.10

* Rev buildroot to latest version.

* Update license.

* update.

* Update gn revision.

* Format BUILD.gn files as the gn revision has been updated.
2020-07-29 13:10:15 -07:00
Dan Field
5f38af543e support fallback codecs on Windows, macOS, iOS (flutter/engine#19989) 2020-07-28 17:46:02 -07:00
Adlai Holler
e5614964f4 Use the GrDirectContext factories instead of deprecated GrContext ones (flutter/engine#19962)
This is part of a larger effort to expose the difference between GrDirectContext,
which runs on the GPU thread and can directly perform operations like uploading
textures, and GrRecordingContext, which can only queue up work to be delivered
to the GrDirectContext later.
2020-07-28 13:32:09 -07:00
Siva
4f1710e807 Manual merge of Dart a3815b6590...24c7666def (flutter/engine#19967)
* Manual merge or Dart into flutter a3815b6590...24c7666def

dart-lang/sdk@24c7666def Update tests that have the current version number hardcoded
dart-lang/sdk@f88ce7aef5 Increase Dart version to 2.10

* Update language version.

* Update license.

* Hpdate language version.

* Update license.
2020-07-24 11:00:34 -07:00
gaaclarke
ee0e1788d9 Made the linter print out more information in its output and fixed bugs (flutter/engine#19895) 2020-07-22 15:38:09 -07:00
Dan Field
baa6f4ac3c Refactor instantiateImageCodec/decodeImageFromPixels to provide an ImageDescriptor (flutter/engine#19537)
Refactors instantiateImageCodec and decodeImageFromPixels to provide intermediate data about the image width, height, and bytes per pixel. This allows for more fine grained control from Dart, particularly when trying to reason about how or whether to maintain aspect ratio in the targetWidth/targetHeight parameters.

This leaves the existing methods functional by re-implementing them to use the new ImmutableBuffer/ImageDescriptor class.

The ImmutableBuffer class is provided so that callers can avoid copying the image data multiple times if they wish to re-recreate the image descriptor.

Related Issues
2020-07-21 14:59:18 -07:00
gaaclarke
96ba83732d Added a more complete docstring for SemanticsFlags (flutter/engine#19817) 2020-07-16 13:13:26 -07:00
Zachary Anderson
c6313931cb Revert "Avoid a copy in EncodeImage (#19504)" (flutter/engine#19739)
This reverts commit dad9640ddef265e1c62433c0044dde04723b5653.
2020-07-14 10:29:34 -07:00
David Worsham
cbd3cd9c0d fuchsia: Enable most unittests (flutter/engine#19583)
Tweak the primary flutter build rule so that fuchsia is more similar to
other platforms in how tests and the shell are built.

Only embedder_unittests and GLFW tests are disabled on Fuchsia now.

TEST: Ran unittests on host/fuchsia; workstation on fuchsia
BUG: fxb/53847, fxb/54056
2020-07-13 17:36:19 -07:00
Zachary Anderson
dad9640dde Avoid a copy in EncodeImage (flutter/engine#19504) 2020-07-10 14:36:13 -07:00
Andre
402412982f Use identical in hashValues instead of operator== (flutter/engine#19615) 2020-07-09 20:29:33 -04:00
Jason Simmons
9a39551dfb Clarify the relationship between PictureRecorder and Canvas (flutter/engine#19393) 2020-07-09 11:06:03 -07:00
Kaushik Iska
8818677dfd Track motion events for reuse post gesture disambiguation (flutter/engine#19484)
This change makes it so that we track all the motion events encountered by `FlutterView` and all of its subviews in the `MotionEventTracker` class, indexed by a unique `MotionEventId`. This identifier is then passed to the Flutter framework as seen in https://github.com/flutter/flutter/pull/60930. Once the gestures take part in gesture disambiguation and are sent back to the engine, we look-up the original motion event using the `MotionEventId` and dispatch it to the platform.

Bug: https://github.com/flutter/flutter/issues/58837
2020-07-06 22:22:37 -07:00
Guruji Panda
cf740767d5 Fix paths in source and yaml files to minimize changes in google3 (flutter/engine#19414) 2020-07-01 16:13:03 -07:00
Alexandre Ardhuin
2c2e5f362c Operator equals (flutter/engine#19303)
* use Object for operator==

* apply style guide for operator==
2020-06-30 23:16:31 +02:00
liyuqian
02f828632c Use FixtureTest to remove duplicate code (flutter/engine#19219)
Fixes https://github.com/flutter/flutter/issues/59109
2020-06-30 10:55:38 -07:00
David Worsham
919f8e6a42 Move fuchsia/scenic integration behind #define (flutter/engine#19003)
Additionally create "_next" permutations for all of the test binaries
on Fuchsia, in order to test both code-paths.

Using the #define follow-up CLs can also create a flutter_runner_next
binary that does not contain any legacy integration code.

BUG: 53847
2020-06-26 14:03:18 -07:00
Gary Qian
855fa8fde8 Revert method channel platform resolved locale (flutter/engine#19136) 2020-06-19 17:40:22 -07:00
Jason Simmons
c7bc6e9ad0 Avoid creating a vector when constructing Dart typed data objects for platform messages (flutter/engine#18838) 2020-06-18 09:58:03 -07:00
Dan Field
07849dc46c Parameterize upscaling for image decoding (flutter/engine#19067)
Adds an `allowUpscale` parameter to the Dart interfaces for instantiateImageCodec and decodeImageFromPIxels. If set to false, the image bounds will be clamped at their intrinsic dimensions.

A later commit will change the default to true.
2020-06-18 09:42:08 -07:00
zljj0818
1fd49da298 Poor video scaling quality #53080 (flutter/engine#18814)
Use bilinear instead of nearest filter to draw surface texture

Related Issues:
https://github.com/flutter/flutter/issues/53080

Tests:
- TextureLayerTest
2020-06-17 11:14:05 -07:00
Dan Field
0b5b38c8b4 Instantiate image codec doc fix (flutter/engine#19062)
Correctly describe the way aspect ratio is managed when one parameter is not specified.
2020-06-16 15:14:04 -07:00
Gary Qian
c9fa545cf3 Platform resolved locale and Android localization refactor (flutter/engine#18645) 2020-06-16 04:29:50 -07:00
Yegor
b457938f23 apply null safety syntax to mobile dart:ui (flutter/engine#18933)
* apply null safety syntax to mobile dart:ui
2020-06-12 12:42:12 -07:00
liyuqian
b58ef5144e Add ui_benchmarks (flutter/engine#18945) 2020-06-11 10:55:03 -07:00
Brian Osman
3a2315895e SkMatrix::MakeFoo is deprecated, use SkMatrix::Foo instead (flutter/engine#18934) 2020-06-09 16:55:13 -04:00
Yegor
3a75937e4a nullability clean-ups (flutter/engine#18880)
* nullability clean-ups
2020-06-08 10:55:24 -07:00
Yegor
f53e3cad55 null-annotate remaining engine code (flutter/engine#18852)
* null-annotate remaining engine code
2020-06-05 21:00:07 -07:00
Yegor
9ed3637fa0 add nullability annotations to lib/ui/painting.dart (flutter/engine#18374)
* add nullability annotations to lib/ui/painting.dart
2020-06-05 10:26:14 -07:00