421 Commits

Author SHA1 Message Date
Adam Barth
a94d398847 Don't grey out Sky code in Atom
For some reason having |packages| in this .gitignore file is causing Atom to
grey out all the files in the Sky package. Moving the entry up to the root of
the git repo fixes the issue.
2015-08-14 15:39:09 -07:00
Hans Muller
1f7b9229cf Merge pull request #623 from HansMuller/dismissable-bug
Reset the Dimissable fade animation on slow flings
2015-08-14 14:18:31 -07:00
Adam Barth
1a8f4e36d1 Rev pub package 2015-08-14 14:14:46 -07:00
Hans Muller
2c5c4538fc Reset the Dimissable fade animation on slow flings 2015-08-14 14:14:44 -07:00
Collin Jackson
5183eb9b63 Merge pull request #621 from collinjackson/more_text_refactor
Refactor RenderParagraph to do more work at the painting layer
2015-08-14 14:03:12 -07:00
Collin Jackson
779f5743e5 Refactor of text rendering into painting layer 2015-08-14 13:30:56 -07:00
Adam Barth
6efbcdc975 Add haptic and aural feedback service
And use the service in mine_digger to notify the user when they flag a bomb.
2015-08-14 12:46:04 -07:00
Adam Barth
d291fcaecd Merge pull request #620 from abarth/compositing_update
Add a compositing update phase
2015-08-14 11:09:28 -07:00
Adam Barth
e17aa1b63a Add a compositing update phase
We need to compute whether a RenderObject has a composited descendant so that
we can decide whether to use canvas.saveLayer or to create a new composited
layer while walking down the tree during painting.

The compositing update walks the tree from the root only to places where the
tree's structure has been mutated. In the common case during an animation loop,
we won't need to visit any render object beyond the root.
2015-08-14 10:47:39 -07:00
Adam Barth
e0f14e3719 Add debug painting for layer borders
This patch makes it easier to debug layerization issues.
2015-08-14 10:46:53 -07:00
Adam Barth
86da2f9bf4 Separate the notions of offset and size in compositing
Separating these notions makes them easier to work with because offset is
relative to the parent layer whereas size is intrinsic to the layer itself.
This patch fixes the underpainting bugs when compositing the stocks example.
2015-08-14 09:49:38 -07:00
Adam Barth
53884a37de Generalize _cleanRelayoutSubtreeRootChildren into visitChildren
This generalization will let us implement other alogorithims that need to walk
the RenderObject tree.
2015-08-14 09:37:19 -07:00
mpcomplete
0c05c97e20 Merge pull request #597 from mpcomplete/value.animation
Add a ValueAnimation helper class for AnimationPerfomance.
2015-08-14 12:03:27 -04:00
Adam Barth
87df0e5b3c Fix analyzer warnings 2015-08-14 09:00:42 -07:00
Adam Barth
bcf18623b9 Merge pull request #608 from abarth/composite_frame
Add a compositing step to the lifecycle
2015-08-13 16:32:18 -07:00
Adam Barth
bf260f98e3 Add a compositing step to the lifecycle
Now we have the ability to draw multiple PictureLayers. We still squash all the
pictures together into a single SkPicture for simplicity. In the future, we'll
submit them to C++ separately and composite them on the GPU thread.
2015-08-13 16:31:45 -07:00
Hans Muller
681b366abe Merge pull request #606 from HansMuller/progress-indicator
Adds CicularProgressIndicator and LinearProgressIndicator

Setting a ProgressIndicator's value to null (the default) makes it an "indeterminate progress" or activity indicator.

The indeterminate animations for both kinds of progress bars are essentially the same and wrong vis the Material Design spec, http://www.google.com/design/spec/components/progress-activity.html. I'll improve conformity with the visual design in a future CL.
2015-08-13 16:17:27 -07:00
Hans Muller
babe380f0d Adds CicularProgressIndicator and LinearProgressIndicator
Setting a ProgressIndicator's value to null (the default) makes it an "indeterminate progress" or activity indicator.

The indeterminate animations for both kinds of progress bars are essentially the same and wrong vis the Material Design spec, http://www.google.com/design/spec/components/progress-activity.html. I'll improve conformity with the visual design in a future CL.
2015-08-13 16:15:21 -07:00
Adam Barth
4d68bc8754 Merge pull request #605 from abarth/long_press
Expose longpress and showpress in Listener
2015-08-13 16:04:17 -07:00
Adam Barth
3523a10ab4 Expose longpress and showpress in Listener 2015-08-13 15:48:07 -07:00
P.Y. Laligand
130119dff0 Fixed a typo in the widget tutorial. 2015-08-13 14:41:55 -07:00
Matt Perry
82d84c766f Add a ValueAnimation helper class for AnimationPerfomance.
Used for AnimationPerformance with a single AnimatedValue<T> variable.
2015-08-13 17:29:32 -04:00
Adam Barth
7cba729110 Switch painting over to using PictureLayer
Currently we have a single PictureLayer that everyone draws into. A future
patch will teach the system to use multiple PictureLayers.
2015-08-13 14:24:29 -07:00
Adam Barth
be8454073a Rename createsNewDisplayList to requiresCompositing
This patch prepares for introducing the compositing system by repurposing the
relevant parts of the createsNewDisplayList system. This patch also removes the
no-longer-relevant parts of that system.
2015-08-13 12:43:39 -07:00
Adam Barth
45be4c6faf Kill sky_server by port instead of pid
We seem to have trouble killing sky_server by its pid. Instead, lets try
killing it by looking up which process is listening on the sky_server port.
2015-08-13 12:28:53 -07:00
mpcomplete
dc304b42a6 Merge pull request #592 from mpcomplete/animation.asserts
Fix common asserts in animation API.
2015-08-13 13:55:28 -04:00
Adam Barth
c80603cf0e Add PaintingContext which has-a sky.Canvas instead of is-a sky.Canvas
We'll need this for compositing because we need to switch out the sky.Canvas
when we switch compositing layers.
2015-08-13 10:18:33 -07:00
Matt Perry
8a7293170e Fix common asserts in animation API.
1. We would assert if you tried to start an animation from within an
animation status callback. This is a common pattern, so I fixed this
assert (in Ticker._tick).
2. We would assert for animations with duration under a millisecond.
Fixed.

Also removed the workarounds assocated with #1.
2015-08-13 13:18:25 -04:00
Adam Barth
7295563d7a Rev pub package 2015-08-13 09:20:16 -07:00
Adam Barth
12586a6343 RenderBox.hitTest should do the bounds check
Previously we were doing the bounds testing for hit tests in the parent, but
that doesn't work if the child paints at a location other than 0.0, 0.0. Now we
do the bounds check in the child. This also simplifies Scaffold's hit testing.

Fixes #558
2015-08-12 17:46:10 -07:00
Adam Barth
b4e3f8591b Rev pub package 2015-08-12 14:46:59 -07:00
Adam Barth
0fcf1912ae Update README.md 2015-08-12 09:18:32 -07:00
Adam Barth
70869f93f0 Require a new version of sky_tools 2015-08-12 09:12:32 -07:00
Hans Muller
16ffdc67a6 Merge pull request #572 from HansMuller/ensure-visible
Adds ensureWidgetIsVisible() function to scrollable.dart
2015-08-11 16:51:24 -07:00
Andrew Wilson
a1249ad2c7 Maximum bounds for the mimic in the overlay can now be specified. 2015-08-11 16:50:19 -07:00
Hans Muller
9e9d845b1f Adds ensureWidgetIsVisible() function to scrollable.dart
Set the scrollOffset of a widget's Scrollable ancestor so that the
widget is centered within the scrollable. A future CL will add
support for specifying exactly where the widget appears. The scroll
can be animated by specifying the animation: parameter.

Changed the duration Scrollable.scrollTo() parameter from a Duration
to an AnimationPerformance so that one can configure all aspects of
the animation. The caller may also listen to the animation to schedule
other work while it updates or when its status changes.
complete
2015-08-11 16:49:48 -07:00
Eric Seidel
8417fb62da Merge pull request #571 from eseidelGoogle/splash
Attempt to make our splashes closer to other Android apps
2015-08-11 15:06:51 -07:00
Eric Seidel
cd5715bbf3 Attempt to make our splashes closer to other Android apps
And also Material Design of course.

@abarth
2015-08-11 14:56:36 -07:00
Adam Barth
5bbf0d8967 Merge pull request #570 from abarth/paint_once
Don't paint twice
2015-08-11 14:54:48 -07:00
Adam Barth
88eba9150f Don't paint twice
In refactoring the way we generate the SkPicture, I accidentially made us
generate the SkPicture twice. This CL causes us to generate it only once.
2015-08-11 14:38:49 -07:00
Matt Perry
3d9f523179 Scaffold: animate the FloatingActionButton with the SnackBar.
This introduces the concept of an Anchor, which you can use to link
transitions together. I've used this in the Fitness and Stocks apps to
link the FAB and SnackBar to animate together by sharing the
SlideTransition.

I also fixed the Scaffold hit testing code to apply sub-widget
transforms, so it works with Transformed nodes.
2015-08-11 17:21:20 -04:00
Adam Barth
eee90d0dd6 Merge pull request #560 from afandria/patch-1
Update README.md
2015-08-11 13:59:00 -07:00
Eric Seidel
441fe4d491 Fix crash when hitting "enter" key on keyboard during entry
Now it wont crash on save, but it still doesn't display
the error message in a snackbar and this also doesn't
wire up the enter/go key to actually do anything.

We'll need to implement performEditorAction on our
InputConnection implementation to catch this key and
pass it along to dart.

Our Input control needs to get more powerful to handle things
like this, including filtering of input.

The code was crashing by triggering a bug in the SnackBar
which didn't assert for actions, but crashed when they
were not null.

Partial fix for https://github.com/domokit/sky_engine/issues/543

@abarth
2015-08-11 12:27:54 -07:00
Alex Fandrianto
195fe22a31 Update README.md
Added missing :
2015-08-11 11:59:25 -07:00
Adam Barth
a96f59516c Rev pub package 2015-08-11 10:51:48 -07:00
Adam Barth
c3e48c53d9 Merge pull request #553 from abarth/immersive
Add support for immersive mode on Android
2015-08-11 10:37:41 -07:00
Adam Barth
e770b9da52 Merge pull request #552 from abarth/fix_image_layout
Images in Stocks drawer layout at crazy sizes
2015-08-11 10:15:45 -07:00
Adam Barth
345f017640 Add support for immersive mode on Android
Fixes #512
2015-08-11 10:13:34 -07:00
Adam Barth
ae9f170243 Images in Stocks drawer layout at crazy sizes
Now that we get sky.Image callbacks synchronously, we were actually figuring in
the width and height of images the second time the drawer opened in the Stocks
app. That exposed a bug in our RenderImage layout code whereby it would ignore
the _width and _height properties when the image was non-null.
2015-08-11 09:52:22 -07:00
Adam Barth
375c24772e Remove weak handle from sky.Paint
This patch converts sky.Paint to be a pure Dart object, which means we don't
need to open a weak handle to sky.Paint. Avoiding the weak handle reduces the
amount of weak handle callbacks we need to process at the end of GC and
therefore reduces jank.
2015-08-11 09:37:20 -07:00