DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,361 Commits 882 Branches 1,069 Tags
Commit Graph

26071 Commits

Author SHA1 Message Date
skia-flutter-autoroll
169507a42a Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions) (flutter/engine#51006) 
https://skia.googlesource.com/skia.git/+log/d5ca52bc7739..636e136b0da9

2024-02-27 jlavrova@google.com Reland "Implementing Fontations font scanner"
2024-02-27 johnstiles@google.com Manually roll Dawn to the latest version.
2024-02-27 johnstiles@google.com Delete legacy shadeSpan implementation of Perlin Noise.
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc25d8806a33 to 32b3df0d7dd6 (5 revisions)
2024-02-27 kjlubick@google.com Minor clang tidy/format fixes
2024-02-27 michaelludwig@google.com Reland "[skif] Add transparent padding to source saveLayers"
2024-02-27 kjlubick@google.com Enforce IWYU on skottie and sksg
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from acba61cb3e27 to f0af4730d927 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 17:40:09 +00:00
zijiehe@
c274921fa6 [Fuchsia] Use shared gn-sdk from chromium (flutter/engine#50855) 
Fuchsia team is working on getting rid of non-versioned libraries and sysroot (see b/40935282), but flutter is using a fairly old version of in-house gn-sdk. It's hard to maintain it anymore.
So this change removes the in-house gn-sdk and replaces it with the gn-sdk from chromium.
This is a prerequisite to select the idk / sdk lib version according to the api-level.

This change contains three parts:
1) Replacing gn-sdk/ with gn-sdk/src/ since the chromium needs a README.chromium in gn-sdk/ folder.
2) Making the existing build rules work with the newer gn-sdk.
3) Drive-by replacing "gtest_runner.shard.cml" with "sys/testing/gtest_runner.shard.cml", it's in fuchsia sdk already.

Bug: [b/40935282](https://issues.chromium.org/issues/40935282?pli=1&authuser=0)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 17:30:05 +00:00
Jackson Gardner
fce1fe5b2c Reland "Implement Frame Timing callbacks in Skwasm" (flutter/engine#50987) 
This is a reland of the previous PR, now that the blocking Dart SDK issue has been fixed (see https://github.com/dart-lang/sdk/issues/54991).

Also, I addressed an issue where the timings were incorrect due to different time origins on the main thread and web worker. The timings should be accurate now.

Notes from the original PR are as follows:

Fixes https://github.com/flutter/flutter/issues/140429

Some notes here:
* Refactored the frame timing systems so that we can deal with asynchronous rendering.
* Consolidated rendering of multiple pictures in skwasm into a single call, so that the rasterization can be properly measured.
* Pulled the frame timings tests into the `ui` test suite so that they run on all renderers (including skwasm).
 2024-02-27 16:42:25 +00:00
Zachary Anderson
827e920f48 Move protobuf to //flutter/third_party (flutter/engine#50997) 
For https://github.com/flutter/flutter/issues/67373

Currently the files in the secondary buildroot for protobuf are checked
out from their own git repo. Flutter owns a mirror of that repo. To move
protobuf to `//flutter/third_party`, we can land a change in that repo,
and then revert it after we're done with the buildmoot. Alternately, in
this PR, I've just copied the files into the flutter/engine repo under
the secondary buildroot and made the changes.
 2024-02-27 08:37:21 -08:00
skia-flutter-autoroll
70e24583ba Roll Skia from 2f2a718b27f7 to d5ca52bc7739 (3 revisions) (flutter/engine#51003) 
https://skia.googlesource.com/skia.git/+log/2f2a718b27f7..d5ca52bc7739

2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 34f900647879 to 73efb9ea35f6
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dd4b27ecbb53 to 34f900647879 (9 revisions)
2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0f69b790c7a4 to bbe6452b420c (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 16:30:27 +00:00
Dan Field
3b99e7ab98 Actually use Impeller in scenario_app tests (flutter/engine#50977) 
Right now, the scenario_app tests that claim to use Impeller are not actually using Impeller. This is for a few reasons:

- The arguments passed via instrumentation do not end up by default on the `Intent` for the `Activity` that is under test.
- The arguments passed via instrumentation were in the wrong order and not getting sent to instrumentation at all.

This patch updates existing tests to use a new `@Rule` that reads the arguments from the instrumentation's argument `Bundle` and injects them into the `Intent` that we actually pass to the `Activity` under test. It also updates the argument order in the script and adds a verification that Impeller prints that it is being used at least once.
 2024-02-27 04:37:23 +00:00
Matan Lurey
539dc4eccc Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989) 
Closes https://github.com/flutter/flutter/issues/144076.

I had to make some other cleanup changes in order to avoid the program
hanging.
 2024-02-26 19:17:44 -08:00
skia-flutter-autoroll
6ba5eee587 Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996) 
https://dart.googlesource.com/sdk.git/+log/2876f5684ced..67b2a250747b

2024-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-179.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 02:36:15 +00:00
Matan Lurey
adc86fe60b Fix usage of --out-dir with a relative path. (flutter/engine#50992) 
@dnfield:

> it looks like the new dart script doesn't necessarily work well with
relative directories for the out dir
 2024-02-26 18:35:28 -08:00
skia-flutter-autoroll
9bb1d34f89 Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994) 
https://skia.googlesource.com/skia.git/+log/ba3ed5998af3..aa28c3a30a98

2024-02-26 brianosman@google.com Handle recursion limit gracefully in the stroker
2024-02-26 johnstiles@google.com Revert "[skif] Add transparent padding to source saveLayers"
2024-02-26 johnstiles@google.com Use nmad primitive in inverse and transcendental functions.
2024-02-26 herb@google.com Reland "Implement ARM only unpremul using SIMD"
2024-02-26 johnstiles@google.com Add Raster Pipeline fused negative multiply-add primitive.
2024-02-26 michaelludwig@google.com [skif] Add transparent padding to source saveLayers
2024-02-26 kjlubick@google.com Try adding a gn clean before building fontations
2024-02-26 herb@google.com Revert "Implement ARM only unpremul using SIMD"
2024-02-26 herb@google.com Implement ARM only unpremul using SIMD
2024-02-26 jvanverth@google.com [graphite] Enable SmallPathAtlas.
2024-02-26 michaelludwig@google.com Update legacy LCD ARGB32 blitter to match RP for transparent pixels
2024-02-26 johnstiles@google.com Add Perlin Noise Raster Pipeline implementation.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 01:58:11 +00:00
auto-submit[bot]
63614f6be8 Reverts "Migrate Android scenario_app to the SurfaceProducer API (#50993)" (flutter/engine#50995) 
Reverts flutter/engine#50993

Initiated by: matanlurey

Reason for reverting: The digests will come back negative, as this change shows bugs in the `ImageTexture` implementation.

Original PR Author: matanlurey

Reviewed By: {jonahwilliams, johnmccutchan}

This change reverts the following previous change:
Original Description:
Part of testing https://github.com/flutter/flutter/issues/139702.

Without this PR, the Impeller + Vulkan Scenario App will draw nothing/potentially crash, because there is no way to draw the (current) `SurfaceTexture`-based textures in Vulkan (and never will be).

This change does the following:
- Skia -> Nothing
- Impeller + OpenGLES -> On newer Android devices, uses `ImageReader` instead
- Impeller + Vulkan -> Always uses `ImageReader`

See also: https://api.flutter.dev/javadoc/io/flutter/view/TextureRegistry.SurfaceProducer.html.
 2024-02-27 01:49:26 +00:00
Matan Lurey
5b9bb4bacf Migrate Android scenario_app to the SurfaceProducer API (flutter/engine#50993) 
Part of testing https://github.com/flutter/flutter/issues/139702.

Without this PR, the Impeller + Vulkan Scenario App will draw nothing/potentially crash, because there is no way to draw the (current) `SurfaceTexture`-based textures in Vulkan (and never will be).

This change does the following:
- Skia -> Nothing
- Impeller + OpenGLES -> On newer Android devices, uses `ImageReader` instead
- Impeller + Vulkan -> Always uses `ImageReader`

See also: https://api.flutter.dev/javadoc/io/flutter/view/TextureRegistry.SurfaceProducer.html.
 2024-02-27 01:39:23 +00:00
Tong Mu
c139338825 Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985) 
This reverts commit cb110ebc948c362cec5ac921cf8ef5e9ca530102.

Reason: Internal test failure blocking roll
OCL:610420483:BASE:610486571:1708978396098:f2c3c31

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-27 00:58:22 +00:00
Matan Lurey
71f9dec343 Refactor args parsing/environment constructor for scenario_app (flutter/engine#50980) 
This moves the ever-growing amount of options and defaults into it's own
class(es).

The test runner itself has no tests (yet), but this shim will make
writing tests easier. I tried to make no other real changes to how the
runner functions in this PR.
 2024-02-26 15:29:32 -08:00
Jonah Williams
9eca58ab36 [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981) 
If we hit this exception (which we seem to do a lot), then we weren't triggering the first frame latch.
 2024-02-26 23:03:31 +00:00
Jason Simmons
36531a7209 [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983) 2024-02-26 22:52:01 +00:00
skia-flutter-autoroll
aaa76eeaba Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979) 
https://dart.googlesource.com/sdk.git/+log/c479735adcf9..2876f5684ced

2024-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-178.0.dev
2024-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-177.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 22:31:35 +00:00
Zachary Anderson
cae1c8dc3a Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327) 
Related https://github.com/flutter/flutter/issues/142868
 2024-02-26 13:39:05 -08:00
Jonah Williams
00b8a0c043 [Impeller] disble render pass caches. (flutter/engine#50976) 
This is related to the crashes in https://github.com/flutter/flutter/issues/144116

> I'm going to disable this caching for now until I understand why its not working for tester. Potentially the cache itself was unsafe and validation is just missing, but I need to do some research. If I don't find anything then i'll consider conditionally disabling for flutter tester builds
 2024-02-26 21:09:16 +00:00
John McCutchan
a0e82bb991 Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971) 
Fixes https://github.com/flutter/flutter/issues/142952
 2024-02-26 13:00:49 -08:00
Jason Simmons
24152a08d1 [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883) 
The Vulkan pipeline library queues pipeline creation tasks to a ConcurrentTaskRunner.  If the ContextVK is destroyed before these tasks execute, then the ConcurrentMessageLoop destructor will delete the pending tasks.

Each task lambda holds a reference to a promise that will be completed with the pipeline.  If the task was never run and its promise was never completed, then the promise destructor will complete it with an exception.  This will cause a std::abort because Flutter is built without exception support.

This PR wraps the promise in an object that completes it with a default value during destruction if the promise was never given a value.
 2024-02-26 20:06:29 +00:00
Matan Lurey
dec92d85f2 Better filtering for Android scenario_app runner. (flutter/engine#50937) 
_🍴 'd from https://github.com/flutter/engine/pull/50933, will rebase
when merged._

Closes https://github.com/flutter/flutter/issues/143458.

A picture is a 1000 words:

![Screenshot 2024-02-23 at 7 01
29 PM](https://github.com/flutter/engine/assets/168174/7254b3be-cc49-4bad-ae43-e61ac4a853ad)

This is still noisy, but at least all the output appears to be part of
the execution.

As you recall, the full logs are always available in the
FLUTTER_LOGS_DIR output.
 2024-02-26 11:36:10 -08:00
Jackson Gardner
d1d7c08ce9 Make sure to call setHeightOverride as well on TextStyle and StrutStyle (flutter/engine#50920) 
This fixes https://github.com/flutter/flutter/issues/143877

We apparently need to call `setHeightOverride(true)` on `TextStyle` and `StrutStyle` objects in order to properly apply the height.
 2024-02-26 18:52:59 +00:00
Jackson Gardner
45b0c5ef88 Correctly offset the cull rect of the opacity layer. (flutter/engine#50928) 
This fixes https://github.com/flutter/flutter/issues/140999. Previously, the cull rect would be misplaced causing many elements to not render at all.
 2024-02-26 18:52:56 +00:00
Zachary Anderson
8a4feb869c [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952) 
For https://github.com/flutter/flutter/issues/132807

The spinner is mostly copied from the flutter_tool.
 2024-02-26 09:31:15 -08:00
yaakovschectman
ac3cb8cd7b Add Platform View Manager to Windows shell (flutter/engine#50598) 
Create a manager for platform views accessible to the compositor, handle
the methods that the framework will send.

Addresses https://github.com/flutter/flutter/issues/143375

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2024-02-26 10:13:46 -05:00
skia-flutter-autoroll
ac6ab0491c Roll Skia from a79c52feafa4 to cb2a47da08b7 (3 revisions) (flutter/engine#50962) 
https://skia.googlesource.com/skia.git/+log/a79c52feafa4..cb2a47da08b7

2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from dd4b27ecbb53 to 78ad8c9c4948
2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 88ef1b147e5e to dd4b27ecbb53 (2 revisions)
2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 75674438c2f4 to 03f52d4a902b (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 07:18:05 +00:00
Zachary Anderson
52ad6e42d2 Move linux_android_emulator_skia builder to prod (flutter/engine#50956) 
Follow-up from https://github.com/flutter/engine/pull/50954
 2024-02-26 07:14:21 +00:00
Zachary Anderson
af1428f011 Further shard Android emulator tests (flutter/engine#50954) 
Even when not flaking anymore, we'll probably want to split these up
into separate shards, and the Linux VMs are plentiful so there's no harm
in doing this.
 2024-02-25 12:46:34 -08:00
skia-flutter-autoroll
8ffc36b8e3 Roll Fuchsia Linux SDK from Oac3MZ5VgZ9g3Q3cL... to kLvCWEgbL1VTRW69e... (flutter/engine#50953) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-25 17:13:11 +00:00
skia-flutter-autoroll
df3d8d22f7 Roll Fuchsia Linux SDK from sO-oG6KoeFlPK2WLR... to Oac3MZ5VgZ9g3Q3cL... (flutter/engine#50946) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 15:47:05 +00:00
Dan Field
f235a65897 Avoid reloading font collection for spawned engines with compatible asset managers (flutter/engine#50897) 
@jason-simmons @jiahaog fyi

I need to figure out a test for this still but it seems to work. Hot restart is kind of a mess though, because `Engine::Restart` nulls out the asset manager it ends up reloading the font collection for every engine after a restart. But we separately need to fix hot restart, it's not very usable on the example app 

Fixes https://github.com/flutter/flutter/issues/143701
 2024-02-24 14:58:37 +00:00
skia-flutter-autoroll
3d1c0f0318 Roll Skia from 45b38664b4ed to f94b35f33a82 (3 revisions) (flutter/engine#50940) 
https://skia.googlesource.com/skia.git/+log/45b38664b4ed..f94b35f33a82

2024-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d85c6c8d1c86 to d0f72e9692c4 (3 revisions)
2024-02-23 johnstiles@google.com Revert "Add Perlin noise stage to Raster Pipeline."
2024-02-23 johnstiles@google.com Revert "Remove matrix from PaintingData."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 08:52:08 +00:00
Tong Mu
cb110ebc94 Reland 4: Multiview pipeline (flutter/engine#50931) 
This relands https://github.com/flutter/engine/pull/49950.

Nothing is changed. The error turns out a flake (it passes once),
although this PR might have made the flake more flaky.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-23 20:52:53 -08:00
Matan Lurey
2db47e5a50 Actually list all sources for scenario_app target. (flutter/engine#50933) 
Without this the GN cache can easily become invalid if nothing else
changed.
 2024-02-23 20:27:01 -08:00
skia-flutter-autoroll
807ac0c932 Roll Dart SDK from 9849ca5fcaec to e5e4aaceaf23 (1 revision) (flutter/engine#50934) 
https://dart.googlesource.com/sdk.git/+log/9849ca5fcaec..e5e4aaceaf23

2024-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-173.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-24 01:52:04 +00:00
Loïc Sharma
788179d383 [Windows] Refactor the a11y announcement test (flutter/engine#50888) 
This refactors the Windows accessibility announcement test. This will make it easier to add a headless variant of this test as part of https://github.com/flutter/flutter/issues/143765.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-24 00:26:02 +00:00
Dan Field
54689ee475 Avoiding using separate FlutterLoaders in scenario_app (flutter/engine#50927) 
Fixes https://github.com/flutter/flutter/issues/144046

When we use the same FlutterLoader from the injector, the initialization method knows it doesn't have to do as much work - using separate Flutter loaders (in this case for every test that derives from TestActivity, which is basically all of them) causes spurious warning messages to be printed for every test.
 2024-02-23 23:46:19 +00:00
skia-flutter-autoroll
7186299856 Roll Skia from 9d8d3f053775 to 45b38664b4ed (1 revision) (flutter/engine#50926) 
https://skia.googlesource.com/skia.git/+log/9d8d3f053775..45b38664b4ed

2024-02-23 aperez@igalia.com Reland "Add sk_malloc_size() to query usable allocation sizes"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 23:39:47 +00:00
Matan Lurey
5ff7a8bc99 Refactor Android scenario_app to remove shell entrypoint, simplify. (flutter/engine#50922) 
Closes https://github.com/flutter/flutter/issues/144045.

There is still more work I want to do, like pulling args parsing into it's own class, and potentially cleanup the [golden file collection](https://github.com/flutter/flutter/issues/144047), but those seem reasonable for future (lower priority) PRs.
 2024-02-23 23:34:05 +00:00
Loïc Sharma
b73e827969 [Windows] Add helper for headless integration tests (flutter/engine#50885) 
We'll add more headless mode tests as part of https://github.com/flutter/flutter/issues/143765.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-23 23:23:29 +00:00
Zachary Anderson
9f1ed38ee0 Shift //third_party/icu to //flutter/third_party (flutter/engine#50924) 
For https://github.com/flutter/flutter/issues/67373
 2024-02-23 23:23:27 +00:00
auto-submit[bot]
c388fc8bf0 Reverts "Reland 3: Multiview pipeline (#49950)" (flutter/engine#50929) 
Reverts flutter/engine#49950

Initiated by: dkwingsmt

Reason for reverting: Head redness 
```
java.lang.RuntimeException: Timeout waiting for firstFrameLatch to signal
	at dev.flutter.scenarios.ExternalTextureFlutterActivity.waitUntilFlutterRendered(ExternalTextureFlutterActivity.java:98)
	at dev.flutter.scenariosui.ScreenshotUtil.capture(ScreenshotUtil.java:122)
```

Original PR Author: dkwingsmt

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Original Description:
This is the 3rd attempt to land multiview pipeline, following
https://github.com/flutter/engine/pull/47239.

The pipeline now properly implements the required logic for
`scheduleWarmUpFrame` to work in a multi-view setup, following the
preparation in https://github.com/flutter/flutter/pull/143290 and
https://github.com/flutter/engine/pull/50570.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2024-02-23 15:15:00 -08:00
Dan Field
7fd214252c Remove timeouts from CountdownLatch.await in tests (flutter/engine#50930) 
See
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#never-check-if-a-port-is-available-before-using-it-never-add-timeouts-and-other-race-conditions

This may be contributing to flakiness in the Java/Scenario_app tests. We
should just timeout when CI says it's taken too long - on a slow machine
5 or 10 seconds may not be enough time.
 2024-02-23 15:10:16 -08:00
Tong Mu
dd271d0880 Reland 3: Multiview pipeline (flutter/engine#49950) 
This is the 3rd attempt to land multiview pipeline, following
https://github.com/flutter/engine/pull/47239.

The pipeline now properly implements the required logic for
`scheduleWarmUpFrame` to work in a multi-view setup, following the
preparation in https://github.com/flutter/flutter/pull/143290 and
https://github.com/flutter/engine/pull/50570.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-23 13:39:54 -08:00
skia-flutter-autoroll
d7d7eeae4d Roll Skia from fde4d63c5e61 to 9d8d3f053775 (1 revision) (flutter/engine#50921) 
https://skia.googlesource.com/skia.git/+log/fde4d63c5e61..9d8d3f053775

2024-02-23 johnstiles@google.com Reland 'Eliminate unnecessary function parameter copies in SkRP.'

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 21:01:16 +00:00
Jim Graham
4aa93cbf61 [Impeller] Compute UV coordinates lazily in PositionUVWriter (flutter/engine#50879) 
The stroking code was performing texture coordinate conversion on each created vertex. Since there were often very few calculations needed for each vertex, interspersing a coordinate transform with each vertex append was clogging up the code.

This change will defer the calculation of the texture coordinates until the end of the stroking process so that the polyline widening code can do its job efficiently and then later the coordinate conversion code can do its job also efficiently in a tight loop. This change also opened up the opportunity to optimize a common case (no effect transform) even more than before.
 2024-02-23 19:52:19 +00:00
skia-flutter-autoroll
68c773fb26 Roll Skia from 49dd7ed24bec to fde4d63c5e61 (3 revisions) (flutter/engine#50917) 
https://skia.googlesource.com/skia.git/+log/49dd7ed24bec..fde4d63c5e61

2024-02-23 johnstiles@google.com Remove matrix from PaintingData.
2024-02-23 robertphillips@google.com Revert "Implementing Fontations font scanner"
2024-02-23 johnstiles@google.com Add Perlin noise stage to Raster Pipeline.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 19:30:23 +00:00
skia-flutter-autoroll
f1219ae5fd Roll Skia from 037e08e92598 to 49dd7ed24bec (3 revisions) (flutter/engine#50916) 
https://skia.googlesource.com/skia.git/+log/037e08e92598..49dd7ed24bec

2024-02-23 robertphillips@google.com [graphite] Trial balloon of stable keying system for known runtime effects
2024-02-23 kjlubick@google.com Move SkTextBlobTrace from src/core to tools/text
2024-02-23 kjlubick@google.com Address clang-tidy suggestions in src/pathops

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-23 18:26:05 +00:00
John McCutchan
82dd6cd6e3 Add an initial 'build' command to engine_tool (flutter/engine#50681) 
* Adds a 'build' command to `et`.
* Renamed `query builds` to `query builders` because that seemed to be
more precise(?)

Some extra requests during review:
1. I've left some questions I'd like answers to at the top of
`build_command.dart` I suspect @zanderso and @loic-sharma can give me
(some?) answers.
2. I suspect I'm holding the FakeProcessManager wrong or there is a
better way to write the tests in `build_command_test.dart`. Pointers to
good examples are appreciated.
 2024-02-23 10:02:34 -08:00