7057 Commits

Author SHA1 Message Date
Justin McCandless
8fbc77e24e Cupertino(Sliding)SegmentedControl docs reference (#48925) 2020-01-17 12:53:01 -08:00
Justin McCandless
c61e55ad6b Selection menu not showing when selection is 0,0 (#49000) 2020-01-17 10:58:01 -08:00
Greg Spencer
f013b25b9c
Add TargetPlatform.macOS tests to the widgets library. (#48997) 2020-01-17 10:51:38 -08:00
Greg Spencer
3dbe90e1fd
Add TargetPlatform.macOS tests to the material library (#48996)
This contains the test changes for adding TargetPlatform.macOS, which was done in #43457.

The main goal of this PR is to enable tests in the material library that are currently running only on iOS to also run on macOS, but only for the tests where that makes sense. For instance, we don't run any of the haptic feedback tests on macOS.
2020-01-17 10:51:11 -08:00
Greg Spencer
bf1d822198 Add TargetPlatform.macOS tests to cupertino, foundation, rendering, and services libraries. (#45644) 2020-01-16 19:38:01 -08:00
Michael Goderbauer
cb5918f626 Doc fixes in Image related docs (#48994) 2020-01-16 17:18:02 -08:00
rami-a
d016146439 Allow for cupertino modal popups to be dismissed with semantics (#48915) 2020-01-16 12:58:01 -08:00
Alexandre Ardhuin
003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
rami-a
91f8d3da32
Prevent disabled cupertino textfield from being edited with voiceover/talkback (#48902) 2020-01-16 18:21:16 +00:00
suragch
4c1d79f42f Update assert message for AnimatedContainer (#48962)
The error message was misleading because BoxDecoration does not have a `backgroundColor` parameter. Instead it has a `color` parameter, which sets the background color. I also removed the optional `new` keyword.
2020-01-16 10:03:43 -08:00
Hans Muller
6006c23757
Step 2 of 2: Remove Flutter's FloatingActionButton dependency on ThemeData accent properties (#46923) 2020-01-16 07:21:25 -08:00
Josh Burton
6852605c4f Adds floatLabelBehavior to InputDecoration (#46115) 2020-01-15 18:53:01 -08:00
Alexandre Ardhuin
c195b771cc replace runtimeType.toString() (#48892) 2020-01-15 16:58:02 -08:00
Konstantin Scheglov
5a072a9365 Add missing type arguments to fix implicit dynamic. (#48853) 2020-01-15 16:53:02 -08:00
Per Classon
a752435fac Exclude modal barrier Container in Drawer from Semantics on Android (#48841) 2020-01-15 16:48:02 -08:00
Anthony
aeb12144e6 Use a separately focusable semantics node for the chip delete icon (#48740) 2020-01-15 16:38:04 -08:00
chunhtai
d372814f78 reland add lifecycle enum and remove workaround (#48460) 2020-01-15 16:33:01 -08:00
Tianguang
c88320458e Allow IconButton to have smaller sizes (#47457) 2020-01-15 08:38:02 -08:00
Shi-Hao Hong
0174267316 ButtonBar.verticalDirection and AlertDialog.actionsVerticalDirection (#48728) 2020-01-14 16:48:02 -08:00
Dan Field
3e63411256 Avoid runtimeType.toString in toString overrides/debugLabels (#48607) 2020-01-14 16:43:01 -08:00
Kate Lovett
5ca4cc8852 Restored change (#48529) 2020-01-14 09:38:02 -08:00
rami-a
68d0c89ffc
Return the correct number of semantic children for the ListView.separated constructor (#48741) 2020-01-14 16:18:48 +00:00
Michel Feinstein
9585acd478 Fixing AutomaticKeepAlive Docs (#48575) 2020-01-13 17:18:02 -08:00
Prerak Mann
8b6b3b62c1 Passes scrollPhysics (#48342) 2020-01-13 17:08:01 -08:00
Tianguang
d7d642653a
Add asserts requiring BoxConstraints' parameters to be non-null (#48295) 2020-01-13 21:34:30 +01:00
Kate Lovett
8f92cb710e Fixing PageScrollPhysics to get along with NestedScrollView (#48457) 2020-01-13 11:58:03 -08:00
Greg Spencer
6495d3775d
Allow requestFocus on an unattached FocusNode to create a deferred focus request (#48589)
This changes the behavior of requestFocus when it is called on a FocusNode that does not yet have a parent, so that it defers requesting focus until it receives a parent. Before this change, calling requestFocus before it had a parent was a no-op.

This allows scenarios where a widget is newly added and wishes to immediately request the focus. Previously, it was very hard to make that work because requesting focus before the widget's focus node had a parent was ignored, so the developer had to wait until two frames later to request focus (one for the widget's node to be added to the focus tree, and one to request the focus).

Now, in order to have a widget be focused when initially added, you just need to call requestFocus on its node when you create it, and as soon as it is added, it will automatically request focus.

This is different from the autofocus attribute on the Focus widget, because it unconditionally requests focus when added (autofocus will only request focus if nothing else in the scope has focus).
2020-01-13 11:56:47 -08:00
Michael Goderbauer
6a5964d89c Make ParentDataWidget usable with different ancestor RenderObjectWidget types (#48541) 2020-01-13 10:08:01 -08:00
Ian Hickson
e2b169ebd3 Apply void_checks lint. (#48267) 2020-01-13 10:03:01 -08:00
Dan Field
5129c2d295
Fix typo (#48385) 2020-01-10 17:06:16 -08:00
Chris Yang
7dba0da277
Fix platform view pointer event global route position detection (#48459) 2020-01-10 16:52:22 -08:00
Maya
c90b118247 Add padEnds option to SliverFillViewport (#48207) 2020-01-10 14:33:02 -08:00
LongCatIsLooong
02db6a8052 DiagnosticsTreeStyle.oneLine for CupertinoThemeData (#48084) 2020-01-10 14:23:02 -08:00
Ben Konyi
d907a26229
Fixed issue where PaginatedDataTable would not fill the width of its containing Card (#48531) 2020-01-10 09:44:22 -08:00
gaaclarke
31f399f973 Stopped increasing the cache size to accomodate large images. (#47387) 2020-01-10 09:43:03 -08:00
Shi-Hao Hong
db08afd07f Allow for customizable ModalRoute barrierTween (#48345) 2020-01-09 19:28:01 -08:00
Hans Muller
169f157908
Step 1 of 2: Warn about Flutter's FloatingActionButton dependency on ThemeData accent properties (#48435) 2020-01-09 10:30:17 -08:00
Greg Spencer
1df6e2af5d
Simplify the Shortcuts widget diagnostic output (#48265)
This simplifies the diagnostic output for the Shortcuts widget so that if a debugLabel is supplied, then that is printed instead of the full list of shortcut keys in the map. Also, the output of the shortcut map is simplified to have the list of keys presented in more readable text.
2020-01-09 09:54:23 -08:00
Shi-Hao Hong
51e24a3561
Implement reverseTransitionDuration for TransitionRoute (#48274)
* Implement reverseTransitionDuration in TransitionRoute
2020-01-09 09:31:38 -08:00
creativecreatorormaybenot
c241f9f6b2 Document reasoning for why CustomMultiChildLayout size can't depend on children and how to do it (#48451) 2020-01-09 08:28:02 -08:00
Alexandre Ardhuin
82262d8896 format operator== according to flutter style guide (#48449) 2020-01-09 08:23:02 -08:00
Kate Lovett
84aa29ce63 Gold Pre-submit flow for contributors without permissions (#47551) 2020-01-09 08:08:03 -08:00
Greg Spencer
fabf4e3d0d Reverse the sense of the terms snippet and sample. (#48254) 2020-01-08 15:28:02 -08:00
Tong Mu
dbed575c01 Add test of scrolling competition (#47492) 2020-01-08 15:23:02 -08:00
Sunbreak
4e6d649f14 Add optional endian argument for WriteBuffer/ReadBuffer (#46661) 2020-01-08 15:18:03 -08:00
Marius Meißner
0384c8c482 Flexible padding (header height) for expanded panels (#47951)
* Added property for expanded padding of expansion panel for solving #24071

* #24071: Renamed default const name for being more descriptive

* #24071: Improved comment of property expandedPadding

* #24071: Improved test by expanding the expansion panel by header tap + precise assertion

* #24071: Renamed property to be more descriptive

* #24071: Adjusted property comment and added missing trailing commas

* #24071: Improved test by checking real exact header size

* #24071: Added test for default header padding

* #24071: Improved comment of expandedHeaderPadding + code style adjustments

* #24071: Added missing trailing comma
2020-01-08 12:33:25 -08:00
David Iglesias
f65f7f0118 Change video_demo slightly so it works on web. (#46719) 2020-01-08 12:28:01 -08:00
Greg Spencer
8b132015bb
Add CatmullRomCurve and CatmullRomSpline (#47547)
This adds CatmullRomCurve animation curve, and a CatmullRomSpline, which is what it uses to do interpolation.

This allows us to create animation curves which can smoothly interpolate the values given to the curve.

Since I've introduced a 2D spline curve, I also created a Curve2D base class for such parametric curves.
2020-01-08 07:59:54 -08:00
Dan Field
505af78ae1
StackTrace parser, fix assertion error message (#48343) 2020-01-07 22:49:27 -08:00
Alexander Aprelev
317b9e786b
Revert "Document reasoning for why CustomMultiChildLayout size can't depend on children and how to do it (#47797)" (#48369)
This reverts commit de2514c0e2631e33996d131e8743fbcb7bbd57c4 as it breaks analyze-linux and web_tests-0-linux checks.
2020-01-07 21:42:18 -08:00