DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,576 Commits 882 Branches 1,069 Tags
Commit Graph

23999 Commits

Author SHA1 Message Date
Chris Yang
110ec685de [ios] Reland "[ios] use python script to generate extension safe frameworks and code sign them" #46004" (flutter/engine#46014) 
Relands https://github.com/flutter/engine/pull/45781
The Flutter.framework and the sim folders are mistakenly added to the artifact, this PR removed those files along with re-landing the original changes 

https://github.com/flutter/flutter/pull/134966 should pass with this change. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-20 16:18:21 +00:00
skia-flutter-autoroll
18c48846db Roll Skia from 56ce5bb201c6 to f54c214a739b (4 revisions) (flutter/engine#46098) 
https://skia.googlesource.com/skia.git/+log/56ce5bb201c6..f54c214a739b

2023-09-20 michaelludwig@google.com [skif] Use optionals to track unbounded input/output bounds
2023-09-20 robertphillips@google.com [graphite] Use Compose helper to implement dithering
2023-09-20 kjlubick@google.com Revert "[Fontations] Test path equivalence for a set of test fonts and strings"
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from bc9a66c04290 to 881dc3bb55fd (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 15:27:00 +00:00
skia-flutter-autoroll
05774cbbbc Roll Skia from fd317812bd27 to 56ce5bb201c6 (4 revisions) (flutter/engine#46096) 
https://skia.googlesource.com/skia.git/+log/fd317812bd27..56ce5bb201c6

2023-09-20 drott@chromium.org [Fontations] Test path equivalence for a set of test fonts and strings
2023-09-20 johnstiles@google.com Migrate NVIDIA test disables into SkSLTest.cpp.
2023-09-20 brianosman@google.com [graphite] Adjust the working context inside working format color filter
2023-09-20 robertphillips@google.com [graphite] Add a PaintOption class to the precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 14:42:02 +00:00
skia-flutter-autoroll
058dcd40a5 Roll Skia from d7f2d1083979 to fd317812bd27 (2 revisions) (flutter/engine#46094) 
https://skia.googlesource.com/skia.git/+log/d7f2d1083979..fd317812bd27

2023-09-20 weiyuhuang@google.com Expose 5 more paragraph methods from Canvaskit for Flutter.
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from bc9bc348e2da to 5b50d4261358

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 13:58:50 +00:00
skia-flutter-autoroll
65cbb8c06d Roll Skia from 7d9d5ac84d8f to d7f2d1083979 (1 revision) (flutter/engine#46091) 
https://skia.googlesource.com/skia.git/+log/7d9d5ac84d8f..d7f2d1083979

2023-09-20 maryla@google.com Fix default values for gain map metadata.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 10:34:21 +00:00
skia-flutter-autoroll
799989c2b9 Roll Skia from e9b9e9a4f541 to e3aa86332255 (1 revision) (flutter/engine#46088) 
https://skia.googlesource.com/skia.git/+log/e9b9e9a4f541..e3aa86332255

2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1b17251d0e2c to 918412e0912f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 06:31:34 +00:00
skia-flutter-autoroll
94959274b2 Roll Dart SDK from b8f006d88c07 to b3fd178ce59f (3 revisions) (flutter/engine#46087) 
https://dart.googlesource.com/sdk.git/+log/b8f006d88c07..b3fd178ce59f

2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-183.0.dev
2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-182.0.dev
2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 05:34:03 +00:00
Brandon DeRosier
9761621578 [Impeller] Ensure that reused textures are cleared before getting sampled by backdrop textures (flutter/engine#46084) 
Fix for https://github.com/flutter/flutter/issues/135053.

I'm going to try and optimize out this case later, since Wondrous is
inadvertently paying for a backdrop filter that contributes nothing to
the final image.
 2023-09-19 22:33:37 -07:00
Brandon DeRosier
2bc09e284c [Impeller] Use BlackTransparent clear color when backdrop filters are present. (flutter/engine#46085) 
Fix for https://github.com/flutter/flutter/issues/135053.

We already duck out of the Entity absorbing part of the optimization,
but we also need to duck here when computing clear colors, otherwise we
end up double-applying the effect of clearing entities at the beginning
of a pass in some cases.
 2023-09-19 22:13:37 -07:00
skia-flutter-autoroll
493a368184 Roll Fuchsia Linux SDK from ZhY53WD7bFJSA3xoO... to aHtib4LBcLwx7JwK-... (flutter/engine#46082) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 04:19:21 +00:00
skia-flutter-autoroll
46f2372f24 Roll Skia from 1a8885b9e03c to 5d916c04e9fc (6 revisions) (flutter/engine#46081) 
https://skia.googlesource.com/skia.git/+log/1a8885b9e03c..5d916c04e9fc

2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from b4ee53fe6042 to ca3aa4986e49
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 927fde2f2c6e to 34426197856b
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 5a23365ca776 to bc9bc348e2da
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a5a762c16294 to 4983a463d62a
2023-09-20 fmalita@chromium.org [mesh2d demo] Include CK copy
2023-09-19 armansito@google.com [graphite][mtl] Align dynamic thread group memory to 16 bytes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 03:56:22 +00:00
godofredoc
3c2c0cc1fe Use magic envs to pass commit and temp folder. (flutter/engine#46015) 
The fuchsia scripts rely on paths and the commit version being passed as parameters. This changes pass those values using special environment variables.

Bug: https://github.com/flutter/flutter/issues/126461

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-20 02:42:19 +00:00
Chinmay Garde
c762dfe955 [Impeller] Fix validation error about incorrect aspect on buffer to texture copies. (flutter/engine#46078) 
This shows up when we try to set the contents of a depth of stencil image. The aspect was assumed to be color only because typical Impeller workloads have device-transient depth and stencil images. But the "stencil mask" test apparently does set the context directly. Besides, this is perfectly valid usage. This makes Vulkan resilient to said usage.
 2023-09-19 23:40:14 +00:00
Jonah Williams
dc05767b39 [Impeller] Affinity adjustments for Vulkan backend. (flutter/engine#46063) 
Runs the waiter threads with efficiency affinity and the worker thread with "not performance" affinity.
 2023-09-19 23:34:11 +00:00
Chinmay Garde
bed3ae87ee [Impeller] Fix validation errors in RendererTest. (flutter/engine#46076) 
Vulkan validation was tripping on the fact that renderer tests were rendering to the root render pass. This root render pass doesn't contain a stencil buffer. However, `MakeDefaultPipelineDescriptor` assumes a stencil and color attachment. The other backends are resilient to this mismatch since there is no compat render pass created upfront. But Vulkan was sad. This should only happen in the low level tests. In the higher levels of the framework, we have variants that make sure there is a pipeline pass and render pass compatibility.

Fixes validations of the kind:

```
--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-vkCmdDraw-renderPass-02684
|               ID Number: 1349015333
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|         Related Objects: RenderPass [16305153808034431137] [Playground Render Pass], RenderPass [18100546345029861533] [Compat Render Pass: BoxFade Pipeline]
|                 Trigger: Validation Error: [ VUID-vkCmdDraw-renderPass-02684 ] Object 0: handle = 0xe2478b00000000a1, name = Playground Render Pass, type = VK_OBJECT_TYPE_RENDER_PASS; Object 1: handle = 0xfb320f000000009d, name = Compat Render Pass: BoxFade Pipeline, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0x50685725 | vkCmdDraw: RenderPasses incompatible between active render pass w/ VkRenderPass 0xe2478b00000000a1[Playground Render Pass] and pipeline state object w/ VkRenderPass 0xfb320f000000009d[Compat Render Pass: BoxFade Pipeline] Attachment 4294967295 is not compatible with 1: The first is unused while the second is not.. The Vulkan spec states: The current render pass must be compatible with the renderPass member of the VkGraphicsPipelineCreateInfo structure specified when creating the VkPipeline bound to VK_PIPELINE_BIND_POINT_GRAPHICS (https://vulkan.lunarg.com/doc/view/1.3.224.1/mac/1.3-extensions/vkspec.html#VUID-vkCmdDraw-renderPass-02684)
-----------------------------------------------------------------

```
 2023-09-19 23:25:07 +00:00
skia-flutter-autoroll
9647e35f62 Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (flutter/engine#46075) 
https://skia.googlesource.com/skia.git/+log/fe3568162721..1a8885b9e03c

2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 6fbc053bdad0 to a5a762c16294
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 4880b92b4f1c to 927fde2f2c6e
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 75c3a7bb1f19 to b4ee53fe6042
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 3c3b69cdbecd to 5a23365ca776
2023-09-19 johnstiles@google.com Fix a few more GCC warnings.
2023-09-19 bungeman@google.com Revert "Enforce IWYU on more src/core files"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 22:34:05 +00:00
gaaclarke
8ddfb38703 [Impeller] adds hardware gate for wide gamut (flutter/engine#46051) 
fixes https://github.com/flutter/flutter/issues/133015

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-19 22:27:36 +00:00
Jackson Gardner
566eaa9d21 Properly transfer objects between the main thread and web worker. (flutter/engine#46061) 
We need to make sure to add objects to the transfer list when we send them across the ui thread/web worker boundary. Otherwise, they get copied, which is very expensive.

On my M1 MacBook Pro, I took measurements of scrolling in the material 3 demo. Before this change, the work on the web worker thread was taking about 25-40ms per frame. After the change, it's around 2ms.
 2023-09-19 22:23:40 +00:00
gaaclarke
70b4e83c3d Made the warning about downgrading wide gamut happen at the correct time (flutter/engine#46064) 
fixes https://github.com/flutter/flutter/issues/135033

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-19 21:45:35 +00:00
Matan Lurey
42bac1a9a9 Conform to clang_tidy in client_wrapper headers. (flutter/engine#46058) 
Partial work towards https://github.com/flutter/flutter/issues/134969.

All of these were auto-suggested by Clang, and mostly avoid unnecessary
copies.
 2023-09-19 14:43:06 -07:00
gaaclarke
9a2dcd854e [Impeller] Adds unit test to make sure we can encode bgr101010xr to png. (flutter/engine#46007) 
fixes https://github.com/flutter/flutter/issues/133942

This is current blocked on the skia bug: https://g-issues.skia.org/issues/300986800
Depends on skia fix: https://skia-review.googlesource.com/c/skia/+/757816

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-19 21:24:47 +00:00
Chris Yang
2b2092a781 [ios] scenario test make parent view controller hide status bar (flutter/engine#46065) 
The parent view controller of FlutterViewController in `non_full_screen_flutter_view_platform_view` does not explicitly set the status bar hidden. iOS 17 will show the status bar causing the golden to be no deterministic. 

Part of https://github.com/flutter/flutter/issues/133207

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-19 21:23:16 +00:00
Michael Goderbauer
f98560e895 Enable strict-inference (flutter/engine#46062) 
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
 2023-09-19 21:17:16 +00:00
skia-flutter-autoroll
eb1ebd7600 Roll Skia from 559a964f9f1b to fe3568162721 (5 revisions) (flutter/engine#46069) 
https://skia.googlesource.com/skia.git/+log/559a964f9f1b..fe3568162721

2023-09-19 jvanverth@google.com [graphite] Switch signed unique ID iterators to unsigned.
2023-09-19 jamesgk@google.com Add "unsafe apis" toggle for Adapter in Graphite DawnTestContext
2023-09-19 fmalita@chromium.org [skottie] Make text shaper header public
2023-09-19 jvanverth@google.com [graphite] Add option to disable cached glyph uploads.
2023-09-19 jamesgk@google.com [graphite] Use Dawn's dual-src blend coeffs when possible

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 21:15:05 +00:00
Srujan Gaddam
978165ed7d Implement JSObject instead of extending (flutter/engine#46070) 
JSObject will have a factory constructor to create an object literal, so
you can't extend it as it will no longer have a generative constructor
(@staticInterop types can't have generative constructors).
 2023-09-19 14:14:16 -07:00
Matan Lurey
4f1227c920 FlutterMouse.* -> kFlutterMouse.*, so we can lint header files. (flutter/engine#46056) 
Partial work towards https://github.com/flutter/flutter/issues/134969.

---------

Co-authored-by: Chris Bracken <chris@bracken.jp>
 2023-09-19 14:13:18 -07:00
Matan Lurey
3c7f8df584 Add TODO(name) to comply with Clang Tidy. (flutter/engine#46057) 
Partial work towards https://github.com/flutter/flutter/issues/134969.
 2023-09-19 12:54:08 -07:00
Chris Yang
4260e227dc [ios]Adjust golden test threshold for TwoPlatformViewsWithOtherBackDropFilterTests based on current macOS version (flutter/engine#45891) 
TwoPlatformViewsWithOtherBackDropFilterTests is failing on macOS 13 with the same simulator version used in macOS 12. The image diff looks identical and slightly above the threshold. This PR adjusts the threshold for this test temporarily so our CI can run on both macOS 13 and 12. This change can be reverted when we move all our CI to macOS 13

Fixes https://github.com/flutter/flutter/issues/134740

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-19 19:54:00 +00:00
skia-flutter-autoroll
e8830a730b Roll Skia from d756a2f5665d to 559a964f9f1b (9 revisions) (flutter/engine#46059) 
https://skia.googlesource.com/skia.git/+log/d756a2f5665d..559a964f9f1b

2023-09-19 brianosman@google.com Fix encoder funtion for 101010_xr
2023-09-19 johnstiles@google.com Pass the GraphiteTestContext to the most-complex DEF_TESTs.
2023-09-19 johnstiles@google.com Return a ContextInfo from Graphite's ContextFactory.
2023-09-19 kjlubick@google.com Add grep (pgrep) to Docker container used to build Skia-release
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 640b7331b244 to e1a78e7e85a9 (2 revisions)
2023-09-19 bungeman@google.com [skshaper] Stage "Split off SkUnicode specific code"
2023-09-19 jvanverth@google.com [graphite] Track whether ordered Recordings are required.
2023-09-19 jmbetancourt@google.com expose textProperty slot support to CanvasKit
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 91ef1f3cfd30 to 7cb117e0b06c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 18:30:17 +00:00
Matan Lurey
1475e52d11 Deprecate fml::LOG_X in favor of kLogX. (flutter/engine#46052) 
This is required to eventually land https://github.com/flutter/flutter/issues/134969 (lint header files).

No changes in behavior in this PR. Future steps:

 - Change existing `LOG_X` references to `kLogX`
 - Delete `LOG_X`
 2023-09-19 18:05:38 +00:00
Matan Lurey
7ebcf75a46 Rename layoutGoals to kLayoutGoals to enforce lints on headers. (flutter/engine#46054) 
This is required to eventually land https://github.com/flutter/flutter/issues/134969 (lint header files).
 2023-09-19 17:58:33 +00:00
skia-flutter-autoroll
0363248df8 Roll Skia from d54cf63f051b to d756a2f5665d (5 revisions) (flutter/engine#46048) 
https://skia.googlesource.com/skia.git/+log/d54cf63f051b..d756a2f5665d

2023-09-19 kjlubick@google.com Enforce IWYU on more src/core files
2023-09-19 johnstiles@google.com Migrate Mali 400 test disables into SkSLTest.cpp.
2023-09-19 johnstiles@google.com Migrate Adreno test disables into SkSLTest.cpp.
2023-09-19 kjlubick@google.com Add way to get GrDirectContext from Ganesh-backed image
2023-09-19 robertphillips@google.com [graphite] Use Compose helper to add color filters to the key

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 16:33:04 +00:00
Jackson Gardner
7f3c15c543 Update CI to Chrome 117 (flutter/engine#45842) 2023-09-19 16:27:49 +00:00
Mouad Debbar
2c66a531e9 [web] DOM objects implement JS object (flutter/engine#46047) 
Instead of doing `as JSAny` for DOM objects that are defined in static JS interop, let's make them `implements JSObject`?

cc @eyebrowsoffire @srujzs thoughts?
 2023-09-19 15:53:16 +00:00
skia-flutter-autoroll
ebd9e705e0 Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (flutter/engine#46040) 
https://skia.googlesource.com/skia.git/+log/1e84aa4509cd..91adc7d289f7

2023-09-19 robertphillips@google.com [graphite] Refactor the precompilation SelectOption and AddToKey methods
2023-09-19 kjlubick@google.com Add googlefonts CIPD asset to fontations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 14:30:28 +00:00
skia-flutter-autoroll
b4f66d847b Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039) 
https://dart.googlesource.com/sdk.git/+log/8ad823c03f26..e7cd697bd0e9

2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-179.0.dev
2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-178.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 14:22:54 +00:00
Kevin Lubick
65945baf01 Add more missing Skia #includes (flutter/engine#46034) 
Ran into compile errors when refactoring Skia's #includes. This
addresses those

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-19 10:05:20 -04:00
Bruno Leroux
195a313245 [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… (flutter/engine#44848) 
## Description

This PR update the helper function that invokes the control channel 'resize' command (previous implementation relied on a deprecated format). It also adds a similar helper function for the 'overflow' commands exposed by the control channel.

See:

c00c022036/lib/ui/channel_buffers.dart (L302-L309)

## Related Issue

iOS and macOS implementation for https://github.com/flutter/flutter/issues/132386

Similar implementations:
- Android: https://github.com/flutter/engine/pull/44434
- Linux: https://github.com/flutter/engine/pull/44636

## Tests

Adds two tests.
 2023-09-19 09:40:18 +00:00
skia-flutter-autoroll
d9a3f74eec Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028) 
https://dart.googlesource.com/sdk.git/+log/5b0e7bda1379..8ad823c03f26

2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-177.0.dev
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-176.0.dev
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-175.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 09:34:14 +00:00
skia-flutter-autoroll
68136393cd Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (flutter/engine#46026) 
https://skia.googlesource.com/skia.git/+log/744807d740c7..1e84aa4509cd

2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 18f1b3b8e79d to 91ef1f3cfd30 (11 revisions)
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6e55411b61e1 to 1b17251d0e2c (10 revisions)
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 02233e019c4e to 5ca21ed72084 (5 revisions)
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from aea31dd66eb1 to 1b17251d0e2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 07:37:31 +00:00
Jonah Williams
88e963e0fd [Android] Add support for setting thread affinity based on core speed. (flutter/engine#45673) 
https://github.com/flutter/flutter/issues/134452

This patch parses the speed of all CPU data out of /proc and constructs a table that allows us to request high level CPU affinities: performance, efficiency, and not performance. These affinties are applied where appropriate during Android thread construction.
 2023-09-19 03:50:05 +00:00
Chinmay Garde
88f8bb7e25 [Impeller] Fix STB backend to account for max texture sizes. (flutter/engine#46010) 
Gets rid of the hardcoded 2048 px size.

Followup from review comment left unaddressed in https://github.com/flutter/engine/pull/45992.

Missing this will be less easy after https://github.com/flutter/flutter/issues/133029.
 2023-09-19 03:26:36 +00:00
Matan Lurey
2b4d2616aa [Impeller] Hold the CommandPoolVK at a higher scope. (flutter/engine#46013) 
Fixes https://github.com/flutter/flutter/issues/134982.

I could never reproduce the flakes locally, but this should prevent `pool1 == pool2`.
 2023-09-19 01:25:25 +00:00
skia-flutter-autoroll
ac6eb5de3d Roll Skia from 0c990ab9e097 to 4122791099ce (19 revisions) (flutter/engine#46016) 
https://skia.googlesource.com/skia.git/+log/0c990ab9e097..4122791099ce

2023-09-18 johnstiles@google.com Remove orphaned test disable.
2023-09-18 brianosman@google.com Remove paint-color transform in working-format color filter
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 45116d485d17 to 75c3a7bb1f19
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from ac643e8ecce3 to 6fbc053bdad0
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 420bf03c7a80 to 3c3b69cdbecd
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 5b191a5ec3d1 to 4880b92b4f1c
2023-09-18 brianosman@google.com Suppress alpha-only image shader logic when sampled via runtime effects
2023-09-18 bungeman@google.com Reland "[skicu] Use cache and respect locale"
2023-09-18 johnstiles@google.com Remove Dawn Ganesh-specific SkSL test disables.
2023-09-18 brianosman@google.com In DM, use an SkSurface for CPU configs
2023-09-18 johnstiles@google.com Add contextType() accessor to test contexts.
2023-09-18 kjlubick@google.com Enforce IWYU on src/core/SkC* and SkD*
2023-09-18 kjlubick@google.com Remove TextBlob's empty mailbox in favor of delegate
2023-09-18 egdaniel@google.com Remove SkRefCnt from GrGpu.
2023-09-18 jmbetancourt@google.com [skottie] make SkottieSlide slot manager UI responsive to live changes
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 22b6ca1c6191 to 18f1b3b8e79d (2 revisions)
2023-09-18 johnstiles@google.com Re-enable pixel-local storage test.
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 53e6e021f9b7 to cf45d7c5dc0d (1 revision)
2023-09-18 johnstiles@google.com Pass test run details into SkSL test permutation runner.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-19 01:21:21 +00:00
Kevin Lubick
114d818f47 Add missing include of SkPath (flutter/engine#45996) 
This is needed as Skia refactors its #includes internally.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-18 23:49:17 +00:00
Chinmay Garde
91066844ea [Impeller] Respect max supported texture size when allocating glyph atlas texture. (flutter/engine#45992) 
The earlier limit of 4096u was pessimistically small on some backends and too big on others (like older versions of OpenGL ES). The former would stop glpyhs from rendering when they got sufficiently large or numerous. The latter would cause errors on texture allocation.

The full fix is tracked in https://github.com/flutter/flutter/issues/133092
 2023-09-18 22:37:57 +00:00
Chris Bracken
0a532593f1 Revert "[Windows] Update vsync on raster thread (#45310)" (flutter/engine#46000) 
This also reverts the ANGLE roll (for which the original fix was landed) to 48e2c605adcd5bcc1622b18f357c7a73ebfb3543.

fixes: https://github.com/flutter/flutter/issues/134262

This reverts commit 2bec12f0b4d76d9f60d55d057e16cd2788083ade.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-18 22:34:29 +00:00
Matan Lurey
8af3ec1fb9 Provide a default --target-variant for clang_tidy. (flutter/engine#45909) 
Using `engine_repo_tools`, provide a default `--target-variant` for the `clang_tidy` tool.

Mostly test code added below, the major change is that `--target-variant` now has a default other than `host_debug` if we're running inside of an engine root (which we ~always are). I didn't make any other changes (i.e. to the pre-commit hook) to keep this change smallish.

Also rewrote the `README.md` to represent the current state as best I could.
 2023-09-18 22:34:27 +00:00
Chris Yang
c27c8aaa15 Revert "[ios] use python script to generate extension safe frameworks and code sign them" (flutter/engine#46004) 
Reverts flutter/engine#45781

Issue with engine roll https://github.com/flutter/flutter/pull/134964.
We need to update the conductor and performa manual roll.
We also need to remove the Flutter.framework from the artifact.zip
 2023-09-18 22:09:33 +00:00
John McCutchan
c74acc92aa Disable HardwareBuffer backed Platform Views temporarily (flutter/engine#45986) 
Necessary to unblock the GPay release
 2023-09-18 12:36:16 -07:00