DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
28,723 Commits 882 Branches 1,069 Tags
Commit Graph

22119 Commits

Author SHA1 Message Date
Tong Mu
0d1d5a7d34 [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653) 
This PR changes the view ID type to `int64_t` and typedef it to
`FlutterViewId`

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-04 23:08:57 -07:00
skia-flutter-autoroll
71c4831258 Roll Skia from 6577130e14b6 to bf4217c3f0da (1 revision) (flutter/engine#41762) 
https://skia.googlesource.com/skia.git/+log/6577130e14b6..bf4217c3f0da

2023-05-05 michaelludwig@google.com Reland "[skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-05 04:02:09 +00:00
陈昱
aa95b83a0d Close connection on keyboard close (flutter/engine#41500) 
Fix:
- https://github.com/flutter/flutter/issues/123523
- https://github.com/flutter/flutter/issues/124890

### Before this patch:

https://user-images.githubusercontent.com/30322203/228413196-29c57bb0-3220-495b-9e73-f58777de440f.mp4

### After this patch:

https://user-images.githubusercontent.com/30322203/228413249-fc06f49d-6579-4476-9788-90f12a53b8c3.mp4
 2023-05-05 02:55:05 +00:00
Jackson Gardner
f2970b73b0 Revert "Skwasm Font Loading" (flutter/engine#41750) 
Reverts flutter/engine#41246

The new font manifest parsing fails in some cases.
 2023-05-04 23:54:18 +00:00
Jenn Magder
29dc3361f0 Fix flaky FlutterChannelsTests, stop mocking NSObject (flutter/engine#41747) 
I don't know why this is only flaking on arm64 Macs, but instead of mocking out `NSObject` which seems to continue to be mocked on some background thread, instead mock out the more-specific `FlutterTaskQueue` protocol.  Turn the tests back on.

Fixes https://github.com/flutter/flutter/issues/126013
Reverts https://github.com/flutter/engine/pull/41740

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-04 22:58:12 +00:00
skia-flutter-autoroll
c8110a1cb7 Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746) 
https://skia.googlesource.com/skia.git/+log/a4828415b4af..00693e987828

2023-05-04 johnstiles@google.com Remove unused flag from VarDeclaration::Convert.
2023-05-04 johnstiles@google.com Use packed contexts for ternary ops in SkRP.
2023-05-04 michaelludwig@google.com [skif] Automatically switch to NN sampling when possible
2023-05-04 johnstiles@google.com Create test case demonstrating inliner issue.
2023-05-04 johnstiles@google.com Generate simpler code when SkArenaAlloc makes a POD type.
2023-05-04 michaelludwig@google.com Add skia_use_legacy_colorfilter_imagefilter GN arg for flutter roll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 22:58:10 +00:00
godofredoc
67ff63e16a Migrate linux unopt to engine_v2. (flutter/engine#41658) 
Migrates linux unopt to use engine v2 recipes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-04 21:59:52 +00:00
Jonah Williams
11bd4c8bb3 [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744) 
This avoids tessellation if the application draws a Rect or RREct with Path.addRect or Path.addRREct.
 2023-05-04 20:51:21 +00:00
Michael Ludwig
4a82a1b867 Add temporary staging GN arg for Skia roll (flutter/engine#41743) 
In order to enable the new behavior, dl_imagefilter_unittests need to be
updated to reflect new bounds mapping values. This requires an atomic PR
to disable the legacy arg and update after skia rolls.

Required to land https://skia-review.googlesource.com/c/skia/+/693058
and progress on https://skbug.com/9283

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-04 13:38:01 -07:00
Dan Field
ee7376a670 Disable flaky tests on arm64 (flutter/engine#41740) 
Reduces severity of https://github.com/flutter/flutter/issues/126013
 2023-05-04 12:22:18 -07:00
skia-flutter-autoroll
e6ece101f0 Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737) 
https://skia.googlesource.com/skia.git/+log/6950f56ad2ec..a4828415b4af

2023-05-04 johnstiles@google.com Use a packed context for SkRP case_op.
2023-05-04 johnstiles@google.com Ensure linear-SRGB conversion is free when it's a no-op.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 19:11:41 +00:00
Jackson Gardner
6f5ad9737e Skwasm Font Loading (flutter/engine#41246) 
This implements font loading for the skwasm renderer.

In addition, it does some pretty major refactors:
1) Simplified the font collection interface to just have a single `loadAssetFonts` call, without the separate registration and debug fonts loading stuff
2) Debug fonts load now through http/asset mocking mechanisms instead of having a separate `downloadDebugTestFonts` call
3) Consolidated a few of our different unit test setup functions into a single `setUpUnitTests` function
 2023-05-04 18:22:53 +00:00
godofredoc
a21064fb0a Migrate linux_host_engine to engine v2. (flutter/engine#41715) 
The artifacts generated by legacy and engine v2 are identical. This PR is moving linux host engine to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-04 16:23:51 +00:00
skia-flutter-autoroll
c9a790b448 Roll Skia from 93c869da03f5 to 9b19c0a0acf0 (14 revisions) (flutter/engine#41725) 
https://skia.googlesource.com/skia.git/+log/93c869da03f5..9b19c0a0acf0

2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 502a387d3238 to d6fb4eb8ccb8 (11 revisions)
2023-05-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b89ed2f23a03 to ecefa6c65969 (1 revision)
2023-05-04 michaelludwig@google.com Revert "[skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter"
2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fc9661a5b52e to eca6699311e8 (1 revision)
2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from ba39d81f9797 to fc9661a5b52e (1 revision)
2023-05-03 johnstiles@google.com Add realistic/ directory to golden outputs.
2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 25854b6d2ad9 to 4ec2a864c052 (5 revisions)
2023-05-03 jvanverth@google.com [graphite] A couple more minor Vulkan issues.
2023-05-03 michaelludwig@google.com [skif] Use FilterResult::applyColorFilter in SkColorFilterImageFilter
2023-05-03 michaelludwig@google.com [skif] Re-implement Magnifier image filter
2023-05-03 fmalita@chromium.org [svg] Add SK_API to public classes
2023-05-03 johnstiles@google.com Use padding to save an op when invoking to/fromLinearSrgb.
2023-05-03 herb@google.com constify FindEnclosingEdges
2023-05-03 michaelludwig@google.com Add GM exploring SkImageFilters::Magnifier behavior

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 07:02:38 +00:00
skia-flutter-autoroll
b7e9833ca1 Roll Fuchsia Linux SDK from n1UnzmslAzt04yRv6... to LIacrdFhuTuHnYh0B... (flutter/engine#41724) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-04 05:48:20 +00:00
Jackson Gardner
5189eda98b Populate fallback fonts from CIPD in tests (flutter/engine#41656) 
This fixes https://github.com/flutter/flutter/issues/85793

The script that generates the font fallback data also rolls a package to CIPD with these files and updates the DEPS to download those files from CIPD. This makes sure that these tests are hermetic.
 2023-05-04 05:12:54 +00:00
Dan Field
1535542946 Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720) 
This would have helped me figure out why I wasn't getting the same failures as on CI more quickly.
 2023-05-04 01:49:22 +00:00
Brandon DeRosier
4f9622c56b [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711) 
Fixes https://github.com/flutter/flutter/issues/125906.
Fixes https://github.com/flutter/flutter/issues/125908.

Going to add this back once I'm able to work out why the clear colors
aren't working on GL/Vulkan. Stepping though with a debugger for both
GLES and Vulkan, the clear colors seems to be getting piped through as
expected. But the frame captures reveal that they're actually not.
 2023-05-03 17:16:38 -07:00
godofredoc
7a1eeaffae Add relative path support for malioc_diff. (flutter/engine#41703) 
Relative paths are required for integrating this tool as a test in engine v2.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-03 23:45:30 +00:00
Tong Mu
a7c3f6162c [macOS] Remove view ID from public (flutter/engine#41712) 
This is a reland of https://github.com/flutter/engine/pull/39958, but
only contains the minimal changes that removes all references to viewId
from public interfaces, reverting these changes from
https://github.com/flutter/engine/pull/39576.

Flutter doesn't really support multi-view anyway. These methods
currently only works for view 0. We better remove them until we mark
multi-view stable. It was a mistake that I decided to add them to public
interfaces.

For the reason why https://github.com/flutter/engine/pull/39958 failed,
I'm pretty sure it's the change to
[platform_dispatcher.dart](https://github.com/flutter/engine/pull/39958/files#diff-57d6953e215d0e5dd7260ee60b665c812aa730566ef0b30f7ff1e3d661143585)
that mysteriously and unintentionally appeared in the change list.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-03 15:40:14 -07:00
Brandon DeRosier
579c8fe3d8 [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676) 
This is essentially a revert of
https://github.com/flutter/engine/pull/41060 with better comments.
 2023-05-03 13:41:57 -07:00
Jonah Williams
dfff522046 Remove physical model layer (flutter/engine#41593) 
Removes the physical model layer and associated engine code. This was already deprecated and removed in the framework. By removing it in the engine, we can also remove the need for layer tree diff/paint/preroll to have the device pixel ratio. This will simplify some of the multi-view work

Fixes https://github.com/flutter/flutter/issues/125720
 2023-05-03 20:28:53 +00:00
Greg Spencer
18125adcfc Reland: "Determine lifecycle by looking at window focus also" (#41094) (flutter/engine#41702) 
## Description

This reverts commit e49577708d9d5315fa6c001d7dc20ee80d04cd35 to re-land #41094 because the Google test failures have been fixed. There are no changes to the original PR, since the fixes were in the Google code.
 2023-05-03 19:21:58 +00:00
skia-flutter-autoroll
a2b6651eeb Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705) 
https://skia.googlesource.com/skia.git/+log/887e58fff02f..93c869da03f5

2023-05-03 kjlubick@google.com Move SkImageGenerator::MakeFromEncoded to private
2023-05-03 herb@google.com Take const ref in is(Right|Left)Of
2023-05-03 michaelludwig@google.com [skif] Add applyColorFilter to FilterResult
2023-05-03 johnstiles@google.com Add golden-output test for to/fromLinearSrgb.
2023-05-03 nicolettep@google.com [graphite] Make ResourceProvider's resource cache protected instead of private
2023-05-03 nicolettep@google.com [graphite] Add VulkanDescriptorPool, VulkanDescriptorSet classes
2023-05-03 johnstiles@google.com Add single-slot immediate min/max ops.
2023-05-03 jamesgk@google.com [graphite] Don't track snippet req flags on gatherer
2023-05-03 herb@google.com Handle more cases for sk_doubles_nearly_equal_ulps
2023-05-03 johnstiles@google.com Fix fuzzer-discovered error with repeated assignment.
2023-05-03 kjlubick@google.com Manually Roll Dawn from 22f70bb09892 to 2966d3ad08eb (35 revisions)
2023-05-03 kjlubick@google.com Fix typos in public.bzl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 18:51:03 +00:00
Mouad Debbar
9ed3f6008e [web] Improve null safety for color->css (flutter/engine#41699) 
Turning `colorToCssString` into an extension method on `ui.Color` improves null safety and developer ergonomics.
 2023-05-03 18:15:04 +00:00
Mouad Debbar
9cb01b94d5 [web] Remove unused function parameter (flutter/engine#41700) 
The `hasAutofillOverlay` and `cssSelectorPrefix` parameters aren't really used in any useful way. Let's remove them.
 2023-05-03 17:57:21 +00:00
godofredoc
70a249203a Migrate Android Engine Debug to Engine V2. (flutter/engine#41687) 
Legacy and engine v2 builds artifacts are identical. This PR is moving the legacy build to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-03 17:19:04 +00:00
Kevin Lubick
e05e7a8552 Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693) 
In https://skia-review.googlesource.com/c/skia/+/687642, Skia moved some
gpu-related methods on SkSurface to be static functions in a different
header. This updates those callsites in Flutter.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-05-03 09:03:39 -07:00
joshualitt
e370809b5e [web] Add dart:js_interop_unsafe to SDK. (flutter/engine#41591) 
Adds the `dart:js_interop_unsafe` library to the SDK.
 2023-05-03 08:38:33 -07:00
skia-flutter-autoroll
f2e169131e Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 14:54:05 +00:00
skia-flutter-autoroll
17d6952ca9 Roll Skia from 7781dda8104f to 3c1ecab42cd4 (2 revisions) (flutter/engine#41688) 
https://skia.googlesource.com/skia.git/+log/7781dda8104f..3c1ecab42cd4

2023-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 73da11c893a5 to 502a387d3238 (7 revisions)
2023-05-03 armansito@google.com [sksl][wgsl] Prefix expressions and matrix equality test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 07:20:05 +00:00
skia-flutter-autoroll
946602b2f3 Roll Skia from 54c32e41eced to 7781dda8104f (1 revision) (flutter/engine#41684) 
https://skia.googlesource.com/skia.git/+log/54c32e41eced..7781dda8104f

2023-05-03 johnstiles@google.com Add multi-slot immediate bitwise-and.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 04:30:22 +00:00
skia-flutter-autoroll
d1b9feff35 Roll Skia from 089b9cca26fe to 54c32e41eced (3 revisions) (flutter/engine#41683) 
https://skia.googlesource.com/skia.git/+log/089b9cca26fe..54c32e41eced

2023-05-02 johnstiles@google.com Store a slot-count in RP builder immediate ops.
2023-05-02 johnstiles@google.com Generate fewer ops when invoking children via `exchange_src`.
2023-05-02 sunxiaodi@google.com [cabe] upload Pinpoint response data to skia CIPD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-03 02:37:18 +00:00
Ian McKellar
cc02c8d27e [fuchsia] fix run_integration_test.sh (flutter/engine#41668) 
This updates the `fx serve` check to reflect the current state of
Fuchsia's package serving.
 2023-05-03 09:44:37 +10:00
skia-flutter-autoroll
c1c55658bc Roll Skia from 644e199b6832 to 089b9cca26fe (14 revisions) (flutter/engine#41675) 
https://skia.googlesource.com/skia.git/+log/644e199b6832..089b9cca26fe

2023-05-02 kjlubick@google.com Move SkSurface::GetBackend* to SkSurfaces namespace
2023-05-02 jvanverth@google.com [graphite] Disable GraphitePurgeNotUsedSinceResourcesTest on Dawn
2023-05-02 jamesgk@google.com [sksl] Support FB fetch in Metal
2023-05-02 fmalita@chromium.org Add missing SkVideoDecoder header
2023-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fa4dad7039f3 to cb476d124f71 (5 revisions)
2023-05-02 jmbetancourt@google.com clean src files for JetSki BUILDs
2023-05-02 jvanverth@google.com [graphite] Clean up of SkImageShader::addToKey().
2023-05-02 jvanverth@google.com [graphite] Fix more minor features for Vulkan.
2023-05-02 fmalita@chromium.org [skwindow] Revisit naming
2023-05-02 kjlubick@google.com Mark SkSurface::recordingContext() and recorder() as const
2023-05-02 istepancar@gmail.com Update AUTHORS
2023-05-02 fmalita@chromium.org [jetski] Fix gn/gradle builds
2023-05-02 fmalita@chromium.org Update Viewer/Android build
2023-05-02 johnstiles@google.com Remove abs_float SkRP ops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-02 22:54:19 +00:00
Bruno Leroux
d56b8bee57 Web - Fix selection jump on Chrome for Android (flutter/engine#41202) 
## Description

This PR fixes cursor jump on Chrome for Android when the user taps in a multiline `TextField`.

Using the following code sample:

<details><summary>Code sample</summary>

```dart

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Text Field Focus',
      home: MyCustomForm(),
    );
  }
}

// Define a custom Form widget.
class MyCustomForm extends StatelessWidget {
  const MyCustomForm({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Text Field Focus'),
      ),
      backgroundColor: Colors.amber,
      body: Padding(
        padding: const EdgeInsets.all(16.0),
        child: TextField(
          decoration: const InputDecoration(
            fillColor: Colors.white,
            filled: true
          ),
          autofocus: true,
          maxLines: 3,
          controller: TextEditingController(text: '1\n2\n3\n4\n'),
        ),
      ),// This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

```
</details>

On a mobile browser, once the page is loaded, tap after the number 3: 

- Before this PR: the TextField content is automaticaly scrolled and the selection is set after number 1.

https://user-images.githubusercontent.com/840911/232051413-b913f890-6cb1-4c60-92d0-7a3bf74cc688.mov

## Implementation

A multiline `TextField` relies on an HTML `<textarea>` elements. When a tap occurs the selection should be updated from Flutter not by the HTML element itself. 
This PR prevents mouse events on Chrome for Android. Those events conflicts with Flutter selection changes.
Previously, mouse events were only prevented on desktop but they are also emitted on mobile, see https://bugs.chromium.org/p/chromium/issues/detail?id=119216#c11.

## Related Issue

Related to https://github.com/flutter/flutter/issues/124483 (partial fix because the issue is also reproducible on iOS/Safari).

## Tests

Adds 1 test.
 2023-05-02 19:34:35 +00:00
Jenn Magder
19aaa2d2da Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension (flutter/engine#41223) 
As of https://github.com/flutter/engine/pull/41219 all the .ci.yaml builders will run on either Macmini8,1 (x64) or Macmini9,1 (arm).  Stop specifying `Macmini8,1` on individual builders and let the specified architecture be the deciding factor.

Reverts #41203
 2023-05-02 17:37:51 +00:00
godofredoc
5060013dbf Migrate Linux Android AOT Engine to engine V2. (flutter/engine#41638) 
The legacy and engine v2 builds are generating the artifacts in the same way and have been validated over a 1+ months. This PR is moving the legacy build to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-02 16:57:48 +00:00
skia-flutter-autoroll
6c13b2a290 Roll Skia from c574ba686a93 to 644e199b6832 (1 revision) (flutter/engine#41666) 
https://skia.googlesource.com/skia.git/+log/c574ba686a93..644e199b6832

2023-05-02 kjlubick@google.com [canvaskit] Deploy v0.38.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-02 15:13:24 +00:00
Jason Simmons
5e4cd80437 Clone the parent Android engine's asset provider into a spawned engine (flutter/engine#41642) 
Typically the AndroidShellHolder's apk_asset_provider_ is set by AndroidShellHolder::Launch when the DartExecutor runs the engine's entrypoint.

But if the engine was started by Spawn, then the apk_asset_provider_ was not being set.  This would cause a crash if the resulting engine was later used to spawn another engine.

Fixes https://github.com/flutter/flutter/issues/122364
 2023-05-02 14:50:58 +00:00
Wu Zhong
b0de18ba41 [macOS] Add lookupKeyForAsset to FlutterPluginRegistrar (flutter/engine#37421) 
Fixes https://github.com/flutter/flutter/issues/47681

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-02 11:28:41 +00:00
skia-flutter-autoroll
19da3500f7 Roll Skia from c9e0992be00b to e18b7415188c (1 revision) (flutter/engine#41659) 
https://skia.googlesource.com/skia.git/+log/c9e0992be00b..e18b7415188c

2023-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 28404b632bd4 to 73da11c893a5 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-02 07:00:05 +00:00
skia-flutter-autoroll
e1af95b676 Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655) 
https://skia.googlesource.com/skia.git/+log/38e56b6da8f9..c9e0992be00b

2023-05-01 istepancar@gmail.com refactor(*): make canvaskit init parameter optional
2023-05-01 alecmouri@google.com Increase precision of csc uniforms on ganesh
2023-05-01 jvanverth@google.com [Metal] Block out deprecated GPU family interface on newer SDKs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-02 03:30:01 +00:00
Jim Graham
6ad6014776 [Impeller] take advantage of DisplayList culling (flutter/engine#41606) 
Switching the calls to dispatch into an Impeller Dispatcher to use a cull rect to enable pre-culling of the out-of-bounds ops.

This change showed an improvement of around 2x on the rendering performance of the non-intersecting platform view benchmark, but that was measured without the recent changes to the destructive blend modes in Impeller renderer.
 2023-05-01 23:27:52 +00:00
godofredoc
3b8e1ec80f Use os_dimension in framework tests. (flutter/engine#41649) 
Dimensions are now used to detect the drone to use. Framework tests are using shard_util_v2 but not engine v2 builds and require to pass the drone dimension from the .ci.yaml file.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-01 23:27:50 +00:00
Srujan Gaddam
08ab47dddf Turn @staticInterop tear-off into closure (flutter/engine#41643) 
@staticInterop members will start disallowing tear-offs, so this member
should turn into a closure.

Unblocks a roll in the SDK that disallows tear-offs.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.
 2023-05-01 16:18:32 -07:00
Chris Yang
7055742137 Update xcode to 14e222b (flutter/engine#41640) 
Engine part of. https://github.com/flutter/flutter/issues/125814

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-01 22:23:57 +00:00
Alexander Aprelev
2f2dc81599 Run flutter license script with dart --intrepret_irregexp runtime option (flutter/engine#41646) 
For extremely large RegExp's that are used in flutter license script, running interpreter-based implementation is faster than running generated unoptimized code. For normal-sized RegExp's optimized code is expected to be faster.

Local testing shows 5x speed up on full license script run (311s vs 1430s).

Should help with https://github.com/flutter/flutter/issues/118193
 2023-05-01 22:07:06 +00:00
skia-flutter-autoroll
89daa2770d Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645) 
https://skia.googlesource.com/skia.git/+log/82d1ef7a833e..38e56b6da8f9

2023-05-01 jvanverth@google.com [graphite] Get dm tests running with Vulkan.
2023-05-01 jvanverth@google.com [graphite] Track buffer access mask and use for GPU->CPU transfer.
2023-05-01 johnstiles@google.com Add dedicated op for immediate-value bitwise-and.
2023-05-01 sunnyps@chromium.org graphite: Ensure Graphite backend specific unions are always non-empty
2023-05-01 penghuang@chromium.org Reland "graphite: support selecting backend of graphite dawn"
2023-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1d74856fe8c0 to 077edbc2d56d (4 revisions)
2023-05-01 johnstiles@google.com Revert "graphite: support selecting backend of graphite dawn"
2023-05-01 johnstiles@google.com Use SkArenaAlloc for SkSL memory pooling.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-05-01 21:07:01 +00:00
Chris Yang
2c864fa88d Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test TwoPlatformViewsWithOtherBackDropFilterTests (flutter/engine#41532) 
iPhone 8 is old and not installed by default with the latest XCodes. Move the scenario test to a newer iPhone that has a home button. (Unfortunately, iPhones without home button have the bottom navigation bar that animates, resulting inconsistency during screenshots)

Fixes https://github.com/flutter/flutter/issues/125167

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-05-01 20:57:20 +00:00