7455 Commits

Author SHA1 Message Date
David Iglesias
0c2c7cfd15 Add web engine screenshot (scuba) tests (flutter/engine#12353)
* Import all golden files and tests from internal repo.
* Adapt test files to new screenshot API, and tweak some settings.

(Check PR to see individual changes to each file)

Fixes https://github.com/flutter/flutter/issues/40975
2019-09-20 09:00:55 -07:00
skia-flutter-autoroll
f6081ed304 Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) (flutter/engine#12369)
https://skia.googlesource.com/skia.git/+log/9a9841178078..ffdc3e668061

git log 9a9841178078..ffdc3e668061 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 ethannicholas@google.com added support for SkSL unpremul function

Created with:
  gclient setdep -r src/third_party/skia@ffdc3e668061

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 10:23:54 -04:00
skia-flutter-autoroll
406558f67b Roll src/third_party/skia be0d7dfa6194..9a9841178078 (2 commits) (flutter/engine#12368)
https://skia.googlesource.com/skia.git/+log/be0d7dfa6194..9a9841178078

git log be0d7dfa6194..9a9841178078 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bf4268a3963b..6c4ff5ddab07 (8 commits)
2019-09-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@9a9841178078

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 05:24:42 -04:00
skia-flutter-autoroll
07acdaab94 Roll src/third_party/skia e5b65d212bca..be0d7dfa6194 (3 commits) (flutter/engine#12367)
https://skia.googlesource.com/skia.git/+log/e5b65d212bca..be0d7dfa6194

git log e5b65d212bca..be0d7dfa6194 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b8149cbe28ad..3243c3b11405 (453 commits)
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e9b6f28fdd71..b6fa949c4539 (2 commits)
2019-09-20 mtklein@google.com raster 8888 pow2 samples hack

Created with:
  gclient setdep -r src/third_party/skia@be0d7dfa6194

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 01:35:57 -04:00
liyuqian
56bb40c017 Revert "Reland "Smooth out iOS irregular input events delivery (#11817)" (#12280)" (flutter/engine#12364)
This reverts commit dedf24e797d6257f9bb776cdf0d7525a16610321.

Reason: flutter/flutter#40863

TBR: chinmaygarde, iskakaushik
2019-09-19 19:39:36 -07:00
skia-flutter-autoroll
4054ea63df Roll src/third_party/skia f47717ad8cc7..e5b65d212bca (4 commits) (flutter/engine#12366)
https://skia.googlesource.com/skia.git/+log/f47717ad8cc7..e5b65d212bca

git log f47717ad8cc7..e5b65d212bca --date=short --no-merges --format='%ad %ae %s'
2019-09-19 halcanary@google.com pdf-comparison and image_diff_metric tools
2019-09-19 robertphillips@google.com New proposed syntax for SkColorTypes
2019-09-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@e5b65d212bca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 21:49:03 -04:00
Matt Carroll
fce67bf3a8 Fixes race condition that was reported internally. (flutter/engine#12362) 2019-09-19 16:36:17 -07:00
Siva
c5ac59ebee  Roll src/third_party/dart 7c1821c4aa...ea969c358e (flutter/engine#12339)
* Roll src/third_party/dart 7c1821c4aa...ea969c358e (6 commits)

dart-lang/sdk@7c1821c4aa [NNBD/VM] Restructure VM patch files for the NNBD dart sdk split
dart-lang/sdk@0c23664c8f [vm/fuzzer] Reduce number of methods per class
dart-lang/sdk@3135eb569d [vm/bytecode] Fix initial scope in field initializers
dart-lang/sdk@1345fb80ac Use TypeParameterElement instead of TypeParameterType in inference.
dart-lang/sdk@430ff6d649 Migration: fix "matching" functionality of edge testing infrastructure.
dart-lang/sdk@f1bff1b512 Add option to run ddb with observatory
2019-09-19 16:07:34 -07:00
skia-flutter-autoroll
bed1fcbc51 Roll src/third_party/skia 9a8b846baf43..f47717ad8cc7 (7 commits) (flutter/engine#12361)
https://skia.googlesource.com/skia.git/+log/9a8b846baf43..f47717ad8cc7

git log 9a8b846baf43..f47717ad8cc7 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 robertphillips@google.com Alter wacky_yuv_formats GM to skip rows if the required backing GPU format(s) aren't supported
2019-09-19 robertphillips@google.com Remove "experimental" comments regarding RG_F16 and RGBA_16161616
2019-09-19 mtklein@google.com stifle warning in tValue2Scalar()
2019-09-19 jvanverth@google.com Set up prototype interface for MakeFromCAMetalLayer
2019-09-19 robertphillips@google.com Revert "Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur"
2019-09-19 csmartdalton@google.com Use GrResourceProvider::MakeApprox for mask filter proxy sizes
2019-09-19 robertphillips@google.com Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur

Created with:
  gclient setdep -r src/third_party/skia@f47717ad8cc7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 15:03:42 -07:00
skia-flutter-autoroll
aee3d67a28 Roll src/third_party/skia 18531cde2ab7..9a8b846baf43 (1 commits) (flutter/engine#12360)
https://skia.googlesource.com/skia.git/+log/18531cde2ab7..9a8b846baf43

git log 18531cde2ab7..9a8b846baf43 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 brianosman@google.com Particles: Sub-effect spawning and some slight refactoring

Created with:
  gclient setdep -r src/third_party/skia@9a8b846baf43

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 12:02:03 -04:00
skia-flutter-autoroll
ddd6c46f76 Roll src/third_party/skia 6344cbd1df76..18531cde2ab7 (2 commits) (flutter/engine#12358)
https://skia.googlesource.com/skia.git/+log/6344cbd1df76..18531cde2ab7

git log 6344cbd1df76..18531cde2ab7 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7003d5fc306..bf4268a3963b (7 commits)
2019-09-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@18531cde2ab7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 05:27:48 -04:00
skia-flutter-autoroll
5a9ac4bfc7 Roll src/third_party/skia e2a903e18b59..6344cbd1df76 (3 commits) (flutter/engine#12357)
https://skia.googlesource.com/skia.git/+log/e2a903e18b59..6344cbd1df76

git log e2a903e18b59..6344cbd1df76 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b1c1d2844bd1..b8149cbe28ad (423 commits)
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 61a2765940a7..e9b6f28fdd71 (3 commits)
2019-09-19 mtklein@google.com fold srcover coverage with SkVMBlitter

Created with:
  gclient setdep -r src/third_party/skia@6344cbd1df76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 01:39:03 -04:00
Dan Field
e4a8130bc6 skip flaky test (flutter/engine#12355) 2019-09-18 21:43:11 -07:00
Dan Field
0b33917787 java lints (flutter/engine#12354) 2019-09-18 21:20:04 -07:00
Kaushik Iska
4d6b95ebdc [flutter_runner] Port vulkan surface changes (flutter/engine#12350)
[flutter_runner] use dedicated allocation info

    This informs the vulkan driver that we're allocating memory
    dedicated to a single image. This is required for aemu and
    might also allow future drivers to make optimizations currently
    not possible.

    No change in behavior. Existing tests (modular_tests,
    scenic_tests, etc.) are sufficient and regressions will be
    prevented by running these tests on aemu.

    DX-939 #comment

    Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#meta/spinning_cube.cmx
    Change-Id: If4ecd9aaa09f12f94654a68e8e9fe979748f44af

    [flutter_runner] use external image create info

    DX-939 #progress
    MA-394 #progress

    This informs the vulkan driver that we're creating an image
    that will be backed by external memory. The driver driver can
    decide to use different memory requirements based on the if
    memory for the image can be exported or not.

    No change in behavior. Existing tests (modular_tests,
    scenic_tests, etc.) are sufficient and regressions will be
    prevented by running these tests on aemu.

    Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#meta/spinning_cube.cmx
    Change-Id: I489318c2e31f752f76c80a81245e203861d44d94
2019-09-18 19:06:12 -07:00
skia-flutter-autoroll
51c7eb7711 Roll src/third_party/skia f19f9caab2b4..e2a903e18b59 (1 commits) (flutter/engine#12351)
https://skia.googlesource.com/skia.git/+log/f19f9caab2b4..e2a903e18b59

git log f19f9caab2b4..e2a903e18b59 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 csmartdalton@google.com Reland "Reorder msaa and mipmap resolves to happen all at once"

Created with:
  gclient setdep -r src/third_party/skia@e2a903e18b59

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 21:53:53 -04:00
Kaushik Iska
5bdd5ec96c [flutter_runner] Explicitly set |trace_skia| to false (flutter/engine#12349)
Explicitly set |Application|'s |flutter::Settings| |trace_skia| field to
false (it currently defaults to false), in order to slightly simplify
the enabling skia trace events workflow.

PT-145 #comment-patch

Change-Id: Ib40f9ed3dc6f824056465db2cd45309c78b7e3b4
2019-09-18 18:02:43 -07:00
Kaushik Iska
51fc8e108d [flutter_runner] Port the new compilation trace from topaz (flutter/engine#12348) 2019-09-18 18:02:34 -07:00
Kaushik Iska
b198248b55 [flutter_runner][async] Migrate dart/flutter to new async-loop APIs (flutter/engine#12347)
Change-Id: I11ca124878d2652798ed49958c42aa10ae019ef9
2019-09-18 17:45:53 -07:00
Kaushik Iska
555f0b2506 [flutter_runner] Move from runner context to component context (flutter/engine#12346)
* [flutter_runner] Move from runner context to component context

* remove the file references
2019-09-18 17:45:46 -07:00
Kaushik Iska
4063939bd8 [flutter_runner] Port over the tuning advice (flutter/engine#12345) 2019-09-18 17:32:08 -07:00
Kaushik Iska
9e522b13b1 [flutter_runner] Remove usages of shared snapshots from CC sources (flutter/engine#12343)
Build rules still reference creating share snapshot data and instructions. This makes the engine to always pass them as empty to the dart vm. To be followed up with a change to alter the build rules to stop referencing the shared snapshots.

This is not being used currently and the fact that the runner will be built outside of the flutter tree means that the apps will not have much to gain via shared snapshots. The rationale behind this change is to partially make migrating the runner out of topaz tree easier.

Change-Id: Ibc4dd6a298d65082416af753522f5a17c88a750a
2019-09-18 17:31:54 -07:00
Kaushik Iska
2c1b30a4f2 [flutter_runner] Do not use prebuilts just yet (flutter/engine#12340) 2019-09-18 15:31:57 -07:00
Dan Field
a8cfcfc78d Add missing CL, fix targets for Fuchsia (flutter/engine#12338) 2019-09-18 15:06:50 -07:00
David Iglesias
25d2d2a47a More controls for Screenshot tests (for web) (flutter/engine#12284)
New features for golden tests (for web):

* Height/width of headless browser instance extracted to constants
* Remove border from the host iframe
* Added 'region' to matchGoldenFile, so screenshots can capture only
a subset of the viewport
* Added image-format-awareness (png) to screenshot comparison, so it
doesn't only look at raw bytes
* When a test fails, output a diff image alongside the unexpected
output.
2019-09-18 14:58:30 -07:00
skia-flutter-autoroll
2772d80a9f Roll src/third_party/skia 8391bac5c6f0..f19f9caab2b4 (8 commits) (flutter/engine#12341)
https://skia.googlesource.com/skia.git/+log/8391bac5c6f0..f19f9caab2b4

git log 8391bac5c6f0..f19f9caab2b4 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 bsalomon@google.com Handle F16Norm clamping in SkPaint->GrPaint conversion.
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 mtklein@google.com move skvm debug tools back to core
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 herb@google.com Reland "SkZip - synchronized indexing of several pointers"
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 robertphillips@google.com Last tranche of new SkColorTypes
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@f19f9caab2b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 17:38:06 -04:00
Tamir Duberstein
8156de6820 [fuchsia] add fuchsia.netstack.Netstack (flutter/engine#12325)
Needed in preparation for
https://dart-review.googlesource.com/c/sdk/+/117620.

Test:
  git grep -l -E '(socket\.Provider|NameLookup)' | \
  xargs grep -L fuchsia.netstack.Netstack
2019-09-18 12:01:49 -07:00
skia-flutter-autoroll
ddcb802813 Roll src/third_party/skia dd0dff1c35d2..8391bac5c6f0 (8 commits) (flutter/engine#12337)
https://skia.googlesource.com/skia.git/+log/dd0dff1c35d2..8391bac5c6f0

git log dd0dff1c35d2..8391bac5c6f0 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 bsalomon@google.com Add F16Norm mode to viewer
2019-09-18 bsalomon@google.com blurrect_compare GM: draw "masks" in white for RGBA fallback.
2019-09-18 csmartdalton@google.com Weed out duplicates from the proxy version of addDependency
2019-09-18 mtklein@google.com faster PNG encoding in skottie_tool
2019-09-18 csmartdalton@google.com Revert "Use a "decal" domain for filterMaskGPU"
2019-09-18 csmartdalton@google.com Revert "Abolish absClear"
2019-09-18 bsalomon@google.com Use mipmapping/protected to lookup scratch textures.
2019-09-18 jvanverth@google.com Reland "Add ETC2 support to Metal backend."

Created with:
  gclient setdep -r src/third_party/skia@8391bac5c6f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 13:53:16 -04:00
David Iglesias
c9f422f6eb Ensure DRRects without corners also draw. (flutter/engine#12330)
Uncovered this bug running some additional engine tests. Backported the
test here, and fixed the recording_canvas code.
2019-09-18 10:45:43 -07:00
Amir Hardon
f105e44be5 Update ExternalViewEmbedder class comment. (flutter/engine#11063) 2019-09-18 11:18:38 -06:00
skia-flutter-autoroll
0304798fe7 Roll src/third_party/skia d545bfbb94ca..dd0dff1c35d2 (25 commits) (flutter/engine#12334)
https://skia.googlesource.com/skia.git/+log/d545bfbb94ca..dd0dff1c35d2

git log d545bfbb94ca..dd0dff1c35d2 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 kjlubick@google.com [canvaskit] roll to 0.7.0
2019-09-18 csmartdalton@google.com Abolish absClear
2019-09-18 csmartdalton@google.com Revert "Reorder msaa and mipmap resolves to happen all at once"
2019-09-18 csmartdalton@google.com Reorder msaa and mipmap resolves to happen all at once
2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d32dae1bb37c..a7003d5fc306 (11 commits)
2019-09-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c6edebc270af..b1c1d2844bd1 (382 commits)
2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 30847688f059..61a2765940a7 (7 commits)
2019-09-18 herb@google.com Revert "SkZip - synchronized indexing of several pointers"
2019-09-18 csmartdalton@google.com Use a "decal" domain for filterMaskGPU
2019-09-17 herb@google.com SkZip - synchronized indexing of several pointers
2019-09-17 ethannicholas@google.com fixed an SkSL parse issue
2019-09-17 bungeman@google.com Properly subset the run in ShapeThenWrap.
2019-09-17 csmartdalton@google.com Reland "Use "clamp" when reexpanding gaussian blurs"
2019-09-17 ethannicholas@google.com Additional SkSL swizzle optimizations
2019-09-17 brianosman@google.com Update SkParticleEffect comments based on review feedback
2019-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-17 bsalomon@google.com Respect ImageSetEntry alpha in one-at-a-time code path
2019-09-17 brianosman@google.com Fix standalone SkSL build after adding SkOnce to SkSLByteCode
2019-09-17 herb@google.com A fix and unit test for jagged characters
2019-09-17 brianosman@google.com Move raster hack for color type on layers with image filters to device
2019-09-17 halcanary@google.com experimental/minimal_ios_mtl_skia_app
2019-09-17 brianosman@google.com Make SkSL::ByteCodeFunction::preprocess thread-safe
2019-09-17 bsalomon@google.com Pass color types when creating texture with initial data.
2019-09-17 bsalomon@google.com Fix bug where coverage on interior of stroked rects is applied twice

Created with:
  gclient setdep -r src/third_party/skia@dd0dff1c35d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 10:07:12 -04:00
Matt Carroll
8b3ca2b9c9 Added javadoc comments to FlutterActivity and FlutterFragmentActivity. (flutter/engine#12328) 2019-09-17 16:22:13 -07:00
Kaushik Iska
65d96ebd6f Revert "Provide dart vm initalize isolate callback so that children isolates belong to parent's isolate group. (#9888)" (flutter/engine#12327)
This reverts commit 41241f202f74a576f5d568bdb73ecff688ac3962.
2019-09-17 15:57:37 -07:00
Ankit Dave
9cde840656 [flutter] Remove old A11y API's. (flutter/engine#12308) 2019-09-17 15:40:17 -07:00
skia-flutter-autoroll
6d4624f1d7 Roll fuchsia/sdk/core/linux-amd64 from RRgw-... to F-g18... (flutter/engine#12326)
Roll fuchsia/sdk/core/linux-amd64 from RRgw-... to F-g18...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-17 18:18:55 -04:00
Chinmay Garde
c8ecb03fa8 Account for root surface transformation on the surfaces managed by the external view embedder. (flutter/engine#11384)
The earlier design speculated that embedders could affect the same
transformations on the layers post engine compositor presentation but before
final composition.

However, the linked issue points out that this design is not suitable for use
with hardware overlay planes. When rendering to the same, to affect the
transformation before composition, embedders would have to render to an
off-screen render target and then apply the transformation before presentation.
This patch negates the need for that off-screen render pass.

To be clear, the previous architecture is still fully viable. Embedders still
have full control over layer transformations before composition. This is an
optimization for the hardware overlay planes use-case.

Fixes b/139758641
2019-09-17 15:16:59 -07:00
Matt Carroll
c8c68ac789 Introduce FlutterFragmentActivity (flutter/engine#12305) 2019-09-17 15:09:38 -07:00
Chinmay Garde
7dda245874 Shuffle test order and repeat test runs once. (flutter/engine#12275)
The tests we write must be resilient to the order in which they are run in the
harness. That is, they must not rely on global state set by other tests that
have already run in the process. Also, these tests must themselves be
repeatable. That is, they must correctly clean up after themselves and be able
to run successfully again in the same process.

This patch adds some safeguards against (but does NOT guarantee) the addition of
tests that violate the dictum.

Additionally, test failures must be easily reproducible for folks investigating
the test failure. Also, tests that assert correctness of unrelated code must not
stop progress on the authors patch.

This changes does not hinder reproducibility of test failures because the random
seed is printed in the logs before running each test. Developers attempting to
reproduce the failure locally can do the same via the following invocation
`--gtest_shuffle --gtest_repeat=<the count> --gtest_random_seed=<seed from failing run>`.

This change does introduce potential burden on patch authors that may see
failures in unrelated code as a newly failing shuffle seed is used on their
runs. To ameliorate this, we will formulate guidance for them to aggressively
mark such tests as disabled and file bugs to enable the same.

The test seed is intentionally kept low because it’s purpose is to test that
individual tests are repeatable. It must not be used as a replacement for
fuzzing.
2019-09-17 14:50:51 -07:00
Harry Terkelsen
e6d5c594ec Update canvaskit backend (flutter/engine#12318)
* Improve the CanvasKit backend for Flutter Web

- Improve font handling by trying to load a "normal" font face
  instead of using the first face matching the family.
- Implement Vertices and drawVertices

* Add license header to vertices.dart

* Remove unused 'encodedPositions'

* Delete commented old code. Don't use Skia by default

* Add `vertices.dart` to licenses file
2019-09-17 14:42:18 -07:00
Mouad Debbar
b4aae10f0d README for the felt tool (flutter/engine#12323) 2019-09-17 14:03:31 -07:00
Jason Simmons
c667b18e15 Fix continuous event polling in the GLFW event loop (flutter/engine#12320)
* Do not pass a milliseconds::max() timeout that will overflow when converted
  to nanoseconds
* Avoid holding the task_queue_mutex_ while calling glfwWaitEventsTimeout
* Use a signed type to hold the difference between a task's timestamp and
  the current engine time

Fixes https://github.com/flutter/flutter/issues/40281
2019-09-17 13:54:38 -07:00
rafern
7d72616400 Tests for #11283 (flutter/engine#12322)
Added tests for #11283. The itEncodesNullObjects test fails with the branch before the merge and succeeds with the master branch
2019-09-17 13:52:40 -07:00
David Iglesias
0d2e83cde2 Improve check to render (or not) a DRRect when inner falls outside of outer on RecordingCanvas (flutter/engine#12229)
* Improve check to determine if a rrect is fully contained within another in RecordingCanvas.
* Add unit tests.

Fixes https://github.com/flutter/flutter/issues/37772 (and others)
2019-09-17 13:27:44 -07:00
gaaclarke
402a8a452e Channel buffers (flutter/engine#12167)
Added channel buffers to 'ui' so that messages have a place to
go until message handling is setup.
2019-09-17 12:22:00 -07:00
xster
e8717143e9 Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible (flutter/engine#12128) 2019-09-17 12:00:46 -07:00
stuartmorgan
c66d5e6d17 Adds PluginRegistry to the C++ client wrapper API (flutter/engine#12287)
Makes the plugin registration structure consistent with macOS. This will
be used in generated plugin registrant files rather than a specific
implemenation class, so this helps unblock the creation of generated
registrants on Windows and Linux.
2019-09-17 11:41:22 -07:00
liyuqian
8bb2b639df Add "type" to getDisplayRefreshRate protocol (flutter/engine#12319)
Per kenzieschmoll's request.

Will update https://github.com/flutter/flutter/wiki/Engine-specific-Service-Protocol-extensions once this is merged.
2019-09-17 11:35:01 -07:00
Mouad Debbar
bb1ec63121 Add a build command to felt (flutter/engine#12303)
- The build command supports a `--watch` or `-w` flag to watch for
changes and rebuild.

Fixes https://github.com/flutter/flutter/issues/40392
2019-09-17 10:31:13 -07:00
skia-flutter-autoroll
ca7917147b Roll src/third_party/skia df432d5efb70..d545bfbb94ca (1 commits) (flutter/engine#12316)
https://skia.googlesource.com/skia.git/+log/df432d5efb70..d545bfbb94ca

git log df432d5efb70..d545bfbb94ca --date=short --no-merges --format='%ad %ae %s'
2019-09-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@d545bfbb94ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-17 08:01:04 -04:00
skia-flutter-autoroll
624b8e7001 Roll fuchsia/sdk/core/linux-amd64 from rwf0-... to RRgw-... (flutter/engine#12315)
Roll fuchsia/sdk/core/linux-amd64 from rwf0-... to RRgw-...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-17 05:32:39 -04:00