DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,295 Commits 882 Branches 1,069 Tags
Commit Graph

26843 Commits

Author SHA1 Message Date
skia-flutter-autoroll
0627f01acf Roll Skia from db21ce8d0f28 to fe545a316f68 (1 revision) (flutter/engine#52313) 
https://skia.googlesource.com/skia.git/+log/db21ce8d0f28..fe545a316f68

2024-04-23 johnstiles@google.com Fix signedness of format string.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-23 03:03:15 +00:00
skia-flutter-autoroll
c56d6c787e Roll Dart SDK from 95f95b3118fe to 9f64eecc8cf3 (2 revisions) (flutter/engine#52312) 
https://dart.googlesource.com/sdk.git/+log/95f95b3118fe..9f64eecc8cf3

2024-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-88.0.dev
2024-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-87.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-23 01:58:20 +00:00
skia-flutter-autoroll
9b45fe38f1 Roll Skia from e6de04b82b57 to db21ce8d0f28 (1 revision) (flutter/engine#52309) 
https://skia.googlesource.com/skia.git/+log/e6de04b82b57..db21ce8d0f28

2024-04-22 penghuang@chromium.org graphite: add slice in DawnTextureInfo and DawnTextureSpec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-23 00:51:18 +00:00
hellohuanlin
cabd4fcacd [ios_edit_menu]add native edit menu (flutter/engine#50095) 
Support native edit menu on the engine side. 

Design doc: https://docs.google.com/document/d/16-8kn58h_oD902e7vPSh6W20aHRBJKyNOdSe5rbAe_g/edit?resourcekey=0-gVdJ3fbOybV70ZKeHU7fkQ&tab=t.0

*List which issues are fixed by this PR. You must list at least one issue.*

https://github.com/flutter/flutter/issues/103163

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-22 23:36:18 +00:00
Matan Lurey
627238cc93 Fail run_impeller_golden_tests if LUCI_CONTEXT && !GOLDCTL (flutter/engine#52300) 
Works to prevent future outages like https://github.com/flutter/flutter/issues/147180.

Also added an explicit `--no-skia-gold` flag to use when we don't want Skia Gold used, and used it in the one place we decided (in internal chat) it made sense, `mac_unopt.json` (was added in 674874e613 for validation-layers testing only).
 2024-04-22 23:17:41 +00:00
Jonah Williams
1fd38c8986 [Impeller] skip lineTo for empty contours. (flutter/engine#52290) 
If we close an empty contour, don't insert a lineTo

Fixes https://github.com/flutter/flutter/issues/146648
 2024-04-22 23:00:04 +00:00
skia-flutter-autoroll
1d7d365284 Roll Skia from 3b32e3280b67 to e6de04b82b57 (6 revisions) (flutter/engine#52304) 
https://skia.googlesource.com/skia.git/+log/3b32e3280b67..e6de04b82b57

2024-04-22 brianosman@google.com Remove assert in Slug deserialization
2024-04-22 brianosman@google.com Reland "Restore affine bitmap procs"
2024-04-22 armansito@google.com [graphite] Remove stale TODO comment re r8unorm storage
2024-04-22 armansito@google.com [graphite] Use analytic rrect renderer in all path strategies
2024-04-22 kjlubick@google.com Sort load order
2024-04-22 jamesgk@google.com [graphite] Analytic blur for circles

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-22 22:15:27 +00:00
Jonah Williams
dbd72955e4 [Impeller] re-enable gold CTL. (flutter/engine#52299) 
Add goldctl dependency to arm64

Fixes https://github.com/flutter/flutter/issues/147180
 2024-04-22 21:01:23 +00:00
Jenn Magder
80cd050cae Break dependency cycle of FlutterViewController <-> FlutterPlatformView (flutter/engine#52271) 
Trying to migrate the iOS embedder MRC to ARC, I'm attempting to break some dependency cycles so it's easier to migrate the "leaf" dependencies to ARC, working my way up.

The cycle is:
**`FlutterViewController`** -> `FlutterView` -> `FlutterPlatformView` ->  (Before this PR)**`FlutterViewController`** 

`FlutterViewController` depends on many other large MRC classes, like FlutterEngine., so I'd like to pull that one out so `FlutterView`, `FlutterPlatformView`, and `FlutterOverlayView` can be migrated to ARC in a smaller PR.

`FlutterPlatformView` only depends on `FlutterViewController` in this one place, casting a `UIViewController` and calling `-forceTouchesCancelled:`.  

0e6143504c/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm (L1201)

Instead, move `-forceTouchesCancelled:` to the existing `FlutterViewResponder` protocol with the other touch events, which `FlutterViewController` already implements.  The cast can then be removed, breaking the cycle.

Clean up all the imports.

Part of https://github.com/flutter/flutter/issues/137801, though this doesn't actually migrate anything to ARC.
 2024-04-22 19:03:49 +00:00
Chris Bracken
0ce6126c47 [et] Lookup output filesystem path, not label (flutter/engine#52248) 
Sets BuildTarget.executable to the `root_out_dir`-relative path of the
executable (e.g. `displaylist_unittests`) instead of its label (e.g.
`//out/host_debug/displaylist_unittests`). This is required since, in
the lines following the output lookup, we assume it to be a path
relative to the build output directory.

Also breaks out functions for:
* `_runGnDesc`: returns the JSON output of `gn desc buildDir target`
* `_runGnOutputs`: returns the output files listed by `gn outputs
buildDir target`

Noticed while working on:
https://github.com/flutter/flutter/issues/147071

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-22 11:13:16 -07:00
skia-flutter-autoroll
42f644f9aa Roll Skia from 975859a96f8f to eb29b46236e6 (9 revisions) (flutter/engine#52297) 
https://skia.googlesource.com/skia.git/+log/975859a96f8f..eb29b46236e6

2024-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 71b11532ed72 to b7e3beee69a5 (1 revision)
2024-04-22 armansito@google.com [graphite] Fix canvaskit build
2024-04-22 michaelludwig@google.com [graphite] Relax fLastTask assert in Device::flushPendingWorkToRecorder
2024-04-22 jamesgk@google.com [graphite] Rename RectBlurData to AnalyticBlurMask
2024-04-22 johnstiles@google.com Remove calls to SkScalarToFloat and SkFloatToScalar.
2024-04-22 johnstiles@google.com Remove SkScalarIsFinite/NaN from public API.
2024-04-22 michaelludwig@google.com [graphite] Don't store unmappable buffer as reusable
2024-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b7cc986dba6d to 2bc8bf46657d
2024-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dcb627bc133f to b7cc986dba6d (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-22 18:11:06 +00:00
Harry Terkelsen
37db59763d [canvaskit] Add configuration for maximum canvases (flutter/engine#51735) 
Allows developers to customize the maximum amount of overlay canvases.

Fixes https://github.com/flutter/flutter/issues/144589

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-22 10:56:26 -07:00
PurplePolyhedron
2ae24d260d Fix link in BlendMode.saturation (flutter/engine#52156) 
Fix typo in the document of `BlendMode.saturation`. It has a link to image https://flutter.github.io/assets-for-api-docs/assets/dart-ui/blend_mode_hue.png, while it should be `blend_mode_saturation.png`

https://github.com/flutter/flutter/issues/146820

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-22 17:48:26 +00:00
Jenn Magder
286b611779 Refactor and migrate FlutterUndoManagerPlugin to ARC (flutter/engine#52234) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate `FlutterUndoManagerPlugin` from MRC to ARC. 

1. Refactor so the plugin and its tests don't need to understand the details of `FlutterViewController` or `FlutterEngine` (its delegate).  This decouples the plugin, and means it doesn't depend on any MRC classes.
2. Change the delegate so conforming only requires the objects the undo plugin actually needs.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-04-22 17:14:35 +00:00
skia-flutter-autoroll
c2c0ca89c0 Roll Dart SDK from 0a83dd7e61b1 to 0ed66a4d77cb (1 revision) (flutter/engine#52294) 
https://dart.googlesource.com/sdk.git/+log/0a83dd7e61b1..0ed66a4d77cb

2024-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-85.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-22 17:05:25 +00:00
skia-flutter-autoroll
fc847b4506 Roll Fuchsia Linux SDK from 3cyVJn1037SXTT5qT... to Rr9lFiKCPhMXDGa89... (flutter/engine#52289) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-21 08:48:25 +00:00
Jonah Williams
c657c7f7f4 [Impeller] compute UVs in vertex stage. (flutter/engine#52106) 
Split the functionality of texture_fill and tiled_texture_fill vertex stages:

* The former will accept uvs as part of the vertex data and pass it to the fragment stage.
* The latter will compute the uv geometry in the vertex stage from the position and the normalizing transform.

With this functionality, we can delete all of the CPU based uv computation code.  Additionally, there is some clean up to remove support for external textures (which use the tiled texture mode) from the texture contents. The external textures are used with an image shader/draw rect by internal engine code and won't go down the drawImageRect path anymore.
 2024-04-20 19:41:19 +00:00
skia-flutter-autoroll
3af46f1395 Roll Fuchsia Linux SDK from RruZA4WorQDkGpz25... to 3cyVJn1037SXTT5qT... (flutter/engine#52283) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-20 07:44:23 +00:00
skia-flutter-autoroll
b5f7f7731e Roll Skia from 7be6fe3150fc to 9735c573e7e9 (2 revisions) (flutter/engine#52281) 
https://skia.googlesource.com/skia.git/+log/7be6fe3150fc..9735c573e7e9

2024-04-20 michaelludwig@google.com [graphite] Track failed Buffer mappings to cause snap() to return null Recording
2024-04-20 armansito@google.com [graphite][vello] Use R8UnormStorage feature in compute path atlas

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-20 04:41:22 +00:00
Chris Bracken
c9f3a89bf4 [et] Fix concurrent modification exception (flutter/engine#52247) 
We cannot modify the list of build targets as we're iterating over it. Instead of removing non-test/non-executable elements, instead we add executable test targets to a separate testTargets list and use that.

Noticed while working on: https://github.com/flutter/flutter/issues/147071

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-20 03:40:59 +00:00
John Stiles
a439829bf6 Remove SkScalarIsFinite from Flutter Engine. (flutter/engine#52270) 
SkScalarIsFinite is deprecated. Use `std::isfinite` instead.
 2024-04-20 03:37:06 +00:00
skia-flutter-autoroll
c5b677c1d4 Roll Skia from 514d7fc627b3 to 7be6fe3150fc (1 revision) (flutter/engine#52280) 
https://skia.googlesource.com/skia.git/+log/514d7fc627b3..7be6fe3150fc

2024-04-20 armansito@google.com Roll vello from 74715ee4650e to 6c1e8b815b1e (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-20 03:04:30 +00:00
Chris Bracken
f5b84d2125 [et] Simplify path canonicalisation logic (flutter/engine#52275) 
In order to canonicalise paths, previously we were doing an iterative
computation to resolve symlinks to a canonical path, directory by
directory. This was because on macOS and other BSDs, readlink doesn't
support the `-f` (follow symlinks) option. However, macOS and other
BSD-based systems *do* bundle the `realpath` utility, which resolves
symlinks.

This patch is stacked on top of #52274 and is the second commit
(dec38dda38d1ef0bc3a548ef1f750c5855e9d9f4).

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-19 19:21:58 -07:00
skia-flutter-autoroll
7793174797 Roll Dart SDK from d882ce089110 to 95e0894dc8e6 (1 revision) (flutter/engine#52279) 
https://dart.googlesource.com/sdk.git/+log/d882ce089110..95e0894dc8e6

2024-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-20 02:04:23 +00:00
skia-flutter-autoroll
296824d8b5 Roll Skia from 1910252ea26a to 514d7fc627b3 (6 revisions) (flutter/engine#52277) 
https://skia.googlesource.com/skia.git/+log/1910252ea26a..514d7fc627b3

2024-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4737535cad1a to 71b11532ed72 (6 revisions)
2024-04-19 bungeman@google.com [paragraph] Only load typefaces once in tests
2024-04-19 michaelludwig@google.com Revert "Restore affine bitmap procs"
2024-04-19 bungeman@google.com Make sysopen python3
2024-04-19 johnstiles@google.com Replace SkIsFinite with a parameter-pack implementation.
2024-04-19 michaelludwig@google.com [graphite] One-time uploads can be discarded

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-20 00:50:12 +00:00
Chris Bracken
d0cef3ee8a [et] Fix path canonicalization (flutter/engine#52274) 
Previously we were getting the enclosing directory path of the `et` tool
(via the `dirname` builtin), then canonicalising the path by resolving
symlinks. This doesn't work if the `et` on the path is itself a symlink.
For example, if a user created a symlink `et` in a concrete directory at
`~/.local/bin`:

```
~/.local/bin/et -> ~/src/flutter/engines/src/flutter/bin/et
```
first we'd compute the dirname of the script:
```
~/.local/bin
```
then we'd resolve symlinks:
```
~/.local/bin
```
and incorrectly assume that was the engine directory.

Instead, we now resolve symlinks, then compute the enclosing directory.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-19 17:24:26 -07:00
Tong Mu
83414d7856 [macOS] Consolidate view management (flutter/engine#52254) 
This PR improves view management logic of the macOS `FlutterEngine`
class.
* View operation assertions are now centralized in
`registerViewController:` and `deregisterViewControllerForIdentifier:`.
* `addViewController` now directly calls `.viewController =` on implicit
views, so that it matches its verbatim description.
* The doc for `addViewController` correctly reflects the fact that it
doesn't support multiple views yet.

Additionally, a useless (for now) member variable is removed.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-19 14:25:49 -07:00
skia-flutter-autoroll
7731c03636 Roll Skia from f4a214ecf197 to 1910252ea26a (3 revisions) (flutter/engine#52269) 
https://skia.googlesource.com/skia.git/+log/f4a214ecf197..1910252ea26a

2024-04-19 michaelludwig@google.com [graphite] Add Swizzle::selectChannelInR(i) helper
2024-04-19 brianosman@google.com Tweak RescaleWithTransform test expectations
2024-04-19 brianosman@google.com Add SkArc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 21:24:12 +00:00
Jonah Williams
9aeeb27d88 [Impeller] add non-emulated advanced blend support to experimental canvas (flutter/engine#52245) 
Adds support for non-emulated advnaced blends (Android Vulkan and iOS devices). Still need to add support for emulation when we do backdrop filters.
 2024-04-19 21:24:09 +00:00
Jonah Williams
0e6143504c [Impeller] organize texture shaders / delete blend.frag + external_texture_fill (flutter/engine#52137) 
* Deletes blend.frag/vert . This was identical to the existing texture_fill shader.
* Move alpha to frag info and stop passing as varying.
~~* Deletes strict src rect fragment shader. We should be able to compute the UVs on the CPU, which is trivial since this is only used for rectangular draws.~~
* Deletes external texture fill in favor of tiled texture external fill. The former shader is marginally faster, but we don't use it since we don't correctly check for the right extensions needed for non-emulated sampling modes with external textures on GLES. Easier to just always use emulated tile modes
 2024-04-19 20:48:18 +00:00
skia-flutter-autoroll
a3573b1f91 Roll Skia from 0689969ffaee to f4a214ecf197 (1 revision) (flutter/engine#52265) 
https://skia.googlesource.com/skia.git/+log/0689969ffaee..f4a214ecf197

2024-04-19 johnstiles@google.com Switch std::isfinite to SkIsFinite throughout Skia.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 18:50:20 +00:00
Jim Graham
2f1254623a [Impeller] Use the new DisplayList depth info in the experimental canvas prototype (flutter/engine#52214) 
Plumbing the new DL depth data into the experimental direct rendering Impeller canvas prototype.
 2024-04-19 18:35:06 +00:00
skia-flutter-autoroll
04da91f5fa Roll Dart SDK from 1c49f17b5437 to 2ff00e4eb759 (1 revision) (flutter/engine#52264) 
https://dart.googlesource.com/sdk.git/+log/1c49f17b5437..2ff00e4eb759

2024-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 18:18:21 +00:00
skia-flutter-autoroll
c7e9148feb Roll Skia from fa31a916cbb8 to 0689969ffaee (1 revision) (flutter/engine#52263) 
https://skia.googlesource.com/skia.git/+log/fa31a916cbb8..0689969ffaee

2024-04-19 michaelludwig@google.com Reland "[graphite] Remember last snapped task for scratch devices"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 17:26:32 +00:00
skia-flutter-autoroll
e4c316d635 Roll Skia from d01e53b8beb7 to fa31a916cbb8 (1 revision) (flutter/engine#52261) 
https://skia.googlesource.com/skia.git/+log/d01e53b8beb7..fa31a916cbb8

2024-04-19 brianosman@google.com Restore affine bitmap procs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 16:31:09 +00:00
Jonah Williams
4868acea58 [Impeller] remove absorb opacity limit. (flutter/engine#52160) 
Both contents correctly check for absorb opacity so I think this is pointless.
 2024-04-19 16:31:07 +00:00
gaaclarke
d65bd10007 [Impeller] cleaned up semantics for RenderPipelineT and added docstrings (flutter/engine#52237) 
I just tried to capture all thing things I found confusing about these
and clean them up. We were mixing up Pipeline and RenderPipelineT in our
generics arguments and RenderPipelineT wasn't clear since it was named
like a template parameter but was a runtime type.

Summary of edits:
-  RenderPipelineT -> RenderPipelineHandle
- Added docstrings for RenderPipelineHandle and Variants
- cleaned up generics parameters to ContentContext methods and Variants
- replaced references that called the variant's default pipeline handle
a "prototype" since it clashed with places that just call it the
"default".

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-19 09:15:08 -07:00
skia-flutter-autoroll
f7456a3d4a Roll Skia from 0bdd0daaa3fc to d01e53b8beb7 (2 revisions) (flutter/engine#52260) 
https://skia.googlesource.com/skia.git/+log/0bdd0daaa3fc..d01e53b8beb7

2024-04-19 bungeman@google.com Roll depot_tools and recipes-py
2024-04-19 brianosman@google.com Always pin the sweepAngle in CreateDrawArcPath

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 15:36:06 +00:00
skia-flutter-autoroll
3a1fc298b3 Roll Dart SDK from 3e139f5d0720 to 1c49f17b5437 (1 revision) (flutter/engine#52259) 
https://dart.googlesource.com/sdk.git/+log/3e139f5d0720..1c49f17b5437

2024-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 14:22:17 +00:00
skia-flutter-autoroll
27147c0d9e Roll Fuchsia Linux SDK from peYcbx9eguHcbhMP0... to RruZA4WorQDkGpz25... (flutter/engine#52252) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 06:35:44 +00:00
skia-flutter-autoroll
b0969ac415 Roll Dart SDK from a46161eec56d to 12e49f395fd9 (1 revision) (flutter/engine#52251) 
https://dart.googlesource.com/sdk.git/+log/a46161eec56d..12e49f395fd9

2024-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-77.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 06:34:00 +00:00
skia-flutter-autoroll
e2c4bd0002 Roll Skia from ca5481ebd0fb to 7ad507eca0bd (2 revisions) (flutter/engine#52249) 
https://skia.googlesource.com/skia.git/+log/ca5481ebd0fb..7ad507eca0bd

2024-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 764410d4d655 to 9aec4b969291 (2 revisions)
2024-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e3ade2b88835 to dcb627bc133f (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 06:28:33 +00:00
skia-flutter-autoroll
d0ff3fa1a4 Roll Dart SDK from 62b85ea79bce to a46161eec56d (1 revision) (flutter/engine#52243) 
https://dart.googlesource.com/sdk.git/+log/62b85ea79bce..a46161eec56d

2024-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 02:27:05 +00:00
Brian Quinlan
13be0415cf Add a dependency on package:web_socket in pkg_demo_test (flutter/engine#52239) 
`package:web_socket` is used by newer versions `package:web_socket_channel`.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-04-19 01:35:00 +00:00
skia-flutter-autoroll
514dbb18a7 Roll Skia from 8fd4d8eaadc2 to fef9f270935c (7 revisions) (flutter/engine#52240) 
https://skia.googlesource.com/skia.git/+log/8fd4d8eaadc2..fef9f270935c

2024-04-18 nscobie@google.com [graphite] Refactor VULKAN_CALL_RESULT to call checkVkResult
2024-04-18 bungeman@google.com [pdf] Emit FontFamily/Stretch/Weight for Type3
2024-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aa20d192b8c4 to 707349d2ea9e (3 revisions)
2024-04-18 bungeman@google.com Run gn_to_bp.py with python3
2024-04-18 michaelludwig@google.com [graphite] Add TextureProxyView::replaceSwizzle()
2024-04-18 michaelludwig@google.com Revert "[graphite] Remember last snapped task for scratch devices"
2024-04-18 johnstiles@google.com Implement ASAN poisoning for TArray reserved capacity.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-19 00:25:37 +00:00
Jonah Williams
44f81fa6e8 [Impeller] dont use half precision constants / Fixes for SPIRV tools roll (flutter/engine#52213) 
See b/335381180

In an upcoming version of SPIRV tools, these constants are being flagged as invalid. Due to some combination of the macros + inlining we're ending up with multiple precision modifiers on the constants:

```
third_party/flutter_engine/impeller/entity/shaders/radial_gradient_fill.frag: GLSL to SPIRV failed; Compilation error. 0 error(s) and 1 warning(s).
third_party/flutter_engine/impeller/entity/shaders/radial_gradient_fill.frag:14: warning: '' : all default precisions are highp; use precision statements to quiet warning, e.g.:
third_party/flutter_engine/impeller/entity/shaders/radial_gradient_fill.frag:          "precision mediump int; precision highp float;" 
shaderc: internal error: compilation succeeded but failed to optimize: ID '112' decorated with RelaxedPrecision multiple times is not allowed.
  %float_n0_474999994 = OpConstant %float -0.474999994
  ```
  
  We don't really benefit from half precision on these, since we're either using them for equality or can cheaply convert to half precision anyway.
 2024-04-18 23:08:02 +00:00
skia-flutter-autoroll
450d9a8036 Roll Skia from edece87ce734 to 8fd4d8eaadc2 (1 revision) (flutter/engine#52238) 
https://skia.googlesource.com/skia.git/+log/edece87ce734..8fd4d8eaadc2

2024-04-18 johnstiles@google.com Move SkFloatBits.h into src/base instead of include/private.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-18 22:56:57 +00:00
Tong Mu
1e085fee4c [macOS] Rename viewId to viewIdentifier (flutter/engine#52202) 
This PR adds `FlutterViewController` with new API `viewIdentifier` and
renames all occasions that mention "viewId" to "viewIdentifier", to
align with the requirement for the iOS shell.

A new typedef `FlutterViewIdentifier` is also added. ~~The problem is,
we don't have a file to contain this typedef. Currently I put them in a
new file called `common.h`. I'm open to other suggestions.~~ It has been
moved to `FlutterViewController.h`.
* Another alternative is to not use the type def, but use `int64_t`
directly. I'm ok with this choice too, since honestly it's just a 64
int.

Also, macOS's definition for `kFlutterImplicitViewId` has been removed
in favor of the one in `common/constants.h`.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-18 15:05:01 -07:00
skia-flutter-autoroll
f11a13edac Roll Skia from 1af1e478ef85 to edece87ce734 (5 revisions) (flutter/engine#52233) 
https://skia.googlesource.com/skia.git/+log/1af1e478ef85..edece87ce734

2024-04-18 johnstiles@google.com Fix crash in nanobench IsFinite benchmark.
2024-04-18 michaelludwig@google.com [graphite] Add Image_YUVA::Wrap factory to handle validation
2024-04-18 kjlubick@google.com Add EGL factory
2024-04-18 johnstiles@google.com Update format strings in docs/examples for correct signedness.
2024-04-18 johnstiles@google.com Round up SkSTArray storage to an 8 byte multiple.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-18 20:49:09 +00:00
Chinmay Garde
3bba94a45f Suppress in-actionable warnings in the iOS profiler. (flutter/engine#52227) 
This is a benign log that is not actionable to the end user. The profiler checker for this and tries again anyway.

Fixes https://github.com/flutter/flutter/issues/116193
 2024-04-18 19:50:27 +00:00