682 Commits

Author SHA1 Message Date
Ian Hickson
88c94f57c7
Remove unnecessary consts (#21410) 2018-09-04 17:05:30 -07:00
Marcin Szałek
1658fd9412 Added size to stepper icons (#19313)
* Added size to stepper icons

* Added Stepper icons size test
2018-09-04 16:51:39 -07:00
Will Larche
2ef7cd649c
[Icons] Updating default icon theme values. (#20840)
Closes #3188
2018-09-04 19:26:52 -04:00
liyuqian
f7b2722d50
Add clipBehavior to Chips and update documents (#21231)
This fixes https://github.com/flutter/flutter/issues/20746
2018-08-30 23:27:37 -07:00
Jonah Williams
f2442b8a13
Fix traversal order issues caused by intersecting or overlapping child rects (#21235) 2018-08-30 19:55:07 -07:00
Hans Muller
ce51e71d19
Add Card clipBehavior pass-through property (#21187) 2018-08-30 10:09:44 -07:00
MH Johnson
19c9628256
[Material] Fix 20051 FAB tooltip touch target (#21084)
* [FAB] Updated tooltip touch target.

* Remove "new" keyword

* [FAB] Updated tooltip touch target.

* "long press button edge"

* remove new

* remove new

* put "new" keywords back in

* Remove check for childless tooltip

* Added regression test - tooltip works on edge of FAB which has no child.

Added helper method to find the right edge of a in the tests.

* Changed "find.byType(text)" to "find.text('Add')"
2018-08-30 09:59:13 -04:00
Jonah Williams
bf5e4b45fe
Make sure modal BottomSheets routes are identified as dialog routes (#21075) 2018-08-28 19:21:00 -07:00
Jonah Williams
3b309bda07
Add a localization for counter text, separate into own semantic node (#21029) 2018-08-28 12:39:24 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
David Shuckerow
458d0b3d21
Update the reorderable list to use the primary scroll controller when… (#20895) 2018-08-28 12:08:41 -06:00
liyuqian
38d155a421
Add default-no-clip tests to more buttons (#21012)
Note that such tests already exist for RaisedButton and MaterialButton
2018-08-27 11:25:47 -07:00
liyuqian
ce8ba6e8b3
Set the default clip to Clip.none again. (#20752)
This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b and
updates the goldens versoin.

This requires https://github.com/flutter/flutter/pull/20751 to
land first.
2018-08-23 18:05:11 -07:00
jslavitz
3900d42bfa
Control, Shift and Arrow Key functionality for Chromebook (#20204)
* added keyboard functionatliy to android builds

* Added tests

* almost ready for review

* ready for review

* Fixes

* final comments

* final commit

* removing raw keyboard changes

* removing raw keyboard changes

* removing raw keyboard changes

* actual last commit

* fixed the imports

* a few more changes

* A few more changes

* a few changes

* Final changes

* Final changes2

* final actual commit for real

* final actual commit for real2

* final actual commit for real3

* final actual commit for real4

* final

* final 2

* f

* f2

* fin

* fin 2

* fin3

* fin4
2018-08-23 17:16:44 -07:00
Jonah Williams
09fe34708f
Add localization for expand icon collapse/expand tap hint (#20766) 2018-08-22 10:20:51 -07:00
sir-boformer
09e7902f5b Fix small TabBar inconsistencies (#20887)
Tabs are now padded by 16.0 on the left and right  (used to be 12.0).
2018-08-22 09:42:18 -07:00
liyuqian
ee8754df4a
Add customBorder to InkWell so it can clip ShapeBorder (#20751)
This fixes #20483 by letting InkWell do its own clipping.

PathOp.intersect is not used because we have too many unit tests that rely on clipping (e.g., paints..clipXXX()..drawCircle())

The goldens are updated due to small AA changes of the additional clipPath.
2018-08-22 09:25:01 -07:00
Hans Muller
18e7549bc8
Update BottomNavigationBar.didUpdateWidget() (#20890)
BottomNavigationBar's state needs to update _backgroundColor when its configuration changes.
2018-08-21 17:10:31 -07:00
Ian Hickson
94f9604a96
Cleanup (#20754)
- remove an //ignore that is no longer needed
- fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient)
- add some asserts to help track down bugs quicker
- update a TODO to point to the currently relevant bug
- fix some indenting
- improve the naming of some privates to improve readability
2018-08-21 14:02:48 -07:00
Ian Hickson
b7261586e5
Audit TODO syntax (#20837)
Fixes the pattern for some TODOs to match our style guide.

(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
ebeem
9d6d03fc08 Add ability to set collapse mode in flexible space bar (#18526)
* Add ability to set collapse mode in flexible space bar

* Add tests to collapse mode in flexible space bar

* Fix minor style nit

* Fix getting collapse mode does not handle unknown values

* Change const key to final in space bar collapse mode test

* Return null collapse padding if mode is unknown
2018-08-21 10:26:08 -07:00
liyuqian
980c8a737b
Add golden test for clipping (#20750)
For #20483
2018-08-20 14:33:27 -07:00
Hans Muller
2ed8a50e7e
Fix (another) typo in InputDecorationTheme.debugFillProperties() (#20759) 2018-08-20 11:30:21 -07:00
David Shuckerow
a98bfd755c
Wrap the ReorderableList's children with a MergeSemantics (#20715) 2018-08-20 10:48:24 -07:00
Jonah Williams
e56a73e42c
Add support for by word movement granularities to semantics (#19949) 2018-08-17 12:17:34 -07:00
xster
0f4ea504bc
Correctly chain finders to ancestor/descendant finders (#20601) 2018-08-15 17:24:03 -07:00
Ian Hickson
686d8f8a22 Shim package:test to avoid matcher issues (#20602)
* Upgrade everything except matcher.
* Roll matcher (and test)
* Adjust tests that depend on flutter:test directly to depend on a shim
* Require use of package:test shim and remove other references to package:test
2018-08-14 20:33:58 -07:00
Jonah Williams
8de0e15e4f
Revert to defaultClipBehavior (#20578) 2018-08-14 20:23:04 -07:00
Jonah Williams
4b6cc47338
add label to drawer and regression test cases (#20537) 2018-08-14 10:17:39 -07:00
liyuqian
13bfa7353e
Set default clipBehavior to Clip.none and update tests (#20205)
This fixes https://github.com/flutter/flutter/issues/18057
2018-08-09 16:38:08 -07:00
Anthony
a49bffa54e
Extend Outline Button test coverage with test for disabled state (#19908)
* Create test case for disabled state of outline button
2018-08-09 14:39:33 -04:00
Jonah Williams
e4b989bf3d
math correctly (#20368) 2018-08-09 09:45:44 -07:00
David Shuckerow
99d5ef903c
Add custom actions to the reorderable list (#20108) 2018-08-07 12:48:23 -07:00
Jonah Williams
4de692a2b9
Add AccessibilityFeatures to media query and fix Snackbar a11y behavior (#19336) 2018-08-07 10:11:21 -07:00
Jonah Williams
4a7b4a4dde
increase size of user account drawer headers to 48 by 48 (#20266) 2018-08-06 13:56:15 -07:00
Jonah Williams
a0b5448b84
Add route/routeName to search page (#20190) 2018-08-04 08:50:10 -07:00
Christian Mürtz
ad163749b7 Extend InputDecoration with prefix/suffix padding (#19514)
Add widget valued prefix and suffix properties to InputDecoration.  These new properties are alternatives to prefixText and suffixText.
2018-08-03 09:51:34 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
Jonah Williams
ffdd6e1bf1
Toggle whether label or hint contribute to text field semantics when unfocused/focused (#19790) 2018-08-01 21:02:40 -07:00
jslavitz
d2ab29d25e
Drawer fix (#20015)
* Drawer fix

* fixed nits

* fixed nits

* fixed nits

* final change

* Drawer fix final
2018-08-01 10:14:25 -07:00
Jonah Williams
e9c8e36bde
When dispatching a semantic event, check if the node has been merged with parent (#20020) 2018-07-31 10:43:56 -07:00
Jonah Williams
5b30b393a8
make sure bottom nav bar always contributes labels (#19934) 2018-07-30 21:06:31 -07:00
Jonah Williams
ee396272d3
Fix dropdown button semantics (#19932) 2018-07-30 15:36:26 -07:00
David Shuckerow
f844fadaf3
Reorderable list widget and Material demo (#18374) 2018-07-30 15:21:00 -07:00
Jonah Williams
dfe5b591a6
Increase time picker clock touch targets to 48 by 48 (#19936) 2018-07-30 10:46:16 -07:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Jonah Williams
730a534fbb
Make Card explicitChildNodes vs container be configurable (#19693) 2018-07-26 17:27:45 -07:00
Jonah Williams
f516074a98
Add header SemanticsFlag to bottom nav bar (#19803) 2018-07-26 13:29:28 -07:00
jslavitz
28dc007450
Added single open panel functionality (#19624)
* Just commiting two files now

* Fixed one tab

* Fixed latest changes

* Changed the data structure from a map to a single radio panel object

* A few more changes

* Fixed change from expansion radio to regular list

* Fixed change from expansion radio to regular list2

* Changed the radio constructor

* Last fixes

* Final commit

* Actual final commit

* Last change
2018-07-25 14:35:17 -07:00
Jonah Williams
810a29d663
Semantics framework updates (#18758)
Changes:

- Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
- Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
- Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
- Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
- Added dismiss and liveRegion to snackbar widget
- Updated custom painter semantics to handle image, liveRegion, toggle
- Updated relevant tests to use correct flag/action
2018-07-24 13:10:17 -07:00