8602 Commits

Author SHA1 Message Date
Chris Bracken
05edc00a6f
Eliminate Dart 1 support from Flutter test (#21408) 2018-09-05 10:41:44 -07:00
Jonah Williams
61719c4e9f
fix unawaited future (#21439) 2018-09-05 09:29:22 -07:00
Matteo Crippa
5907a7264d Fix/ios run simulator (#20262) 2018-09-05 09:03:08 -07:00
Danny Tuppeny
6e64cb0ad8
Fix windows crash running flutter run which tries to find Xcode (#21423)
* Add a failing test for #21418

* Filter workflows to only those applicable to the current platform

Fixes #21418.
2018-09-05 16:22:12 +01:00
tonyzhao1
58d98ce31e Create categories for doctor validators (#20758)
* First step in Flutter Doctor refactor. Assigns categories to all validators.

* Revert "Roll engine e54bc4ea1832..a84b210b3d26 (6 commits) (#20453)"

This reverts commit 05c2880a1736bbc90c8870a3b498fab074b0d4c0.

* Split iOS and Android workflows into workflow and validator classes.

* Change ValidatorCategory to handle standalone validators that share a
category (e.g. IntelliJ).

Also make Android Studio and Android toolchain use separate categories.

At this stage, flutter doctor output matches what it was previously.
(The summary() method itself has not yet been changed )

* Change doctor summary code to support validator categories.

Output is still unchanged.

* Handle small formatting issues.

* Flip Flutter category's isGroup field to false until it's actually
needed.

* Revert auto-generated formatting changes to keep those lines from
muddying the pull.

* Small fixes pointed out by analyzer.

* Properly fix analyzer issues around const constructors.

* Small changes to address comments.

* Add tests to verify grouped validator behavior and validationtype
merging.

* Update doctor.dart

* Add comments for clarification.
2018-09-04 19:36:47 -07:00
Ian Hickson
88c94f57c7
Remove unnecessary consts (#21410) 2018-09-04 17:05:30 -07:00
Marcin Szałek
1658fd9412 Added size to stepper icons (#19313)
* Added size to stepper icons

* Added Stepper icons size test
2018-09-04 16:51:39 -07:00
Chris Bracken
2ab4ed748e
Eliminate Dart 1 support from DevFS (#21404)
Dart 1 is no longer supported in Flutter. Hot reload now always occurs
via kernel file updates (plus any asset bundle changes).
2018-09-04 16:47:57 -07:00
Will Larche
2ef7cd649c
[Icons] Updating default icon theme values. (#20840)
Closes #3188
2018-09-04 19:26:52 -04:00
Chris Bracken
70eefd1e9c
Eliminate Dart 1 support from FlutterDevice class (#21402) 2018-09-04 15:42:05 -07:00
Chris Bracken
63fde92adc
Eliminate Dart 1 support from Xcode xcconfig files (#21400) 2018-09-04 14:33:49 -07:00
Jonah Williams
3cd6f40a34
wire bold text flag to text widget (#21325) 2018-09-04 13:49:20 -07:00
Chris Bracken
d04a057efd
Eliminate BuildInfo.previewDart2 (now always true) (#21392)
Dart 1 is no longer supported in Flutter.
2018-09-04 13:38:17 -07:00
Jonah Williams
5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)
This reverts commit 3306fc10421cfbad8f772d23c02aca27c7ca1d76.
2018-09-04 12:40:40 -07:00
Jacob Richman
3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.

Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Chris Bracken
ac8b906cb4
Eliminate support for Dart 1 in AOT snapshotter (#21388) 2018-09-04 10:17:12 -07:00
Chris Bracken
ed0b8be041
Eliminate script snapshot support (#21387)
Script snapshots were only every used in Dart 1 mode, which is no longer
supported.
2018-09-04 10:05:26 -07:00
Hans Muller
343b57036a
InheritedModel - an InheritedWidget for data models (#19739)
Added InheritedModel:  An InheritedWidget that's intended to be used as the base class for models whose dependents may only depend on one part or "aspect" of the overall model.
2018-09-04 09:31:52 -07:00
Danny Tuppeny
a74f591d0c
Change asset_bundle_package_font_test to memory file system (#21114)
* Change assert_bundle_package_font_test to memory file system

This is to work towards being able to run the tests without `-j1` (#21113). These tests were using the real filesystem and setting/relying on fs.currentDirectory. There was a comment about this being because the memory provider didnt' support POSIX and Windows, however that seems to have changed since (and many other asset tests already do something similar to this).

* Trim trailing whitespace

* Add a workaround for Windows path slash directions

Strictly this is correct, but the real FS can tolerate either path. The in-memory file system is more strict (see https://github.com/google/file.dart/issues/112).

* Extract a helper for writing schema files in tests

* Missed file when saving!

* Remove redundant comment

* Rename writeBasicSchema -> writeEmptySchema

* Use the file we already have to write contents

* Make comments more descriptive

* Remove another dupe of writeSchema to use the shared one

* Rename schema -> pubspec_schema

* Trim whitespace
2018-09-04 17:12:24 +01:00
Chris Bracken
041ff621a7
Eliminate --preview-dart-2 flag (#21304)
This patch eliminates the --preview-dart-2/--no-preview-dart-2 flag,
hardcoding all uses to true. It also defaults all previewDart2 method
parameters to true, where they hadn't yet been.

A series of subsequent patches will eliminate all previewDart2
parameters and the associated code from within the codebase.
2018-09-04 08:50:05 -07:00
Danny Tuppeny
db7aa6a069
Unskip passing tests on Windows + add a new failing test with GH reference (#21351)
* Unskip integration tests on Windows that now pass

The referenced issue is closed and these tests pass for me locally on Windows now.

* Remove import that's no longer used

* Add another issue that is afffecting these tests on Windows

* Add a hot restart test and mark skip on Windows

Skipped due to https://github.com/flutter/flutter/issues/21348.
2018-09-04 16:24:10 +01:00
jensjoha
cd65903f56
Initialize from dill on tests (#20414) 2018-09-04 11:17:10 +02:00
Viet Do
26b2909077
Cupertino Countdown Timer Picker doc fix (#21299) 2018-09-02 11:29:10 -07:00
xster
457e7b23df
Fix FixedExtentScrollController.animateToItem (#20618) 2018-09-01 04:06:46 -07:00
Amir Hardon
4aaa5dfe31
Don't reject the gesture after all pointers are up on AndroidView. (#21295)
This was a bug, when e.g a LongPressGestureRecognizer was in the gesture
arena, the android view gesture team may not yet win the arena when the
last pointer was up. This change allows AndroidView to win the gesture
even after all pointers are up.
2018-08-31 16:32:21 -07:00
Amir Hardon
abb55cb649
fix wrong hashCode implementation in FakeMotionEvent (#21291) 2018-08-31 16:16:37 -07:00
Chris Bracken
4a0106658f
Migrate hot reload tests to Dart 2 (#21290) 2018-08-31 15:40:00 -07:00
Chris Bracken
4d0f09a2aa
Migrate Flutter Tester tests to Dart 2 (#21292) 2018-08-31 15:39:34 -07:00
Chris Bracken
a6af2ca643
Run resident_runner_test in Dart 2 mode (#21288) 2018-08-31 14:31:38 -07:00
Chris Bracken
251e82d211
Migrate devfs tests to Dart 2 (#21285)
DevFS.update only runs in Dart 2 mode when the generator parameter is
supplied. In Dart 2 mode, both mainPath and pathToReload are required
parameters; this patch marks them as such.

generator is required for running in Dart 2. All call sites other than tests already explicitly set this value.

Note the statements on line 510 and line 516 for why mainPath and pathToReload are required.
2018-08-31 13:31:56 -07:00
Chris Bracken
9d0084ff57
Restrict compilationQueue to library-visibility (#21280)
Its type uses a generic type which is limited to library-visibility.
Eliminating compilationQueue from ResidentCompiler's public interface
makes it possible to mock in tests.
2018-08-31 12:22:50 -07:00
Mikkel Nygaard Ravn
6cc8008283
Fix extraction of product bundle ID for iOS projects (#21252) 2018-08-31 11:07:15 +02:00
liyuqian
f7b2722d50
Add clipBehavior to Chips and update documents (#21231)
This fixes https://github.com/flutter/flutter/issues/20746
2018-08-30 23:27:37 -07:00
xster
cda2c223f5
Turn on unawaited_futures in flutter_tools (#21048) 2018-08-30 20:57:44 -07:00
Jonah Williams
f2442b8a13
Fix traversal order issues caused by intersecting or overlapping child rects (#21235) 2018-08-30 19:55:07 -07:00
Todd Volkert
2f32166f4b
Update packges (#21241)
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Chris Bracken
6d7ecab25c
Minor improvements to analyzer test naming (#21234)
Clarify the intent of these tests.
2018-08-30 14:07:34 -07:00
Alexander Aprelev
e4b7e87bdd
Pass uri instead of filepaths when hot-reloading. (#21201)
* Pass uri instead of filepaths when hot-reloading.

Bug: https://github.com/flutter/flutter/issues/21168

* Remove imports. Enable another test

* Restore skipping of test on mac
2018-08-30 12:08:23 -07:00
Suvorov Daniil
7598050fff Add VS Code path to user install (#21070) 2018-08-30 18:42:25 +01:00
Alan Russian
7306ac95d5
Fix spellings of AppBar (#21197) 2018-08-30 10:41:34 -07:00
Hans Muller
ce51e71d19
Add Card clipBehavior pass-through property (#21187) 2018-08-30 10:09:44 -07:00
Greg Spencer
ec5c2e3e0c
Add links to implicit animation illustrations. (#21092)
This adds links to the already existing animated diagrams in the asset-for-api-docs repo.
2018-08-30 10:09:22 -07:00
Jonah Williams
d1417c72a3
'fix' build (#21225) 2018-08-30 09:51:01 -07:00
Mikkel Nygaard Ravn
22832d3634
Support for flutter run/build module on iOS (#21216) 2018-08-30 16:18:44 +02:00
MH Johnson
19c9628256
[Material] Fix 20051 FAB tooltip touch target (#21084)
* [FAB] Updated tooltip touch target.

* Remove "new" keyword

* [FAB] Updated tooltip touch target.

* "long press button edge"

* remove new

* remove new

* put "new" keywords back in

* Remove check for childless tooltip

* Added regression test - tooltip works on edge of FAB which has no child.

Added helper method to find the right edge of a in the tests.

* Changed "find.byType(text)" to "find.text('Add')"
2018-08-30 09:59:13 -04:00
Greg Spencer
7cebaac985
Makes switching channels remove version freshness stamp. (#21182)
When switching between channels, we were leaving around the version freshness stamp file (bin/cache/flutter_version_check.stamp), which meant that the flutter tool would read from that file to see what the cached date of the most recent commit to the current channel (branch) was. The problem was that since the file was created while on the previous channel, the cached date was for the wrong channel, so if you switch from master to beta, flutter would think that the channel was out of date, and a new version was available, at least for three days after the first time it checked (after three days since the last time the freshness was checked, the cached date would get updated).

This PR modifies the channel command to remove that stamp file whenever the user switches channels, so that the cached date will be from the right channel when it is recreated.

Fixes #21134
2018-08-29 21:53:39 -07:00
Jonah Williams
f353c308a1
remove flaky rects (#21194) 2018-08-29 17:21:08 -07:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 (#21181) 2018-08-29 16:48:23 -07:00
Jonah Williams
44cdb049d8
Update Text/Rich text to describe recognizers in semantics (#20676) 2018-08-29 13:55:48 -07:00
Alexander Aprelev
a7d954eb31
Add TODOs to remove lint ignore directives. (#21170)
This is follow-up to https://github.com/flutter/flutter/pull/21143.
2018-08-29 10:25:19 -07:00