2704 Commits

Author SHA1 Message Date
Adam Barth
04dca44f27 Be consistent about method versus function (#4828)
Fixes #4761
2016-07-06 18:45:42 -07:00
Devon Carew
ec752d813d send ext.flutter.debugDumpApp; ext.flutter.reassemble (#4810)
* send ext.flutter.debugDumpApp; ext.flutter.reassemble

* expose debugDumpRenderTree
2016-07-04 11:21:56 -07:00
Adam Barth
3cbb20d176 Just use SemanticAnnotator instead of Iterable<SemanticAnnotator> (#4813) 2016-07-03 21:16:21 -07:00
Adam Barth
839def55ba Teach the system to shutdown semantics (#4811)
We now stop updating semantics when there are no remaining clients.
2016-07-01 17:57:10 -07:00
Jason Simmons
cbf7d98874 Allow a host message handler to return a null result (#4812)
Host apps will return null if there is no matching handler for a message name
2016-07-01 15:50:29 -07:00
Adam Barth
5ed8f1a1fd Add semantics for Sliders (#4808)
Also, make SemanticsOwner into a real class and use it instead of a static in
several places.
2016-07-01 13:38:24 -07:00
Adam Barth
8c535ad7d7 Update use of @protected (#4805)
Now that protected can be accessed from inside the same library, we can
use protected in a number of new places and we can remove some
trampolines we were using to work around its previous semantics.
2016-07-01 10:06:40 -07:00
Adam Barth
e0f37027ab Add some tests for these tweens (#4804) 2016-07-01 09:46:37 -07:00
Adam Barth
95a26ab0e8 Switch to SemanticAction (#4791)
This patch updates the framework to use the new SemanticAction in
semantics.mojom.
2016-06-30 17:38:05 -07:00
Hans Muller
107cbd3185 Refresh Indicator fine tuning (#4800) 2016-06-30 15:36:06 -07:00
Matt Perry
6298a1aeb1 Fix a bug where ScrollableGrid/ScrollableList would flicker when (#4794)
navigating away.

Details are in the bug, but when we navigate away, the overscroll
indicator around the Scrollable would change the widget hierarchy. This
would trigger the Scrollable to rebuild, which would cause its
scrollOffset to be clamped to 0 for a frame.

BUG=https://github.com/flutter/flutter/issues/4597
2016-06-30 15:43:47 -04:00
pq
ec256c5ee4 Removed trampoline. 2016-06-30 10:50:38 -07:00
pq
a417786d77 Update to latest analyzer (w/ cleanup).
Bye-bye `@protected `trampolines! :)
2016-06-30 10:39:45 -07:00
Hans Muller
d9b9983e1a Refresh indicator (#4788) 2016-06-30 10:07:28 -07:00
Adam Barth
63eedb7677 Semantics debugger shouldn't crash when reparenting nodes (#4782)
Our previous approach to detecting when we needed to remove semantics nodes
didn't account for reparenting.
2016-06-28 14:44:02 -07:00
pq
543f705adb Cleanup empty statements.
The new `empty_statements` lint (in the next DEV roll), flags these empty statements.  Harmless, except the one in `basic.dart` that fixes a real-life bug. :)
2016-06-28 13:42:22 -07:00
Chinmay Garde
1a5ca2f675 Fix failing tooltip_test.dart by avoiding floating point comparisons. (#4781) 2016-06-28 12:49:11 -07:00
Chinmay Garde
b8bcd62e54 Remove counters used to tag variables and symbols in the solver for debugging purposes. (#4780) 2016-06-28 11:58:24 -07:00
Hans Muller
77cd8ee40e Reproduce the Shrine home page portrait grid layout (#4779) 2016-06-28 11:05:18 -07:00
Adam Barth
41d6303570 Improve test coverage for material.dart (#4776)
Previously these widget had zero test coverage. Also, improve the
coverage tooling Mac.
2016-06-28 08:48:48 -07:00
Adam Barth
14f42a6a48 Improve test coverage in rendering.dart (#4775) 2016-06-27 17:38:53 -07:00
Adam Barth
bb0c41f2a6 Improve test coverage for gestures.dart (#4773)
This patch adds tests for some code paths we weren't hitting before and removes
some dead code that couldn't be tested because it was unreachable.
2016-06-27 14:42:41 -07:00
Adam Barth
2898768dde Add some missing docs (#4772)
These docs complete the dartdocs for their respective libraries.
2016-06-27 14:42:25 -07:00
Adam Barth
2af668f832 Change how navigator prevents redundant operations (#4769)
* Change how navigator prevents redundant operations

Instead of requiring transactions, we now cancel all active pointers that are
interacting with the navigator and absorb future pointers until we get a chance
to build. This approach isn't perfect (e.g., events that trigger off the
cancelled pointers could still interact with the navigator), but it should be
better than the current transaction-based approach.

Fixes #4716

* Remove openTransaction

* test

* fixup
2016-06-27 13:07:47 -07:00
Hans Muller
08bf1b6bce Scrollable dropdown, dropdown underline cosmetics (#4766) 2016-06-27 10:28:20 -07:00
Adam Barth
5fc04dab74 Document State (#4762)
This patch documents State in detail because it's a very common class
for developers to work with and it has a number of subtles.
2016-06-26 16:22:20 -07:00
Adam Barth
2fa6a709c9 Improve documentation for framework.dart (#4758) 2016-06-25 12:22:14 -07:00
Adam Barth
9c0c0225a6 Add a test for GridPaper (#4754)
Previously this widget was completely untested.
2016-06-24 20:46:17 -07:00
Chinmay Garde
ae835f08df Document the public members of the Cassowary package. (#4744) 2016-06-24 17:31:47 -07:00
Adam Barth
9850fe1861 Test all but one line in animation.dart (#4751)
The one line we don't test is the private constructor for the Curves class,
which exists to ensure that no one constructs the Curves class.
2016-06-24 16:33:04 -07:00
Adam Barth
b00efda7fc Improve change notifier (#4747)
This patch improves some subtle behaviors about the change notifier.
2016-06-24 15:53:48 -07:00
Chinmay Garde
490622b4da Add a wrapper for accessing the URL launcher service. (#4688) 2016-06-24 14:51:03 -07:00
Adam Barth
46da9e8498 Add a simple way of merging coverage data (#4726)
`flutter test` now has a `--merge-coverage` flag that can be used to merge
coverage data from previous runs, enabling faster iteration cycles.
2016-06-23 18:02:55 -07:00
Hans Muller
68efa6a3fc Correct scrolling tabbar tab indicator size (#4723) 2016-06-23 15:17:17 -07:00
Adam Barth
05eef4a9b2 Get to 100% test coverage for src/animation/animations.dart (#4721) 2016-06-23 15:15:31 -07:00
Adam Barth
56039c0e64 Improve test coverage for animation.dart (#4718)
We now have 100% coverage of animation.dart and animation_controller.dart.
Also, add some basic tools for working with lcov files. These tools need much
more polish.
2016-06-23 13:43:42 -07:00
Adam Barth
74761265bc Add dartdoc for tabs and text selection handles (#4715) 2016-06-23 13:43:16 -07:00
Hans Muller
c12c179a72 Make DataTable readable with the dark theme (#4717) 2016-06-23 10:59:07 -07:00
Ian Hickson
e5fb2fb0d3 An API for tracking software licenses. (#4711) 2016-06-23 10:34:11 -07:00
Phil Quitslund
55b51ee549 Merge pull request #4697 from pq/analyzer_0.27.4-alpha.14
Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
2016-06-23 10:03:49 -07:00
Adam Barth
73cd70f776 Add test coverage for lastElapsedDuration (#4705)
Also, fix the bug where apps would assert when you change the time dilation.
Use that mechanism to fix the animation controller tests.
2016-06-22 17:14:55 -07:00
pq
b2fed16454 _BuildFunction => WidgetBuilder 2016-06-22 15:39:27 -07:00
pq
dcc7b144af Updated closure trampolines. 2016-06-22 15:25:25 -07:00
Hans Muller
bb2e7b5250 Add AppBar iconTheme parameter (#4693) 2016-06-22 15:19:31 -07:00
pq
352e2f573b Update to latest analyzer (0.27.4-alpha.14) and misc. analysis fixes.
* brings in analyzer version (`0.27.4-alpha.14`) corresponding to current Dart SDK (`1.18.0-dev.2.0`).
* updates analysis to use prefered API for embedder URI resolution
* adds trampolines to `State` and `StatelessWidget` to allow for warning-free within-library @protected access (needed since we closed off access to @protected closures from outside subclasses).
* turns off cache dependency tracking for analysis (in DDC this amounted to a 10% speed improvement).
2016-06-22 14:34:30 -07:00
Ian Hickson
cd89e867ef About box API (#4677)
This API is the front-end part of the work on showing licenses.

Future patches will:

* Provide an API for registering what licenses should be shown here,
  which will be used by this feature to shown licenses but could also be
  used by custom code for showing licenses (e.g. for people not using
  the Material widgets).

* Actually populate this license API from all the licenses we currently
  use in the engine, in the framework, and from any pub packages that
  are used (directly or indirectly) by the application.
2016-06-22 10:42:02 -07:00
Adam Barth
bf740cf46b Restore SystemChrome.setEnabledSystemUIOverlays (#4680)
I erroneously removed this function in an earlier patch. Also, export
SystemUiOverlayStyle because we expose that enum in the SystemChrome
API.
2016-06-22 16:45:47 +02:00
Adam Barth
a8f6f44a55 Update engine to include new version of Mojo (#4668)
This required switching from the Future-based bindings to the callback-based
bindings.
2016-06-21 15:53:47 -07:00
Hans Muller
b81229b5f1 DropdownButton layout (#4582) 2016-06-21 15:20:35 -07:00
Hans Muller
0e38cba95f Make the limit that defines Row/Column free space configurable (#4646) 2016-06-21 14:29:22 -07:00