3713 Commits

Author SHA1 Message Date
Michael Goderbauer
026c89835f
Clarify Offstage docs (#18089) 2018-06-01 15:22:33 -07:00
Michael Goderbauer
4c5303a204
Unfocus textfield if it is disabled (#18097) 2018-06-01 09:40:52 -07:00
Ian Hickson
b83749cab0
Golden file tests for clip (#18056)
Also, fixes "flutter run" for golden tests, and some docs.
2018-06-01 00:23:26 -07:00
Ian Hickson
72c459bcfc
Fix crash when painting empty tables (#17952) 2018-05-31 22:47:25 -07:00
Ian Hickson
1891173999
Spacer should only flex in the main axis direction. (#18052) 2018-05-31 20:38:37 -07:00
Alexander Markov
ed20de0ae9
Restore omitted optional 'new' to fix Flutter gallery in Dart 1 mode (#18087) 2018-05-31 17:48:09 -07:00
Hans Muller
f1e4defbbc
Pass locale along to RenderParagraph (#17879) 2018-05-31 11:01:24 -07:00
Ian Hickson
9f1e76e967
Clean up baseline logic in material library. (#17922) 2018-05-30 22:53:03 -07:00
Dan Field
587a1b7708
Expose Gradient.radial (#17826)
* Expose Gradient.radial

* cleanup doc

* update tests, null check

* add asset images
2018-05-30 21:45:21 -04:00
Victor Choueiri
d57cc44f05 Add SweepGradient (#17368)
This PR adds a SweepGradient class, extending Gradient to expose the engine's ui.Gradient.sweep shader.

Similar to LinearGradient and RadialGradient - SweepGradients can be used in a BoxDecoration or passed to a Paint's shader.
2018-05-30 15:18:17 -07:00
Jonah Williams
6fc7199dcc
Add outer gesture detector to increase mini-fab size to 48x48 (#17921) 2018-05-30 14:54:39 -07:00
Greg Spencer
b921fdc58e
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041)
This reverts commit 3258602073c6a05b1b051fddf644cba92116694b.
2018-05-30 13:51:14 -07:00
Greg Spencer
3258602073
Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)
Fixes #18028

Just changes typedef declarations, no logic changes.
2018-05-30 12:13:58 -07:00
Mikkel Nygaard Ravn
055ad0ce4c
Fix typos (#18017) 2018-05-30 11:12:33 +02:00
Michael Goderbauer
a2d1d27f79
Keep indeterminate RefreshProgressIndicator spinning until end of time (#18010) 2018-05-29 18:04:13 -07:00
Todd Volkert
d6d35ca7cc
Address post-review comments from #17977 (#18000) 2018-05-29 14:45:40 -07:00
Todd Volkert
7c60b7405a
Instrument vm service extensions in the gallery (#17977)
https://github.com/flutter/flutter/issues/17956

* Add a `debugInstrumentAction()` method that will wrap an action
  in a stopwatch and print the time it took to run the action.
* Add a global `debugInstrumentationEnabled` that will control
  whether `debugInstrumentAction()` does anything (even in debug
  builds).
* Add some basic instrumentation to `registerServiceExtension()`
* Temporarily enable the `debugInstrumentationEnabled` flag in the
  Gallery to give us better visibility into what's happening in
  https://github.com/flutter/flutter/issues/17956
2018-05-28 12:40:43 -07:00
Mikkel Nygaard Ravn
4a72973cec
Fix typo (#17959) 2018-05-28 11:33:40 +02:00
Mikkel Nygaard Ravn
cd34e6cc28
Fix typo (#17958) 2018-05-28 09:54:54 +02:00
fmatosqg
7d25378932 Make image resolution more strict, clean gallery pubspec.yaml (#17241) (#17322) 2018-05-26 08:33:13 -07:00
Jonah Williams
b6ceff552b
re-add semantic service events for tap and longPress (#17918) 2018-05-25 18:42:02 -07:00
Todd Volkert
bae78a6f73
Fix RenderListTile actual baseline computation (#17915)
It should be calling `tile.getDistanceToActualBaseline()` rather than
`tile.getDistanceToBaseline()`.  This is causing us to hit assertions
`getDistanceToBaseline()`
2018-05-25 13:15:34 -07:00
Michael Goderbauer
1361071a21
Don't crash when TextField w/ explicit controller is activated via a11y (#17892)
Fixes #17801.
2018-05-25 09:56:24 -07:00
Emmanuel Garcia
c4d6311a29
Fix #16464
* Fix #16464: Pass hit test when a big child is inside RenderFittedBox, RenderTransform, RenderFractionalTranslation, or RenderFollowerLayer

* Override `hitTestChildren`

* RenderTransform and RenderFollowerLayer shouldn't check if they are hit
themselves

* Test the hit test for translated child into translated box

* Add hit test for `FractionalTranslation`

* Don't check if RenderFractionalTranslation is hit themself

* Add hit test for FractionalTranslation

* Add test for FractionalTranslation
2018-05-24 23:16:16 -07:00
Michael Goderbauer
d5a103402c
Expandable Search (#17629) 2018-05-24 09:30:37 -07:00
Michael Goderbauer
bf0f4e6b2e
Document defaults of GestureDetector.behavior and link to debugging options (#17785) 2018-05-23 17:01:19 -07:00
Hans Muller
14cce38668
Remove built-in right-edge appbar padding (#17852) 2018-05-23 13:14:12 -07:00
Collin Jackson
66b50ed02b
Default toggleableActiveColor to accentColor if not set (#17848) 2018-05-23 12:56:28 -07:00
Hans Muller
41fb069cb7
Prevent Switch from looping on and off (#17821) 2018-05-23 09:49:14 -07:00
Todd Volkert
9471e4e216
Ensure that VM service extension handlers are run on outer event loop. (#17812)
Fixes https://github.com/flutter/flutter/issues/17597
2018-05-22 11:55:46 -07:00
Hans Muller
0a383fce36
Fix InkRipple.cancel(), added paints..everything (#17787) 2018-05-22 07:46:57 -07:00
Yegor
4beb57c324
Roll engine; pass semantics child orders (#16970)
* pass semantics children in traversal and hit test orders

* explain why we are inverting _children

* Roll engine
2018-05-21 20:55:28 -07:00
Michael Goderbauer
7471ff8c89
showOnScreen doesn't trigger scroll if item is already fully on screen (#17729) 2018-05-21 16:33:47 -07:00
ng1905
eda3167ac6 Fix ScrollOffset calculation when childCount is null (#17722) 2018-05-21 15:39:09 -07:00
Hans Muller
12bab13429
Handle the case where InputDecorator is constrained to 0x0 (#17777) 2018-05-21 13:11:02 -07:00
Victor Choueiri
8717a5e6f7 Fix Scaffold.endDrawer dartDoc to mention openEndDrawer (#17719) 2018-05-18 17:19:35 -07:00
Greg Spencer
1f5fcb7432
Speed up AnimatedSwitcher. (#17265)
This optimizes the AnimatedSwitcher so that it tags the right widget with its keyed subtree, and avoids rebuilding the transition unnecessarily.

This significantly improves the performance of Chips (which uses AnimatedSwitcher to swap out it's avatar and delete icon children).
2018-05-18 16:27:19 -07:00
Christopher Araüjo
8a4db32bb8 Added onChangeStart and onChangeEnd to CupertinoSlider (#17535)
This is a follow up on issue #17169 and the pull request #17298

This pull request adds the onChangeStart and onChangeEnd callbacks for CupertinoSlider. These are called when a user starts and ends a change respectively.

Pushing for @dcaraujo0872, the PR author.
2018-05-18 14:52:46 -07:00
xster
ef25052c51
Let scrollOffsetCorrection on small lists not leave the list stuck in overscroll (#17599) 2018-05-18 14:40:39 -07:00
Greg Spencer
3c5a7a3005
Make non-global constants have consistent naming (with just _ instead of _k) (#17584)
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this.

Only naming changes to private vars: no logic changes.
2018-05-17 23:04:41 -07:00
Greg Spencer
e4b574d3d3
Cupertino Dialog Changes (#17676)
This replaces abandoned PR #14824 by @ekbiker, and gives it some love.
2018-05-17 22:36:16 -07:00
Noam Drong
fd55c4ec5b Add glyph references for Cupertino-style icons (#16605) 2018-05-17 12:42:49 -07:00
Greg Spencer
ac67efbc83
Moving API doc asset URLs to point to the new location. (#17697)
I'm moving the assets in the assets-for-api-docs repo to a slightly different location to help with organization in that repo, so this PR points the doc URLs to the new location. The old assets won't be removed until this PR makes its way to the API docs website.

No documentation or code changes here, other than changing doc image URLs.
2018-05-17 09:53:06 -07:00
Dan Field
85cb38e71a
Fix consolidate HTTP response and add test (#17082)
* Fix consolidate response and add test

* Update AUTHORS

* ignore content-length

* fix formatting/update comment

* more commas

* Fix consolidate response and add test

* Update AUTHORS

* ignore content-length

* fix formatting/update comment

* more commas

* remove extra newline
2018-05-17 07:04:05 -04:00
Michael Goderbauer
6c9a7c5803
fixes (#17624) 2018-05-16 14:20:16 -07:00
Hans Muller
60272ee5bd
Restore the ListTile layout updates (#17661)
restored https://github.com/flutter/flutter/pull/17496
restored https://github.com/flutter/flutter/pull/17580
2018-05-16 12:33:07 -07:00
Jason Simmons
bb35bc3627
Add a background paint property to TextStyle (#17586)
See https://github.com/flutter/flutter/issues/11961
2018-05-16 09:19:28 -07:00
Greg Spencer
f38743593d
Add Spacer Widget (#16642)
This adds a simple spacer widget first suggested by Scott Stoll (@ScottS2017) in the abandoned PR #15802

This PR replaces that one, cleans it up, and adds a test.
2018-05-15 19:37:21 -07:00
Jonah Williams
ebd9a9621d
Increase contrast of Checkbox, Radio, And Switch widgets (#17637) 2018-05-15 17:55:45 -07:00
Hans Muller
6dcb0d62c3
Change kRadialReactionRadius from 24 to 20 (#17620) 2018-05-15 15:06:03 -07:00