DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,855 Commits 882 Branches 1,069 Tags
Commit Graph

24198 Commits

Author SHA1 Message Date
skia-flutter-autoroll
01f56591bd Roll Fuchsia Linux SDK from SQrHxRVqMo5arcS3p... to tpiob-Qyh6oYiIznS... (flutter/engine#46532) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 04:34:19 +00:00
Jia Hao
c2eecba786 [Impeller] Don't define CanvasRecorder if IMPELLER_TRACE_CANVAS is not set. (flutter/engine#46476) 
Internal bug: b/303067268

https://github.com/flutter/engine/pull/46376 is causing a breakage to the internal engine build because of 543348a044/impeller/aiks/canvas_recorder.h (L58-L62). Internally, we do not set `IMPELLER_TRACE_CANVAS`.

It looks like the cause is that the internal toolchain causes the `static_assert` to be compiled even though the template is not instantiated.

@chingjun helped me to figure out the following:

https://stackoverflow.com/questions/5246049/c11-static-assert-and-template-instantiation points us to the spec. In the later version (ISO/IEC 14882:2017(E)):

> The program is ill-formed, no diagnostic required, if ... no valid specialization can be generated for a template or a substatement of a constexpr if statement (9.4.1) within a template and the template is not instantiated,

<details>

<summary>The relevant section</summary>

![The relevant section of the spec](https://github.com/flutter/engine/assets/7111741/4503efcd-9479-4c7a-b4a1-7302dea1653b)

</details>

Interpretation: the compiler can either choose to emit the error caused by the `static_assert` or not. Currently the compiler used by the build here on LUCI does not; internally it does.

For example, the following links shows that simply changing the Clang version affects whether the error appears or not for a minimal template.

- ok: https://godbolt.org/z/n9nYrcvcP
- not ok: https://godbolt.org/z/fWcvdcn35

Hence, `#ifdef` out the class instead of using a `static_assert` for more consistent behavior across these two toolchains.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-04 02:29:17 +00:00
skia-flutter-autoroll
aba0fcf6c5 Roll Skia from c66c89c56549 to 4cc56b6b3453 (1 revision) (flutter/engine#46525) 
https://skia.googlesource.com/skia.git/+log/c66c89c56549..4cc56b6b3453

2023-10-03 jvanverth@google.com Move some functionality for PathAtlas into Compute and Raster.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 22:51:04 +00:00
Matan Lurey
b6dfcba94b [Impeller] Implement a MockGLES, that provides trampolines for ProcGLESTable (flutter/engine#46433) 
Unblocks testing https://github.com/flutter/flutter/issues/135715. See
`README.md` for details.

I made one non-testing change to the proc_table itself, which is if a
function call will fail, we will print out what is about to fail in the
validation log. It was useful when debugging the test creation itself,
and it's only enabled when GL call checks are enabled anyway.

@gaaclarke I originally implemented it with `FML_THREAD_LOCAL`, but
figured doing a global lock essentially was the same thing, and would
prevent parallel test runs from stepping on each-other in weird ways?

/cc @chinmaygarde for visibility.
 2023-10-03 16:23:25 -06:00
Matan Lurey
217689a9c0 [Impeller] Invoke glDebugMessageControl before glPushDebugGroup (flutter/engine#46392) 
Closes https://github.com/flutter/flutter/issues/135715.

I plan to add tests before submitting once
https://github.com/flutter/engine/pull/46433 lands, probably something
around `glDebugMessageControl` being emitted once per context, since
that's what we need to keep working for Pixel phones.

## Output

<details>

<summary>Screenshot of app running locally, showing lack of off-screen
MSAA</summary>


![flutter_01](https://github.com/flutter/engine/assets/168174/23642582-ce4c-47dc-8edf-7e6cfd12a074)

</details>

```shell
$ fl run --enable-impeller --local-engine=$ENGINE/out/android_debug_unopt_arm64 --local-engine-host=$ENGINE/out/host_debug_unopt_arm64

Launching lib/main.dart on Pixel 5 in debug mode...
Running Gradle task 'assembleDebug'...                             33.7s
✓  Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app-debug.apk...          17.8s
E/flutter (17749): [ERROR:flutter/shell/platform/android/android_context_gl_impeller.cc(80)] Using the Impeller rendering backend (OpenGLES).
Syncing files to device Pixel 5...                                  70ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on Pixel 5 is available at: http://127.0.0.1:57181/CrsakIgCHFY=/
I/cle_opacity_foo(17749): Compiler allocated 4413KB to compile void android.view.ViewRootImpl.performTraversals()
The Flutter DevTools debugger and profiler on Pixel 5 is available at:
http://127.0.0.1:9101?uri=http://127.0.0.1:57181/CrsakIgCHFY=/
```
 2023-10-03 16:14:20 -06:00
skia-flutter-autoroll
f9e1cae064 Roll Dart SDK from 318c46832196 to 817f77ceba40 (1 revision) (flutter/engine#46520) 
https://dart.googlesource.com/sdk.git/+log/318c46832196..817f77ceba40

2023-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-226.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 22:11:32 +00:00
Matan Lurey
90595b5afa Opt out flutter/third_party/** from clang-tidy checks explicitly. (flutter/engine#46514) 
See https://github.com/flutter/flutter/issues/134969.

/cc @zanderso
 2023-10-03 22:06:09 +00:00
Brandon DeRosier
4b271e17c5 [Impeller] Stencil -> Clip (flutter/engine#46519) 
The days of using the stencil buffer for clip tracking may be numbered, so move away from mentioning the stencil buffer for concepts that are actually about clips.
 2023-10-03 22:06:07 +00:00
skia-flutter-autoroll
fedd8e1f1f Roll Skia from d8ec08c6d49d to b708dd7d1092 (1 revision) (flutter/engine#46518) 
https://skia.googlesource.com/skia.git/+log/d8ec08c6d49d..b708dd7d1092

2023-10-03 lehoangquyen@chromium.org graphite-dawn: only wait for wgpu::RenderPipeline on 1st use

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 21:09:15 +00:00
skia-flutter-autoroll
ab270f4503 Roll Skia from 22d1ae035048 to d8ec08c6d49d (1 revision) (flutter/engine#46515) 
https://skia.googlesource.com/skia.git/+log/22d1ae035048..d8ec08c6d49d

2023-10-03 lovisolo@google.com [bazel] SurfaceManager: Add SurfaceOptions struct.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 20:22:06 +00:00
skia-flutter-autoroll
ab2944ab21 Roll Skia from 3a227c225839 to 22d1ae035048 (1 revision) (flutter/engine#46513) 
https://skia.googlesource.com/skia.git/+log/3a227c225839..22d1ae035048

2023-10-03 johnstiles@google.com Move the FP child-impl array into MeshGP::Impl.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 19:34:05 +00:00
Brandon DeRosier
8d43bd4625 [Impeller] Fix framebuffer blend UVs. (flutter/engine#46489) 
Fixes b/303120488.

There's no need to use the `GetCoverageUVs` utility in this case.
Correct usage here would require the geometry to match the coverage
rectangle of the snapshot in pass space with no further transformations
to the geometry.
We should just render the snapshot texture as-is with simple 0/1 UVs and
the snapshot's transform.
 2023-10-03 12:02:44 -07:00
skia-flutter-autoroll
22c94062e4 Roll Skia from cb4cfa571393 to 3a227c225839 (3 revisions) (flutter/engine#46511) 
https://skia.googlesource.com/skia.git/+log/cb4cfa571393..3a227c225839

2023-10-03 lovisolo@google.com [bazel] Move //gm/surface_manager to //tools/testrunners/surface_manager.
2023-10-03 lovisolo@google.com [bazel] Fix broken GrDirectContext::flushAndSync() call in GaneshGLSurfaceManager.cpp.
2023-10-03 robertphillips@google.com [graphite] Add ability to directly invoke the basic blending methods

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 18:51:27 +00:00
skia-flutter-autoroll
3d4597dec5 Roll Skia from a114c3d5672b to cb4cfa571393 (1 revision) (flutter/engine#46510) 
https://skia.googlesource.com/skia.git/+log/a114c3d5672b..cb4cfa571393

2023-10-03 fmalita@chromium.org [skottie] More locale staging

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 18:05:05 +00:00
skia-flutter-autoroll
07fb62c5a7 Roll Skia from 93c6a6dd404d to a114c3d5672b (2 revisions) (flutter/engine#46507) 
https://skia.googlesource.com/skia.git/+log/93c6a6dd404d..a114c3d5672b

2023-10-03 fmalita@chromium.org [canvaskit] Handle unicode input in Skottie WYSIWYG bindings
2023-10-03 lovisolo@google.com [bazel] Add //:gen_compile_flags_txt_linux_amd64 utility.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 17:17:06 +00:00
skia-flutter-autoroll
83928ffd4a Roll Skia from 37a2a8c95f34 to 93c6a6dd404d (2 revisions) (flutter/engine#46502) 
https://skia.googlesource.com/skia.git/+log/37a2a8c95f34..93c6a6dd404d

2023-10-03 robertphillips@google.com [graphite] Add an AddDitherBlock helper function
2023-10-03 penghuang@chromium.org graphite: caching wgpu::BindGroupLayout in graphite pipeline objects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 16:31:44 +00:00
skia-flutter-autoroll
f8b804f98d Roll Skia from 30132659083d to 37a2a8c95f34 (4 revisions) (flutter/engine#46501) 
https://skia.googlesource.com/skia.git/+log/30132659083d..37a2a8c95f34

2023-10-03 johnstiles@google.com Remove IthTexureSampler helper.
2023-10-03 egdaniel@google.com [Graphite] Add public query for current cache usage.
2023-10-03 sharaks@google.com Merge 9 release notes into RELEASE_NOTES.md
2023-10-03 fmalita@chromium.org [skottie] Stage locale change

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 15:45:07 +00:00
skia-flutter-autoroll
fe83bd46ca Roll Skia from 63af3585fc68 to 30132659083d (1 revision) (flutter/engine#46498) 
https://skia.googlesource.com/skia.git/+log/63af3585fc68..30132659083d

2023-10-03 robertphillips@google.com [graphite] Add PaintParamsKeyBuilder::addBlock helper

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 15:01:35 +00:00
skia-flutter-autoroll
f45e3f2965 Roll Skia from a05b5edb3119 to 63af3585fc68 (1 revision) (flutter/engine#46495) 
https://skia.googlesource.com/skia.git/+log/a05b5edb3119..63af3585fc68

2023-10-03 sharaks@google.com Update Skia milestone to 120

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 13:29:05 +00:00
dependabot[bot]
a682a85cc8 Bump actions/setup-python from 4.7.0 to 4.7.1 (flutter/engine#46488) 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 4.7.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v4.7.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/702">actions/setup-python#702</a></li>
<li>Add range validation for toml files by <a href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/726">actions/setup-python#726</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.7.1">https://github.com/actions/setup-python/compare/v4...v4.7.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="65d7f2d534"><code>65d7f2d</code></a> Add range validation for toml files (<a href="https://redirect.github.com/actions/setup-python/issues/726">#726</a>)</li>
<li><a href="f97b83114c"><code>f97b831</code></a> Bump word-wrap from 1.2.3 to 1.2.4 (<a href="https://redirect.github.com/actions/setup-python/issues/702">#702</a>)</li>
<li>See full diff in <a href="61a6322f88...65d7f2d534">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4.7.0&new-version=4.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2023-10-03 05:45:23 +00:00
skia-flutter-autoroll
f7906073e5 Roll Skia from 1ec5c024f61e to ef4abc18ef53 (2 revisions) (flutter/engine#46486) 
https://skia.googlesource.com/skia.git/+log/1ec5c024f61e..ef4abc18ef53

2023-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a17b968c91ef to 0387aac67124 (4 revisions)
2023-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7f4d495c89c2 to 5b6f768198ce (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 05:31:50 +00:00
skia-flutter-autoroll
70c39fd364 Roll Dart SDK from b121fbe079e8 to a4a29db16711 (1 revision) (flutter/engine#46487) 
https://dart.googlesource.com/sdk.git/+log/b121fbe079e8..a4a29db16711

2023-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-223.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 05:31:47 +00:00
skia-flutter-autoroll
f7e4bdb4d1 Roll Fuchsia Linux SDK from ZzYmXHUmcE0gMgZn1... to HZHIjaqYGV-JOwWfn... (flutter/engine#46483) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 03:04:15 +00:00
John McCutchan
6a0fe28dac Restrict ImageReader backed Platform Views to Android 33+ (flutter/engine#46478) 
This is necessary to be able to access the fence associated with each
frame that is produced. This API is not available below 33.
 2023-10-02 19:23:51 -06:00
skia-flutter-autoroll
fc8473c4b6 Roll Dart SDK from 311a337a4b1a to b121fbe079e8 (1 revision) (flutter/engine#46477) 
https://dart.googlesource.com/sdk.git/+log/311a337a4b1a..b121fbe079e8

2023-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 21:28:22 +00:00
skia-flutter-autoroll
27088a2657 Roll Skia from fcd1b7521805 to 064f144adedd (1 revision) (flutter/engine#46472) 
https://skia.googlesource.com/skia.git/+log/fcd1b7521805..064f144adedd

2023-10-02 jvanverth@google.com Rename SoftwarePathAtlas to RasterPathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 19:50:08 +00:00
skia-flutter-autoroll
772847d0e8 Roll Skia from b5b5ee1d0a93 to fcd1b7521805 (1 revision) (flutter/engine#46468) 
https://skia.googlesource.com/skia.git/+log/b5b5ee1d0a93..fcd1b7521805

2023-10-02 johnstiles@google.com Create ProgramImpls for child FPs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 18:14:18 +00:00
skia-flutter-autoroll
561b64ecf2 Roll Skia from 53848cbd4e30 to b5b5ee1d0a93 (2 revisions) (flutter/engine#46467) 
https://skia.googlesource.com/skia.git/+log/53848cbd4e30..b5b5ee1d0a93

2023-10-02 fmalita@chromium.org [skottie] Add missing SkUnicode include
2023-10-02 kjlubick@google.com Enforce IWYU on more src/core files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 17:15:35 +00:00
skia-flutter-autoroll
8989d1431c Roll Skia from 3a7a3bbd27d4 to 53848cbd4e30 (3 revisions) (flutter/engine#46466) 
https://skia.googlesource.com/skia.git/+log/3a7a3bbd27d4..53848cbd4e30

2023-10-02 johnstiles@google.com Factor out `invokeFP` so that it can be called by outside code.
2023-10-02 herb@google.com Add a quadratic crossings finder for testing
2023-10-02 kjlubick@google.com Replace exec_tools -> tools and update to Bazel 6.3.2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 16:32:14 +00:00
skia-flutter-autoroll
21058e84f8 Roll Skia from e72023890373 to 3a7a3bbd27d4 (1 revision) (flutter/engine#46464) 
https://skia.googlesource.com/skia.git/+log/e72023890373..3a7a3bbd27d4

2023-10-02 fmalita@chromium.org [skottie] Add support for custom text locales

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 15:47:05 +00:00
skia-flutter-autoroll
4a59845a8a Roll Dart SDK from c9b521394392 to 311a337a4b1a (1 revision) (flutter/engine#46457) 
https://dart.googlesource.com/sdk.git/+log/c9b521394392..311a337a4b1a

2023-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-221.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 13:23:36 +00:00
Bruno Leroux
2475a550db [Linux] Rename 'set_allow_channel_overflow' to 'set_warns_on_channel_… (flutter/engine#46360) 
## Description

This PR is a follow-up to https://github.com/flutter/engine/pull/44636 which introduces the `set_allow_channel_overflow` function. It renames this function to `set_warns_on_channel_overflow`.

The previous naming was inspired by the framework side implementation.
c00c022036/lib/ui/channel_buffers.dart (L574)

During the review of the iOS/macOS implementation, https://github.com/flutter/engine/pull/44848#discussion_r1310463864, we agreed that the existing naming is confusing because it implies that overflow will be allowed, but this not the case this function is used to enable/disable error messages when a channel overflows. 

## Related Issue

Follow-up for https://github.com/flutter/flutter/issues/132386.

## Tests

Updates 2 tests.
 2023-10-02 05:36:16 +00:00
skia-flutter-autoroll
4f0a905e54 Roll Skia from a2e605c42ba8 to 7bd63cc5cba3 (1 revision) (flutter/engine#46452) 
https://skia.googlesource.com/skia.git/+log/a2e605c42ba8..7bd63cc5cba3

2023-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c8eb90e92f62 to a17b968c91ef (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,djsollen@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-02 05:32:25 +00:00
Jonah Williams
a7bac4e984 [Impeller] disable texture to texture blit in GLES. (flutter/engine#46443) 
These are failing with a GL_INVALID_OPERATION.
 2023-09-30 23:49:17 +00:00
Matan Lurey
aa8dd4faa7 [Impeller] Make some Open GL errors non-fatal, check in debug mode (not unopt). (flutter/engine#46434) 
Closes https://github.com/flutter/flutter/issues/135767.
 2023-09-30 09:43:58 -07:00
skia-flutter-autoroll
1457312aa0 Roll Dart SDK from 4574906880c1 to c4e955c13ed5 (1 revision) (flutter/engine#46439) 
https://dart.googlesource.com/sdk.git/+log/4574906880c1..c4e955c13ed5

2023-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-219.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-30 13:22:35 +00:00
skia-flutter-autoroll
bd4adbe772 Roll Fuchsia Linux SDK from U0lgvzao-MdzfEvoT... to ZDxyy9-hcaVyv65as... (flutter/engine#46437) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-30 11:38:38 +00:00
skia-flutter-autoroll
0a66048b74 Roll Dart SDK from 9aca08d40398 to 4574906880c1 (1 revision) (flutter/engine#46435) 
https://dart.googlesource.com/sdk.git/+log/9aca08d40398..4574906880c1

2023-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-218.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-30 05:28:33 +00:00
Jason Simmons
50a17ba824 [Impeller] Apply the transform to PointFieldGeometry coverage (flutter/engine#46428) 
Fixes https://github.com/flutter/flutter/issues/134068
 2023-09-30 01:53:23 +00:00
skia-flutter-autoroll
3e7ec67048 Roll Dart SDK from 0931bb8a43c8 to 9aca08d40398 (1 revision) (flutter/engine#46432) 
https://dart.googlesource.com/sdk.git/+log/0931bb8a43c8..9aca08d40398

2023-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-217.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-30 01:27:03 +00:00
gaaclarke
b674ebe6db [Impeller] fixed subpass filter coverage with image filters (flutter/engine#46431) 
fixes: https://github.com/flutter/flutter/issues/135777
fixes: https://github.com/flutter/flutter/issues/135766
fixes: https://github.com/flutter/flutter/issues/135212

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-29 18:00:38 -07:00
John McCutchan
af107ceba5 Add an AndroidManifest.xml flag to disable ImageReader backed Platform Views (flutter/engine#46430) 
An internal customer is seeing flickering on some high FPS phones.

While we try and reproduce / gain more knowledge of this problem this PR adds a AndroidManifest.xml flag to disable their usage.

The boolean flag is:
```
"io.flutter.embedding.android.DisableImageReaderPlatformViews"
```

Adding the following to your manifest will disable their usage:

```
<meta-data
  android:name="io.flutter.embedding.android.DisableImageReaderPlatformViews"
  android:value="true" />
```
 2023-09-30 00:33:33 +00:00
Casey Hillers
f61c3b45a2 Disable enableHardwareBufferRenderingTarget (flutter/engine#46425) 
* Causing flickering in web views
* Follow up of cl/569435819 for Google to unblock the rolls
 2023-09-29 22:56:07 +00:00
Tong Mu
c7f206212a Multi-view Rasterizer (flutter/engine#45512) 
This PR refactors `Rasterizer` so that it's more suitable for multi-view.

Design doc: [flutter.dev/go/multi-view-pipeline-and-rasterizer](http://flutter.dev/go/multi-view-pipeline-and-rasterizer)

With this change, `Rasterizer::DrawToSurfaces` has a structure that can handle drawing to multiple views, although the lack of some functionality still blocks it, mostly related to `ExternalViewEmbedder` and `RasterCache`. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-29 21:43:55 +00:00
skia-flutter-autoroll
62ddadfc03 Roll Dart SDK from 955a3a964621 to 0931bb8a43c8 (1 revision) (flutter/engine#46423) 
https://dart.googlesource.com/sdk.git/+log/955a3a964621..0931bb8a43c8

2023-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-216.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-29 21:28:56 +00:00
Jonah Williams
b8e79543f6 [Impeller] Redo simplify invert colors. (flutter/engine#46416) 
Now with fewer state bugs.

Fixes https://github.com/flutter/flutter/issues/135699
 2023-09-29 21:11:16 +00:00
Jackson Gardner
2c58573690 Use dart:_wasm constructs to avoid dependence on WebAssembly.Function (flutter/engine#46388) 
Use the newly exposed functionality in `dart:_wasm` to fix up two different hacks we have:
1) When creating an image from an image source, use `wasm:import` instead of `@Native` and pass the image source directly as an externref. (Direct wasm binding instead of a JS interop shim, yay).
2) When binding the surface callback, previously we were wrapping the callback in a JS function, and then using `WebAssembly.Function` to create a wasm function wrapper around that. Now, we can create a `WasmFuncRef` that is a direct reference to a dart function and pass that over. Now there are no intermediary JavaScript layers when skwasm calls back to us, and we no longer are dependent on the type reflection flag in Chrome.

This fixes https://github.com/flutter/flutter/issues/134556
 2023-09-29 20:52:36 +00:00
skia-flutter-autoroll
1848abe6c0 Roll Skia from 2d4045f55fd5 to a063eaeaf1e0 (6 revisions) (flutter/engine#46420) 
https://skia.googlesource.com/skia.git/+log/2d4045f55fd5..a063eaeaf1e0

2023-09-29 michaelludwig@google.com Revert "Reland "[skif] Draw FilterResults directly for layer restoration""
2023-09-29 kjlubick@google.com Add CI jobs to test external_client build of "buffet" options
2023-09-29 kjlubick@google.com Revert "Add fontations gm to Bazel build of viewer"
2023-09-29 kjlubick@google.com Add fast-reject when SkStream implements getLength() but not getPosition()
2023-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4d31920a095a to 8ac5d8e1a9fe (3 revisions)
2023-09-29 michaelludwig@google.com Reland "[skif] Draw FilterResults directly for layer restoration"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-29 20:46:27 +00:00
skia-flutter-autoroll
9cc5d3b14d Manual roll Dart SDK from e042e83c85a5 to 955a3a964621 (2 revisions) (flutter/engine#46412) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/e042e83c85a5..955a3a964621

2023-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-215.0.dev
2023-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-214.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-29 18:46:03 +00:00
auto-submit[bot]
38a714dd32 Reverts "[Impeller] simplify invert colors flag by supporting composed color filters." (flutter/engine#46414) 
Reverts flutter/engine#46391
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/135699

To avoid the ugly complicated code for conditionally applying both colorfilters, make the dl dispatcher handle merging these filters together in a defined order. The original bug is caused by not checking for invert colors in a CPU fast path.
 2023-09-29 18:01:26 +00:00