DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
226 Commits 882 Branches 1,069 Tags
Commit Graph

45 Commits

Author SHA1 Message Date
Ojan Vafai
ab8e1f98d5 Remove more support for floats from RenderBlockFlow. 
This doesn't change any behavior. Floats were already removed.
This is just removing effectively noop code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/692563004
 2014-11-03 12:40:09 -08:00
Ojan Vafai
ed0c01cdca Remove CSS Grid Layout and grid media queries. 
The two are unrelated, but it was easier to just grep for grid
and remove them all. Aside from the media query change, there
isn't any change in behavior since grid was behind a flag.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689853003
 2014-10-31 16:40:03 -07:00
Ojan Vafai
7d3feb3952 Remove line breaking to avoid window. 
Now that we don't have multi-column or pagination, this
is dead code. This also means we don't need to call
layoutBlockFlow in a loop.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/697713002
 2014-10-31 12:41:40 -07:00
Ojan Vafai
20dd8466c7 Remove border-fit. 
This just lets you size an element to it's content. We should
do this in a more generic way or let you override layout
and do it yourself.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/698613002
 2014-10-31 10:59:40 -07:00
Elliott Sprehn
c384b62ef1 Remove lots of dead virtuals from Element. 
Mostly form related things we don't need now.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/694703002
 2014-10-30 23:03:02 -04:00
Ojan Vafai
80efab4680 Remove straggling bits of listboxes. 
Also remove some straggling bits of textareas along the way.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/653993007
 2014-10-30 16:46:17 -07:00
Ojan Vafai
31c4826beb Remove createsAnonymousWrapper. It's dead code. 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/696493003
 2014-10-30 14:41:47 -07:00
Adam Barth
fc451b47eb Unfork Sky's trace events 
This CL remove the body of Sky's TraceEvent.h in favor of the version in base.
There's still some more of the system to unwind before we can remove all the
other boilerplate.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/691663002
 2014-10-30 09:39:46 -07:00
Ojan Vafai
0dfbf8aa38 Remove writing mode code from the linebox tree. 
Yo dawg, I heard you like ternaries.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/688233002
 2014-10-29 20:29:59 -07:00
Ojan Vafai
21bde7479d Remove final instances of WritingMode in Sky. 
After this patch, the only instance of WritingMode is in a comment.
No change in behavior.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/674073005
 2014-10-29 19:58:14 -07:00
Ojan Vafai
86ed666dc2 Get rid of isWritingModeRoot. 
This function always returns false now that we don't have writing modes.

TBR=esprehn@chromium.org

Remove flipForWritingMode.

It's a noop now that we don't have writing modes.

Review URL: https://codereview.chromium.org/688223002
 2014-10-29 19:53:05 -07:00
Ojan Vafai
13ffe46a43 Remove flipForWritingMode. 
It's a noop now that we don't have writing modes.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684393002
 2014-10-29 19:45:15 -07:00
Ojan Vafai
90b8d2e589 Remove text-combine. 
This is a vertical writing mode feature. Sky doesn't support
vertical writing mode.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/677843004
 2014-10-29 19:30:32 -07:00
Ojan Vafai
3b628f7d39 Delete a ton more dead vertical writing mode code. 
No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684383002
 2014-10-29 19:08:09 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code. 
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
 2014-10-29 19:06:59 -07:00
Elliott Sprehn
ca6775b3da Remove a lot of Widget APIs. 
We don't need a lot of the Widget API. I also removed the
visibility code which seems to have been broken when we
removed FrameView::show and hide(), which looks like it
would have broken image loading. Unfortuantely we don't
have pixel tests or tests that load images so I can't
test this yet. Even so it's a good simplificatin since
our system has no concept of hidden widgets.

R=abarth@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/691453002
 2014-10-29 15:23:10 -07:00
Elliott Sprehn
7c0366d891 Remove most of FloatingObject. 
This leaves some uses of FloatingObject*, but it doesn't
leave the impl of the class so it's all dead code passing
around null pointers. I'll remove that in a future patch.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/689733003
 2014-10-29 15:04:40 -07:00
Elliott Sprehn
e47b2bdb5f Remove a lot of floats related code. 
R=eseidel@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/678113005
 2014-10-29 14:08:55 -07:00
Ojan Vafai
959c404854 Remove all writing mode function arguments and remove writing mode from RenderStyle. 
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/683803006
 2014-10-29 12:18:30 -07:00
Ojan Vafai
8b0d9e8ac9 First past at removing writing mode. 
This removes the parsing and the enum. This leaves a bunch of
dead code around to fix in a followup.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689743002
 2014-10-29 12:17:11 -07:00
Ojan Vafai
ce9aa787cb Remove more frame-level scrolling machinery. 
This is all dead code. No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/678193005
 2014-10-28 19:27:52 -07:00
Elliott Sprehn
dc00d6678b Remove a lot of dead Scrollbar methods. 
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685003003
 2014-10-28 17:29:41 -07:00
Ojan Vafai
423d08cc86 More cleanup of dead code now that we don't have frame-level scrolling. 
No change in behavior. The overflowchanged event was never fired.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687783003
 2014-10-28 16:53:47 -07:00
Elliott Sprehn
b8843caa44 Remove concept of child Widgets. 
FrameView doesn't really need to know about the child widgets,
which are just Scrollbars now.

I also deleted some dead code from Widget and removed FrameWidget
since we don't need that abstraction now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685593005
 2014-10-28 16:53:12 -07:00
Elliott Sprehn
63d21b0287 Remove RenderWidget. 
This is part of the old iframe and plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/682263003
 2014-10-28 15:10:32 -07:00
Elliott Sprehn
2f329e05b0 Remove RenderPart. 
This was part of the old plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/686903003
 2014-10-28 15:01:27 -07:00
Ojan Vafai
c2ceb794d5 Get rid of slow repaint objects and main thread scrolling reasons. 
We will only have one scrolling path in Sky, so we don't need
machinery for mutiple scrolling codepaths.

Remove viewportConstrained plumbing.

Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/661633003
 2014-10-28 14:57:38 -07:00
Ojan Vafai
223c532e5f Remove viewportConstrained plumbing. 
Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688433003
 2014-10-28 14:28:39 -07:00
Ojan Vafai
f11504f4e8 Remove layerIsContainerForFixedPositionLayers. 
We don't have fixed position. We'll later need to remove this
functionality from cc as well.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680263005
 2014-10-28 13:59:57 -07:00
Ojan Vafai
054799183a Remove a bit more position:fixed plumbing. 
No change in behavior.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/688443003
 2014-10-28 12:56:42 -07:00
Eric Seidel
c32433111b Remove almost all of Oilpan 
The only things left are all the baseclasses
and macros in heap/Handle.h which are referenced
throughout all of core.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686783002
 2014-10-28 09:36:50 -07:00
Ojan Vafai
42ea48b379 Remove a bunch of fixed position dead code. 
There is not change in behavior here. Just removing dead
code now that we no longer support position:fixed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686653002
 2014-10-28 09:34:19 -07:00
Ojan Vafai
9423819dcc First pass at removing position:fixed. 
The root is never scrollable, so position:fixed doesn't
do anything anymore.

Also remove some dead frame-level scrolling code that interacted
with fixed position things.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/686633002
 2014-10-27 19:42:46 -07:00
Eric Seidel
64b5cb61a1 Remove all oilpan transitional types 
I used do-webcore-rename from Blink/WebKit
which is very good at doing this kind
of search-replace.

Also removed toRefPrtNativeArray after
conversion since it previously had two
separate flavors.  Both versions are no longer
used so I've removed the code until we
need one again.

https://www.irccloud.com/pastebin/5C16p5cE
is the diff I used to do-webcore-rename

TBR=abarth@chromium.org
 2014-10-27 14:13:01 -07:00
Ojan Vafai
995c857ce6 Remove a bunch of frame-level scrolling machinery. 
This just removing dead/noop code. No change in behavior.

R=abarth@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/681023002
 2014-10-27 13:10:04 -07:00
Ojan Vafai
ac7ea65ede Remove a bunch of unused or never-set settings. 
Just mechanical changes. No change in behavior.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/681553003
 2014-10-25 22:51:40 -07:00
Ojan Vafai
57a45f79ff Remove pinch viewports. 
Sky doesn't have concept of pinch zoom.

Remove more frame-level scrolling machinery.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/681583002
 2014-10-25 10:11:22 -07:00
Ojan Vafai
be4206ab28 Remove more frame-level scrolling machinery. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680703002
 2014-10-24 23:31:45 -07:00
Elliott Sprehn
8106700a04 Remove most of visited link support. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/667003003
 2014-10-24 23:22:02 -07:00
Adam Barth
969ccf4282 Remove compiler feature detection for = delete 
All supported compilers have this feature. Also remove unused macros for
OVERRIDE now that override are broadly supported.

R=esprehn@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/673403002
 2014-10-24 23:19:08 -07:00
Ojan Vafai
1728572222 Remove some more frame-level scrolling machinery. 
This includes removing a bunch of scrolling methods and
accessors on Window.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/677223002
 2014-10-24 23:16:28 -07:00
Adam Barth
e8c9ecc556 Use override and final instead of OVERRIDE and FINAL 2014-10-24 15:15:13 -07:00
Ojan Vafai
f45642cf8c Get rid of ScrollView. 
We only allow overflow scrolling. The frame isn't special.
This is a first step in making that happen. There's a lot of
code to remove after this patch, but this gets rid of
ScrollView and a bunch of frame-level scrolling code.

Had to add in a FrameWidget class so that Scrollbar.cpp had
a way of getting to FrameView::removeChild without pulling
a core class into platform. This might go away when we rip
out the Widget tree if we made it so that FrameView didn't
keep a list of Scrollbar instances.

Modified scrollbar.html to use overflow scrolling instead of
frame level scrolling. Once we get rid of the split between
Document and documentElement, we'll be able to make the root
element in the page scrollable as well (i.e. any child of the
Document).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/646273006
 2014-10-23 20:20:25 -07:00
Elliott Sprehn
2b1e6cfc42 Remove overflowchanged event. 
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/672353002
 2014-10-23 14:29:40 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00