25 Commits

Author SHA1 Message Date
Elliott Sprehn
c0bf67d1f9 Remove interactive content and form related API from HTMLElement.
In particular this inlines the accessKeyAction, removes isInteractiveContent()
which was for special casing certain elements in event dispatch, and removes
eventParameterName() which was only needed for inline event handlers.

I also moved Node::commonAncestor into NodeRenderingTraversal, the only
callers of it passed NodeRenderingTraversal::parent as the second argument,
it didn't make sense to have this generic thing.

R=abarth@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/693243002
2014-10-31 18:48:50 -07:00
Adam Barth
e18d99a0f3 Make clicks on <a> request a navigation
Currently our window manager isn't listening for these requests, but it would
work if we loaded sky in wm_flow or example_window_manager.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/695803003
2014-10-31 11:27:44 -07:00
Adam Barth
97565a73db Introduce blink::ServiceProvider
This CL is a warmup for making hyperlinks actually work. ServiceProvider lets
the embedder inject a bundle of services that are specific to the embedding
context (e.g., NavigatorHost). Services that are independent to the embedding
context can be injected via blink::Platform.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/696733003
2014-10-31 10:54:03 -07:00
Ojan Vafai
80efab4680 Remove straggling bits of listboxes.
Also remove some straggling bits of textareas along the way.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/653993007
2014-10-30 16:46:17 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code.
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
2014-10-29 19:06:59 -07:00
Ojan Vafai
53638e9784 Remove more frame-level scrolling machinery.
We don't need to know anymore whether the scroll was programmatic.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684063002
2014-10-28 20:10:59 -07:00
Ojan Vafai
e246934fb9 Remove more scrolling methods from FrameView.
No change in behavior. Just deleting dead code.
Also removes ScrollAnimatorNone since it's unused.
We'll need to bring some of this back, but we'll
do that when we get rid of composited scrolling.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/682363002
2014-10-28 17:38:08 -07:00
Elliott Sprehn
dc00d6678b Remove a lot of dead Scrollbar methods.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685003003
2014-10-28 17:29:41 -07:00
Ojan Vafai
423d08cc86 More cleanup of dead code now that we don't have frame-level scrolling.
No change in behavior. The overflowchanged event was never fired.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687783003
2014-10-28 16:53:47 -07:00
Elliott Sprehn
63d21b0287 Remove RenderWidget.
This is part of the old iframe and plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/682263003
2014-10-28 15:10:32 -07:00
Elliott Sprehn
2f329e05b0 Remove RenderPart.
This was part of the old plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/686903003
2014-10-28 15:01:27 -07:00
Ojan Vafai
c2ceb794d5 Get rid of slow repaint objects and main thread scrolling reasons.
We will only have one scrolling path in Sky, so we don't need
machinery for mutiple scrolling codepaths.

Remove viewportConstrained plumbing.

Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/661633003
2014-10-28 14:57:38 -07:00
Ojan Vafai
223c532e5f Remove viewportConstrained plumbing.
Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688433003
2014-10-28 14:28:39 -07:00
Ojan Vafai
f11504f4e8 Remove layerIsContainerForFixedPositionLayers.
We don't have fixed position. We'll later need to remove this
functionality from cc as well.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680263005
2014-10-28 13:59:57 -07:00
Ojan Vafai
42ea48b379 Remove a bunch of fixed position dead code.
There is not change in behavior here. Just removing dead
code now that we no longer support position:fixed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686653002
2014-10-28 09:34:19 -07:00
Ojan Vafai
9423819dcc First pass at removing position:fixed.
The root is never scrollable, so position:fixed doesn't
do anything anymore.

Also remove some dead frame-level scrolling code that interacted
with fixed position things.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/686633002
2014-10-27 19:42:46 -07:00
Eric Seidel
6b82826198 Remove various Heap* types.
Also removed a bunch of trace() methods which
I touched by accident.  Turns out they're
all very interconnected sadly.

I re-wrote Supplement to not use templates
in an earlier version of this patch
but hit some trouble with vtables
and decided to table that work
for a later time once more of oilpan
has been unwound.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/683703003
2014-10-27 18:19:46 -07:00
Eric Seidel
64b5cb61a1 Remove all oilpan transitional types
I used do-webcore-rename from Blink/WebKit
which is very good at doing this kind
of search-replace.

Also removed toRefPrtNativeArray after
conversion since it previously had two
separate flavors.  Both versions are no longer
used so I've removed the code until we
need one again.

https://www.irccloud.com/pastebin/5C16p5cE
is the diff I used to do-webcore-rename

TBR=abarth@chromium.org
2014-10-27 14:13:01 -07:00
Ojan Vafai
995c857ce6 Remove a bunch of frame-level scrolling machinery.
This just removing dead/noop code. No change in behavior.

R=abarth@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/681023002
2014-10-27 13:10:04 -07:00
Ojan Vafai
f9e0a463af Remove meta viewport and @viewport CSS rules.
We won't need configurations like this since we don't have things
like page zoom and a default width.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/654693004
2014-10-25 23:08:58 -07:00
Ojan Vafai
ac7ea65ede Remove a bunch of unused or never-set settings.
Just mechanical changes. No change in behavior.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/681553003
2014-10-25 22:51:40 -07:00
Adam Barth
e8c9ecc556 Use override and final instead of OVERRIDE and FINAL 2014-10-24 15:15:13 -07:00
Ojan Vafai
f45642cf8c Get rid of ScrollView.
We only allow overflow scrolling. The frame isn't special.
This is a first step in making that happen. There's a lot of
code to remove after this patch, but this gets rid of
ScrollView and a bunch of frame-level scrolling code.

Had to add in a FrameWidget class so that Scrollbar.cpp had
a way of getting to FrameView::removeChild without pulling
a core class into platform. This might go away when we rip
out the Widget tree if we made it so that FrameView didn't
keep a list of Scrollbar instances.

Modified scrollbar.html to use overflow scrolling instead of
frame level scrolling. Once we get rid of the split between
Document and documentElement, we'll be able to make the root
element in the page scrollable as well (i.e. any child of the
Document).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/646273006
2014-10-23 20:20:25 -07:00
Elliott Sprehn
725950ed7f Remove context menus.
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/640143004
2014-10-23 17:10:06 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00