19 Commits

Author SHA1 Message Date
Elliott Sprehn
c9e551fda5 Remove more stuff from Widget.
This removes even more APIs from widget. This also removes some methods
that had been broken and made infinitely recursive on FrameView.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/684353002
2014-10-29 15:57:18 -07:00
Elliott Sprehn
ca6775b3da Remove a lot of Widget APIs.
We don't need a lot of the Widget API. I also removed the
visibility code which seems to have been broken when we
removed FrameView::show and hide(), which looks like it
would have broken image loading. Unfortuantely we don't
have pixel tests or tests that load images so I can't
test this yet. Even so it's a good simplificatin since
our system has no concept of hidden widgets.

R=abarth@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/691453002
2014-10-29 15:23:10 -07:00
Ojan Vafai
53638e9784 Remove more frame-level scrolling machinery.
We don't need to know anymore whether the scroll was programmatic.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684063002
2014-10-28 20:10:59 -07:00
Ojan Vafai
ce9aa787cb Remove more frame-level scrolling machinery.
This is all dead code. No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/678193005
2014-10-28 19:27:52 -07:00
Ojan Vafai
e246934fb9 Remove more scrolling methods from FrameView.
No change in behavior. Just deleting dead code.
Also removes ScrollAnimatorNone since it's unused.
We'll need to bring some of this back, but we'll
do that when we get rid of composited scrolling.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/682363002
2014-10-28 17:38:08 -07:00
Ojan Vafai
423d08cc86 More cleanup of dead code now that we don't have frame-level scrolling.
No change in behavior. The overflowchanged event was never fired.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/687783003
2014-10-28 16:53:47 -07:00
Elliott Sprehn
b8843caa44 Remove concept of child Widgets.
FrameView doesn't really need to know about the child widgets,
which are just Scrollbars now.

I also deleted some dead code from Widget and removed FrameWidget
since we don't need that abstraction now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/685593005
2014-10-28 16:53:12 -07:00
Elliott Sprehn
63d21b0287 Remove RenderWidget.
This is part of the old iframe and plugin system, we don't need it.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/682263003
2014-10-28 15:10:32 -07:00
Ojan Vafai
c2ceb794d5 Get rid of slow repaint objects and main thread scrolling reasons.
We will only have one scrolling path in Sky, so we don't need
machinery for mutiple scrolling codepaths.

Remove viewportConstrained plumbing.

Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/661633003
2014-10-28 14:57:38 -07:00
Ojan Vafai
223c532e5f Remove viewportConstrained plumbing.
Sky doesn't have viewport constrained elements (no position:fixed).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688433003
2014-10-28 14:28:39 -07:00
Eric Seidel
c32433111b Remove almost all of Oilpan
The only things left are all the baseclasses
and macros in heap/Handle.h which are referenced
throughout all of core.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686783002
2014-10-28 09:36:50 -07:00
Eric Seidel
64b5cb61a1 Remove all oilpan transitional types
I used do-webcore-rename from Blink/WebKit
which is very good at doing this kind
of search-replace.

Also removed toRefPrtNativeArray after
conversion since it previously had two
separate flavors.  Both versions are no longer
used so I've removed the code until we
need one again.

https://www.irccloud.com/pastebin/5C16p5cE
is the diff I used to do-webcore-rename

TBR=abarth@chromium.org
2014-10-27 14:13:01 -07:00
Ojan Vafai
995c857ce6 Remove a bunch of frame-level scrolling machinery.
This just removing dead/noop code. No change in behavior.

R=abarth@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/681023002
2014-10-27 13:10:04 -07:00
Ojan Vafai
57a45f79ff Remove pinch viewports.
Sky doesn't have concept of pinch zoom.

Remove more frame-level scrolling machinery.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/681583002
2014-10-25 10:11:22 -07:00
Ojan Vafai
be4206ab28 Remove more frame-level scrolling machinery.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/680703002
2014-10-24 23:31:45 -07:00
Ojan Vafai
1728572222 Remove some more frame-level scrolling machinery.
This includes removing a bunch of scrolling methods and
accessors on Window.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/677223002
2014-10-24 23:16:28 -07:00
Adam Barth
e8c9ecc556 Use override and final instead of OVERRIDE and FINAL 2014-10-24 15:15:13 -07:00
Ojan Vafai
f45642cf8c Get rid of ScrollView.
We only allow overflow scrolling. The frame isn't special.
This is a first step in making that happen. There's a lot of
code to remove after this patch, but this gets rid of
ScrollView and a bunch of frame-level scrolling code.

Had to add in a FrameWidget class so that Scrollbar.cpp had
a way of getting to FrameView::removeChild without pulling
a core class into platform. This might go away when we rip
out the Widget tree if we made it so that FrameView didn't
keep a list of Scrollbar instances.

Modified scrollbar.html to use overflow scrolling instead of
frame level scrolling. Once we get rid of the split between
Document and documentElement, we'll be able to make the root
element in the page scrollable as well (i.e. any child of the
Document).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/646273006
2014-10-23 20:20:25 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00