gaaclarke
203f11647f
Update color assertions ( #154752 )
...
issue: https://github.com/flutter/flutter/issues/127855
This is a forward fix to help
https://github.com/flutter/engine/pull/54981 land.
It makes the following changes:
1) Removes hardcoded `Color.toString()` assumptions in asserts
1) Switches some lerp tests to use numbers that are more friendly to
uint8_t and floating point numbers
1) implements custom matchers for color
1) removes word wrapping for some asserts since it makes them fragile to
changes in `Color.toString()` invocations
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-10 15:32:40 -07:00
Polina Cherkasova
65e3007687
Remove opt out for CurvedAnimation. ( #147594 )
2024-05-28 16:35:29 -07:00
Valentin Vignal
c83d650de4
Fix memory leak in data table ( #146892 )
2024-04-18 07:16:32 -07:00
Taha Tesser
40dda2b4bb
Add DataColumn.headingRowAlignment for DataTable ( #144006 )
...
fixes [[`DataTable`] Unable to center the label of a DataColumn without side effects](https://github.com/flutter/flutter/issues/143340 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: MaterialApp(
home: Material(
child: DataTable(
columns: <DataColumn>[
DataColumn(
headingRowAlignment: MainAxisAlignment.center,
onSort: (int columnIndex, bool ascending) {},
label: const Text('Header'),
),
],
sortColumnIndex: 0,
rows: const <DataRow>[
DataRow(
cells: <DataCell>[
DataCell(Center(child: Text('Data'))),
],
),
],
),
),
),
);
}
}
```
</details>
### Center `DataColumn.mainAxisAlignment` without sort arrow

### Center `DataColumn.mainAxisAlignment` with sort arrow

2024-04-01 09:42:51 +00:00
Mitchell Goodwin
6190c5eea1
Widget state properties ( #142151 )
...
Fixes #138270 .
Moves the majority of the logic of MaterialStateProperties down to the widgets layer, then has the existing Material classes pull from the widgets versions.
2024-03-19 17:58:13 +00:00
Polina Cherkasova
baf739c8e6
Remove usage of testWidgetsWithLeakTracking. ( #140239 )
2023-12-15 14:13:31 -08:00
Polina Cherkasova
a7b69b069f
Unpin leak_tracker and handle breaking changes in API. ( #132352 )
2023-08-14 10:05:20 -07:00
Polina Cherkasova
e8b397caca
Setup leak tracking regression for material. ( #130169 )
2023-07-22 06:45:27 -07:00
Jason Simmons
e24c64d8ee
Fix DataTableThemeData.copyWith handling of dataRowHeight ( #126943 )
...
Fixes https://github.com/flutter/flutter/issues/126676
2023-05-16 21:44:24 +00:00
Taha Tesser
f7fb14ec58
Add customizable mouse cursor to DataTable ( #123128 )
2023-03-23 17:45:34 -07:00
David Neuy
3681b27a47
Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. ( #114338 )
...
* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props.
* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests.
* Fix analysis errors
* Review changes.
* Add asserts for dataRowMinHeight and dataRowMaxHeight
* Add asserts for dataRowMinHeight and dataRowMaxHeight
* Make dataRowHeight a computed getter
* Remove get only dataRowHeight from hashCode...
* Update deprecated after
* Add new line at end of AUTHORS
* Apply suggestions from code review
* Update packages/flutter/test/material/data_table_test.dart
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:32:29 +00:00
Hans Muller
a10e295a02
Added identical(a,b) short circuit to Material Library lerp methods ( #120829 )
2023-02-15 17:41:41 -08:00
Darren Austin
17e2fce1cf
Add const MaterialStatePropertyAll class. ( #104127 )
2022-05-19 09:35:33 -07:00
Taha Tesser
bafac1778b
Add missing ListTile tests, remove duplicate test and fix typos ( #101141 )
2022-04-06 09:36:10 -07:00
Taha Tesser
f263806c26
Fix Local DataTableTheme not being inherited by DataTable Widget ( #101112 )
2022-03-31 12:25:10 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint ( #81153 )
2021-05-19 09:54:02 -07:00
Chinmoy
bb43d2c632
Added checkboxHorizontalMargin to DataTable and PaginatedDataTable ( #71217 )
2021-02-17 15:11:52 -08:00
Per Classon
ee08c2278a
Add decoration parameter to DataTable and DataTableTheme ( #66640 )
...
* Add decoration parameter to DataTable and DataTableTheme
2020-10-09 14:11:17 +02:00
Alexandre Ardhuin
4acc790252
enable lint cast_nullable_to_non_nullable ( #67629 )
2020-10-08 21:05:43 +02:00
Darren Austin
3c21775c94
Migrate Material framework tests to null safety ( #67556 )
...
Migrate Material framework tests to null safety.
2020-10-07 16:44:00 -07:00
Alexandre Ardhuin
f551178408
migrate material to nullsafety ( #67166 )
...
* migrate material to nullsafety
* address review comments
* address review comments
* fix build
2020-10-06 11:36:50 +02:00
Per Classon
ba1aeb409e
Reland "Add DataTableTheme to allow for themable DataTables ( #64316 )" ( #65383 )
2020-09-10 13:00:04 -07:00
Per Classon
0bb1e573fc
Revert "Add DataTableTheme to allow for themable DataTables ( #64316 )" ( #65382 )
...
This reverts commit cb4b8677219482e3378b1b6bfeff1241a453ccb6.
2020-09-08 15:28:13 +02:00
Per Classon
cb4b867721
Add DataTableTheme to allow for themable DataTables ( #64316 )
2020-09-02 15:40:06 -07:00