Kate Lovett
a04fb324be
Bump Dart to 3.8 and reformat ( #171703 )
...
Bumps the Dart version to 3.8 across the repo (excluding
engine/src/flutter/third_party) and applies formatting updates from Dart
3.8.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-07 17:58:32 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
Michael Goderbauer
79506323b9
Adjust tools tests that would be broken by formatting ( #160393 )
...
These tests depend on line numbers that `dart format` is changing.
Pre-format the files in question and adjust the tests so they continue
to pass when the entire repo is formatted.
2024-12-17 00:34:00 +00:00
Ian Hickson
c7123c96cd
Factor out use of "print" in flutter_goldens ( #144846 )
...
This is part 5 of a broken down version of the #140101 refactor.
This PR removes direct use of `print` and replaces it with a callback.
2024-03-17 01:56:19 +00:00
Ian Hickson
77c3807c80
Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #140101 )" ( #141814 )
...
Reverts https://github.com/flutter/flutter/pull/140101
That PR somehow made non-matching gold tests not fail at HEAD.
Fixes https://github.com/flutter/flutter/issues/141880
- Blocked by https://github.com/flutter/flutter/issues/140169
- https://github.com/flutter/flutter/pull/141427
2024-01-19 20:29:11 +00:00
Ian Hickson
62f1594908
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #140101 )
...
Originally landed in https://github.com/flutter/flutter/pull/139549
Originally reverted in https://github.com/flutter/flutter/pull/140085
- Remove all use of global variables.
- Always pass in all dependencies, only create them in main or in tests.
- Pass in the "print" primitive.
- Make all network traffic retry (except when run locally, when it just auto-passes).
- Enable tests to be run in random order.
- Better error messages
2023-12-21 21:35:07 +00:00
auto-submit[bot]
91877c6345
Reverts "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal" ( #140085 )
...
Reverts flutter/flutter#139549
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
* Remove all use of global variables.
* Always pass in all dependencies, only create them in main or in tests.
* Pass in the "print" primitive.
* Make all network traffic retry (except when run locally, when it just auto-passes).
* Enable tests to be run in random order.
2023-12-13 20:20:20 +00:00
Ian Hickson
11a9cb7029
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #139549 )
...
* Remove all use of global variables.
* Always pass in all dependencies, only create them in main or in tests.
* Pass in the "print" primitive.
* Make all network traffic retry (except when run locally, when it just auto-passes).
* Enable tests to be run in random order.
2023-12-13 04:09:13 +00:00
Hans Muller
0d4b5ae122
Dev, examples/api, etc updated for Material 3 by default ( #129683 )
...
Updated tests in dev, examples/api, and tests/widgets to ensure that
they continue to pass when the default for `ThemeData.useMaterial3` is
changed to true.
This is the final set of changes required for
https://github.com/flutter/flutter/issues/127064 .
2023-06-28 09:41:58 -07:00
Danny Tuppeny
06952ba254
[flutter_tools] Add support for URI formats like ?line=x for "flutter test" ( #119740 )
...
* [flutter_tools] Add support for URI formats like ?line=x for "flutter test"
* Remove unnecessary function
* Handle parsing absolute paths on Windows
* Use Windows-style paths when running on Windows
* Fix paths in isFile
* Remove unnecessary clear
2023-02-27 19:13:00 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Alexander Markov
c63d797f94
Upgrade dependencies ( #117007 )
2022-12-14 13:13:05 -08:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky ( #114450 )" ( #114902 )
...
This reverts commit 53e6876226a7729531be7be4fa7321363c5a3b30.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky ( #114450 )
...
* allow marking a golden check as flaky
* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib
* Pause
* ++
* ++
* Analyzer therapy
* Once more with feeling
* Nits
* Review feedback
* Silly oops
* Test progress
* More tests
* Finish
* Nits
* Analyzer
* Review feedback
Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Flutter GitHub Bot
b748d1fb1a
Roll pub packages ( #107185 )
2022-07-07 17:46:07 +00:00
Alexander Markov
0cd8f3d02b
Restore expectations for dev/automated_tests/flutter_test/exception_handling_test ( #105778 )
2022-06-14 07:56:32 -07:00
gaaclarke
1f53fcd92b
manual engine->flutter roll ( #105344 )
2022-06-03 20:58:10 -07:00
Jonah Williams
90a592bf36
[flutter_tools] fix test asset loading ( #103667 )
2022-05-14 10:59:07 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Kate Lovett
a288bd5e3f
Re-land Assert golden files use the right extension ( #99082 )
2022-02-24 21:06:19 -08:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e8dbcb451cc6e969161032cc08da52a.
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. ( #91332 )
2021-10-07 09:53:03 -07:00
Jason Simmons
6b7f46353f
Manual roll of engine from e0011fa561d6 to 2118a1bb4bf0 (7 revisions) ( #84666 )
...
Includes updates to test expectations due to changes in the widget kernel
transformer.
2021-06-16 06:22:34 -07:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push ( #82564 )
2021-05-21 15:09:03 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push ( #82057 )" ( #82525 )
2021-05-14 12:09:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push ( #82057 )
2021-05-13 14:34:04 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push ( #81235 )" ( #81829 )
...
This reverts commit 35ad43f20caa71ec051a97bc8bc8fec552fb4452.
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push ( #81235 )
2021-05-03 17:14:03 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push ( #76288 )" ( #81226 )
...
This reverts commit c26ed03c8a77810136cc087ae60048ace062842d.
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push ( #76288 )
...
* Migrate to ChannelBuffers.push
* Move TestDefaultBinaryMessenger to its own file
* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. ( #77099 )
2021-03-03 17:29:02 -08:00
Michael Goderbauer
4a17405812
++ ( #74862 )
2021-01-28 09:59:05 -08:00
Sam Rawlins
6ea2806b71
Remove unnecessary imports ( #74382 )
2021-01-27 10:59:05 -08:00
Jia Hao
22f1700427
[flutter_tools] Make setting of CWD consistent for flutter test ( #74622 )
2021-01-25 22:34:03 -08:00
Jonah Williams
f4e79e6828
[flutter_tools] add support for dart defines to flutter test ( #70791 )
2020-11-18 14:52:49 -08:00
Ian Hickson
e10bdbbd9d
Fix RangeMaintainingScrollPhysics ( #65135 )
2020-09-07 11:40:03 -07:00
Michael Goderbauer
3b887bec47
Reland "migrate part of painting to nullsafety ( #62696 )" ( #62872 )
2020-08-04 16:06:04 -07:00
Yazeed Al-Khalaf
d41b1fbb50
✒ Spell Check All .md Files Related to Flutter 💙 ( #61564 )
...
* 🐛 Fix Spelling Issues in Main README.md
* 🐛 Fix spelling issues in dev README.md
* 🐛 Fix spelling issues in complex_layout README.md
* 🐛 Fix spelling issues in macrobenchmarks README.md
* 🐛 Fix spelling issues in platform_views_layout README.md
* 🐛 Fix spelling issues in test_Apps/stocks README.md
* 🐛 Fix spelling issues in bots README.md
* ✒ Spell Check dev/ci README.md
* ✒ Spell Check dev/ci/docker_linux README.md
* ✒ Spell Check dev/devicelab README.md
* ✒ Spell Check dev/docs README.md
* ✒ Spell Check dev/snippets README.md
* ✒ Spell Check dev/snippets/config/templates README.md
* ✒ Spell Check dev/tools/gen_keycodes README.md
* ✒ Spell Check dev/tools/vitool README.md
* ✒ Spell Check examples/catalog README.md
* ✒ Spell Check examples/flutter_view README.md
* ✒ Spell Check examples/image_list README.md
* ✒ Spell Check examples/layers README.md
* ✒ Spell Check examples/platform_channel README.md
* ✒ Spell Check examples/platform_channel_swift README.md
* ✒ Spell Check examples/platform_view README.md
* ✒ Spell Check packages/_flutter_web_build_script README.md
* ✒ Spell Check packages/flutter_localizations README.md
* ✒ Spell Check packages/flutter_tools README.md
* ✒ Spell Check CODE_OF_CONDUCT.md
* ✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md
* ✒ Spell Check dev/integration_test/android_views README.md
* ✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md
* ✒ Spell Check dev/integration_tests/flutter_gallery README.md
* ✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md
* ✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md
* ✒ Spell Check dev/integration_tests/ios_host_app README.md
* ✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md
* ✒ Spell Check dev/automated_tests/flutter_test README.md
* ✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md
* ✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md
* ✒ Spell Check packages/flutter_tools/doc/daemon.md
* ✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md
* ✒ Minimize line to 80 columns
* ✒ Minimize line to 80 columns
* ✒ Fix Typo
* ✒ Chnaged numbers to 1 for testing purposes
* ✒ Changed numbers to 1 for testing purposes
* ❌ Remove 'a' which is a typo
* ✒ Change a sentence to be better
* ✒ Remove 'a' which is a typo
* ✒ Fix small issue
* ✒ Fix small typo
* ✒ Fix some typos
* ❌ Remove trailing space
* ❌ Remove trailing space
* 🐛 Fix small typo
* ✒ Fix Typo
* 🐛 Fix small bug
2020-07-22 18:23:47 -07:00
Alexandre Ardhuin
49dc9b1227
fix tree ( #59257 )
2020-06-11 16:05:18 +02:00
Katarina Sheremet
3b067049ad
Support tags in testWidgets ( #55141 )
2020-04-28 15:49:01 -07:00
Katarina Sheremet
d8f353af5b
Support tags when running tests from command line ( #55152 )
2020-04-21 10:35:13 -07:00
Konstantin Scheglov
b0492cc976
Fix newly reported prefer_const_constructors lints. ( #54176 )
2020-04-07 08:59:01 -07:00
Alexander Aprelev
c6665e43da
Roll flutter engine to 10887c2abe7b7fe5866e84d6b63dd546f02fc963 ( #53669 )
...
* Update stack trace test expectations to adjust for a fix landed in dart sdk
* Include engine roll to 10887c2abe7b7fe5866e84d6b63dd546f02fc963
* Update column for the exception expectation
2020-03-31 11:28:03 -07:00
Alexandre Ardhuin
c2ae654ddf
enable avoid_single_cascade_in_expression_statements ( #51944 )
2020-03-05 08:03:26 +01:00
Jason Simmons
479e27c9f1
Update stack trace test goldens to handle engine builds with lazy async stacks ( #51216 )
...
The next engine roll will introduce --lazy-async-stacks, which affects the
contents of stack traces. This updates test expectations to match both the
old and new stack trace formats.
2020-02-21 12:05:30 -08:00
Clement Skau
3275adb7fb
Updates test expectations for stack traces. ( #51185 )
...
With --lazy-async-stacks the stack output has changed slightly so updating the expect files to match.
This is a follow-up to https://github.com/flutter/flutter/pull/51047 as a preparation for the next engine roll which will start enabling --lazy-async-stacks in JIT mode.
2020-02-21 13:38:56 +01:00
Dan Field
f81588a5a3
Roll engine bb01cb7faf26..77c5812d48b8 ( #50994 )
2020-02-18 16:33:55 -08:00
Alexandre Ardhuin
3800bb7b10
fix missing spaces in adjacent strings ( #49159 )
2020-01-21 16:43:03 -08:00
Ian Hickson
14145a4ec9
Try re-enabling all these tests. ( #46615 )
2019-12-09 18:58:02 -08:00
