Kate Lovett
9d96df2364
Modernize framework lints ( #179089 )
...
WIP
Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues
- Run `dart format .` in the right places.
Local analysis and testing passes. Checking CI now.
Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
htoor3
cb90ae4d97
[web] - Clean up skipped tests ( #124981 )
...
Fixes https://github.com/flutter/flutter/issues/124174
Fixes https://github.com/flutter/flutter/issues/124980
2023-04-18 19:31:18 +00:00
htoor3
68ed603bf2
[web] Skip temporarily broken test ( #124160 )
...
[web] Skip temporarily broken test
2023-04-05 22:58:56 +00:00
Yegor
c2409797ff
Roll chrome 96 attempt 2 ( #100073 )
...
* [web] roll Chromium dep to 96.2
Roll Chromium 96.2.
This is the second attempt to roll it. The previous attempt
(https://github.com/flutter/flutter/pull/99725 ) failed due to a LUCI
cache issue.
* cache-bust CIPD dependency by changing its name
* specify chrome_and_driver version in canvaskit tests
* fix CRC corruption in kTransparentImage
2022-03-17 13:23:43 -07:00
Zachary Anderson
1223e87f7b
Revert "[web] roll Chromium dep to 96.2 ( #99725 )" ( #99949 )
...
This reverts commit 0d4b73b2e87a7220fc872c51b1095506e9377ab9.
2022-03-10 21:09:49 -08:00
Yegor
0d4b73b2e8
[web] roll Chromium dep to 96.2 ( #99725 )
2022-03-10 15:45:20 -08:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push ( #82564 )
2021-05-21 15:09:03 -07:00
David Iglesias
c94f0bea65
[web] Make web integration tests shadow DOM aware. ( #82926 )
2021-05-20 16:14:02 -07:00
Yegor
2f3f5f09eb
FlutterDriver: deprecate enableAccessibility; redirect it to setSemantics; add setSemantics tests ( #82939 )
...
* deprecate enableAccessibility; redirect it to setSemantics
Co-authored-by: David Iglesias <ditman@gmail.com>
2021-05-19 22:10:26 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push ( #82057 )" ( #82525 )
2021-05-14 12:09:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push ( #82057 )
2021-05-13 14:34:04 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push ( #81235 )" ( #81829 )
...
This reverts commit 35ad43f20caa71ec051a97bc8bc8fec552fb4452.
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push ( #81235 )
2021-05-03 17:14:03 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push ( #76288 )" ( #81226 )
...
This reverts commit c26ed03c8a77810136cc087ae60048ace062842d.
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push ( #76288 )
...
* Migrate to ChannelBuffers.push
* Move TestDefaultBinaryMessenger to its own file
* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Michael Goderbauer
66d5a30de7
Reland "Migrate driver tests in example/ to NNBD ( #75022 )" ( #75264 )
2021-02-04 11:11:03 -08:00
Jenn Magder
6bd54753d7
Revert "Migrate driver tests in example/ to NNBD ( #75022 )" ( #75161 )
...
This reverts commit 50a8ecb7d6cd1fe34bd7982f463909fb649e98e8.
2021-02-01 11:45:07 -08:00
Michael Goderbauer
50a8ecb7d6
Migrate driver tests in example/ to NNBD ( #75022 )
2021-02-01 10:16:03 -08:00
Jonah Williams
55e183eb09
[null-safety] migrate hello_world to null safety ( #70112 )
...
* [null-safety] migrate flutter gallery to null safety
2020-11-09 12:51:04 -08:00
Angjie Li
d2fa384c31
Allow Developers to enable Accessibility testing on WebFlutterDriver and get the underlying webDriver ( #65051 )
2020-09-08 13:15:06 -07:00
Nurhan Turgut
9ba4eb04dd
[web] Smoke tests for web engine ( #51003 )
...
* smoke test for web
* fix comments and remove logs
* addressing reviewer comments
* fix analyzer issue
* running the test on cirrus
* cirrus yaml syntax error
* pub get for web_drivers
* go to the examples directory before running the flutter app
* cirrus is not able to find chromedriver. add a sleep to see if timing is the issue.
* run chrome driver in the background
* After PR #51084 , flutter drive command can build and run a web app. Clean flutter run command from cirrus.yml
* enable web
2020-02-24 13:09:21 -08:00
