Kate Lovett
9d96df2364
Modernize framework lints ( #179089 )
...
WIP
Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues
- Run `dart format .` in the right places.
Local analysis and testing passes. Checking CI now.
Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00
Kate Lovett
a04fb324be
Bump Dart to 3.8 and reformat ( #171703 )
...
Bumps the Dart version to 3.8 across the repo (excluding
engine/src/flutter/third_party) and applies formatting updates from Dart
3.8.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-07 17:58:32 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
gaaclarke
1ed8a0a0fd
Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 ( #155579 )
...
fixes https://github.com/flutter/flutter/issues/155578
A manual roll for https://github.com/flutter/flutter/pull/155560
2024-09-24 00:21:06 +00:00
engine-flutter-autoroll
0da0479702
Manual roll Flutter Engine from 4f4734cd48da to a0d650e37f5d (3 revisions) ( #131967 )
...
Manual roll requested by jacksongardner@google.com
Cannot build log URL because revision "a0d650e37f5d" is invalid: Luci builds of "Linux Web Framework tests" for a0d650e37f5d715468d8797519c622998ff5ab27 was FAILURE
2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from a0b59bac20fc to 8a3277696c52 (1 revision) (flutter/engine#44405 )
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZvUiUZL9vUp2LcvHG... to 3uzA1Z-yaMQE_Cz5f... (flutter/engine#44403 )
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 6dc76e862f90 to 7cf7e2da3557 (1 revision) (flutter/engine#44402 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZvUiUZL9vUp2 to 3uzA1Z-yaMQE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-05 01:22:17 +00:00
Dan Field
a21f33e7ad
avoid incorrect usage of TimelineTask ( #127527 )
...
This code was added based on a misunderstanding of the API surface.
2023-05-25 09:17:02 -07:00
Ian Hickson
245d6d45a1
Assert that runApp is called in the same zone as binding.ensureInitialized ( #122836 )
...
Assert that runApp is called in the same zone as binding.ensureInitialized
2023-03-16 22:33:09 +00:00
yaakovschectman
5bea4d9023
Revert "Assert that runApp is called in the same zone as binding.ensureInitialized ( #117113 )" ( #122830 )
...
Revert "Assert that runApp is called in the same zone as binding.ensureInitialized"
2023-03-16 20:29:13 +00:00
Ian Hickson
96f927fb0d
Assert that runApp is called in the same zone as binding.ensureInitialized ( #117113 )
...
Assert that runApp is called in the same zone as binding.ensureInitialized
2023-03-16 19:28:14 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Zachary Anderson
558b7e0042
Adjust test to tolerate additional trace fields ( #116914 )
...
* Adjust test to tolerate additional trace fields
* Fix syntax error
2022-12-12 13:21:24 -08:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jason Simmons
c62d103bb6
Always finish the timeline event logged by Element.inflateWidget ( #101794 )
2022-04-13 09:34:06 -07:00
Kenzie Davisson
14cf4daeab
Add debugging flags to enhance the timeline arguments for Build, Layout, and Paint ( #101602 )
2022-04-11 13:56:10 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import ( #101600 )
2022-04-08 12:56:45 -07:00
gaaclarke
35b18ba2e9
Made flag for debugging build time of user created widgets ( #100926 )
...
* Added a bool that allows us to limit debugProfileBuildsEnabled to user
created widgets.
* made it turned on by default
* switched to hashmap
* Cleaned everything up and added tests
* fixed an odd test where it wants to be able to add asserts and run in profile mode
* hixie feedback
* hixie2
* made it default to false
* updated docstring as per dans request
2022-04-05 10:54:21 -07:00
Michael Goderbauer
195a1cc413
Prepare dev (minus flutter_gallery) for use_super_parameters ( #100516 )
2022-03-29 12:52:42 -07:00
CHAHBOUN Mohammed
ba53b55949
Add child for placeholder widget ( #100372 )
2022-03-23 13:20:23 -07:00
Michael Goderbauer
61ac285608
[performance] Trace direct calls to inflateWidget ( #98277 )
2022-02-11 13:30:18 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Ian Hickson
840e109e07
Improve tracing ( #93086 )
2021-12-10 10:09:24 -08:00
Jason Simmons
c2f452c0a8
Reuse a TimelineTask for the scheduler frame and animate events ( #90168 )
2021-09-17 10:07:06 -07:00
Dan Field
c02961256a
Reland remove DefaultShaderWarmup ( #88455 )
2021-08-18 21:37:03 -07:00
Dan Field
c91a298249
Take DPR into account for image inversion ( #88309 )
2021-08-16 15:35:10 -07:00
Darren Austin
9c3cd40af2
Skip test audit for dev tests. ( #87147 )
2021-08-03 11:17:41 -07:00
Jim Graham
c451b6b0d7
Revert "Perform no shader warm-up by default ( #87126 )" ( #87238 )
...
This reverts commit 32c2e2bad9738798fc74e81133fffb8a84f751fb.
2021-07-29 15:14:16 -07:00
Dan Field
32c2e2bad9
Perform no shader warm-up by default ( #87126 )
2021-07-27 16:34:05 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Sam Rawlins
208bf4bc92
Remove "unnecessary" imports in dev/ ( #81004 )
2021-05-07 08:59:02 -07:00
Dan Field
362eefeeca
deflake image_painting_event_test ( #80871 )
2021-04-21 10:21:28 -07:00
Tong Mu
8a821ff0b5
Revert "Remove "unnecessary" imports. ( #79610 )" ( #80070 )
...
This reverts commit 98a96189937105f51e58e65543e2c6019a82cb33.
2021-04-08 11:36:30 -07:00
Sam Rawlins
98a9618993
Remove "unnecessary" imports. ( #79610 )
2021-04-07 22:34:03 -07:00
Michael Goderbauer
8364140e51
Clean-up ignores that are not ignoring anything (dev/ edition) ( #78490 )
2021-03-18 11:06:03 -07:00
Michael Goderbauer
15703fb93b
Migrate some dev/ things to null-safety ( #74861 )
2021-01-28 09:54:03 -08:00
Dan Field
d1538320d2
Roll packages to null safe (vm_service, test, etc.) ( #74671 )
2021-01-26 09:15:54 -08:00
Zachary Anderson
be82bb8fdf
Add tracing test to check default streams ( #74109 )
2021-01-16 18:27:09 -08:00
Dan Field
7eb8447485
Allow new methods to be added to ui.Image for tests ( #65876 )
...
Remove fake image implementations, add createTestImage to flutter_test
2020-09-22 11:55:39 -07:00
Ben Konyi
3a5a3eaf68
Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #62147 )
...
This reverts commit adc9dde3ba8563eebb824feb689f95eb947ab745.
- Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start
- Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
2020-07-29 10:05:40 -07:00
Ben Konyi
adc9dde3ba
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61975 )" ( #61993 )
...
This reverts commit f7a1c87ffdb9476c25cda487cb7232617be31b33.
2020-07-21 16:17:23 -07:00
Ben Konyi
f7a1c87ffd
Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61975 )
...
This reverts commit 4867f5931ff87a88fd3e89e7cf1b3cd9bd427670.
2020-07-21 15:44:38 -07:00
Ben Konyi
4867f5931f
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61882 )" ( #61909 )
...
This reverts commit 895b7ef6faf4e9c6ad641ad556855ff38fbd04bb.
2020-07-20 16:41:01 -07:00
Ben Konyi
895b7ef6fa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61882 )
...
This reverts commit 38fe887342f6c6bf40dd2c25442b892644e11a39.
2020-07-20 16:01:58 -07:00
Ben Konyi
38fe887342
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61633 )" ( #61641 )
...
This reverts commit 594c3541aae145123f964a60f3c30beda4a889c3.
2020-07-16 11:43:54 -07:00
Ben Konyi
594c3541aa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61633 )
...
This reverts commit a1a5a8f6357788a3f5e1c4e60a4ae9abf9e6aed2.
2020-07-16 11:38:17 -07:00
Ben Konyi
a1a5a8f635
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools ( #61276 )" ( #61395 )" ( #61498 )
...
This reverts commit f98184e487b933ef415f1257940a9dd576e9f073.
2020-07-14 16:32:49 -07:00
