Kate Lovett
9d96df2364
Modernize framework lints ( #179089 )
...
WIP
Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues
- Run `dart format .` in the right places.
Local analysis and testing passes. Checking CI now.
Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00
Jonah Williams
89311b7600
remove frame policy benchmark. ( #163245 )
...
This benchmark is a benchmark of the integration test binding which IMO
is not that important given that we continue to rely on flutter_driver
for actual performance metrics.
2025-02-13 20:26:04 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
Jim Graham
b51859ec33
Add benchmark for scrolling very long pictures ( #133434 )
...
This benchmark will track the performance of the RTree implementation to cull very large pictures down to just the portion visible on the screen.
2023-08-31 19:03:14 +00:00
Jonah Williams
dfa3d33328
[devicelab] track performance of animated image filter ( #115850 )
...
* [devicelab] track performance of animated image filter
* ++
* make animations repeat and add dispose
* make duration more consistently 10sec
2022-11-29 01:59:19 +00:00
Jim Graham
fe70a2b0f7
add page delays to the fullscreen versions of the textfield perf benchmarks ( #107746 )
2022-08-11 19:11:06 +00:00
ColdPaleLight
1919167540
Added benchmark for early removal of unused raster cache entris mecha… ( #107918 )
2022-07-20 19:13:06 +00:00
Jim Graham
dbe38eec21
Fix the scroll delta negation in the E2E version of picture_cache_perf benchmark ( #107678 )
2022-07-19 22:57:05 +00:00
Jim Graham
4d0fd4f894
Fix some issues with launching E2E benchmarks and add page delays in textfield benchmarks ( #107500 )
2022-07-14 08:14:08 +00:00
JsouLiang
f0200f0106
Add benchmark case for RasterCache ( #103338 )
2022-06-29 23:54:10 +00:00
Dan Field
be7a4227c7
Add a macrobenchmark for laying out text in a list ( #104736 )
2022-05-26 15:25:10 -07:00
wangying
b3d7a691f6
Add benchmark for clipper layers raster cache ( #102495 )
...
* Add clipper raster cache benchmarks
* fix ci test error
* Add PhysicalModel widget to test
* Set top margin adaptive screen height
* Remove PhysicalModel
2022-05-13 14:04:06 +08:00
Phil Quitslund
80849adee1
[dev, bots, examples] rename local functions with _s ( #102703 )
2022-04-28 10:44:06 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jonah Williams
fa96ddd427
add missing benchmark test file from https://github.com/flutter/flutter/pull/102532 ( #102544 )
2022-04-25 21:39:07 -07:00
Jim Graham
493323506f
add gradient benchmarks ( #101549 )
2022-04-08 17:20:22 -07:00
wangying
712abb08e2
Add benchmark for ShaderMask RasterCache ( #100127 )
2022-03-28 00:15:07 -07:00
wangying
b4040c867b
Add benchmark for ColorFilter raster cache ( #99542 )
2022-03-16 19:15:13 -07:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Jim Graham
9c934041bd
Add benchmarks to measure impact of alpha saveLayers in DisplayLists ( #97336 )
2022-01-27 13:25:17 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers ( #96422 )
2022-01-21 14:43:59 -08:00
Jim Graham
6c21e43608
stabilize the way we navigate multiple pages for E2E macrobenchmarks ( #96157 )
2022-01-05 10:05:05 -08:00
Jim Graham
ee204880a5
Opacity Peephole optimization benchmarks ( #94447 )
2021-12-01 01:39:02 -08:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Darren Austin
37bc722339
Migrate dev/benchmarks/macrobenchmarks to null safety. ( #85501 )
2021-06-29 11:49:27 -07:00
Dan Field
9c0bd18c40
Reland eliminate timeouts from integration tests ( #85141 )
2021-06-23 13:08:51 -07:00
Dan Field
69f2f8a18b
Revert "Remove per-test timeouts from integration tests ( #85098 )" ( #85133 )
...
This reverts commit b96c3c22ce350cd1999066601804c50a36e97ce6.
2021-06-23 08:17:27 -07:00
Dan Field
b96c3c22ce
Remove per-test timeouts from integration tests ( #85098 )
2021-06-23 07:17:28 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint ( #77398 )
2021-03-05 18:29:04 -08:00
Michael Goderbauer
0f568298d8
enable use_key_in_widget_constructors lint ( #77032 )
2021-03-02 10:14:02 -08:00
Sam Rawlins
6ea2806b71
Remove unnecessary imports ( #74382 )
2021-01-27 10:59:05 -08:00
LongCatIsLooong
cbe72db135
macrobenchmark: TextField with complex paragraph ( #73374 )
2021-01-12 15:44:01 -08:00
Ming Lyu (CareF)
92f82c7b88
Transport e2e based perforamnce test to integration_test and remove duplicate watchPerformance ( #67594 )
2020-10-17 20:37:03 -07:00
Ming Lyu (CareF)
76c0d69b14
migrate textfield_perf to e2e ( #64503 )
2020-10-02 14:47:03 -07:00
Ming Lyu (CareF)
db2532a949
migrate color_filter_and_fade_perf ( #64484 )
2020-10-01 17:32:02 -07:00
Ming Lyu (CareF)
f681fcf32b
migrate backdrop_filter_perf ( #64482 )
2020-09-22 19:52:02 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Ming Lyu (CareF)
b3f19a3e1a
migrate animated_placeholder_perf ( #64478 )
2020-09-16 07:47:03 -07:00
Ming Lyu (CareF)
51f1c98490
migrate cubic_bezier_perf to e2e ( #64487 )
2020-09-11 20:02:03 -07:00
Ming Lyu (CareF)
0f4d24819d
Revert "run the test longer time ( #64185 )" ( #64255 )
2020-08-20 15:06:08 -07:00
Ming Lyu (CareF)
1fc3a5e439
run the test longer time ( #64185 )
2020-08-19 21:23:59 -04:00
