5 Commits

Author SHA1 Message Date
Matan Lurey
55269c5fb5
last_engine_commit.ps1: Use $flutterRoot instead of $gitTopLevel (#172786)
Closes https://github.com/flutter/flutter/issues/172190.
2025-07-25 21:46:14 +00:00
Matan Lurey
90b655f10b
Fix use of Join-Path in last_engine_commit.ps1(poweshell) (#172242)
It worked on the Mac version of Powershell (`pwsh`) but [not on the
Windows
bots](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8709168939844960513/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout):
```txt
00:09 +37 ~2 -3: C:/b/s/w/ir/x/w/flutter/dev/tools/test/last_engine_commit_test.dart: returns the last engine commit [E]
  Failed running "powershell [C:\b\s\w\ir\x\t\last_engine_commit_test.88f44c9f\flutter\bin\internal\last_engine_commit.ps1]" (exit code = 1),
  stdout: 
  stderr: Join-Path : A positional parameter cannot be found that accepts argument 'internal'.
  At C:\b\s\w\ir\x\t\last_engine_commit_test.88f44c9f\flutter\bin\internal\last_engine_commit.ps1:29 char:35
  + ... SION_PATH = Join-Path $gitToplevel "bin" "internal" "release-candidat ...
  +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      + CategoryInfo          : InvalidArgument: (:) [Join-Path], ParentContainsErrorRecordException
      + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.JoinPathCommand
```

... this looks safer, I'll make sure it passes pre-subs this time.
2025-07-16 18:26:27 +00:00
Matan Lurey
0669195a3a
Use release-*.version to simplify last_engine_commit.sh (no branch operations) (#172236)
This fixes https://github.com/flutter/flutter/pull/172184 by considering
the last commit to `release-candidate-branch.version` as the significant
commit.

Otherwise, operationally, it works the same. I tested this on 3.35 and
it works as expected (where the current does not).
2025-07-16 17:11:46 +00:00
Matan Lurey
9e70384fba
Allow a release without engine cherrypicks (adds fallback logic) (#172184)
Closes https://github.com/flutter/flutter/issues/172179.
2025-07-15 22:26:23 +00:00
Matan Lurey
a401c5ddde
Add bin/internal/last_engine_commit.sh and tests. (#168387)
Towards https://github.com/flutter/flutter/issues/168273.

Once merged, the recipes branch (specifically `release_packager.py`) can
use this as a lint.

/cc @reidbaker
2025-05-06 19:04:18 +00:00