Jenn Magder
b2cc192a31
Add Gemini Code Assist review config and style guide ( #172785 )
...
- Initial config files for [Gemini Code Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
These config files are modified versions of the one already added to the
flutter/packages repo: https://github.com/flutter/packages/pull/9632
based on [the official
docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github ).
- Style guide has links to various contributing docs and style guides.
- Ignore paths associated with version pins and third_party to avoid
reviews on rolls and code that doesn't need modification. See
https://github.com/flutter/packages/pull/9647 .
- Add a note to the PR template to provide some notice/guidance to
contributors about how to use automated feedback, to clarify the role of
the automated reviews and hopefully minimize potential issues in case
the bot leaves incorrect feedback. This is a direct copy of the comment
introduced in https://github.com/flutter/packages/pull/9632 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-28 18:05:22 +00:00
Kate Lovett
777ce1b0da
Add clarification on review timelines in PR template ( #158345 )
...
Adds a reference to tree hygiene to help clarify expectations for review timelines.
2024-11-07 22:13:46 +00:00
Kate Lovett
62586dc09d
Update old wiki links ( #149544 )
...
Part of https://github.com/flutter/flutter/issues/145009
Finishes updating links in the repo that pointed to the old wiki
2024-06-17 17:26:08 +00:00
Kate Lovett
de97a05095
Update PR template for dart fix ( #143879 )
...
I don't know if this is feasible, but figured it was worth seeing.
Often times dart fixes are forgotten as part of the code review process.
I know some people ignore the PR template, but considered maybe a mention was warranted.
I've made the change reflected below:
2024-02-22 02:28:02 +00:00
Michael Goderbauer
76ef7af968
Provide exception for listing an issue. ( #137092 )
...
Latest example of an issue about a typo: https://github.com/flutter/flutter/issues/137080 . I don't think these are helpful, so we shouldn't be encouraging people to file these in order to submit a PR to fix 'em.
2023-10-27 20:32:52 +00:00
Ian Hickson
55185caeb8
Now that the bot is cleverer, we can make the PR template clearer ( #90414 )
2021-09-26 09:18:05 -07:00
Ian Hickson
b0c99fbdb2
Update PULL_REQUEST_TEMPLATE.md ( #76345 )
2021-02-21 18:36:04 -08:00
Abhishek Ghaskata
af0ea8c3db
Grammatical mistake on pull request template ( #75096 )
2021-02-12 09:38:25 -08:00
Ian Hickson
a8247e781b
Simplify the pull request template further. ( #73376 )
2021-01-06 15:49:04 -08:00
Yazeed Al-Khalaf
d41b1fbb50
✒ Spell Check All .md Files Related to Flutter 💙 ( #61564 )
...
* 🐛 Fix Spelling Issues in Main README.md
* 🐛 Fix spelling issues in dev README.md
* 🐛 Fix spelling issues in complex_layout README.md
* 🐛 Fix spelling issues in macrobenchmarks README.md
* 🐛 Fix spelling issues in platform_views_layout README.md
* 🐛 Fix spelling issues in test_Apps/stocks README.md
* 🐛 Fix spelling issues in bots README.md
* ✒ Spell Check dev/ci README.md
* ✒ Spell Check dev/ci/docker_linux README.md
* ✒ Spell Check dev/devicelab README.md
* ✒ Spell Check dev/docs README.md
* ✒ Spell Check dev/snippets README.md
* ✒ Spell Check dev/snippets/config/templates README.md
* ✒ Spell Check dev/tools/gen_keycodes README.md
* ✒ Spell Check dev/tools/vitool README.md
* ✒ Spell Check examples/catalog README.md
* ✒ Spell Check examples/flutter_view README.md
* ✒ Spell Check examples/image_list README.md
* ✒ Spell Check examples/layers README.md
* ✒ Spell Check examples/platform_channel README.md
* ✒ Spell Check examples/platform_channel_swift README.md
* ✒ Spell Check examples/platform_view README.md
* ✒ Spell Check packages/_flutter_web_build_script README.md
* ✒ Spell Check packages/flutter_localizations README.md
* ✒ Spell Check packages/flutter_tools README.md
* ✒ Spell Check CODE_OF_CONDUCT.md
* ✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md
* ✒ Spell Check dev/integration_test/android_views README.md
* ✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md
* ✒ Spell Check dev/integration_tests/flutter_gallery README.md
* ✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md
* ✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md
* ✒ Spell Check dev/integration_tests/ios_host_app README.md
* ✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md
* ✒ Spell Check dev/automated_tests/flutter_test README.md
* ✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md
* ✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md
* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md
* ✒ Spell Check packages/flutter_tools/doc/daemon.md
* ✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md
* ✒ Minimize line to 80 columns
* ✒ Minimize line to 80 columns
* ✒ Fix Typo
* ✒ Chnaged numbers to 1 for testing purposes
* ✒ Changed numbers to 1 for testing purposes
* ❌ Remove 'a' which is a typo
* ✒ Change a sentence to be better
* ✒ Remove 'a' which is a typo
* ✒ Fix small issue
* ✒ Fix small typo
* ✒ Fix some typos
* ❌ Remove trailing space
* ❌ Remove trailing space
* 🐛 Fix small typo
* ✒ Fix Typo
* 🐛 Fix small bug
2020-07-22 18:23:47 -07:00
Michael Goderbauer
4945a92fa6
Link to migration guide tempalte from pull request template ( #58027 )
2020-05-27 10:22:01 -07:00
Ian Hickson
2991dc28a5
Update PULL_REQUEST_TEMPLATE.md ( #45944 )
...
Update for recent changes to policies.
2019-12-03 14:19:29 -08:00
Ian Hickson
1123b71454
Update PULL_REQUEST_TEMPLATE.md ( #29621 )
...
This tries to make it more obvious when someone checks the "tests" box without actually having added tests.
2019-03-28 17:44:58 -07:00
Michael Goderbauer
0bc94f2644
Remove line breaks from PR template ( #28235 )
2019-02-20 18:40:33 -08:00
Michael Goderbauer
f603642471
Adds a template for Pull Requests ( #28224 )
2019-02-20 15:41:28 -08:00
