Matt Boetger
f197a3a00c
Android implementation of content sizing ( #176063 )
...
Android Embedder implementation of content sizing.
Fixes : #149033
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2025-12-08 19:42:24 +00:00
engine-flutter-autoroll
26f311ca5e
Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) ( #179587 )
...
https://dart.googlesource.com/sdk.git/+log/75899721aa42..3c07646cdcb9
2025-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-221.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 18:55:20 +00:00
Matt Boetger
e85ef5d206
Redistribute TESTOWNERS for Android team ( #179464 )
...
Redistributing test ownership among the Android team.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2025-12-08 18:47:20 +00:00
Ahmed Mohamed Sameh
61033df43a
Make sure that a CupertinoListTile doesn't crash in 0x0 environment ( #179109 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoListTile
widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-08 18:23:05 +00:00
Ahmed Mohamed Sameh
07e1cdd9ff
Make sure that a CupertinoFocusHalo doesn't crash in 0x0 environment ( #178773 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoFocusHalo widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-08 18:16:21 +00:00
Ahmed Mohamed Sameh
5be16afd7f
Make sure that a CupertinoPopupSurface doesn't crash in 0x0 environment ( #178929 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoPopupSurface widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-08 18:16:20 +00:00
engine-flutter-autoroll
b2de367c41
Roll Packages from b17d3ffb15fe to 33a9a810b5a2 (3 revisions) ( #179579 )
...
b17d3ffb15...33a9a810b5flutter/packages#10581 )
2025-12-05 engine-flutter-autoroll@skia.org Roll Flutter from
69d8710fadcd to 5b8720312a94 (42 revisions) (flutter/packages#10574 )
2025-12-05 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
19074d12f7ea to 66dd93f9a27f (12 revisions) (flutter/packages#10573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 15:57:23 +00:00
engine-flutter-autoroll
83bbd4bf75
Roll Fuchsia Linux SDK from XCoAHsnYnKrvuWU2o... to _pSztGZvEA3-Ry-GW... ( #179575 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 15:32:44 +00:00
Matthew Kosarek
4000ce2b4e
Implementation of TestWindowingOwner for testing multi-window ( #179355 )
...
## What's new?
This pull request makes it so that multi window applications can be
tested via `testWidgets`. This PR implements the following:
- A `_TestWindowingOwner` that is used by the
`TestWidgetsFlutterBinding`
- A `_TestRegularWindowController` implementation
- A `_TestDialogWindowController` implementation
- A `_TestFlutterView` and `_TestDisplay` for use by the controllers
- Proper `isActivated` status across controllers
- Proper minimization, maximization, and fullscreen status
- Proper sizing (based on constraints)
- Using the new testing abilities in the multiple windows example app
I have purposefully not implemented tooltip windows yet, as they are
still awaiting an implementation in Win32 to be useful.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-12-08 14:17:38 +00:00
engine-flutter-autoroll
0f591daf10
Roll Dart SDK from 11efe37089a7 to 75899721aa42 (2 revisions) ( #179573 )
...
https://dart.googlesource.com/sdk.git/+log/11efe37089a7..75899721aa42
2025-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-220.0.dev
2025-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-219.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 14:08:39 +00:00
engine-flutter-autoroll
2343d68ca4
Roll Skia from 0c016e4aefd5 to b1936c760645 (8 revisions) ( #179568 )
...
https://skia.googlesource.com/skia.git/+log/0c016e4aefd5..b1936c760645
2025-12-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 0c4f9996be15 to 4ccd968c8edc (12 revisions)
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from b106ae90b3af to cba978350d70
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 573c40e1c4e7 to f875023015f9 (16 revisions)
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from dbe64e426552 to 23f08c798e68 (18 revisions)
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 9c01087f9cc7 to 4b94f92c03e7
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 77cefc24c76a to c5ea487bec78
2025-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from ef6c6a80c82e to e7c1ac2e1c20
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 08:32:35 +00:00
engine-flutter-autoroll
6ff4a4acd9
Roll Skia from 3c5f9e0c9269 to 0c016e4aefd5 (1 revision) ( #179565 )
...
https://skia.googlesource.com/skia.git/+log/3c5f9e0c9269..0c016e4aefd5
2025-12-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 06:23:29 +00:00
engine-flutter-autoroll
5f00eaa2f8
Roll Dart SDK from 1a6c6f6398af to 11efe37089a7 (1 revision) ( #179564 )
...
https://dart.googlesource.com/sdk.git/+log/1a6c6f6398af..11efe37089a7
2025-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-218.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 06:15:28 +00:00
engine-flutter-autoroll
2bc9a741b3
Roll Skia from 4830855b6f84 to 3c5f9e0c9269 (1 revision) ( #179561 )
...
https://skia.googlesource.com/skia.git/+log/4830855b6f84..3c5f9e0c9269
2025-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 542 to 543
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-07 18:45:26 +00:00
engine-flutter-autoroll
97409aa3ac
Roll Skia from d5a6b6af6d12 to 4830855b6f84 (1 revision) ( #179557 )
...
https://skia.googlesource.com/skia.git/+log/d5a6b6af6d12..4830855b6f84
2025-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ff6522d5bafb to 53bfad22ed15 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-07 13:23:27 +00:00
engine-flutter-autoroll
bf52dac6fb
Roll Fuchsia Linux SDK from KilaJW3p3J_0yUDtV... to XCoAHsnYnKrvuWU2o... ( #179551 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-07 10:09:28 +00:00
engine-flutter-autoroll
1b1e836721
Roll Skia from 33b32cecb287 to d5a6b6af6d12 (1 revision) ( #179540 )
...
https://skia.googlesource.com/skia.git/+log/33b32cecb287..d5a6b6af6d12
2025-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from dc26c74f7350 to ff6522d5bafb (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 23:37:31 +00:00
engine-flutter-autoroll
613df4d714
Roll Dart SDK from ea201dd2ef12 to 1a6c6f6398af (1 revision) ( #179539 )
...
https://dart.googlesource.com/sdk.git/+log/ea201dd2ef12..1a6c6f6398af
2025-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-217.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 22:00:32 +00:00
engine-flutter-autoroll
d0c3b9c8ae
Roll Dart SDK from d1d30ee8d5a0 to ea201dd2ef12 (1 revision) ( #179537 )
...
https://dart.googlesource.com/sdk.git/+log/d1d30ee8d5a0..ea201dd2ef12
2025-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-216.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 14:32:31 +00:00
engine-flutter-autoroll
c60a8aa279
Roll Dart SDK from 30c906aa00f2 to d1d30ee8d5a0 (1 revision) ( #179534 )
...
https://dart.googlesource.com/sdk.git/+log/30c906aa00f2..d1d30ee8d5a0
2025-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-215.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 09:50:41 +00:00
engine-flutter-autoroll
6d6e752110
Roll Skia from dccd48c6c6ab to 33b32cecb287 (2 revisions) ( #179531 )
...
https://skia.googlesource.com/skia.git/+log/dccd48c6c6ab..33b32cecb287
2025-12-06
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1995d08ee26a to dc26c74f7350 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 04:44:25 +00:00
engine-flutter-autoroll
4a36e904c4
Roll Fuchsia Linux SDK from vDeTl_KBeLJY8nCAx... to KilaJW3p3J_0yUDtV... ( #179530 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 04:40:21 +00:00
engine-flutter-autoroll
88da4d6270
Roll Dart SDK from f3690c23d422 to 30c906aa00f2 (2 revisions) ( #179529 )
...
https://dart.googlesource.com/sdk.git/+log/f3690c23d422..30c906aa00f2
2025-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-214.0.dev
2025-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-213.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 04:40:19 +00:00
engine-flutter-autoroll
723fec502f
Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) ( #179524 )
...
https://skia.googlesource.com/skia.git/+log/e19670f70406..dccd48c6c6ab
2025-12-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-05 kjlubick@google.com Revert "[rust bmp] Define single action
in BUILD.gn for rust targets"
2025-12-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-05 senorblanco@chromium.org Partially fix Graphite/Dawn build
for Wasm.
2025-12-05 vigneshv@google.com SkCrabbyAvifCodec: Guard codec access
with a static lock
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-06 01:08:23 +00:00
Ahmed Mohamed Sameh
5acb8b9d83
Make sure that a CupertinoFormRow doesn't crash in 0x0 environment ( #178979 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoFormRow
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:54:49 +00:00
Ahmed Mohamed Sameh
3a2b6821ee
Make sure that a CupertinoContextMenuAction doesn't crash in 0x0 envi… ( #178721 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoContextMenuAction widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:53:02 +00:00
Ahmed Mohamed Sameh
0951f1e181
Make sure that a CupertinoRadio doesn't crash in 0x0 environment ( #179378 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoRadio
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:53:01 +00:00
Ahmed Mohamed Sameh
a9d7ab92b6
Make sure that a CupertinoSearchTextField doesn't crash in 0x0 enviro… ( #179487 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoSearchTextField widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:51:02 +00:00
Ahmed Mohamed Sameh
fe9a609404
Make sure that a CupertinoPicker doesn't crash in 0x0 environment ( #179258 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoPicker
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:47:49 +00:00
Ahmed Mohamed Sameh
2300260b28
Make sure that a CupertinoAlertDialog doesn't crash in 0x0 environment ( #178858 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoAlertDialog widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:46:25 +00:00
Ahmed Mohamed Sameh
c4daa1f597
Make sure that a CupertinoListTileChevron doesn't crash in 0x0 enviro… ( #179165 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoListTileChevron widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:46:25 +00:00
Ahmed Mohamed Sameh
a8577f996b
Make sure that CupertinoNavigationBar doesn't crash in 0x0 environment ( #179235 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoNavigationBar widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:46:25 +00:00
Ahmed Mohamed Sameh
ebd263e392
Replace dropdown button with dropdown menu ( #179095 )
...
This is my attempt to handle #179094 .
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:46:25 +00:00
Ahmed Mohamed Sameh
362361484d
Make sure that a CupertinoCheckbox doesn't crash in 0x0 environment ( #178630 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoCheckbox
widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:46:25 +00:00
Ahmed Mohamed Sameh
393c51fb46
Make sure that a CupertinoApp doesn't crash in 0x0 environment ( #178610 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoApp
widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:45:03 +00:00
Ahmed Mohamed Sameh
fed50b185e
Make sure that a CupertinoButton doesn't crash in 0x0 environment ( #178629 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoButton
widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:45:03 +00:00
Ahmed Mohamed Sameh
b9424acf3c
Make sure that a CupertinoTimerPicker doesn't crash in 0x0 environment ( #178857 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoTimerPicker widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:45:03 +00:00
Ahmed Mohamed Sameh
2a88fa0f23
Make sure that a CupertinoScrollbar doesn't crash in 0x0 environment ( #179442 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoScrollbar widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-05 23:45:03 +00:00
engine-flutter-autoroll
dcf78a0889
Roll Dart SDK from 0fcab487446d to f3690c23d422 (1 revision) ( #179517 )
...
https://dart.googlesource.com/sdk.git/+log/0fcab487446d..f3690c23d422
2025-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-212.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 22:06:19 +00:00
Bruno Leroux
2296b2b2a2
Update several comments related to theme normalization ( #179457 )
...
## Description
This PR updates some comments in various widgets to reflect the changes
related to Theme normalization.
## Related Issue
Related to https://github.com/flutter/flutter/issues/91772
## Tests
- Documentation only
2025-12-05 22:02:18 +00:00
Dev TtangKong
362b1de299
Reimplemented StretchingOverscrollIndicator with Simulation ported from Android 12. ( #173849 )
...
Fixed an issue #169659
This PR improves the StretchingOverscrollIndicator to better match
native Android behavior.
- Previously, the stretch effect worked well only for slow dragging, and
during fast flings it was absent or felt clipped.
- Implemented a Simulation-based animation that responds naturally to
both slow drags and high-velocity flings.
- The result closely resembles the native Android overscroll behavior
while maintaining Flutter's performance characteristics.
This change ensures that momentum-based gestures produce a more natural
and intuitive overscroll experience, especially for users accustomed to
native Android scroll views.
## Fling
[fling](https://github.com/user-attachments/assets/3944eef3-baaa-47df-82ca-9c49d4283fe4 )
## Pull And Reduce
Also, a very similar animation is implemented when pulling as well.
[pull](https://github.com/user-attachments/assets/2a3025dc-0996-403d-b58b-d07f25487cda )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-05 21:54:29 +00:00
engine-flutter-autoroll
27969a6dcf
Roll Skia from a31411879251 to e19670f70406 (1 revision) ( #179511 )
...
https://skia.googlesource.com/skia.git/+log/a31411879251..e19670f70406
2025-12-05 ccameron@chromium.org SkCodec: Remove some accessors to
skcms_ICCProfile
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 21:53:43 +00:00
John "codefu" McDole
83c66ef408
chore: mark tests as flaky ( #179518 )
...
fixes #179514
2025-12-05 21:04:20 +00:00
engine-flutter-autoroll
1ccdcc2da5
Roll Dart SDK from 42fe3327abca to 0fcab487446d (3 revisions) ( #179506 )
...
https://dart.googlesource.com/sdk.git/+log/42fe3327abca..0fcab487446d
2025-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-211.0.dev
2025-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-210.0.dev
2025-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-209.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 17:14:28 +00:00
engine-flutter-autoroll
5b8720312a
Roll Packages from d39e481da550 to b17d3ffb15fe (3 revisions) ( #179505 )
...
d39e481da5...b17d3ffb1510687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Removes internal native library Dart proxy
(flutter/packages#10537 )
2025-12-04 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Removes internal native library Dart proxy
(flutter/packages#10528 )
2025-12-04 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Removes internal native library Dart proxy
(flutter/packages#10527 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 15:54:32 +00:00
bungeman
144af688e0
Move target_cpu into use_rbe block in Fuchsia build ( #179458 )
...
The `target_cpu` local is only used if `use_rbe` is true. Move its
definition into the `use_rbe` block to avoid local build issues like
```
$ ninja -C engine/src/out/ci/fuchsia_debug_arm64
ERROR at //build/toolchain/fuchsia/BUILD.gn:13:19: Assignment had no effect.
target_triple = "aarch64-unknown-fuchsia"
^------------------------
You set the variable "target_triple" here and it was unused before it went
out of scope.
```
2025-12-05 14:05:08 +00:00
engine-flutter-autoroll
c22da9ac8f
Roll Skia from fe6bf18a3f6b to a31411879251 (3 revisions) ( #179499 )
...
https://skia.googlesource.com/skia.git/+log/fe6bf18a3f6b..a31411879251
2025-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 85c01c01f6cf to 1995d08ee26a (6 revisions)
2025-12-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 12:34:33 +00:00
Kostia Sokolovskyi
6e9567e973
Force WASM single threading in Chrome extensions. ( #179400 )
...
Fixes https://github.com/flutter/flutter/issues/177974
### Description
- Forces WASM single-threading when running a web app as a Chrome
extension.
| BEFORE | AFTER |
| - | - |
| <video alt="before"
src="https://github.com/user-attachments/assets/4b67fce6-4bd7-4646-a0db-dc6ad2ec70aa "
/> | <video alt="after"
src="https://github.com/user-attachments/assets/3f0df9c5-7524-40db-a631-776777f855f9 "/>
|
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
2025-12-05 10:23:30 +00:00
engine-flutter-autoroll
d1a80fe9f8
Roll Skia from aea282ea0bcd to fe6bf18a3f6b (7 revisions) ( #179489 )
...
https://skia.googlesource.com/skia.git/+log/aea282ea0bcd..fe6bf18a3f6b
2025-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 882a54755450 to 0c4f9996be15 (9 revisions)
2025-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 77f89f1efc1a to dbe64e426552 (22 revisions)
2025-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 0f45bef5b019 to 573c40e1c4e7 (7 revisions)
2025-12-05
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d7967c8594a6 to 85c01c01f6cf (6 revisions)
2025-12-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 08:17:27 +00:00
DoLT
017974987f
fix: check both pointer count and action before reusing MotionEvent ( #178528 )
...
Fix issue https://github.com/flutter/flutter/issues/169486
## Problem
After [PR #178015 ](https://github.com/flutter/flutter/pull/178015 ) was
merged, Android platform views experience gesture blocking after
multi-touch operations (e.g., pinch-to-zoom). The issue occurs because:
1. PR #178015 changed framework behavior to encode original pointer
count in events
2. Framework now sends events with **different actions** than the
original MotionEvent
- Example: Framework sends `ACTION_MOVE (2)` while original event is
`ACTION_POINTER_UP (6)`
3. The existing engine code only checked **pointer count**, not action
4. This caused the engine to use original event with wrong action →
gesture blocked
### Logs Showing the Issue
trackedEvent.pointerCount=2, touch.pointerCount=2, trackedEvent.action=6
(ACTION_POINTER_UP), touch.action=2 (ACTION_MOVE) → Pointer counts
MATCH, using original event → WebView receives ACTION_POINTER_UP but
expects ACTION_MOVE → Gesture blocked! ❌
2025-12-05 07:25:16 +00:00
