John "codefu" McDole
6e07446365
Update more missing ninja deps ( #178079 )
...
Post-submits with no pre-submit equiv:
* Linux build_android_host_app_with_module_source
Missed in #178054
2025-11-05 20:56:30 +00:00
John "codefu" McDole
004aabad68
Add ninja / cmake deps to failing tests ( #178054 )
...
Ubuntu 22 rollout triggered some failing tests due to missing deps.
2025-11-05 19:09:20 +00:00
Mouad Debbar
3fd81edbf1
[web] Don't add webparagraph suite to CI ( #177681 )
...
Fix `generate-builder-json` to only include test bundles that are needed
by enabled test suites.
## Before this PR
The script was unconditionally including all test bundles in CI. The
result is that the `dart2js-canvaskit-experimental-webparagraph` bundle
was being generated, even though it was only required by the
`chrome-dart2js-experimental-webparagraph-ui` suite, which had
`enable-ci: false`.
## After this PR
The script starts by finding all test suites with `enable-ci: true`,
then only adds the bundles required by those suites.
2025-11-05 00:25:32 +00:00
Srivats Venkataraman
1444c2846f
Fixing broken link in engine readme ( #177987 )
...
Fixes : #177797
The engine readme had a broken link this PE fixes the broken link
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [] I updated/added relevant documentation (doc comments with `///`).
- [] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-05 00:22:08 +00:00
Gray Mackall
59cb93f14d
Print reason for adb command failure in verified input test (attempt 3) ( #178005 )
...
Print the logs, so we can see why the command is failing in ci. Seems
[the last pr](https://github.com/flutter/flutter/pull/177961 ) was wrong
about the reason, should have just done this in the first place
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-11-05 00:20:35 +00:00
Luke Memet
c652b53819
Fix ReorderableList items jumping when drag direction reverses mid-animation ( #173241 )
...
When rapidly dragging items in a ReorderableList before animations
complete, items would jump to their expected positions rather than
smoothly transitioning.
## Problem
<p align="center">
<img
src="https://github.com/user-attachments/assets/0efb250c-2960-4942-959f-59eccc20cefb "
alt="demo2" width="250">
</p>
The issue occurs when a reorder animation is interrupted by starting a
new drag operation. The interrupted animation would reset to the
starting position of the original animation rather than capturing the
current animated position, causing a visual jump.
## Solution
This PR fixes the issue by:
1. Storing the previous target offset before updating to a new target
2. When an animation is interrupted, calculating the actual current
position based on the animation's progress
3. Using this calculated position as the new starting point for the next
animation
<p align="center">
<img
src="https://github.com/user-attachments/assets/c24e4834-1c6b-41c1-8f44-17b4c79e0993 "
alt="demo2" width="250">
</p>
This PR is part of a series of `ReorderableList` enhancements I've
developed for [TimeFinder](https://timefinder.app ):
- #172740
- #172380
- #172739
- #172738
Fixes #173243
## Code Changes
```dart
// Before
_startOffset = offset;
// After
final double currentAnimValue = Curves.easeInOut.transform(_offsetAnimation\!.value);
final Offset currentPosition = Offset.lerp(_startOffset, previousTarget, currentAnimValue)\!;
_startOffset = currentPosition;
```
This ensures smooth transitions without visual jumping, making rapid
reordering gestures feel more responsive and natural.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [migration
guide] as needed.
- [x] All existing and new tests are passing.
- [x] The analyzer (`flutter analyze --flutter-repo`) does not report
any problems on my PR.
- [x] I am willing to follow-up on review comments in a timely manner.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[migration guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#create-a-migration-guide
2025-11-05 00:20:33 +00:00
Mohellebi abdessalem
3667ffd182
Replace deprecated withOpacity in overflow_bar.0.dart example ( #177813 )
...
<img width="859" height="148" alt="Screenshot 2025-10-27 at 20 09 35"
src="https://github.com/user-attachments/assets/daf13a7b-a157-410a-9feb-dc466128c5a1 "
/>
Similar PRs:
- #177374
- #177490
- #177540
- #177541
- #177542
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-05 00:19:08 +00:00
Mohellebi abdessalem
d33f8e8426
Replace deprecated withOpacity in data_table.1.dart example ( #177812 )
...
<img width="859" height="148" alt="Screenshot 2025-10-27 at 20 09 35"
src="https://github.com/user-attachments/assets/daf13a7b-a157-410a-9feb-dc466128c5a1 "
/>
Similar PRs:
- #177374
- #177490
- #177540
- #177541
- #177542
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-05 00:17:55 +00:00
Mohellebi abdessalem
f02ae41636
Replace deprecated withOpacity in switch.1.dart example ( #177811 )
...
<img width="859" height="148" alt="Screenshot 2025-10-27 at 20 09 35"
src="https://github.com/user-attachments/assets/daf13a7b-a157-410a-9feb-dc466128c5a1 "
/>
Similar PRs:
- #177374
- #177490
- #177540
- #177541
- #177542
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-05 00:17:55 +00:00
engine-flutter-autoroll
87598a3574
Roll Skia from c89b6118266b to 2ff897e9b440 (6 revisions) ( #177999 )
...
https://skia.googlesource.com/skia.git/+log/c89b6118266b..2ff897e9b440
2025-11-04 kjlubick@google.com Add ability to override fuzzing engine
2025-11-04 senorblanco@chromium.org Dawn build: find the correct version
of ninja.
2025-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f3586b617bd9 to 74082a714350 (2 revisions)
2025-11-04 mike@reedtribe.org Fix pathdata build
2025-11-04 kjlubick@google.com Sync Dawn's DEPS via gclient and point
CMake at them
2025-11-04 mike@reedtribe.org remove misspelling
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 19:36:10 +00:00
Gray Mackall
8124e89c63
Fix verified input test in CI (attempt 2) ( #177961 )
...
From looking closer at the logs, I think the failure is that the adb
command isn't specifying the device. This passes locally because I only
have one device, but then fails on CI.
I missed this when looking at the
[logs](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8699178787799824705/+/u/run_android_verified_input_test/stdout )
originally:
```
[2025-11-03 15:50:32.967241] [STDOUT] stdout: [ ] test_driver/main_test.dart 34:40 main.<fn>.<fn>
[2025-11-03 15:50:35.960806] [STDOUT] stdout: [+2993 ms] Expected: <0>
[2025-11-03 15:50:35.960858] [STDOUT] stdout: [ ] Actual: <1>
[2025-11-03 15:50:35.960898] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 149:31 fail
[2025-11-03 15:50:35.960906] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 144:3 _expect
[2025-11-03 15:50:35.960946] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 56:3 expect
[2025-11-03 15:50:35.960957] [STDOUT] stdout: [ ] test_driver/main_test.dart 44:7 main.<fn>
```
The failed expect there isn't related to the verification, it is an
expect on the exit code of the adb command:
https://github.com/flutter/flutter/blob/master/dev/integration_tests/android_verified_input/test_driver/main_test.dart#L44
So the adb command is failing on CI. I think it is for the reason above.
This change makes the device id available to the driver tests that are
run by the devicelab harness, and then pipes it through to ADB.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Gray Mackall <mackall@google.com>
2025-11-04 18:32:28 +00:00
walley892
a41146c205
Replace rendering for solid color circles (both filled and stroked) to use SDFs ( #177482 )
...
Replace rendering for solid color circles (both filled and stroked) to
use SDFs. This change improves the visual quality of circle borders,
especially on platforms without MSAA support.
- Adds a vertex and fragment shader that support SDF rendering for both
filled and stroked circles.
- Adds a `Contents` subclass, `CircleContents` that uses these shaders
for rendering
- Modifies `Canvas::DrawCircle` to use this new contents for drawing
circles
- Only supports circles with a solid color paint. Everything else
continues to use the existing behavior
- Adds a playground test that interactively scales circles to ensure
fidelity at all scales.
- Partially fixes https://github.com/flutter/flutter/issues/167181
Before (Android emulator):
<img width="236" height="245" alt="Screenshot 2025-10-23 at 4 26 18 PM"
src="https://github.com/user-attachments/assets/566de15e-95d3-4b5d-963c-1cebba4aeb50 "
/>
<img width="383" height="394" alt="Screenshot 2025-10-23 at 4 29 32 PM"
src="https://github.com/user-attachments/assets/7ca29be6-89f4-43e6-bd9a-c4ec4179ab1c "
/>
After (Android emulator):
<img width="383" height="394" alt="Screenshot 2025-10-23 at 8 48 17 PM"
src="https://github.com/user-attachments/assets/f138bedc-edc3-4cba-a982-bd3020d9e44c "
/>
<img width="236" height="245" alt="Screenshot 2025-10-23 at 4 24 44 PM"
src="https://github.com/user-attachments/assets/6b5bec91-e3aa-4daa-9233-3a407b1f1378 "
/>
## Pre-launch Checklist
- [x ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x ] I read and followed the [Flutter Style Guide], including
[Features we expect every widget to implement].
- [x ] I signed the [CLA].
- [x ] I listed at least one issue that this PR fixes in the description
above.
- [x ] I updated/added relevant documentation (doc comments with `///`).
- [x ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x ] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-04 18:31:14 +00:00
engine-flutter-autoroll
5bf59c4a4b
Roll Fuchsia Linux SDK from vxK5obzfr1X9P2kSh... to mpsxF1gd-jbKNvmpm... ( #177996 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 18:25:18 +00:00
Jason Simmons
36f0ee7741
Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section ( #177523 )
...
Target names must begin with a platform name. The LUCI configuration
scripts in https://flutter.googlesource.com/infra will look up the
platform name in platform_properties to obtain the dimensions for the
bot where the target will be scheduled.
See https://github.com/flutter/flutter/issues/177465
2025-11-04 18:25:18 +00:00
engine-flutter-autoroll
74e10bb4be
Roll Packages from 1a7075b09ef1 to 3d926aa495d3 (6 revisions) ( #177998 )
...
1a7075b09e...3d926aa495flutter/packages#10348 )
2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from
6f8abdd77820 to 027f2e410241 (26 revisions) (flutter/packages#10335 )
2025-11-03 stuartmorgan@google.com [google_sign_in] Remove use of OCMock
(flutter/packages#10290 )
2025-11-03 stuartmorgan@google.com [interactive_media_ads] Pin iOS
dependency maximum (flutter/packages#10349 )
2025-10-30 magder@google.com [webview_flutter_wkwebview] Remove
specialization of 'map' to fix Swift warning (flutter/packages#9810 )
2025-10-30 engine-flutter-autoroll@skia.org Roll Flutter from
df72035ba8c5 to 6f8abdd77820 (16 revisions) (flutter/packages#10327 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 18:25:17 +00:00
Sigurd Meldgaard
511c4e0bfc
Remove dead code from snippet_generator ( #174440 )
...
Randomly stumbled on code that seems to no longer have clients.
2025-11-04 18:17:10 +00:00
Mouad Debbar
e5d5c01850
[web] Upgrade Chrome to 141 (for engine tests) ( #177743 )
...
- Update Chrome to 141 for web engine tests.
- Improve image codec tests so they exercise all frames.
- Skip the frames of certain images that are known to cause problems in
Chrome.
Chrome bug for the problematic images:
https://issues.chromium.org/456445108
Fixes https://github.com/flutter/flutter/issues/168686
2025-11-04 18:07:04 +00:00
Mohellebi abdessalem
a913d39131
Replace deprecated withOpacity in chip_animation_style.0.dart example ( #177834 )
...
<img width="859" height="148" alt="Screenshot 2025-10-27 at 20 09 35"
src="https://github.com/user-attachments/assets/daf13a7b-a157-410a-9feb-dc466128c5a1 "
/>
Similar PRs:
- #177374
- #177490
- #177540
- #177541
- #177542
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-04 17:05:25 +00:00
engine-flutter-autoroll
3afcc38602
Roll Skia from 03612114a36d to c89b6118266b (1 revision) ( #177991 )
...
https://skia.googlesource.com/skia.git/+log/03612114a36d..c89b6118266b
2025-11-04 ccameron@chromium.org Add SMPTE ST 2094-50 HDR metadata
support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 16:51:12 +00:00
Mouad Debbar
0f9853333f
[web] Delete unused futurize util ( #177861 )
2025-11-04 15:48:13 +00:00
engine-flutter-autoroll
afbfaf9356
Roll Skia from 1a179581af75 to 03612114a36d (1 revision) ( #177984 )
...
https://skia.googlesource.com/skia.git/+log/1a179581af75..03612114a36d
2025-11-04 robertphillips@google.com [graphite] Add Caps::toString
virtual
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 14:17:28 +00:00
engine-flutter-autoroll
285045d6cf
Roll Skia from 150f844e83fb to 1a179581af75 (3 revisions) ( #177979 )
...
https://skia.googlesource.com/skia.git/+log/150f844e83fb..1a179581af75
2025-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from a212e75c2058 to db35dc6c2135 (14 revisions)
2025-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from bc96cfcbee13 to d4d10c202a39 (15 revisions)
2025-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 2ecad23f4965 to ff55757db3ba (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 11:23:39 +00:00
engine-flutter-autoroll
b08709f14d
Roll Dart SDK from 6f1bd8d05b1d to 156bf665dba4 (2 revisions) ( #177976 )
...
https://dart.googlesource.com/sdk.git/+log/6f1bd8d05b1d..156bf665dba4
2025-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-93.0.dev
2025-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-92.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 09:41:28 +00:00
engine-flutter-autoroll
cb07e44960
Roll Skia from 3990fc40acdf to 150f844e83fb (1 revision) ( #177964 )
...
https://skia.googlesource.com/skia.git/+log/3990fc40acdf..150f844e83fb
2025-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from fd4a777ae606 to f3586b617bd9 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 05:41:43 +00:00
engine-flutter-autoroll
2572596009
Roll Skia from 85adfd3b8e75 to 3990fc40acdf (1 revision) ( #177962 )
...
https://skia.googlesource.com/skia.git/+log/85adfd3b8e75..3990fc40acdf
2025-11-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 03:47:28 +00:00
Gray Mackall
40c70dabda
Fix isHeif crash ( #177944 )
...
Fixes https://github.com/flutter/flutter/issues/177942
I did not repro the crash but this looks like a pretty simple NPE that
can be fixed by swapping the `.equals` order.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-11-04 02:51:10 +00:00
engine-flutter-autoroll
af5d3a50f9
Roll Dart SDK from ac065fcd782e to 6f1bd8d05b1d (1 revision) ( #177955 )
...
https://dart.googlesource.com/sdk.git/+log/ac065fcd782e..6f1bd8d05b1d
2025-11-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-91.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 01:54:08 +00:00
engine-flutter-autoroll
9e4e27e1ac
Roll Skia from 001516d132f0 to 85adfd3b8e75 (4 revisions) ( #177958 )
...
https://skia.googlesource.com/skia.git/+log/001516d132f0..85adfd3b8e75
2025-11-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-03 michaelludwig@google.com [graphite] Address comments to
https://skia-review.googlesource.com/c/skia/+/1080957
2025-11-03 lukasza@google.com Revert "[rust png] Support for using
SkPngRustEncoder from `FuzzEncoders.cpp`."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-04 01:52:26 +00:00
Ben Konyi
0359d52908
[ Widget Preview ] Add analytic event that's reported when the previewer is opened ( #177949 )
...
With the addition of IDE support, the widget previewer is often started
by default by IDE plugins, even if users don't open the previewer. This
change adds an additional analytics event which is reported once the
widget preview application is loaded and connects to the DTD instance.
Fixes https://github.com/flutter/flutter/issues/177948
2025-11-04 00:57:53 +00:00
Flutter GitHub Bot
2c6fe3987d
Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be unflaky ( #171144 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
dynamic_path_stroke_tessellation_perf__timeline_summary"
}
-->
The issue https://github.com/flutter/flutter/issues/170784 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20dynamic_path_stroke_tessellation_perf__timeline_summary%22 ).
This test can be marked as unflaky.
2025-11-04 00:56:10 +00:00
engine-flutter-autoroll
6c7167c8b2
Roll Skia from da9b8fb01101 to 001516d132f0 (6 revisions) ( #177951 )
...
https://skia.googlesource.com/skia.git/+log/da9b8fb01101..001516d132f0
2025-11-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-03 michaelludwig@google.com [graphite] PaintParams can represent
image shaders without heap allocations
2025-11-03 mike@reedtribe.org Add flag to switch to pathdata backend
2025-11-03 lukasza@chromium.org [rust png] Support for using
SkPngRustEncoder from `FuzzEncoders.cpp`.
2025-11-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-11-03 vigneshv@google.com SkCrabbyAvifCodec: Set rgb format
explicitly for all cases
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-03 23:54:41 +00:00
b-luk
cfbeed68a3
Add FAQ entry about our attempts to remove Skia image codecs. ( #177947 )
...
Adds a FAQ entry referencing our investigations into removing Skia image
codecs in https://github.com/flutter/flutter/issues/144438 and
https://github.com/flutter/flutter/issues/177863 .
2025-11-03 22:50:22 +00:00
Hannah Jin
ed19f47bec
Add blockAccessibilityFocus flag ( #175551 )
...
Add a new flag for a11y focusable
- Accessibility focus, which is the focus used by screen readers like
TalkBack and VoiceOver, is different from input focus.
- Our current logic use some existing flags to decide if a node is
accessibilty focusable. like "if it's a slider / has a check state / has
keyboard focus/..., then it's a11y focusable"
ecbb115ae3/engine/src/flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java (L98)https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-03 22:18:33 +00:00
Ahmed Mohamed Sameh
43f7a1ea1b
Make sure that a SnackBarAction doesn't crash in 0x0 environment ( #177899 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SnackBarAction
widget.
2025-11-03 21:30:23 +00:00
Ahmed Mohamed Sameh
77920e15d7
Make sure that a SelectionArea doesn't crash in 0x0 environment ( #177876 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SelectionArea
widget.
2025-11-03 21:30:22 +00:00
Gray Mackall
eeff54df43
Speculative fix for android_verified_input_test ( #177937 )
...
This test passes when run locally as instructed in the README for the
devicelab
```
../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t android_verified_input_test
```
but fails on CI:
https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20android_verified_input_test/106/overview
```
[2025-11-03 11:08:04.090018] [STDOUT] stdout: [ ] Original error: ext.flutter.driver: (-32000) Service connection disposed
[2025-11-03 11:08:04.090156] [STDOUT] stdout: [ ] Original stack trace:
[2025-11-03 11:08:04.090199] [STDOUT] stdout: [ ] #0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:268:34)
[2025-11-03 11:08:04.091572] [STDOUT] stdout: [ ] #1 VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1950:25)
[2025-11-03 11:08:04.091647] [STDOUT] stdout: [ ] #2 VmService._call (package:vm_service/src/vm_service.dart:1962:8)
[2025-11-03 11:08:04.091674] [STDOUT] stdout: [ ] #3 VmService.callServiceExtension (package:vm_service/src/vm_service.dart:1901:14)
[2025-11-03 11:08:04.091693] [STDOUT] stdout: [ ] #4 VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:327:12)
[2025-11-03 11:08:04.091713] [STDOUT] stdout: [ ] #5 FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:573:13)
[2025-11-03 11:08:04.091733] [STDOUT] stdout: [ ] #6 main.<anonymous closure> (file:///opt/s/w/ir/x/w/rc/tmpv6pcbna2/flutter%20sdk/dev/integration_tests/android_verified_input/test_driver/main_test.dart:28:57)
[2025-11-03 11:08:04.091750] [STDOUT] stdout: [ ] <asynchronous suspension>
[2025-11-03 11:08:04.091767] [STDOUT] stdout: [ ] #7 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:242:9)
[2025-11-03 11:08:04.091784] [STDOUT] stdout: [ ] <asynchronous suspension>
[2025-11-03 11:08:04.092408] [STDOUT] stdout: [ ] #8 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:240:7)
[2025-11-03 11:08:04.092472] [STDOUT] stdout: [ ] <asynchronous suspension>
[2025-11-03 11:08:04.092502] [STDOUT] stdout: [ ] #9 Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:282:9)
```
Try copying this configuration used by other tests as a speculative fix.
I can't get this test to kick off in presubmit, so I suppose we will
just try this. The test is marked bringup anyways so it won't block the
tree if this doesn't help.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-11-03 20:43:30 +00:00
Kaylee Lubick
aed2e42321
[skia] Explicitly disable XPS backend ( #177050 )
...
Skia's working on some breaking changes to the XPS backend. Flutter does
not use this backend explicitly, but it is being compiled in on Windows
builds. We can explicitly disable it all the time to avoid any
unexpected breakages from impacting Flutter.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-03 20:35:41 +00:00
engine-flutter-autoroll
e72c5371c9
Roll Dart SDK from 2d3aa1d5cb9f to ac065fcd782e (2 revisions) ( #177927 )
...
https://dart.googlesource.com/sdk.git/+log/2d3aa1d5cb9f..ac065fcd782e
2025-11-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-90.0.dev
2025-11-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-89.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-03 19:53:22 +00:00
Loïc Sharma
14ca24d85e
Improve Impeller's docs in the top-level docs folder ( #177848 )
2025-11-03 19:47:52 +00:00
Ahmed Mohamed Sameh
4d10e0c169
Make sure that GridTile doesn't crash in 0x0 environment ( #175321 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the GridTile widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-03 19:44:08 +00:00
Ahmed Mohamed Sameh
0908c2e225
Make sure that a Slider doesn't crash in 0x0 environment ( #177882 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Slider widget.
2025-11-03 19:42:15 +00:00
Andrew Marshall
a642eddae1
fix(impeller): fix params to glDiscardFrameBufferEXT ( #175589 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Fix parameters to
[glDiscardFramebufferEXT](https://registry.khronos.org/OpenGL/extensions/EXT/EXT_discard_framebuffer.txt )
when an application-defined framebuffer is bound. The `is_default_fbo`
parameter is set to `true` if `color_gles.IsWrapped()` is true, however
according to the GLES spec, a non-default framebuffer is bound if
`glBindFramebuffer(GL_FRAMEBUFFER, framebuffer)` is called with
`framebuffer != 0`:
> _The namespace for framebuffer objects is the unsigned integers, with
zero re-
served by OpenGL ES to refer to the default framebuffer. A framebuffer
object
is created by binding an unused name to the target FRAMEBUFFER._
To reproduce this issue, run a flutter application with
`--enable-impeller` on a platform where `glDiscardFramebufferEXT` is
available. The following error is reported:
```
[FATAL:flutter/impeller/renderer/backend/gles/proc_table_gles.h(43)] Fatal GL Error GL_INVALID_ENUM(1280) encountered on call to glDiscardFramebufferEXT
```
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
closes #175588
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-03 19:13:27 +00:00
engine-flutter-autoroll
f863e87821
Roll Skia from 56a10bf56ee0 to da9b8fb01101 (5 revisions) ( #177928 )
...
https://skia.googlesource.com/skia.git/+log/56a10bf56ee0..da9b8fb01101
2025-11-03 michaelludwig@google.com [graphite] Refactor helper function
for local matrix shader block adding
2025-11-03 michaelludwig@google.com Add predefined encoded origin
inverse function
2025-11-03 kjlubick@google.com Port tests to explicitly
serialize/deserialize images in SkPictures
2025-11-03 kjlubick@google.com Fix fuzzer targets and subsequent
bitrotting
2025-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2d7962129e3b to fd4a777ae606 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-03 19:05:09 +00:00
chunhtai
bcd359d746
wires up set application locale to web engine ( #177284 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
fixes https://github.com/flutter/flutter/issues/98948
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-03 18:42:26 +00:00
jesswrd
e43443ba93
[Android 16] Update linux_android_emu_unstable to use avd rev 7 ( #177854 )
...
Updated `linux_android_emu_unstable` configs to use the [latest
build_id](https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/build_id:8699815938758639089 )
with rev 7.
Will audit if test targets pass on rev 7. Expecting
`android_engine_vulkan_tests` to be flaky and the rest to pass.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-03 18:08:26 +00:00
Ahmed Mohamed Sameh
8e567b884d
Make sure that a CheckedPopupMenuItem doesn't crash in 0x0 environment ( #177545 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CheckedPopupMenuItem widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-11-03 18:08:25 +00:00
engine-flutter-autoroll
82ff983ee5
Roll Fuchsia Linux SDK from Ynp3qiXocK8WLTjlb... to vxK5obzfr1X9P2kSh... ( #177917 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-03 16:13:33 +00:00
Adam Spivak
b87e863b80
Update pubspec.yaml.tmpl build version tracker on line 5 ( #173600 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Added a default +1 build number to the version field in
pubspec.yaml.tmpl (line 5). This ensures consistent versioning behavior
across iOS and Android for newly created Flutter projects.
Why this change?
- On iOS, CFBundleShortVersionString (marketing version) must be numeric
(major.minor.patch) and does not include the build number unless
explicitly set.
- On Android, the version name and version code can both be set,
allowing more flexibility in representing the build number.
- Without a build number in pubspec.yaml, Android defaults to +1 while
iOS omits it, resulting in inconsistent version strings between
platforms.
Benefits
- Consistency: Both iOS and Android builds will start with the same
format, e.g., 1.0.0+1.
- Clarity: New projects have a visible build number by default, reducing
confusion for new developers.
- Best Practice: Aligns with Apple’s numeric marketing version rules
while preserving Android’s flexibility.
Developers can still override --build-name and --build-number as needed
for custom versioning.
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
Fixes #165325
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Ben Konyi <bkonyi@google.com>
2025-11-03 16:10:09 +00:00
Jason Simmons
633d6591a1
[Impeller] Fix the source rectangle used when rendering an AtlasContents with the strict mode for nine-patch images ( #177860 )
...
* Convert the source rectangle to texture coordinates and shrink it to
adjust for linear filtering
* Pass the coordinates of the rectangle in the order expected by the
Porter-Duff shader
Fixes https://github.com/flutter/flutter/issues/176544
2025-11-03 15:38:15 +00:00
August
bf4957815e
docs: Default Splash / Loading screen for web app in index.html ( #177084 )
...
Contributes to #102178
First I wanted to cherry-pick
https://github.com/flutter/gallery/pull/630 . But then I noticed that
there already exists a documentation:
https://docs.flutter.dev/platform-integration/web/initialization .
As most users won't expect this to be customizable (as myself), I wrote
a little docs in the index.html.tmpl that link to this page.
https://docs.flutter.dev/platform-integration/web/initialization#example-display-a-progress-indicator
I still think a default splash screen should be in place, e.g. by
providing the `flutter_bootstrap.js` by default (?)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-03 15:21:21 +00:00
