Kate Lovett
9d96df2364
Modernize framework lints ( #179089 )
...
WIP
Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues
- Run `dart format .` in the right places.
Local analysis and testing passes. Checking CI now.
Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
Matan Lurey
c7dd6419d9
Remove RepaintBoundary that is no longer needed. ( #159232 )
...
Closes https://github.com/flutter/flutter/issues/66006 .
From what I can tell in the multi-view effort a variation of
https://github.com/flutter/flutter/pull/88609 already landed, meaning
that the current device-pixel-ratio is being used (as the tests in
#88609 are now passing), and I believe that means we can remove the
override/hack.
Will rely on "Google Testing" to run a TGP internally, or do so myself
if necessary.
2024-11-21 17:50:46 +00:00
Jason Simmons
9bf7d7bb35
Do not paint a description label when rendering an integration test ( #153875 )
...
Fixes https://github.com/flutter/flutter/issues/153624
2024-08-29 17:08:38 +00:00
Michael Goderbauer
60a87d0798
Sync Lints ( #127976 )
...
Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml :
* removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us)
* enabled the new `no_self_assignments` and fixed one issue triggered by the lint.
2023-06-02 04:27:17 +00:00
pdblasi-google
e22e8f2528
Updates integration_test to no longer use TestWindow ( #122358 )
...
Updates `integration_test` to no longer use `TestWindow`
2023-03-14 18:19:20 +00:00
Kaushik Iska
d5f372bccd
Request DartPerformanceMode.latency during transitions ( #110600 )
2022-09-07 12:54:06 -04:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e8dbcb451cc6e969161032cc08da52a.
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. ( #91332 )
2021-10-07 09:53:03 -07:00
Dan Field
c5861cfb56
Revert "Fix DPR in test view configuration ( #88609 )" ( #88889 )
...
This reverts commit 5feee0d8faec96872377b74a90fda0c1fc77930f.
2021-08-25 10:09:03 -07:00
Dan Field
5feee0d8fa
Fix DPR in test view configuration ( #88609 )
2021-08-24 14:26:54 -07:00
Cody Goldberg
ab6ce71402
[flutter_test/integration_test] added setSurfaceSize test coverage ( #82712 )
...
This PR includes an updated test case for integration_test and a new test case for flutter_test to ensure that hit tests transform properly when using setSurfaceSize, for both the IntegrationTestWidgetsFlutterBinding and LiveTestWidgetsFlutterBinding bindings.
2021-07-30 13:47:20 -07:00
Kaushik Iska
df3fe587e8
Validate that min frame number is numeric ( #86498 )
2021-07-15 17:11:09 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors ( #83744 )
2021-06-02 10:14:06 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Chris Bracken
3e7e06512c
Correct misspellings throughout the codebase ( #79500 )
2021-04-01 10:04:03 -07:00
Dan Field
d3092541e2
Reland integration_test NNBD ( #75074 )
...
* Revert "Revert "NNBD integration_test (#74922 )" (#75030 )"
This reverts commit 87b043658bc3eb16cf1032cbc9b0ba6484271cea.
* fix bad merge issues
2021-02-01 10:19:14 -08:00
Ian Hickson
87b043658b
Revert "NNBD integration_test ( #74922 )" ( #75030 )
...
This reverts commit cca9592f0e22b95cdc727cdc73bdc50fa74458b5.
2021-01-29 15:46:21 -08:00
Dan Field
cca9592f0e
NNBD integration_test ( #74922 )
2021-01-29 14:31:06 -08:00
Dan Field
9eacc9ef62
drop mockito for integration_test ( #74770 )
2021-01-26 18:24:03 -08:00
Jia Hao
c2bfb7b348
[integration_test] Wrap pumped widgets with a RepaintBoundary ( #70368 )
2020-12-09 16:33:04 -08:00
Jia Hao
f5933dbad3
[integration_test] Add a setter for defaultTestTimeout ( #70073 )
...
* [integration_test] Add a setter for defaultTestTimeout
* type annotation
* More type annotations
* Fix doc
2020-11-09 08:39:05 -08:00
Dan Field
76784651d4
Move package:integration_test to flutter/flutter ( #69622 )
2020-11-05 17:28:47 -08:00
