creativecreatorormaybenot
19a835498e
Correct typos in RenderParagraph ( #72930 )
2020-12-24 21:24:03 -08:00
Chinmoy
3cd1166a65
Added mainAxisExtent to SliverGridDelegateWithFixedCrossAxisCount and SliverGridDelegateWithMaxCrossAxisExtent ( #71376 )
2020-12-22 16:44:05 -08:00
Kate Lovett
32741c0ec8
Migrate sample code to NNBD ( #72755 )
2020-12-21 16:34:02 -08:00
Todd Volkert
e2a0d03b79
Avoid null check operator failure in RenderFlex._hasOverflow ( #72122 )
...
Fixes https://github.com/flutter/flutter/issues/71972
2020-12-17 19:25:28 -08:00
J-P Nurmi
803c07fe3b
Fix EditableText.enableInteractiveSelection on desktop & web ( #70972 )
...
selectionEnabled was not taken into account in:
key movement handling in RenderEditable
mouse drag handling in TextSelectionGestureDetectorBuilder
2020-12-17 16:56:47 -08:00
Justin McCandless
fb3dba74b7
Correct text selection pivot points ( #71756 )
2020-12-14 11:18:05 -08:00
chunhtai
58081821ab
Editable text should call onSelectionChanged when selection changes a… ( #72011 )
2020-12-11 13:53:04 -08:00
Michael Goderbauer
ff05ca2503
Prepare to migrate API doc samples and snippets to null safety ( #72040 )
2020-12-11 13:39:36 -08:00
Michael Goderbauer
8df56056b4
Revert "Constrain width/hight when asking child for intrinsics ( #71880 )" ( #72102 )
...
This reverts commit ceca634e9800dc50c7680ecb346f8a4e442de5c5.
2020-12-10 17:03:56 -08:00
Michael Goderbauer
ceca634e98
Constrain width/hight when asking child for intrinsics ( #71880 )
2020-12-09 14:42:19 -08:00
Michael Goderbauer
ad88369569
Doc fixes for dry layout ( #71868 )
2020-12-07 15:13:18 -08:00
LongCatIsLooong
df28355b0c
Raw keyboard shortcuts & deletions should not read from _plainText ( #71236 )
2020-12-02 17:13:04 -08:00
Christopher Fujino
96d330a204
Revert "Revert "Implement dryLayout for RenderAnimatedSize ( #71097 )" ( #71180 )" ( #71185 )
...
This reverts commit 358f9b0ee66b93d72f6d3e1b809b0e30611d40d7.
2020-11-24 16:29:39 -08:00
Christopher Fujino
358f9b0ee6
Revert "Implement dryLayout for RenderAnimatedSize ( #71097 )" ( #71180 )
...
This reverts commit b18f1b81fe09a1f2bea39eaac9cc709e1ac600cf.
2020-11-24 15:46:58 -08:00
Michael Goderbauer
b18f1b81fe
Implement dryLayout for RenderAnimatedSize ( #71097 )
2020-11-24 12:28:04 -08:00
Michael Goderbauer
7a3a29e71f
Fixes Intrinsics for RenderParagraph and RenderWrap ( #70656 )
2020-11-20 17:24:58 -08:00
Ian Hickson
d4b871e1a7
Minor documentation fixes ( #70501 )
2020-11-20 14:28:03 -08:00
xubaolin
543d3cfa57
Add a [valid] property of [MouseTrackerAnnotation] indicates the annotation states. ( #69866 )
2020-11-17 08:03:02 -08:00
Greg Spencer
5ddc057636
Remove last references to Window in docs. ( #70637 )
...
This removes the last couple of doc references to the Window class in the framework, so that I can re-land the engine side change that removes the Window class (flutter/engine#22505 ).
2020-11-16 14:52:24 -08:00
Ian Hickson
6cff33832e
More lints ( #70500 )
2020-11-16 11:07:37 -08:00
Jason Simmons
a56584857f
Ignore text selection boxes when assembling semantics for placeholder runs ( #70487 )
2020-11-16 10:28:03 -08:00
Greg Spencer
86f9ab511e
Revert usages of the binding's platformDispatcher to use window instead ( #70319 )
...
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.
Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
2020-11-12 11:17:00 -08:00
Michael Goderbauer
b5a4d08962
Intrinsic Width fixes for RenderParagraph ( #70236 )
2020-11-12 10:19:03 -08:00
J-P Nurmi
153f3d23c3
Fix Editable(Text) shortcuts to respect read-only on desktop ( #69891 )
2020-11-11 15:34:05 -08:00
Michael Goderbauer
786d0306db
Assert for RenderFlex intrinsics if using baseline alignment ( #70139 )
2020-11-10 14:29:41 -08:00
Greg Spencer
bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow ( #69617 )
...
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate
* remove new test platform dispatchers
* Amend documentation
2020-11-09 15:26:29 -08:00
Kate Lovett
31c0291af4
Remove old todo ( #70131 )
2020-11-09 14:44:04 -08:00
chunhtai
0bc0cc6192
Fix crash when widgetspan does not produce a semantics node in render… ( #69919 )
...
* Fix crash when widgetspan does not produce a semantics node in render paragraph
* fix comments
* fixed corner case, added test, refactored semantics widget
* addressing comment
2020-11-09 11:31:56 -08:00
Michael Goderbauer
cee6d46b3d
Do not crash if RichText has recognizers without handlers ( #69793 )
2020-11-04 15:49:05 -08:00
Greg Spencer
88809aa247
Standardize dartdoc macro names ( #69445 )
2020-11-02 13:28:05 -08:00
David Garcia
03a3457f10
fix(itemExtent): Fix rounded issue using precisionErrorTolerance ( #68199 )
2020-11-02 13:23:04 -08:00
Greg Spencer
c0ef94780c
Fix spelling errors ( #69451 )
...
My yearly pass to fix spelling errors in the API dartdocs.
2020-10-31 03:12:27 -07:00
Jacek Marchwicki
32b9af6996
Use the correct pleace for the system navigation bar color adjustment ( #68102 )
2020-10-30 10:48:03 -07:00
Ian Hickson
5317330904
Remove the defaults for textBaseline ( #68646 )
2020-10-29 13:13:06 -07:00
Danny Lin
62741337b8
Fix links to GitHub bug template ( #68374 )
2020-10-28 17:42:05 -07:00
Michael Goderbauer
396cd24770
Allow adding/removing onTap/onDismiss to Semantics ( #69230 )
2020-10-28 17:32:12 -07:00
Justin McCandless
09dc5599dd
Selecting spaces ( #68227 )
...
When attempting to select a space on mobile, Flutter will try to select the word before the space too, if one exists.
2020-10-27 11:30:07 -07:00
Alexander Brusher
099ae9b417
Re-enables tests previously failing due to new semantics flag. ( #66916 )
2020-10-22 15:32:03 -07:00
xubaolin
1bd661f4d4
fix a widgetspan hittest bug ( #68694 )
2020-10-22 14:27:04 -07:00
stuartmorgan
3da995adec
Handle backspace in text fields ( #68812 )
...
Currently the framework handles delete, but not backspace, so embeddings
all have to implement backspace handling themselves. This eliminates
that inconsistency and allows simplified code in embeddings by adding
backspace handling.
It also fixes a bug uncovered in the delete handling where deleting a
selection would also delete the next character after the selection.
2020-10-22 13:51:07 -07:00
Dan Field
4af674285b
Move service extension to correct binding so images are repainted after enabling/disabling, update test ( #68793 )
...
* Move service extension to correct binding so images are repainted after enabling/disabling, update test
* Update binding.dart
2020-10-22 13:34:21 -07:00
Michael Goderbauer
42f3709a5a
Sound null safety for framework and flutter_test ( #68642 )
2020-10-21 10:09:11 -07:00
YeungKC
c706abf075
Fix error cursor position for left and right arrow event after text selection ( #68402 )
2020-10-19 12:42:03 -07:00
Alexandre Ardhuin
c0176c9ee5
use_is_even_rather_than_modulo ( #68301 )
2020-10-16 20:20:00 +02:00
Michael Goderbauer
aaaf37418b
Migrate last batch of tests ( #68163 )
2020-10-14 22:52:05 -07:00
Alexandre Ardhuin
eefcff900c
Final definite assignment ( #67682 )
2020-10-10 14:42:02 -07:00
Matej Knopp
24abe59f38
Provide oldLayer where possible ( #67320 )
2020-10-09 13:07:05 -07:00
Michael Goderbauer
d127f2c94a
Fix nullability for some routing related stuff ( #67675 )
2020-10-08 15:56:31 -07:00
Yuqian Li
587dd00619
Add the missing parantheses ( #67446 )
...
Fixes https://github.com/flutter/flutter/issues/67343
2020-10-08 12:20:30 -07:00
LongCatIsLooong
731374016b
Reland "Add CompositedTransformFollower.{followerAnchor, leaderAnchor} for custom anchoring ( #64930 )" ( #65871 ) ( #65884 )
2020-10-08 11:07:03 -07:00