6799 Commits

Author SHA1 Message Date
Jacob Richman
0884236504
Fix assert due to VSCode passing in an isolateId as well as the expected args to setPubRootDirectories. (#68721) 2020-10-21 12:13:10 -07:00
Michael Goderbauer
42f3709a5a
Sound null safety for framework and flutter_test (#68642) 2020-10-21 10:09:11 -07:00
Justin McCandless
955e07461b
Revert "Fix text field label width on outline input border (#67736)" (#68672) 2020-10-21 08:52:03 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)" (#68714)
This reverts commit ae06c19a371cbf8eb9de84d0c3d880c7cd101683.
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings (#68302) 2020-10-21 16:34:24 +02:00
Jacob Richman
e5d7bab115
Fix null safety error in inspector service extensions taking a variable number of args. (#68661)
* Fix null safety error in inspector service extensions taking variable numbers of args.

Fixes https://github.com/flutter/flutter/issues/68627.
Also fix all inspector tests that do not rely on golden image functionality
so that they run with --enable-experiment=non-nullable. This verifies there
is test coverage to ensure there isn't a regression.

* Remove uses of dynamic.
2020-10-20 18:27:55 -07:00
YeungKC
c706abf075
Fix error cursor position for left and right arrow event after text selection (#68402) 2020-10-19 12:42:03 -07:00
Greg Spencer
8c03ff8c1d
Mark keys that match a shortcut, but have no action defined as "not handled". (#67359)
- - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus.

This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry.

This PR includes:

- Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation").
- Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored.
- Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them.
- Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
2020-10-19 11:26:50 -07:00
Kate Lovett
8df0c5e158
Deprecate old SnackBar methods (#67947) 2020-10-19 10:17:03 -07:00
Ayush Bherwani
ca84cc235c
[MergeSemantics] added code snippet (#68123) 2020-10-19 08:17:03 -07:00
Xavier Chrétien
f26fbb6bdd
Set slider semantics flag for sliders (#68019) 2020-10-19 08:12:03 -07:00
nt4f04uNd
4a32e52460
SpringDescription parameter for the AnimationController fling method (#65057) 2020-10-17 20:32:03 -07:00
xster
3302a12b20
Let Flutter SDK use cupertino_icons 1.0.0 (#65087) 2020-10-16 22:36:01 -07:00
Hamdi Kahloun
7b04435a16
Date Picker jumps back to initialDatePickerMode after day selection (#67926)
Date Picker jumps back to initialDatePickerMode after day selection.
2020-10-16 13:31:20 -07:00
YeungKC
50a7da85f7
Fix text field label width on outline input border (#67736) 2020-10-16 13:12:04 -07:00
Alexandre Ardhuin
c0176c9ee5
use_is_even_rather_than_modulo (#68301) 2020-10-16 20:20:00 +02:00
LongCatIsLooong
438c4ff21c
Reland "More EditableText docs (#66864)" (#68043) 2020-10-16 01:52:04 -07:00
xubaolin
7d25b1a4a1
Improve the document of pageView and ListView (#68001) 2020-10-15 17:22:08 -07:00
Darren Austin
4e3f4bb625
Migrated the Slider widget and tests to null safety. (#68232) 2020-10-15 15:47:04 -07:00
Kate Lovett
5aef988adc
[NNBD] Migrate some Widgets tests (#68157) 2020-10-15 15:42:05 -07:00
Alexandre Ardhuin
73301a35a2
Sync lints (#68136) 2020-10-15 15:37:04 -07:00
Michael Goderbauer
aaaf37418b
Migrate last batch of tests (#68163) 2020-10-14 22:52:05 -07:00
Hans Muller
bf6460f935
Updated Builder API doc (#68151) 2020-10-14 22:47:04 -07:00
Michael Goderbauer
e3184b38be
Migrate some widget tests to NNBD (#68150) 2020-10-14 22:42:05 -07:00
Pedro Massango
ff85d97ae5
Expose the tileColor property (#67135) 2020-10-14 21:27:07 -07:00
Albert Wolszon
e8343c0ec4
Add missing margin to SnackBarAction (#67167) 2020-10-14 15:47:03 -07:00
Darren Austin
2c59a3a760
Migrate Switch tests to null safety. (#68133) 2020-10-14 15:32:04 -07:00
Per Classon
8a7fd39b85
[Material] Parent checkbox in DataTable should deselect all, if children checkboxes are disabled or selected (#67938) 2020-10-14 08:57:06 -07:00
xubaolin
7eeab2666b
Fix DropdownButton bug (#65915) 2020-10-14 01:52:03 -07:00
HeavenOSK
66cf8d47a3
[Improvement] Add prefix Alignment. for toString of Alignment (#67860)
* modify: add prefix `Alignment.` for toString of Alignment
2020-10-14 13:47:28 +08:00
Miguel Beltran
1aaa455f1b
Fix for "Pass RouteSettings to the internal Route in showCupertinoModalPopup" (#67990) 2020-10-13 11:32:20 -07:00
Jonah Williams
37ebe3d82a
Revert "prevent pageView scrolling when calling ensureVisible (#67988)" (#68036)
This reverts commit 62cf4dbf10a6bd5b01ab6687dedda2df7cdc9b35.
2020-10-13 10:52:23 -07:00
Ren You
a57f45e080
Revert "More EditableText docs (#66864)" (#68025)
This reverts commit daa6b2cc29b5ff1f166660f9e70fb38d6c0de6cc.
2020-10-13 09:08:48 -07:00
xubaolin
62cf4dbf10
prevent pageView scrolling when calling ensureVisible (#67988) 2020-10-12 23:12:02 -07:00
Jonah Williams
8aee75f645
Revert "Pass RouteSettings to the internal Route in showCupertinoModalPopup (#56024)" (#67969)
This reverts commit da58f5e6fe034f8edfa1adc08debcb92d42e2a68.
2020-10-12 16:09:20 -07:00
Miguel Beltran
da58f5e6fe
Pass RouteSettings to the internal Route in showCupertinoModalPopup (#56024) 2020-10-12 15:53:54 -07:00
Jonah Williams
c606f044d7
[gestures] make stylus pointer types use touch pan/drag slop (#67885) 2020-10-12 15:20:50 -07:00
Kate Lovett
9464661a98
Fix sample code (#67940) 2020-10-12 14:22:03 -07:00
Anurag Roy
7f1540f323
Add contentPadding property for RadioListTile (#67438)
Exposes contentPadding property for RadioListTile from its appropriate ListTile.
2020-10-12 14:22:01 -07:00
Michael Goderbauer
053ebf2c08
Make CupertinoTabScaffold restorable (#67770) 2020-10-12 14:17:02 -07:00
LongCatIsLooong
daa6b2cc29
More EditableText docs (#66864) 2020-10-12 14:12:06 -07:00
xubaolin
dd41f41f34
CupertinoTextField should not accept requestFocus when disabled (#65235) 2020-10-12 14:07:05 -07:00
Sergey Solodukhin
3e069a433b
fix issue #55400 PopupMenuButton positions menu incorrectly with nest… (#65832) 2020-10-12 11:52:04 -07:00
Per Classon
7668f06ffe
[Material] Use primary color for selected rows and checkboxes in DataTable (#67919) 2020-10-12 10:17:03 -07:00
xubaolin
8538b4f546
Fix TextField bug when the formatter repeatedly format (#67892) 2020-10-12 09:37:03 -07:00
chunhtai
345188d40e
make Router.of nullable (#67683) 2020-10-12 09:32:07 -07:00
xubaolin
8211aaa2ae
Fix ListTile assert when layout at zero size (#66798)
* Fix ListTile assert when layout at zero size #66636
2020-10-12 17:25:38 +08:00
xubaolin
d914d5d2f9
Fix typos in the [BottomNavigationBar] document (#67811) 2020-10-12 02:22:01 -07:00
Alexandre Ardhuin
eefcff900c
Final definite assignment (#67682) 2020-10-10 14:42:02 -07:00
Dan Field
8bb61c3801
Reland ensure visible fix for nested viewports (#67773)
* Revert "Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226)" (#66918)"

This reverts commit e8812c409b646d44ade244c6d425c47940214c6b.

* Fix for page views

* comment
2020-10-09 17:40:33 -07:00