DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Run logcat through shell (#21977)

Browse Source 
This should fix #18889 which may be related to `adb logcat` not working correctly in non-terminals on some LG devices. See https://github.com/flutter/flutter/issues/18889#issuecomment-422217761.
This commit is contained in:
Danny Tuppeny 2018-09-18 17:57:31 +01:00 committed by GitHub
parent ccd070a5b4
commit ff9dc22e44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/android/android_device.dart
View File

@ -498,7 +498,7 @@ class AndroidDevice extends Device {
/// no available timestamp. The format can be passed to logcat's -T option.
String get lastLogcatTimestamp {
final String output = runCheckedSync(adbCommandForDevice(<String>[
'logcat', '-v', 'time', '-t', '1'
'shell', '-x', 'logcat', '-v', 'time', '-t', '1'
]));
final Match timeMatch = _timeRegExp.firstMatch(output);
@ -664,7 +664,7 @@ class _AdbLogReader extends DeviceLogReader {
void _start() {
// Start the adb logcat process.
final List<String> args = <String>['logcat', '-v', 'time'];
final List<String> args = <String>['shell', '-x', 'logcat', '-v', 'time'];
final String lastTimestamp = device.lastLogcatTimestamp;
if (lastTimestamp != null)
_timeOrigin = _adbTimestampToDateTime(lastTimestamp);