DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Skip char key events

Browse Source 
It's confusing to send two key press events. Instead, just send the
lower-level, non-char event.

The real fix will be to define a sensible key event protocol for Mozart, but
this patch unblocks people who are experimenting at higher layers of the stack.
This commit is contained in:
Adam Barth 2016-03-22 12:42:10 -07:00
parent 6c08b3655c
commit fc5ddc3058
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sky/shell/platform/mojo/view_impl.cc
View File

@ -13,7 +13,7 @@ namespace shell {
namespace {
sky::InputEventPtr ConvertKeyEvent(mojo::EventPtr event) {
if (!event->key_data)
if (!event->key_data || event->key_data->is_char)
return nullptr;
sky::InputEventPtr result = sky::InputEvent::New();
result->time_stamp = event->time_stamp;
@ -28,7 +28,7 @@ sky::InputEventPtr ConvertKeyEvent(mojo::EventPtr event) {
return nullptr;
}
result->key_data = sky::KeyData::New();
result->key_data->key_code = event->key_data->key_code;
result->key_data->key_code = static_cast<int>(event->key_data->windows_key_code);
if (static_cast<int>(event->flags) & static_cast<int>(mojo::EventFlags::SHIFT_DOWN))
result->key_data->meta_state |= 0x00000001;
if (static_cast<int>(event->flags) & static_cast<int>(mojo::EventFlags::CONTROL_DOWN))
@ -136,6 +136,8 @@ void ViewImpl::OnEvent(mojo::EventPtr event, const OnEventCallback& callback) {
case mojo::EventType::KEY_PRESSED:
case mojo::EventType::KEY_RELEASED: {
auto sky_event = ConvertKeyEvent(event.Pass());
if (!sky_event)
break;
for (auto& listener : raw_keyboard_listeners_)
listener->OnKey(sky_event.Clone());
break;