DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Report image diff status for iOS scenario golden tests (flutter/engine#22230)

Browse Source
This commit is contained in:
Chris Yang 2020-10-30 13:05:34 -07:00 committed by GitHub
parent edf0e059d6
commit fba0836112
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.m
View File

@ -5,6 +5,7 @@
#import "GoldenImage.h"
#import <XCTest/XCTest.h>
#import <os/log.h>
#include <sys/sysctl.h>
static const double kRmseThreshold = 0.5;
@ -29,6 +30,7 @@ static const double kRmseThreshold = 0.5;
- (BOOL)compareGoldenToImage:(UIImage*)image {
if (!self.image || !image) {
os_log_error(OS_LOG_DEFAULT, "GOLDEN DIFF FAILED: image does not exists.");
return NO;
}
CGImageRef imageRefA = [self.image CGImage];
@ -40,6 +42,7 @@ static const double kRmseThreshold = 0.5;
NSUInteger heightB = CGImageGetHeight(imageRefB);
if (widthA != widthB || heightA != heightB) {
os_log_error(OS_LOG_DEFAULT, "GOLDEN DIFF FAILED: images sizes do not match.");
return NO;
}
NSUInteger bytesPerPixel = 4;
@ -48,6 +51,7 @@ static const double kRmseThreshold = 0.5;
NSMutableData* rawB = [NSMutableData dataWithLength:size];
if (!rawA || !rawB) {
os_log_error(OS_LOG_DEFAULT, "GOLDEN DIFF FAILED: image data length do not match.");
return NO;
}
@ -87,7 +91,14 @@ static const double kRmseThreshold = 0.5;
}
}
double rmse = sqrt(sum / size);
return rmse <= kRmseThreshold;
if (rmse > kRmseThreshold) {
os_log_error(
OS_LOG_DEFAULT,
"GOLDEN DIFF FAILED: image diff greater than threshold. Current diff: %@, threshold: %@",
@(rmse), @(kRmseThreshold));
return NO;
}
return YES;
}
NS_INLINE NSString* _platformName() {