From fa72d77b9d94bd7306198d8ecdd865c3dbcd2f99 Mon Sep 17 00:00:00 2001 From: Qun Cheng Date: Sat, 16 Nov 2024 22:32:26 -0800 Subject: [PATCH] Update unit tests --- .../material/flexible_space_bar_test.dart | 3 ++- packages/flutter/test/material/page_test.dart | 24 +++++++++++++++++-- .../flutter/test/material/snack_bar_test.dart | 2 +- 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a/packages/flutter/test/material/flexible_space_bar_test.dart b/packages/flutter/test/material/flexible_space_bar_test.dart index a98f76a57f8..7caa5e85f89 100644 --- a/packages/flutter/test/material/flexible_space_bar_test.dart +++ b/packages/flutter/test/material/flexible_space_bar_test.dart @@ -1487,6 +1487,7 @@ void main() { home: SubCategoryScreenView(), )); + final int opacityLayerCount = tester.layers.whereType().length; expect(RenderRebuildTracker.count, 1); expect( tester.layers.lastWhere((Layer element) => element is OpacityLayer), @@ -1510,7 +1511,7 @@ void main() { } expect(RenderRebuildTracker.count, greaterThan(1)); - expect(tester.layers.whereType(), isEmpty); + expect(tester.layers.whereType().length, opacityLayerCount - 1); }); // This is a regression test for https://github.com/flutter/flutter/issues/132030. diff --git a/packages/flutter/test/material/page_test.dart b/packages/flutter/test/material/page_test.dart index 7ae339e8e25..bb0f45af369 100644 --- a/packages/flutter/test/material/page_test.dart +++ b/packages/flutter/test/material/page_test.dart @@ -177,6 +177,13 @@ void main() { await tester.pumpWidget( MaterialApp( + theme: ThemeData( + pageTransitionsTheme: const PageTransitionsTheme( + builders: { + TargetPlatform.android: ZoomPageTransitionsBuilder(), + } + ) + ), onGenerateRoute: (RouteSettings settings) { return MaterialPageRoute( allowSnapshotting: false, @@ -251,7 +258,14 @@ void main() { RepaintBoundary( key: key, child: MaterialApp( - theme: ThemeData(useMaterial3: false), + theme: ThemeData( + useMaterial3: false, + pageTransitionsTheme: const PageTransitionsTheme( + builders: { + TargetPlatform.android: ZoomPageTransitionsBuilder(), + } + ) + ), onGenerateRoute: (RouteSettings settings) { return MaterialPageRoute( builder: (BuildContext context) { @@ -293,7 +307,13 @@ void main() { key: key, child: MaterialApp( debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616 - theme: ThemeData(useMaterial3: true), + theme: ThemeData( + pageTransitionsTheme: const PageTransitionsTheme( + builders: { + TargetPlatform.android: ZoomPageTransitionsBuilder(), + } + ) + ), onGenerateRoute: (RouteSettings settings) { return MaterialPageRoute( builder: (BuildContext context) { diff --git a/packages/flutter/test/material/snack_bar_test.dart b/packages/flutter/test/material/snack_bar_test.dart index 7790e7c49c6..ec0460fc4b9 100644 --- a/packages/flutter/test/material/snack_bar_test.dart +++ b/packages/flutter/test/material/snack_bar_test.dart @@ -2671,7 +2671,7 @@ void main() { expect(find.text(snackBarText), findsOneWidget); expect(find.text(firstHeader), findsOneWidget); expect(find.text(secondHeader), findsOneWidget); - await tester.pump(const Duration(milliseconds: 750)); + await tester.pump(const Duration(milliseconds: 850)); expect(find.text(snackBarText), findsOneWidget); expect(find.text(firstHeader), findsNothing); expect(find.text(secondHeader), findsOneWidget);