DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix SliverScrollingPersistentHeader not able to update stretchConfiguration (#112042)

Browse Source
This commit is contained in:
fzyzcjy 2022-09-23 08:42:46 +08:00 committed by GitHub
parent 1fbd7ec117
commit fa2d770c60
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter/lib/src/widgets/sliver_persistent_header.dart
View File

@ -402,6 +402,11 @@ class _SliverScrollingPersistentHeader extends _SliverPersistentHeaderRenderObje
stretchConfiguration: delegate.stretchConfiguration,
);
}
@override
void updateRenderObject(BuildContext context, covariant _RenderSliverScrollingPersistentHeaderForWidgets renderObject) {
renderObject.stretchConfiguration = delegate.stretchConfiguration;
}
}
class _RenderSliverScrollingPersistentHeaderForWidgets extends RenderSliverScrollingPersistentHeader

63
packages/flutter/test/widgets/sliver_persistent_header_test.dart Normal file
View File

@ -0,0 +1,63 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter/src/rendering/sliver_persistent_header.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets(
'_SliverScrollingPersistentHeader should update stretchConfiguration',
(WidgetTester tester) async {
for (final double stretchTriggerOffset in <double>[10.0, 20.0]) {
await tester.pumpWidget(MaterialApp(
home: CustomScrollView(
slivers: <Widget>[
SliverPersistentHeader(
delegate: TestDelegate(
stretchConfiguration: OverScrollHeaderStretchConfiguration(
stretchTriggerOffset: stretchTriggerOffset,
),
),
)
],
),
));
}
expect(
tester.allWidgets.where((Widget w) =>
w.runtimeType.toString() == '_SliverScrollingPersistentHeader'),
isNotEmpty);
final RenderSliverScrollingPersistentHeader render = tester.allRenderObjects
.whereType<RenderSliverScrollingPersistentHeader>()
.first;
expect(render.stretchConfiguration?.stretchTriggerOffset, 20);
});
}
class TestDelegate extends SliverPersistentHeaderDelegate {
TestDelegate({this.stretchConfiguration, this.showOnScreenConfiguration});
@override
double get maxExtent => 200.0;
@override
double get minExtent => 200.0;
@override
Widget build(
BuildContext context, double shrinkOffset, bool overlapsContent) {
return Container(height: maxExtent);
}
@override
bool shouldRebuild(TestDelegate oldDelegate) => false;
@override
final OverScrollHeaderStretchConfiguration? stretchConfiguration;
@override
final PersistentHeaderShowOnScreenConfiguration? showOnScreenConfiguration;
}