DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes a NestedScrollView UserScrollNotification issue (#107632)

Browse Source
This commit is contained in:
xubaolin 2022-07-28 09:54:05 +08:00 committed by GitHub
parent a299c9e7e5
commit f976010f1e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/widgets/nested_scroll_view.dart
View File

@ -1344,6 +1344,7 @@ class _NestedScrollPosition extends ScrollPosition implements ScrollActivityDele
@override
void goIdle() {
beginActivity(IdleScrollActivity(this));
coordinator.updateUserScrollDirection(ScrollDirection.idle);
}
// This is called by activities when they finish their work and want to go

53
packages/flutter/test/widgets/nested_scroll_view_test.dart
View File

@ -120,6 +120,59 @@ Widget buildTest({
}
void main() {
testWidgets('ScrollDirection test', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/107101
final List<ScrollDirection> receivedResult = <ScrollDirection>[];
const List<ScrollDirection> expectedReverseResult = <ScrollDirection>[ScrollDirection.reverse, ScrollDirection.idle];
const List<ScrollDirection> expectedForwardResult = <ScrollDirection>[ScrollDirection.forward, ScrollDirection.idle];
await tester.pumpWidget(MaterialApp(
home: Scaffold(
body: NotificationListener<UserScrollNotification>(
onNotification: (UserScrollNotification notification) {
if (notification.depth != 1) {
return true;
}
receivedResult.add(notification.direction);
return true;
},
child: NestedScrollView(
headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) => <Widget>[
const SliverAppBar(
expandedHeight: 250.0,
pinned: true,
),
],
body: ListView.builder(
padding: const EdgeInsets.all(8),
itemCount: 30,
itemBuilder: (BuildContext context, int index) {
return SizedBox(
height: 50,
child: Center(child: Text('Item $index')),
);
},
),
),
),
),
));
// Fling down to trigger ballistic activity
await tester.fling(find.text('Item 3'), const Offset(0.0, -250.0), 10000.0);
await tester.pumpAndSettle();
expect(receivedResult, expectedReverseResult);
receivedResult.clear();
// Drag forward, without ballistic activity
await tester.drag(find.text('Item 29'), const Offset(0.0, 20.0));
await tester.pump();
expect(receivedResult, expectedForwardResult);
});
testWidgets('NestedScrollView respects clipBehavior', (WidgetTester tester) async {
Widget build(NestedScrollView nestedScrollView) {
return Localizations(