From f7ce5ae3fc60f65d17a304d5c66257438166ecfc Mon Sep 17 00:00:00 2001 From: Ferhat Date: Thu, 17 Oct 2019 15:08:15 -0700 Subject: [PATCH] [web] Update web runner message with flutter.dev/web (#42676) * Update web runner message with flutter.dev/web * Update spoopy test to use Warning instead --- .../lib/src/build_runner/resident_web_runner.dart | 8 +++----- .../test/general.shard/resident_web_runner_test.dart | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart b/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart index 08461643596..f8576bd27d8 100644 --- a/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart +++ b/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart @@ -126,11 +126,9 @@ class ResidentWebRunner extends ResidentRunner { fire + terminal.bolden(rawMessage), TerminalColor.red, ); - const String warning = '👻 '; - printStatus(warning * 20); - printStatus('Warning: Flutter\'s support for building web applications is highly experimental.'); - printStatus('For more information see https://github.com/flutter/flutter/issues/34082.'); - printStatus(warning * 20); + printStatus('Warning: Flutter\'s support for web development is not stable yet and hasn\'t'); + printStatus('been thoroughly tested in production environments.'); + printStatus('For more information see https://flutter.dev/web.'); printStatus(''); printStatus(message); const String quitMessage = 'To quit, press "q".'; diff --git a/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart b/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart index 00839da8727..8ae8e286ec6 100644 --- a/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart @@ -296,11 +296,11 @@ void main() { expect(result.message, contains('Page requires refresh')); })); - test('printHelp without details is spoopy', () => testbed.run(() async { + test('printHelp without details has web warning', () => testbed.run(() async { residentWebRunner.printHelp(details: false); final BufferLogger bufferLogger = logger; - expect(bufferLogger.statusText, contains('👻')); + expect(bufferLogger.statusText, contains('Warning')); })); test('debugDumpApp', () => testbed.run(() async {