From f6f72309175f7f8ea5b1524c6da2cbd2a86efb39 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Wed, 28 Feb 2024 12:54:06 -0800 Subject: [PATCH] [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982) Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test. Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend. --- .../impeller/renderer/renderer_unittests.cc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/engine/src/flutter/impeller/renderer/renderer_unittests.cc b/engine/src/flutter/impeller/renderer/renderer_unittests.cc index 2dbef38b3ab..9ff0d2d505f 100644 --- a/engine/src/flutter/impeller/renderer/renderer_unittests.cc +++ b/engine/src/flutter/impeller/renderer/renderer_unittests.cc @@ -1328,6 +1328,13 @@ std::shared_ptr> CreateDefaultPipeline( } TEST_P(RendererTest, CanSepiaToneWithSubpasses) { + // The GLES framebuffer fetch implementation currently does not support this. + // TODO(chinmaygarde): revisit after the GLES framebuffer fetch capabilities + // are clarified. + if (GetParam() == PlaygroundBackend::kOpenGLES) { + GTEST_SKIP_("Not supported on GLES."); + } + // Define shader types using TextureVS = TextureVertexShader; using TextureFS = TextureFragmentShader; @@ -1416,6 +1423,13 @@ TEST_P(RendererTest, CanSepiaToneWithSubpasses) { } TEST_P(RendererTest, CanSepiaToneThenSwizzleWithSubpasses) { + // The GLES framebuffer fetch implementation currently does not support this. + // TODO(chinmaygarde): revisit after the GLES framebuffer fetch capabilities + // are clarified. + if (GetParam() == PlaygroundBackend::kOpenGLES) { + GTEST_SKIP_("Not supported on GLES."); + } + // Define shader types using TextureVS = TextureVertexShader; using TextureFS = TextureFragmentShader;