From f50e2316e60ca7ddb5a545503ace3bd102829d5a Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Wed, 21 Jul 2021 16:01:05 -0700 Subject: [PATCH] Remove unused build_mode_test (#86808) --- dev/devicelab/bin/tasks/build_mode_test.dart | 85 ------------------- .../ui/integration_test/integration_test.dart | 5 +- dev/integration_tests/ui/lib/build_mode.dart | 14 --- 3 files changed, 3 insertions(+), 101 deletions(-) delete mode 100644 dev/devicelab/bin/tasks/build_mode_test.dart delete mode 100644 dev/integration_tests/ui/lib/build_mode.dart diff --git a/dev/devicelab/bin/tasks/build_mode_test.dart b/dev/devicelab/bin/tasks/build_mode_test.dart deleted file mode 100644 index e73625a9a9d..00000000000 --- a/dev/devicelab/bin/tasks/build_mode_test.dart +++ /dev/null @@ -1,85 +0,0 @@ -// Copyright 2014 The Flutter Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'dart:async'; -import 'dart:convert'; -import 'dart:io'; - -import 'package:flutter_devicelab/common.dart'; -import 'package:flutter_devicelab/framework/devices.dart'; -import 'package:flutter_devicelab/framework/framework.dart'; -import 'package:flutter_devicelab/framework/task_result.dart'; -import 'package:flutter_devicelab/framework/utils.dart'; -import 'package:path/path.dart' as path; - -Future runFlutterAndQuit(List args, Device device) async { - final Completer ready = Completer(); - print('run: starting...'); - final Process run = await startProcess( - path.join(flutterDirectory.path, 'bin', 'flutter'), - ['run', '--suppress-analytics', '--no-publish-port', ...args], - isBot: false, // we just want to test the output, not have any debugging info - ); - final List stdout = []; - final List stderr = []; - int? runExitCode; - run.stdout.transform(utf8.decoder).transform(const LineSplitter()).listen( - (String line) { - print('run:stdout: $line'); - stdout.add(line); - if (line.contains('>>> FINISHED <<<')) { - ready.complete(); - } - }, - ); - run.stderr.transform(utf8.decoder).transform(const LineSplitter()).listen( - (String line) { - print('run:stderr: $line'); - stderr.add(line); - }, - ); - unawaited(run.exitCode.then((int exitCode) { - runExitCode = exitCode; - })); - await Future.any(>[ready.future, run.exitCode]); - if (runExitCode != null) { - throw 'Failed to run test app; runner unexpected exited, with exit code $runExitCode.'; - } - run.stdin.write('q'); - await run.exitCode; - if (stderr.isNotEmpty) { - throw 'flutter run ${args.join(' ')} had output on standard error:\n${stderr.join('\n')}'; - } - return stdout.join('\n'); -} - -void main() { - task(() async { - final Device device = await devices.workingDevice; - await device.unlock(); - final Directory appDir = dir(path.join(flutterDirectory.path, 'dev/integration_tests/ui')); - Future checkMode(String mode, {bool releaseExpected = false, bool dynamic = false}) async { - await inDirectory(appDir, () async { - print('run: starting $mode test...'); - final List args = [ - '--$mode', - if (dynamic) '--dynamic', - '-d', - device.deviceId, - 'lib/build_mode.dart', - ]; - final String stdout = await runFlutterAndQuit(args, device); - if (!stdout.contains('>>> Release: $releaseExpected <<<')) { - throw "flutter run --$mode ${dynamic ? '--dynamic ' : ''}didn't set kReleaseMode properly"; - } - }); - } - await checkMode('debug', releaseExpected: false); - await checkMode('profile', releaseExpected: false); - await checkMode('profile', releaseExpected: false, dynamic: true); - await checkMode('release', releaseExpected: true); - await checkMode('release', releaseExpected: true, dynamic: true); - return TaskResult.success(null); - }); -} diff --git a/dev/integration_tests/ui/integration_test/integration_test.dart b/dev/integration_tests/ui/integration_test/integration_test.dart index 63a1b8d4a57..0f989454089 100644 --- a/dev/integration_tests/ui/integration_test/integration_test.dart +++ b/dev/integration_tests/ui/integration_test/integration_test.dart @@ -2,8 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; -import 'package:integration_ui/build_mode.dart' as app; +import 'package:integration_ui/overflow.dart' as app; void main() { group('Integration Test', () { @@ -11,7 +12,7 @@ void main() { app.main(); await tester.pumpAndSettle(); - expect(find.text('Hello, world!'), findsOneWidget); + expect(find.byType(SizedBox), findsOneWidget); }); }); } diff --git a/dev/integration_tests/ui/lib/build_mode.dart b/dev/integration_tests/ui/lib/build_mode.dart deleted file mode 100644 index 33a98fb9ba9..00000000000 --- a/dev/integration_tests/ui/lib/build_mode.dart +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright 2014 The Flutter Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'dart:io'; -import 'package:flutter/foundation.dart'; -import 'package:flutter/widgets.dart'; - -Future main() async { - print('>>> Release: $kReleaseMode <<<'); - print('>>> FINISHED <<<'); - stdout.flush(); - runApp(const Text('Hello, world!', textDirection: TextDirection.ltr)); -}