mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Removes type annotations in templates (#176106)
Fixes https://github.com/flutter/flutter/issues/176098, [aligning with Effective Dart](https://dart.dev/effective-dart/design#dont-write-type-arguments-on-generic-invocations-that-are-inferred). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
Kate Lovett
GitHub
parent
b01e5a1173
commit
f45deca8ba
@ -137,7 +137,7 @@ class _MyHomePageState extends State<MyHomePage> {
|
||||
// action in the IDE, or press "p" in the console), to see the
|
||||
// wireframe for each widget.
|
||||
mainAxisAlignment: .center,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
const Text('You have pushed the button this many times:'),
|
||||
Text(
|
||||
'$_counter',
|
||||
|
||||
@ -98,7 +98,7 @@ class _MyHomePageState extends State<MyHomePage> {
|
||||
// axis because Columns are vertical (the cross axis would be
|
||||
// horizontal).
|
||||
mainAxisAlignment: .center,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
const Text('You have pushed the button this many times:'),
|
||||
Text(
|
||||
'$_counter',
|
||||
|
||||
@ -50,7 +50,7 @@ class ZoomControls extends StatelessWidget {
|
||||
Widget build(BuildContext context) {
|
||||
return Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
_WidgetPreviewIconButton(
|
||||
tooltip: 'Zoom in',
|
||||
onPressed: enabled ? _zoomIn : null,
|
||||
|
||||
@ -55,10 +55,10 @@ class _WidgetPreviewErrorWidget extends StatelessWidget {
|
||||
child: SingleChildScrollView(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
Text.rich(
|
||||
TextSpan(
|
||||
children: <TextSpan>[
|
||||
children: [
|
||||
TextSpan(
|
||||
text: 'Failed to initialize widget tree: ',
|
||||
style: boldStyle,
|
||||
@ -90,7 +90,7 @@ class _WidgetPreviewErrorWidget extends StatelessWidget {
|
||||
return frames.map<TextSpan>((frame) {
|
||||
if (frame is UnparsedFrame) return TextSpan(text: '$frame\n');
|
||||
return TextSpan(
|
||||
children: <TextSpan>[
|
||||
children: [
|
||||
TextSpan(
|
||||
text: frame.location,
|
||||
style: linkTextStyle,
|
||||
@ -122,7 +122,7 @@ class NoPreviewsDetectedWidget extends StatelessWidget {
|
||||
final style = fixBlurryText(TextStyle(color: Colors.black));
|
||||
return Center(
|
||||
child: Column(
|
||||
children: <Widget>[
|
||||
children: [
|
||||
Text(
|
||||
'No previews detected',
|
||||
style: style.copyWith(fontWeight: FontWeight.bold),
|
||||
@ -196,7 +196,7 @@ class WidgetPreviewGroupWidget extends StatelessWidget {
|
||||
spacing: WidgetPreviewGroupWidget._gridSpacing,
|
||||
runSpacing: WidgetPreviewGroupWidget._gridRunSpacing,
|
||||
alignment: WrapAlignment.start,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
for (final WidgetPreview preview in previews)
|
||||
WidgetPreviewWidget(preview: preview),
|
||||
],
|
||||
@ -963,7 +963,7 @@ class WidgetPreviews extends StatelessWidget {
|
||||
if (previewGroups.isEmpty) {
|
||||
return Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
children: <Widget>[NoPreviewsDetectedWidget()],
|
||||
children: [NoPreviewsDetectedWidget()],
|
||||
);
|
||||
}
|
||||
return LayoutBuilder(
|
||||
|
||||
@ -50,7 +50,7 @@ class ZoomControls extends StatelessWidget {
|
||||
Widget build(BuildContext context) {
|
||||
return Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
_WidgetPreviewIconButton(
|
||||
tooltip: 'Zoom in',
|
||||
onPressed: enabled ? _zoomIn : null,
|
||||
|
||||
@ -55,10 +55,10 @@ class _WidgetPreviewErrorWidget extends StatelessWidget {
|
||||
child: SingleChildScrollView(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
Text.rich(
|
||||
TextSpan(
|
||||
children: <TextSpan>[
|
||||
children: [
|
||||
TextSpan(
|
||||
text: 'Failed to initialize widget tree: ',
|
||||
style: boldStyle,
|
||||
@ -90,7 +90,7 @@ class _WidgetPreviewErrorWidget extends StatelessWidget {
|
||||
return frames.map<TextSpan>((frame) {
|
||||
if (frame is UnparsedFrame) return TextSpan(text: '$frame\n');
|
||||
return TextSpan(
|
||||
children: <TextSpan>[
|
||||
children: [
|
||||
TextSpan(
|
||||
text: frame.location,
|
||||
style: linkTextStyle,
|
||||
@ -122,7 +122,7 @@ class NoPreviewsDetectedWidget extends StatelessWidget {
|
||||
final style = fixBlurryText(TextStyle(color: Colors.black));
|
||||
return Center(
|
||||
child: Column(
|
||||
children: <Widget>[
|
||||
children: [
|
||||
Text(
|
||||
'No previews detected',
|
||||
style: style.copyWith(fontWeight: FontWeight.bold),
|
||||
@ -196,7 +196,7 @@ class WidgetPreviewGroupWidget extends StatelessWidget {
|
||||
spacing: WidgetPreviewGroupWidget._gridSpacing,
|
||||
runSpacing: WidgetPreviewGroupWidget._gridRunSpacing,
|
||||
alignment: WrapAlignment.start,
|
||||
children: <Widget>[
|
||||
children: [
|
||||
for (final WidgetPreview preview in previews)
|
||||
WidgetPreviewWidget(preview: preview),
|
||||
],
|
||||
@ -963,7 +963,7 @@ class WidgetPreviews extends StatelessWidget {
|
||||
if (previewGroups.isEmpty) {
|
||||
return Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
children: <Widget>[NoPreviewsDetectedWidget()],
|
||||
children: [NoPreviewsDetectedWidget()],
|
||||
);
|
||||
}
|
||||
return LayoutBuilder(
|
||||
|
||||
@ -20,7 +20,7 @@ void main() {
|
||||
)) {
|
||||
stdout.writeln(
|
||||
'The widget_preview_scaffold contents do not match the widget_preview_scaffold '
|
||||
'templates. Run "dart test/widget_preview_scaffold.shard/update_widget_preview_scaffold" '
|
||||
'templates. Run "dart test/widget_preview_scaffold.shard/update_widget_preview_scaffold.dart" '
|
||||
'to update widget_preview_scaffold with the latest template contents.',
|
||||
);
|
||||
fail(
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user