DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix RTL icons (#15095)

Browse Source
This commit is contained in:
Ian Hickson 2018-03-21 17:58:07 -07:00 committed by GitHub
parent feadfd2e40
commit f2ffc8de79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
examples/flutter_gallery/lib/demo/material/icons_demo.dart
View File

@ -52,16 +52,16 @@ class IconsDemoState extends State<IconsDemo> {
),
body: new IconTheme(
data: new IconThemeData(color: iconColor),
child: new Padding(
padding: const EdgeInsets.all(24.0),
child: new SafeArea(
top: false,
bottom: false,
child: new Column(
children: <Widget>[
new _IconsDemoCard(handleIconButtonPress),
],
),
child: new SafeArea(
top: false,
bottom: false,
child: new ListView(
padding: const EdgeInsets.all(24.0),
children: <Widget>[
new _IconsDemoCard(handleIconButtonPress, Icons.face), // direction-agnostic icon
const SizedBox(height: 24.0),
new _IconsDemoCard(handleIconButtonPress, Icons.battery_unknown), // direction-aware icon
],
),
),
),
@ -70,10 +70,10 @@ class IconsDemoState extends State<IconsDemo> {
}
class _IconsDemoCard extends StatelessWidget {
const _IconsDemoCard(this.handleIconButtonPress);
const _IconsDemoCard(this.handleIconButtonPress, this.icon);
final VoidCallback handleIconButtonPress;
final IconData icon;
Widget _buildIconButton(double iconSize, IconData icon, bool enabled) {
return new IconButton(
@ -95,8 +95,8 @@ class _IconsDemoCard extends StatelessWidget {
return new TableRow(
children: <Widget> [
_centeredText(size.floor().toString()),
_buildIconButton(size, Icons.face, true),
_buildIconButton(size, Icons.face, false),
_buildIconButton(size, icon, true),
_buildIconButton(size, icon, false),
],
);
}

2
packages/flutter/lib/src/widgets/icon.dart
View File

@ -151,7 +151,7 @@ class Icon extends StatelessWidget {
switch (textDirection) {
case TextDirection.rtl:
iconWidget = new Transform(
transform: new Matrix4.identity()..scale(-1.0),
transform: new Matrix4.identity()..scale(-1.0, 1.0, 1.0),
alignment: Alignment.center,
transformHitTests: false,
child: iconWidget,