From f20c853d20e8e2d4de8d66684ecbfc0fac98e41e Mon Sep 17 00:00:00 2001 From: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Date: Wed, 8 May 2024 05:26:48 +0800 Subject: [PATCH] Implement `RenderEditable.computeDryBaseline` (#147911) Missed `RenderEditable` so https://github.com/flutter/flutter/pull/146224 is failing in google3 --- packages/flutter/lib/src/rendering/editable.dart | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/flutter/lib/src/rendering/editable.dart b/packages/flutter/lib/src/rendering/editable.dart index e03b1d9995a..a5f5c5a30eb 100644 --- a/packages/flutter/lib/src/rendering/editable.dart +++ b/packages/flutter/lib/src/rendering/editable.dart @@ -2302,6 +2302,15 @@ class RenderEditable extends RenderBox with RelayoutWhenSystemFontsChangeMixin, return Size(width, constraints.constrainHeight(_preferredHeight(constraints.maxWidth))); } + @override + double computeDryBaseline(covariant BoxConstraints constraints, TextBaseline baseline) { + final (double minWidth, double maxWidth) = _adjustConstraints(minWidth: constraints.minWidth, maxWidth: constraints.maxWidth); + _textIntrinsics + ..setPlaceholderDimensions(layoutInlineChildren(constraints.maxWidth, ChildLayoutHelper.dryLayoutChild, ChildLayoutHelper.getDryBaseline)) + ..layout(minWidth: minWidth, maxWidth: maxWidth); + return _textIntrinsics.computeDistanceToActualBaseline(baseline); + } + @override void performLayout() { final BoxConstraints constraints = this.constraints;