DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Only set dart_include_wasm_opt when we are actually building the dart sdk. (flutter/engine#41175)

Browse Source 
Only set `dart_include_wasm_opt` when we are actually building the dart sdk.
This commit is contained in:
Jackson Gardner 2023-04-13 21:08:29 -07:00 committed by GitHub
parent 34f107bb41
commit ef11c9d3ae
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/tools/gn
View File

@ -383,10 +383,6 @@ def to_gn_args(args):
else:
gn_args['dart_runtime_mode'] = runtime_mode
# If we are building the dart sdk in-tree, exclude the wasm-opt target, as
# it doesn't build properly with our gn configuration.
gn_args['dart_include_wasm_opt'] = False
# Desktop embeddings can have more dependencies than the engine library,
# which can be problematic in some build environments (e.g., building on
# Linux will bring in pkg-config dependencies at generation time). These
@ -494,6 +490,10 @@ def to_gn_args(args):
'source by setting `--no-prebuilt-dart-sdk` flag to tools/gn'
)
elif is_host_build(args):
# If we are building the dart sdk in-tree, exclude the wasm-opt target, as
# it doesn't build properly with our gn configuration.
gn_args['dart_include_wasm_opt'] = False
# dart_platform_sdk is only defined for host builds, linux arm host builds
# specify target_os=linux.
# dart_platform_sdk=True means exclude web-related files, e.g. dart2js,