From ed774ebfa94db011783b08cdfbf49119ac5ca87b Mon Sep 17 00:00:00 2001 From: Mohellebi abdessalem Date: Tue, 23 Sep 2025 17:45:18 +0100 Subject: [PATCH] Fix linter issues in `VsyncWaiterTest` Capital L for long values (#175780) 03 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- .../android/test/io/flutter/view/VsyncWaiterTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/engine/src/flutter/shell/platform/android/test/io/flutter/view/VsyncWaiterTest.java b/engine/src/flutter/shell/platform/android/test/io/flutter/view/VsyncWaiterTest.java index 35065d227e9..47ea7b22106 100644 --- a/engine/src/flutter/shell/platform/android/test/io/flutter/view/VsyncWaiterTest.java +++ b/engine/src/flutter/shell/platform/android/test/io/flutter/view/VsyncWaiterTest.java @@ -44,7 +44,7 @@ public class VsyncWaiterTest { verify(mockFlutterJNI, times(1)).setAsyncWaitForVsyncDelegate(delegateCaptor.capture()); delegateCaptor.getValue().asyncWaitForVsync(1); shadowOf(Looper.getMainLooper()).idle(); - verify(mockFlutterJNI, times(1)).onVsync(anyLong(), eq(1000000000l / 10l), eq(1l)); + verify(mockFlutterJNI, times(1)).onVsync(anyLong(), eq(1000000000L / 10L), eq(1L)); } @Test @@ -71,7 +71,7 @@ public class VsyncWaiterTest { verify(mockFlutterJNI, times(1)).setAsyncWaitForVsyncDelegate(delegateCaptor.capture()); delegateCaptor.getValue().asyncWaitForVsync(1); shadowOf(Looper.getMainLooper()).idle(); - verify(mockFlutterJNI, times(1)).onVsync(anyLong(), eq(1000000000l / 90l), eq(1l)); + verify(mockFlutterJNI, times(1)).onVsync(anyLong(), eq(1000000000L / 90L), eq(1L)); when(mockDisplay.getRefreshRate()).thenReturn(60.0f); displayListenerCaptor.getValue().onDisplayChanged(Display.DEFAULT_DISPLAY); @@ -79,7 +79,7 @@ public class VsyncWaiterTest { delegateCaptor.getValue().asyncWaitForVsync(1); shadowOf(Looper.getMainLooper()).idle(); - verify(mockFlutterJNI, times(1)).onVsync(anyLong(), eq(1000000000l / 60l), eq(1l)); + verify(mockFlutterJNI, times(1)).onVsync(anyLong(), eq(1000000000L / 60L), eq(1L)); } @Test