From ed4a8e8d0543a258564d403defc49da627a217a5 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Mon, 24 Aug 2020 14:50:38 -0700 Subject: [PATCH] Revert "Pass --verbose-logging to flutter_tester (#64440)" (#64517) This reverts commit 8b52e6a8b2994e848ff43841c8bad154237dc0e8. --- .../lib/src/test/flutter_platform.dart | 1 - .../general.shard/flutter_platform_test.dart | 43 ------------------- 2 files changed, 44 deletions(-) diff --git a/packages/flutter_tools/lib/src/test/flutter_platform.dart b/packages/flutter_tools/lib/src/test/flutter_platform.dart index 063c1d8d37b..8fd501c4ba7 100644 --- a/packages/flutter_tools/lib/src/test/flutter_platform.dart +++ b/packages/flutter_tools/lib/src/test/flutter_platform.dart @@ -800,7 +800,6 @@ class FlutterPlatform extends PlatformPlugin { '--skia-deterministic-rendering', '--enable-dart-profiling', '--non-interactive', - '--verbose-logging', '--use-test-fonts', '--packages=$packages', if (nullAssertions) diff --git a/packages/flutter_tools/test/general.shard/flutter_platform_test.dart b/packages/flutter_tools/test/general.shard/flutter_platform_test.dart index 77baffe270d..f17c869787c 100644 --- a/packages/flutter_tools/test/general.shard/flutter_platform_test.dart +++ b/packages/flutter_tools/test/general.shard/flutter_platform_test.dart @@ -123,49 +123,6 @@ void main() { }, overrides: contextOverrides); }); - group('The arguments that are passed to the test process', () { - MockPlatform mockPlatform; - MockProcessManager mockProcessManager; - FlutterPlatform flutterPlatform; - final Map contextOverrides = { - Platform: () => mockPlatform, - ProcessManager: () => mockProcessManager, - FileSystem: () => fileSystem, - }; - - setUp(() { - mockPlatform = MockPlatform(); - when(mockPlatform.isWindows).thenReturn(false); - mockProcessManager = MockProcessManager(); - flutterPlatform = TestFlutterPlatform(); - when(mockPlatform.environment).thenReturn({}); - }); - - Future> captureArguments() async { - flutterPlatform.loadChannel('test1.dart', MockSuitePlatform()); - when(mockProcessManager.start( - any, - environment: anyNamed('environment')), - ).thenAnswer((_) { - return Future.value(MockProcess()); - }); - await untilCalled(mockProcessManager.start(any, environment: anyNamed('environment'))); - final VerificationResult toVerify = verify(mockProcessManager.start( - captureAny, - environment: anyNamed('environment'), - )); - expect(toVerify.captured, hasLength(1)); - expect(toVerify.captured.first, isA>()); - final List command = toVerify.captured.first as List; - return command.where((String element) => element.startsWith('-')).toSet(); - } - - testUsingContext('contain --verbose-logging', () async { - final Set capturedArguments = await captureArguments(); - expect(capturedArguments, contains('--verbose-logging')); - }, overrides: contextOverrides); - }); - testUsingContext('installHook creates a FlutterPlatform', () { expect(() => installHook( buildMode: BuildMode.debug,