From ec0bccfb5d43ec5b0b83532d7c1fc0d2bb3fbfbf Mon Sep 17 00:00:00 2001
From: Adam Barth <abarth@chromium.org>
Date: Mon, 10 Aug 2015 11:18:44 -0700
Subject: [PATCH] Optimize circular clips slightly

This patch avoids creating weak references on every paint call by caching the
Path object between paints.
---
 packages/flutter/lib/rendering/box.dart | 29 +++++++++++++++++++------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/packages/flutter/lib/rendering/box.dart b/packages/flutter/lib/rendering/box.dart
index ad7c2936de2..8f527b8b6b9 100644
--- a/packages/flutter/lib/rendering/box.dart
+++ b/packages/flutter/lib/rendering/box.dart
@@ -802,7 +802,8 @@ class RenderOpacity extends RenderProxyBox {
     if (_cachedPaint == null) {
       _cachedPaint =  new Paint()
         ..color = new Color.fromARGB(_alpha, 0, 0, 0)
-        ..setTransferMode(sky.TransferMode.srcOver);
+        ..setTransferMode(sky.TransferMode.srcOver)
+        ..isAntiAlias = false;
     }
     return _cachedPaint;
   }
@@ -857,7 +858,8 @@ class RenderColorFilter extends RenderProxyBox {
   Paint get _paint {
     if (_cachedPaint == null) {
       _cachedPaint = new Paint()
-        ..setColorFilter(new sky.ColorFilter.mode(_color, _transferMode));
+        ..setColorFilter(new sky.ColorFilter.mode(_color, _transferMode))
+        ..isAntiAlias = false;
     }
     return _cachedPaint;
   }
@@ -911,10 +913,12 @@ class RenderClipRRect extends RenderProxyBox {
     markNeedsPaint();
   }
 
+  final Paint _paint = new Paint()..isAntiAlias = false;
+
   void paint(PaintingCanvas canvas, Offset offset) {
     if (child != null) {
       Rect rect = offset & size;
-      canvas.saveLayer(rect, new Paint());
+      canvas.saveLayer(rect, _paint);
       sky.RRect rrect = new sky.RRect()..setRectXY(rect, xRadius, yRadius);
       canvas.clipRRect(rrect);
       canvas.paintChild(child, offset.toPoint());
@@ -926,13 +930,24 @@ class RenderClipRRect extends RenderProxyBox {
 class RenderClipOval extends RenderProxyBox {
   RenderClipOval({ RenderBox child }) : super(child);
 
+  final Paint _paint = new Paint()..isAntiAlias = false;
+
+  Rect _cachedRect;
+  Path _cachedPath;
+
+  Path _getPath(Rect rect) {
+    if (rect != _cachedRect) {
+      _cachedRect = rect;
+      _cachedPath = new Path()..addOval(_cachedRect);
+    }
+    return _cachedPath;
+  }
+
   void paint(PaintingCanvas canvas, Offset offset) {
     if (child != null) {
       Rect rect = offset & size;
-      canvas.saveLayer(rect, new Paint());
-      Path path = new Path();
-      path.addOval(rect);
-      canvas.clipPath(path);
+      canvas.saveLayer(rect, _paint);
+      canvas.clipPath(_getPath(rect));
       canvas.paintChild(child, offset.toPoint());
       canvas.restore();
     }