From eaa458dd36a9bd2a13c579c2f01f8516e4eeba65 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Fri, 11 Sep 2020 16:12:22 -0700 Subject: [PATCH] Disable iOS application lifetime Scenario tests (flutter/engine#21125) This speculatively disables the ApplicationLifecycle Scenarios iOS tests which continue to fail after being re-enabled in flutter/engine#21087. Related P0 issue: https://github.com/flutter/flutter/issues/61620 --- .../ios/Scenarios/ScenariosTests/AppLifecycleTests.m | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m b/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m index f1242d7a015..44742aa54b7 100644 --- a/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m +++ b/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m @@ -40,7 +40,9 @@ FLUTTER_ASSERT_ARC self.continueAfterFailure = NO; } -- (void)testDismissedFlutterViewControllerNotRespondingToApplicationLifecycle { +// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness +// has been identified. https://github.com/flutter/flutter/issues/61620 +- (void)skip_testDismissedFlutterViewControllerNotRespondingToApplicationLifecycle { XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"]; // Let the engine finish booting (at the end of which the channels are properly set-up) before @@ -175,7 +177,9 @@ FLUTTER_ASSERT_ARC [engine destroyContext]; } -- (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle { +// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness +// has been identified. https://github.com/flutter/flutter/issues/61620 +- (void)skip_testVisibleFlutterViewControllerRespondsToApplicationLifecycle { XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"]; // Let the engine finish booting (at the end of which the channels are properly set-up) before @@ -280,7 +284,9 @@ FLUTTER_ASSERT_ARC [engine destroyContext]; } -- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle { +// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness +// has been identified. https://github.com/flutter/flutter/issues/61620 +- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle { XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"]; // Let the engine finish booting (at the end of which the channels are properly set-up) before